Commit Graph

62421 Commits

Author SHA1 Message Date
Christian Stenger
23ba55cade GitLab: Avoid wrong request
Change-Id: I8be467559c5a742d40b865fa4ffd2c10344ccbba
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-03 10:34:34 +00:00
Christian Stenger
ed02ebf615 GitLab: Slightly tweak clone dialog layout
Change-Id: I884c06108515f81f77d00fa6d16821f91be000a1
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-03 10:34:26 +00:00
Christian Kandeler
510bbea59a ProjectExplorer: Remove effectively unused enum
Change-Id: Ie4f23e5658e57a367ab77c2cc40443f32a60a8d0
Reviewed-by: hjk <hjk@qt.io>
2022-06-03 10:09:23 +00:00
Christian Kandeler
8690bec140 RemoteLinux: Fix build
Change-Id: I9d16473d7ecdcb05510e8f0f39193fcda8fa10a8
Reviewed-by: hjk <hjk@qt.io>
2022-06-03 10:06:58 +00:00
Mahmoud Badri
8d11ec2656 QmlDesigner: Fix adding the first material to the material library
Fixed that material editor node was not being created when no materials
exist.

Fixes: QDS-7069
Change-Id: I358c497325e8865fc5f012531783dcbe46c32490
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-03 10:00:49 +00:00
Mahmoud Badri
6a7f853ec9 QmlDesigner: Switch to components view upon model attach
the "add imports" view looks confusing when it appears upon switching
from edit mode or welcome screen to design mode. Even worse when it
stays after creating a new project.

Change-Id: Ibc3ff1adc7f6b653d443fec2b8f1803d6ac56ed9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-03 10:00:38 +00:00
Christian Kandeler
42e7195185 CppEditor: Remove unused functions
Change-Id: I392930920b536813c9f8fb4969e7f486960aa0cb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-03 09:57:53 +00:00
hjk
5c7925a03c RemoteLinux: Slimmer interface of tarpackagedeploystep handling
Change-Id: Iae162718226182dd5d5af87c2aae260a9f8c7b45
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-03 09:42:49 +00:00
hjk
d76458a8b6 Utils: Replace Environment::size() check by some isValid() function
More descriptive, and later implementable without full expansion.

Change-Id: Ic3b17ea0b07273f292827a7b63e7695b4bd1cf23
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-03 09:42:26 +00:00
David Schulz
b72f41c7f0 LanguageClient: prevent nullptr access
Change-Id: Ib9838e6912f2f82e4fc9f69f505e2dc9a4c297eb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-03 09:41:01 +00:00
hjk
c6d9ae043b RemoteLinux: Use deploy config id more directly
Closer to the standard pattern.

Change-Id: Ia040de816f20727d772c1d298119a92c184fe28c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-03 09:05:30 +00:00
Thiago Macieira
0978d16093 CppEditor: Consider non-canonical path to clang includes
The include directory is under lib64/ on some systems.

Fixes: QTCREATORBUG-27623
Change-Id: Iba16e8ea451b444ab213fffd16f49dae865cd60e
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-03 08:03:15 +00:00
Artem Sokolovskii
32216652a8 modeleditor: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: I252bd537d766a65b8ceb95b32d652f462f89d188
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-03 07:58:12 +00:00
Artem Sokolovskii
30e60e9979 macros: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Id779aaf869406571288519083883ab57e5c29cec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-06-03 07:58:05 +00:00
Artem Sokolovskii
7020b0a44a ClangFormat: Convert old settings to a new ones
Added possibility to convert old setting to new one out of the box.
So now, if options FormattingInsteadOfIndentting or FormatOnSave
was set the mode will be set to Formatting.

Change-Id: I3c30ca8543d4fe25d1a44665d286f27ac2102c52
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-03 07:47:33 +00:00
David Schulz
ff8495b0a2 Python: fix pyside tool detection
pip might return an incomplete list of files on Windows for
installations. So we need to manually check the Scripts
folder for the tools we are looking for.

Change-Id: I40778607fd2f2015059744f17a539ca381b85560
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-03 07:35:13 +00:00
Christian Kandeler
47105360fa ProjectExplorer: Prevent creating large issues in SanitizerParser
E.g. leak info can get huge, and our task view is not suitable for
displaying items of such size.

Change-Id: Ic22444b23d96fd2a4662ec6c2f3f20f9d8b34816
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-03 07:16:31 +00:00
Thiago Macieira
5947b3c9f0 EasingSimulation: remove default parameters
They can't ever be null, so don't make GCC12 think they can.

In constructor ‘QmlEditorWidgets::EasingSimulation::EasingSimulation(QObject*, QGraphicsView*)’,
    inlined from ‘QtPrivate::QMetaTypeForType<QmlEditorWidgets::EasingSimulation>::getDefaultCtr()::<lambda(const QtPrivate::QMetaTypeInterface*, void*)>’ at qmetatype.h:2266:65,
    inlined from ‘static constexpr void QtPrivate::QMetaTypeForType<QmlEditorWidgets::EasingSimulation>::getDefaultCtr()::<lambda(const QtPrivate::QMetaTypeInterface*, void*)>::_FUN(const QtPrivate::QMetaTypeInterface*, void*)’ at qmetatype.h:2266:20:
easingcontextpane.cpp:55:54: warning: ‘this’ pointer is null [-Wnonnull]
   55 |         m_scene.setSceneRect(0,0,v->viewport()->width(),m_qtLogo->boundingRect().height());
      |                                  ~~~~~~~~~~~~~~~~~~~~^~
qabstractscrollarea.h:56:14: note: in a call to non-static member function ‘QWidget* QAbstractScrollArea::viewport() const’
   56 |     QWidget *viewport() const;
      |              ^~~~~~~~
easingcontextpane.cpp:59:22: warning: ‘this’ pointer is null [-Wnonnull]
   59 |         m_g->setScene(&m_scene);
      |         ~~~~~~~~~~~~~^~~~~~~~~~
qgraphicsview.h:127:10: note: in a call to non-static member function ‘void QGraphicsView::setScene(QGraphicsScene*)’
  127 |     void setScene(QGraphicsScene *scene);
      |          ^~~~~~~~

Change-Id: Iba16e8ea451b444ab213fffd16f4912ba479dcec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-06-02 19:14:40 +00:00
Thiago Macieira
aa5d2eaf13 SmallString: Replace manual itoa implementation with std::to_chars
GCC 12 was producing a huge warning log about this, thinking we were
overflowing the buffer. I don't see how.

In function ‘std::_Require<std::__not_<std::__is_tuple_like<_Tp> >, std::is_move_constructible<_Tp>, std::is_move_assignable<_Tp> > std::swap(_Tp&, _Tp&) [with _Tp = char]’,
    inlined from ‘void std::iter_swap(_ForwardIterator1, _ForwardIterator2) [with _ForwardIterator1 = char*; _ForwardIterator2 = char*]’ at /usr/include/c++/12/bits/stl_algobase.h:182:11,
    inlined from ‘void std::__reverse(_RandomAccessIterator, _RandomAccessIterator, random_access_iterator_tag) [with _RandomAccessIterator = char*]’ at /usr/include/c++/12/bits/stl_algo.h:1107:18,
    inlined from ‘void std::reverse(_BIter, _BIter) [with _BIter = char*]’ at /usr/include/c++/12/bits/stl_algo.h:1134:21,
    inlined from ‘static std::size_t Utils::BasicSmallString<Size>::itoa(long long int, char*, uint) [with unsigned int Size = 31]’ at smallstring.h:956:21,
[... many more frames ...]
move.h:205:11: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
smallstring.h:615:14: note: at offset 46 into destination object ‘buffer’ of size 22
  615 |         char buffer[22];
      |              ^~~~~~
smallstring.h:615:14: note: at offset [14, 22] into destination object ‘buffer’ of size 22
smallstring.h:615:14: note: at offset 46 into destination object ‘buffer’ of size 22

Change-Id: Iba16e8ea451b444ab213fffd16f491e608ee713a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2022-06-02 16:42:17 +00:00
Jarek Kobus
edbec09719 QtcProcess: Don't merge ready read signals
Fix it also for general waitForSignal() implementation.

Amends fc2f3983bc

Task-number: QTCREATORBUG-27578
Change-Id: Ifb9ebbd5c3fa2c900bae924aefccb713983b1697
Reviewed-by: hjk <hjk@qt.io>
2022-06-02 16:06:50 +00:00
hjk
31f0ba4ef9 Utils: Introduce FilePath::displayName()
To produce "<filepath> on <devicename>" which is nicer to read than
"<scheme>://<deviceid>/<filepath>" in some places.

Change-Id: Ife47bbf49382cf73dd4709d826bdeaa8730f88be
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-02 15:14:27 +00:00
Christian Kandeler
51aae3bb1f GccParser: Check for "note: here" output
Much like "requested from here", it usually indicates the interesting
location.

Change-Id: I7db2c8f0a8e5d0ebafedbaaf5cbd04f07055dfe9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-02 14:56:49 +00:00
Samuel Ghinet
fe4d8e3eda Fix tooltip text in 3D Editor toolbar background color button
Task-number: QDS-6585
Change-Id: I397de9ac51b69697234f5f0dc48b90f330ec49d2
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-02 13:32:43 +00:00
David Schulz
b9034e8426 Python: support python 3 mime type in language client
Change-Id: I9319442aecc61e854aaeb0778b959086a70d431b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-02 13:29:17 +00:00
Thomas Hartmann
a734e1b4e8 QmlDesigner: Move reparenting of materials into transaction
Without a transaction we will reparse the document for each reparent.
This will make the process very slow if there are e.g. 20 materials
in the document.

The new parent has to be created first. This cannot be part of the same
transaction, because of limiations in the rewriter.

Change-Id: Ie2c587d0f072b8163846c660dc2dd66bee7146c1
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-02 13:21:20 +00:00
hjk
6bbddf115c Utils: Retain more high level information on EnvironmentChange::Item
Change-Id: I78df3cf7ae767d6baeed46f03587ee21875c8315
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-02 12:49:43 +00:00
Christian Stenger
87b0f2a354 QmlDesigner: Fixup compile fix
Use explicit type for local variable to have a consistent
approach. Amends 6469f99.

Change-Id: I6b7612e1f646e497699e278e4538f9cb4ae37c64
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-02 12:39:06 +00:00
Piotr Mućko
3b02d7b32a McuSupport: Use legacy implementation for QtMCUs 2.2
New implementation of mcu support plugin is not yet finished
so we should use legacy implementation for QtMCUs 2.2 JSON kits.

Change-Id: I8e6a8b7af2c3b4683bb19a5f05edd6ff5df46e5b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-02 12:38:47 +00:00
Christian Kandeler
01ceb3a3cb ClangCodeModel: Switch to LSP-based UI header approach
Generating ui headers in a well-known path and then including that one
in the compilation database does not work in the presence of multiple ui
files with the same name.
As it turns out, we don't have to generate any files at all; instead, we
pass the file contents directly to clangd, which then uses them when
parsing includes of the respective header.
User-visible behavior change apart from the abovementioned bug fix:
Tooltips and "follow symbol" on the include directive now always use the
actual location of the header provided by the build system.

Fixes: QTCREATORBUG-27584
Change-Id: I6b13e12cb3a365199567b0bc824d12b373117697
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-02 11:29:14 +00:00
Eike Ziller
d7ba5a84b0 Merge remote-tracking branch 'origin/8.0'
Change-Id: I024823b6667947895eff7570286cc11ee09d3e1d
2022-06-02 13:26:23 +02:00
hjk
5de18c67f0 Utils: Make Environment has-a NameValueDictory instead of is-a
We need a somewhat more wholistic approach on how to communicate
environment data and changes in the code, a single fixed map
doesn't cut it.

Change-Id: Ifbed254e7e0f4a76f8627e77030889c326f551d4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-02 10:55:56 +00:00
hjk
9524a3f025 ProjectExplorer: Make target device for executable aspect explicit
Just run and host is not enough, build device is needed, too.

This fixes the MakeInstall step for remote linux.

Change-Id: I3ec797379b7d0d5842780d505d8b87a91286e460
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-02 10:55:23 +00:00
Christian Stenger
beb28f8199 QmlDesigner: Fix Qt5 build
Amends c3b90c0ce5.

Change-Id: I16e37678a7981c22c62eaf772c6d8f4f15594bac
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-02 10:01:02 +00:00
Mahmoud Badri
d47ad10728 QmlDesigner: Fix small typo
Change-Id: Ic3fb65b8f8ecf80dcf65c21f5f3e5a35c42d0735
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-02 09:51:51 +00:00
Artem Sokolovskii
1241761035 ios: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: If29d2960692c42456967025d60e6d6d7ddd09928
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-02 09:42:19 +00:00
Thomas Hartmann
57cb9d888b QmlDesigner: Fix potential crash
Change-Id: I85e5b7d8f03e270540294a20ccc24658943a2c9b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-02 09:19:19 +00:00
David Schulz
b9627ddba7 Python: add pyside uic extra compiler
To be able to autocomplete code from .ui forms we need to feed the
python language server the compiled form. The uic extra compiler
generates a temporary ui_name.py file for uncompiled or unsaved ui
files. These files are inside a folder that gets appended to the python
path environment variable for the python language server.

Change-Id: I9f48d2012162f33986639315189c41e0a7e0dad2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-02 09:09:22 +00:00
Jarek Kobus
d8b404a1a3 CppEditor: Get rid of usages.h
Change-Id: I28d8a5f83f87329c2389b0ad99db006d7efa6dc3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-02 09:06:39 +00:00
Jarek Kobus
170527ae23 CppEditorWidget: Get rid of unused methods
Change-Id: Idb3b14089b8eb833530834ffb5583dda0b8917de
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-02 09:06:28 +00:00
The Qt Project
62f330219a Merge "Merge remote-tracking branch 'origin/7.0' into 8.0" into 8.0 2022-06-02 09:06:12 +00:00
Miikka Heikkinen
ffe94d177c QmlDesigner: Fix corrupted preview images in material editor/browser
Now a default preview image is shown if real preview is not yet
available.

Fixes: QDS-7055
Change-Id: Ia2f9ee3aa3b29f49224b6ba8ae8f22f1b36f629a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2022-06-02 08:55:47 +00:00
Eike Ziller
68c5968447 Merge remote-tracking branch 'origin/7.0' into 8.0
Conflicts:
	src/libs/utils/launchersocket.cpp

Change-Id: I7ec649485bb7fc7c299b571d92519d2b7fc9506b
2022-06-02 10:54:10 +02:00
Jarek Kobus
8cd9a2dd12 ModelManagerSupport: Get rid of UsagesCallback from findUsages()
It's not used currently.

Change-Id: Ic3625b0f3c53c09089a361453f29ac639692cffb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-02 08:52:55 +00:00
Mahmoud Badri
e1bb5d058d QmlDesigner: Mark unused params in material editor and browser
Change-Id: I5d1e2dcd340e766f829fe78edb63dfa8beacfa78
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-02 08:50:26 +00:00
Jarek Kobus
b9f0663741 ModelManagerSupport: Get rid of UsagesCallback from globalRename()
It's not used currently.

Change-Id: Id859251f69abf33de3431d1e8b561aedefbb4651
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-02 08:41:33 +00:00
Christian Stenger
6469f99995 QmlDesigner: Fix build with tests
Amends c3b90c0ce5.

Change-Id: I52eee2e9bcf78a1fb7315927efc861115b96a16a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-02 08:06:43 +00:00
Artem Sokolovskii
37bf11550e ScXMLEditor: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Ifaacfe54553e5400ae334263c2d346eeafe4b66c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-02 07:59:17 +00:00
Eike Ziller
bb5137d14a Merge remote-tracking branch 'origin/master' into 8.0
Change-Id: I37b000ea6ea6b5d8c4ac8ed9bf371bc91c14723e
2022-06-02 09:48:39 +02:00
Christian Kandeler
958531adbf Revert "QtSupport: Add support to register Qt versions via qtpaths"
The patch breaks several plugin unit tests; at the very least QtSupport,
AutoTest and ClangCodeModel.

This reverts commit 72aa77ced7.

Change-Id: Iaa7f452d0f43d0072b0bbcf8934fa0dcd6f9b240
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-06-01 14:24:20 +00:00
Artem Sokolovskii
92b3a51358 QMLPlugins: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Ie3e3ec9fdaea856943e5325cabd21e52bf290e70
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-06-01 13:47:19 +00:00