There is no need for special handling when running on remote.
Change-Id: If30245d2ece475cb72df2be4390210d6b8c0c1aa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Use QtcProcess with a path on device instead. Invoke directly
echo -n $SSH_CLIENT command and parse the output locally.
That was the only usage of SshConnection::connectionInfo()
in the whole Creator codebase.
Change-Id: I23a548e8dcfdff370d5db4c7ef10a560d5adc57e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This changeset allows building Qt Creator statically with a reduced number
of plugins, especially without QmlDesigner.
Change-Id: I0050c72d3959fe43edae60bd47ecab9c0ee544b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Use QtcProcess with a path on qnx device instead.
Fix QtcProcess::runBlocking() for remotes.
Change-Id: Ic9364037835b247479f4b4329e40a314e09d5492
Reviewed-by: Rafael Roquetto <rafael.roquetto@qt.io>
The fallback mimetype of application/octet-stream is supposed to only be
a fallback if the mimetype doesn't specify another parent.
Amends 98b1e82d2b
Fixes: QTCREATORBUG-27398
Change-Id: I4ac92dd4817fae37de4499fe9e08aa2e5dd50a51
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This is needed when moving ProcessInterface beweeen threads.
Change-Id: I26158c68bdc8e77ecb3e3d4535ba767ef3d0b63c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
And pass a device path to command instead. The QtcProcess
should automatically select the device's process implementation
when the process is running.
Change-Id: I9f6896260a3f5627975331caa31382f4dc6ff7b0
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
QbsSession::quit() is called only from QbsSession d'tor.
Move this method into private section.
Since QbsSession::quit() body was the only place in code where
we potentially set the m_state into State::ShuttingDown, there is no
need to check whether the m_state is set to State::ShuttingDown,
as that's impossible, since quit() can only be called once
during the lifetime of QbsSession.
Replace a call to quit() in d'tor with quit() body.
Since the ShuttingDown state was set only in d'tor, after
disconnecting from qbsProcess signals, it's not possible that
any signal handler would be called when being in ShuttingDown state.
That's why the SettingDown state is removed in this patch as
being no-op.
Change-Id: Iff77f4119d7122a9723de4a5cd0bb98f4dce8506
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This makes sure that the lsp filter gets enabled if a document is opened
before the corresponding clangd server was initialized. This happens
when loading a session with an open document.
Change-Id: I7987ea60c6fca8b5c070af3a7bcd5325667ed0c5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Instead of connecting to errorOccurred() and finished() signals.
Change-Id: I9fff11875a680240e63db1663299680f885dbdfc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
We delayed switching the "current editor" by the double-click interval
to fix opening editors in extra editor windows from the project tree
etc. This leads to the weird effect that after switching the focus
between editors even within the same window was only applied after a
delay.
Instead just delay setting the current editor by "two events". When
clicking into a window, Qt sets the focus in two phases.
1. First the focus ends up in the focusWidget() in the new window, which
possibly is the editor that was active before in _that_ window
2. Only during the next event processing does Qt set the focus to the widget
that the user clicked into, which could be a non-editor widget, like the
Projects tree
We may only change the current editor if the focus didn't move away from
any editor in (2). So we need to delay setting the current editor until
after the next event processing.
Amends 22c67db406
Fixes: QTCREATORBUG-27479
Change-Id: I3d9197176a2d7ce50e5f29a1ce1b2efef52232d0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
If a property actually is a variant we have to properly parse
the string and convert it to the correct type.
Booleans and numbers were not probably converted.
This did not create many issues, since the conversion happened
later, but it broke copy and paste and merging.
In Qt 5 this conversion seemed to happen mostly automatically.
Boolean literals have to be handled explcitly, since e.g. "10"
is technically true and can be interpreted as boolean.
Task-numbner: QDS-5944
Change-Id: I35c7cae7041667c7eac81e36a285a394263b35a4
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
