When looking up mimetypes by glob or magic, we may not add a mimetype if
it was overwritten by another provider that did not find a match.
The patch that implemented that was very inefficient, because a huge
list of "handled mimetypes" was created that needed to be checked,
every time a mimetype was determined.
Instead inform each provider about their overridden mimetypes once after
loading the mimetypes.
Amends 98b1e82d2b
Fixes: QTCREATORBUG-27319
Change-Id: I409856c272c334798d7a71ce590ff2d4f69c71a1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Use ProcessInterface's setup data when handling
readyRead signals. In this way the user may still
change this setting, also when QtcProcess is running,
as a preparation for the next run. In this way this
works like all other QtcProcess mutators.
Change-Id: Ie80475e322162ce109fb95468ce858f9c98eefa9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
... from CMakeBuildConfiguration to CMakeBuildSystem.
Less back-and-forth this way.
Also, prefer plain buildConfiguration() over cmakeBuildConfiguration()
back-pointers.
Change-Id: Ie1341302ecc10e53d71ca68b7b6eb5f46cfdad5f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
As an user I expect when I select Browse for the build directory
that after the directory has been chosen it will be taken into
consideration.
Amends 1d600101ee
Fixes: QTCREATORBUG-27407
Change-Id: I331b6095c176f57ca8e4c73c0b378a11ce3d6dbc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Since those are QML keywords those ids can create
all kind of unexpected side effects.
Change-Id: I9ecb9b0559c57d59104aacedfca505b559de9685
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
- Remove warning when .clang-format file is absent
- Remove warning when a page is nullptr in addTab function
Change-Id: I4232bc77eaac56c78707fc37aaf75b00b8af9006
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Old GCC versions have #define __cplusplus 1
Change-Id: I71286656df8f9925c2e0ccc46d32546037423268
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Get rid of public msgWinCannotRetrieveDebuggingOutput() method,
as it was used interally in Windows case only.
Get rid of m_listeningPid field, as that's the same what
applicationPID() returns.
Change-Id: I8bfac790f0d363e6f7cc12012597c7b8aaad6d92
Reviewed-by: hjk <hjk@qt.io>
Do not return false from QtcProces::waitForStarted if the process is
already running. This causes mayor issues on windows since QProcess
directly emits started and therefore switches to the running state after
calling QProcess::start.
Change-Id: I4604b08a59918d3df11c8a174b57e1e483e78a0d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Previously we were displaying the word size: 32 bit, 64 bit, but
nowadays we could have x86_64 and arm64 and "64 bit" doesn't cut
it anymore.
Change-Id: I02c1942eae2b93726554561fa4eb83ac8a97dfa0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This change replaces the generic thumbnails for online talks and
online tutorials with an actual video thumbnail + "play" overlay.
The video thumbnails are stored as .webm files in order to have good
compression and reduced visual artifacts. In order to fetch and process
the thumbnails from YouTube, there is now the new Python script
downloadytthumbnails.py:
usage: downloadytthumbnails.py [-h] [-xmlfile XMLFILE]
[-outputdir OUTPUTDIR] [-overwrite]
Parses a 'qtcreator_tutorials.xml', downloads the video thumbnails from
YouTube, scales them down to WelcomeScreen thumbnail size and saves them
as .webm files.
optional arguments:
-h, --help show this help message and exit
-xmlfile XMLFILE The 'qtcreator_tutorials.xml' file.
-outputdir OUTPUTDIR Where the downloaded files are written.
-overwrite Overwrite existing downloaded files.
Task-number: QTCREATORBUG-26937
Change-Id: Id7a91c757e5d87996026e3d0d9e63f1cb7f2d76b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Replaced by the more harmless joinArgs in a compatibility settings
code path for now.
Change-Id: Id6d94faea26002f4a2641b5824d97e09a783b720
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
After changing the protocol so that error signal is no more
sent we need to flush the buffered Done signal when
awaiting for Started signal.
Change-Id: I274bfa375db05627348684f11be535d79c62b42b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Instead of holding the start packet on caller side when
launcher socket isn't ready yet, pass it into the launcher
socket and buffer it there until the socket becomes ready.
This simplifies starting the process considerably.
Get rid of CallerHandle::canWaitFor(), as this is already
checked by QtcProcess itself.
Get rid of LauncherHandle::m_waitingFor field and
LauncherInterface::isReady() method, as both are not used anymore.
Change-Id: Ida6f0629170647249e562028c3ea5db1830b8a0d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This trades a now necessary order of setup for the now removed
"acquaintSiblings" facility.
Change-Id: I85058578b792e210f24573e2ab4e3a40a8813a11
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
In most cases we do want to visit the expressions in a function
template. Changing its accept0 would force those not wanting to visit
it to iterate on the templates (currently a linked list), so we add a
visit method explicitly visiting the expression in all the needed
places.
Fixes: QTCREATORBUG-21869
Change-Id: I47733544bfd32eec357810b97242608b8f7de572
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Instead of connecting to errorOccurred() and finished() signals.
Change-Id: I18548db319274ff28c78fc877711ce7536953212
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
No need to support pre-4.13 settings for an exotic feature like custom
toolchain parsers.
Change-Id: I4c9267d687049f66d3427ed596c91aaaa3c4a2eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It improve in the situations where the mouse move slightly between press
and release event, this should be mostly notable for trackpad users.
Fixes: QTCREATORBUG-26595
Change-Id: I36ef7d23c80c09b9248abd8313c040993ece92a4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It was no longer showing any updates. At some point MaintenanceTool
added <?xml...> headers to its responses, which broke our combine-and-
parse hack, since such a header in the middle of XML is invalid.
Add a hack that removes these headers first. This should be refactored
without the use of ShellCommand in master, because that doesn't allow us
to access the output of the two jobs separately.
Change-Id: I7248b070a8edb1a45248b3531ed50bb0d94eef73
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This has not been caught by GitHub Actions because sdktool is only
being built with MSVC.
Amends c246caf7a9
Change-Id: I620743467e24f77d2bc1861daa03202359d0cc6f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Both the "normal" Qt node adds an example set, and the Android/
Automotive node adds another one with the same paths, leading to e.g.
two items "Qt6 6.2.4" in the dropdown for the examples.
De-duplicate example sets with the same paths, which we already do if an
example set and a Qt version itself refer to the same path.
Fixes: QTCREATORBUG-27294
Change-Id: Ia469045b2f2812612fcd8328bdfd223479b8d449
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
- Indenter uses .clang-format file from a dir of
editing file or from a parent dir. If there is no
such file then indenter starts to use file from a dir
with the name current CodeStyle settings.
- Test fixed
ToDo: Add file absentness processing in case of import
Change-Id: If09ef0c598899856b948c214e524bcfd5dad76e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
