Commit Graph

62421 Commits

Author SHA1 Message Date
hjk
c9c2fef437 SdkTool: Add some docker specific fields to AddDeviceOperation
Change-Id: I0a1f41f9643f2b0eaabd9856d7febde383aa35a0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-09 13:26:46 +00:00
David Schulz
f477cdc2d7 Debugger: update source path mappings
Add latest mingw qt build folder.

Task-number: QTCREATORBUG-27143
Change-Id: I8e5beb21621c681e440d761e2f42635582bdb549
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-03-09 13:19:04 +00:00
hjk
fb9eae0472 SdkTool: Fix some help text
Change-Id: I68983e9dfd2bdff0cff0699f6680c4352cb85f21
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-09 13:17:23 +00:00
Orgad Shaneh
dd5199aa8f Android: Fix memory leak
Reported by Coverity.

Change-Id: Ic05716999a0ebdc21a01dc6790da941474257b5d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-09 11:26:03 +00:00
Orgad Shaneh
52beb85676 ElfReader: Initialize a member
Reported by Coverity.

Change-Id: Idddb778e02e1a26c251c5ead3ed5700545abae12
Reviewed-by: hjk <hjk@qt.io>
2022-03-09 11:25:39 +00:00
Samuel Ghinet
a61f7db1ea Fix: Recents don't show up for Custom presets
In the New Project dialog for QDS, if the user had created a project
from a User-defined (i.e. Custom) preset, this preset did not appear
under the Recents tab.

Task-number: QDS-4989
Change-Id: Ib1f5e772fc9a45ad727627152f292f6e1178ee8c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-09 10:55:49 +00:00
Jarek Kobus
65dd738a01 Fix a call to endFeed() when process wasn't started
Fixes the tst_qtcprocess::lineCallbackIntern() test.

Change-Id: Id608ab834deaccf854f3d8ff9f4a172de58ef9a2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-09 09:38:20 +00:00
Christian Stenger
f1d8c303a8 PE: Provide locator filter for run configurations
Allow to start a run configuration from locator or to change
the current active run configuration.

Change-Id: I3329becb889ffe07396b9b1f0dab4e5ee55aa7a8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-09 08:00:12 +00:00
Assam Boudjelthia
4ba957f9d8 Remove "Device" keyword from platform device name
QC uses the display name set in IDeviceFactory to refer to the
platform name. However, the display name usually have the "Device"
keyword at the end because it's coming form the IDeviceFactory.
That would work fine for example in new device creation dialog.
But QC is using that in other places like new file/project wizard
to show the supported platform for a project, and that's where
having "Device" seems unnecessary or wrong.

This fixes that behavior, but removing that keyword when calling
KitFeatureProvider::displayNameForPlatform().

Change-Id: I5fd4bbcb1ec2579f8b7e86226a7d50b6d7807382
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-08 10:57:49 +00:00
Assam Boudjelthia
0f6e9f7146 Android: don't add all the Service meta-data for Qt 6.2+
These values were removed in Qt 6.2, don't add them in that case.

Fixes: QTCREATORBUG-27088
Change-Id: I5560b18c0a849f7382b498097923ba425e47c40a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-08 10:57:12 +00:00
Samuel Ghinet
618eda3572 Implement custom presets
Task-number: QDS-4989
Change-Id: I95844ae97204ad3bb94905c89f8e16b79eed8f64
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-08 09:39:43 +00:00
Assam Boudjelthia
e1643c8903 Android: display Android 13 packages correctly in sdkmanger
Change-Id: I49cc45dce0523e55ff56df7e429dd9dc93f46534
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-07 11:45:33 +00:00
Rafael Roquetto
88aec12075 QNX: Fix debugger detection
The QNX gdb binary requires the QNX_TARGET env variable to be set even
for codepaths that do not make use of it, namely, when invoking gdb with
the --version or --configuration parameters to detect the ABI. Failure
to set this variable causes gdb to fail with "QNX environment not set!"
instead.

This patch works around that by setting a phony QNX_TARGET variable in
these occasions.

Change-Id: I9f2638c422eb56516b87dde049186579d238de5c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
2022-03-07 00:49:28 +00:00
Leena Miettinen
b9b30c1f4d Core: Rename Output &Panes as Out&put
This was overseen in another change.

Change-Id: I81e461d659dfe0793d8a593fc597acae57275992
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-04 11:54:56 +00:00
Mahmoud Badri
c250d31ca0 QmlDesigner: Enable dropping external assets to a specific folder
Fixes: QDS-6311
Change-Id: I25bccfa6788e3b5d47fc598decbf7e03a00399b4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-03-04 10:14:00 +00:00
Miikka Heikkinen
8da5a772fe QmlDesigner: Group also proxy actions of commands in Edit3DWidget
This fixes exclusion handling when actions are triggered via shortcuts.

Fixes: QDS-6301
Change-Id: Iedfaaed0c2f7d534fa77743a6daa093e334d001d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-04 08:29:29 +00:00
Robert Löhning
0fa5303916 Welcome: Replace search term when adding tags
Currently, both are mixed into one so neither of them works. When both
are separated with a space, the search term is ignored anyway so it's
better to just remove it.

Change-Id: I449b5d80dc50620f13f37c908e63877eb63b3c26
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-03 20:04:20 +00:00
Artem Sokolovskii
72991ea5c1 [ClangFormat] Fix bax with BasedOnStyle field
Behavior was: The field became "LLVM" after a change to another style.
Fixed behavior: BasedOnStyle field becomes and stays chosen style.

Change-Id: I0d41a216f7f06c5681cc20a52c736406307a3724
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 13:26:40 +00:00
Christian Kandeler
99f73bf37f Update qbs submodule
... to HEAD of 1.22 branch.

Change-Id: Id77d7265d226949cfce18124b4bee45b65c043f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:34:14 +00:00
Orgad Shaneh
c2cceee844 QmakePM: Fix potential null dereference
Reported by Coverity.

Change-Id: Ibdb47a711aca4989b22a7f94fd905deff86cb27c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 10:24:34 +00:00
Christian Kandeler
631e2c2a4a ProjectExplorer: Log some values to narrow down a bug
Task-number: QTCREATORBUG-26875
Change-Id: Ifad56dc711241a03d391328cae202adc338ee0eb
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:21:31 +00:00
Jarek Kobus
ac3aa805b9 QtcProcess: Ensure we set the data just after creating handle
...instead of ensuring in many functions that m_setup isn't null.
This amends 36c49cd2ea and
solves the issue for other functions like processId(),
exitCode(), etc...

Amends 36c49cd2ea

Change-Id: I986f7b30e90e5825ae2bb57b4bc2aa14f56e401f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-03-03 10:02:36 +00:00
Miikka Heikkinen
98673190ad QmlDesigner: Add visualization gizmo for ParticleEmitter3D
Particle emitters are now visualized in 3D edit view either by
a small sphere for point emitters or by a proper model for
model based emitters. The visualization model is rendered
transparent. The visualization models can be displayed either
always or only when the parent particle system is active
in editor.

Trail emitters are not visualized, as any visualization would
be misleading, since these emitters follow generated particles.

Fixes: QDS-6189
Change-Id: Idb6f12cadd9cea8110e5290cc18443aeb62c38d6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-03 09:34:57 +00:00
Eike Ziller
ce400a4482 File System view: Fix persistence of Show Folders on Top
Fixes: QTCREATORBUG-27131
Change-Id: I0252cc2d9f026873c7a6a8e70e457a8d150ca1c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-03 08:51:04 +00:00
Christian Stenger
b78b7d065f McuSupport: Fix build with Qt5
Change-Id: Iec6008f1cafd46988003a473791bf7cf1e56caea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-03 05:32:16 +00:00
hjk
36c49cd2ea Utils: Prevent early crash on non-existent commands
Change-Id: Ib94920835396e34827e7b40c30f48d28660e5fcf
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 16:35:28 +00:00
Jarek Kobus
5dd616d243 SshDeviceProcess: Forward declare IDevice
Remove some other unneeded includes.

Change-Id: I9392a61c37fa689f004d1837b3e5f94181c8586a
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 15:55:56 +00:00
hjk
d439a7a25f ProjectExplorer: Dissolve DeviceProcess
Move remaining device member to subclasses where needed.

Change-Id: I1a872315579c7f6529e8937d57511a9e99e06926
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 15:36:02 +00:00
Jarek Kobus
a17374778a Introduce ProcessProxyInterface, enable data sharing
ProcessProxyInterface will be helpful when implementing
public subclasses of ProcessInterface, like
general ssh impl, linux specific impl, qnx specific, etc.

ProcessProxyInterface is sharing private data
between proxy and target.

Change-Id: I8350837bb5f770d6605b860b146604cba5e6b592
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 15:31:13 +00:00
Alexander Drozdov
771d0d67b9 RunControl: fix device passing to the doStart()
Brokken by the f1e973de79.

We must pass local `runnable` instead of runControl()->runnable(),
otherwise device member will be nullptr that breaks all non-Desktop run
configurations, like RemoteLinux one.

Change-Id: I0499008aee14cb3bbcc3e1ebda71c50533b6502e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 14:18:31 +00:00
Cristian Adam
8c00c4c34e CMakePM: Do not modify container in loop
Amends 2f77dc3415

Change-Id: Ida99d5c83eb1b30865b90d83583244728efb38a7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 13:36:09 +00:00
Jarek Kobus
8e0ae8ba96 QtcProcess: Limit the inclusion of qtcprocess.h
Move the rest of QtcProcess enums to processenums.h.
Move ExitCodeInterpreter into processenums.h.
Remove superfluous Utils:: prefix.

Change-Id: Iaa596f353d33d6930085a621b114cc15a35caa80
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 13:30:39 +00:00
Jarek Kobus
6ff1723c4c ProcessInterface: Move out default impl into separate class
Introduce private DefaultImpl class and base QProcessImpl
and ProcessLauncherImpl on it. Remove default impl specific
methods from ProcessInterface.

Change-Id: Iea964ab19cc0ea8401180f65351b6ef3f595703f
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 13:30:14 +00:00
Christian Kandeler
9735049e2c ClangCodeModel: Suppress "Unknown argument" error
Unknown compiler flags are an unsuppressable error in clang.
But we do not want to maintain a blacklist of unsupported GCC and MSVC
options or a whitelist of supported clang options, as both would
constantly go out of date.
As clangd seems to work fine despite the error message, we simply filter
out this type of diagnostic.

Fixes: QTCREATORBUG-27113
Change-Id: Ib32601831eded60daf80eb0ca5cf01bbd71493fa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:54 +00:00
Christian Kandeler
f8cec0a85a ClangCodeModel: Properly highlight static data members
C_STATIC_MEMBER is mutually exclusive with C_FIELD, so it must not be a
mix-in style.

Task-number: QTCREATORBUG-27111
Change-Id: If9e5f44790f1b7d124f4b2e9859f8c2223c0c424
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:22 +00:00
Eike Ziller
4c465ed654 Switch to new MIME database implementation
Can be switched to old implementation by configuring with
-DQTC_USE_NEW_MIMEDATABASE=NO

Change-Id: I0fdd104c422093381589f2e154ab2b093fe92ad9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 12:41:27 +00:00
Jarek Kobus
c24ff5ad19 Use const iterator for erase
Change-Id: Ibfbc19518ad6d7d28cf864f1f94125222ed62c28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 12:35:33 +00:00
Jarek Kobus
ff0ce27c1f ApplicationLauncher: Unify API
Make the API more similar to QtcProcess API.
Rename:
  processStarted() -> started()
  error() -> errorOccurred()
  processError() -> error()

Change-Id: I86d650d55a643f5999fc91e56b985f699e2d7245
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 12:34:06 +00:00
Jarek Kobus
14d39b871d SshRemoteProcess: Add missing override
At some point QtcProcess::start() started to be virtual,
so the intention is that SshRemoteProcess overrides it.

Amends 95c9579c58

Change-Id: Iff0c0984f07440c58c5f89a0f5e188503756d6d0
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 11:39:22 +00:00
Christiaan Janssen
da6cf91432 McuSupport: Change Kit Aspects validation check CMake variables
Before QUL 2.0, path for tools used during compilation were passed as
environment variables. Starting with 2.0, they are passed as CMake
configuration arguments. So, in order to validate a kit, the
dependencies aspect now needs to validate the CMake configuration
aspects. As 1.9 will no longer be supported, starting with this version
of Qt Creator, the environment checking code is removed.

Change-Id: I24991063dcdf9b455bd8f20226756dc2b3637f6d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-02 11:37:53 +00:00
hjk
1ae012df94 ProjectExplorer: Fix undefined behavior
Amends 6942c58d65.

Change-Id: I8db8ab1fd1d52467aefdc93f639816bfa1379277
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 11:37:37 +00:00
Jarek Kobus
4bb4bc2a99 Use ProcessInfo instead of DeviceProcessItem
Remove DeviceProcessItem class.

Change-Id: I2fcac473dc12b47f50c329645f27d60619304e77
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 09:53:29 +00:00
Jarek Kobus
87154986d2 SshRemoteProcessRunner: Remove unimplemented method
Change-Id: I4c075da36bc4f50a35692fd1ae2a61504954a05d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:57 +00:00
Jarek Kobus
53095f666f SshRemoteProcessRunner: Unify API
Make the API more similar to QtcProcess API.
Rename signals to started() and finished().

Change-Id: I01f3a148749b666b8f145d8769222a234ccc9bce
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:47 +00:00
Jarek Kobus
b5cf3186a3 SshRemoteProcessRunner: Drop error string from processClosed()
Change-Id: I3d05fb253944d6fa47854693aa4ee21d36b35a32
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:33 +00:00
Jarek Kobus
d3c1632a0f SshRemoteProcessRunner: Unify API
Make the API more similar to QtcProcess API.
Drop process prefix for getters.

Change-Id: I21b99bb5b11956d923c0e526c08bbea9686e5c95
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 09:52:09 +00:00
Eike Ziller
b7abe6a6ac Mimetypes v3: Re-implement setGlobPatternsForMimeType
Allows setting the glob pattern in the MIME Type settings.
Not implemented for BinaryProvider, since we don't use that for Qt
Creator.

Re-implements part of afa2212f8d

Change-Id: Ib9ab06aac833cb7d81d894e0d502f6d169618710
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 08:03:05 +00:00
Eike Ziller
897907f401 ImageViewer: Handle invalid SVGs and GIFs nicely
Fail opening the file in the image viewer, like we do for other images,
so Qt Creator can offer a different editor (binary editor).

We have separate code paths/backends for SVGs and movies (including
GIFs), which didn't catch invalid images early.

Fixes: QTCREATORBUG-27121
Change-Id: I1bfbca70b7d76ee9cac3e0f35494b62e3856069e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 07:48:33 +00:00
Tim Jenssen
2dfa9f0882 qds: fix crash, if two or more projects be opened
Change-Id: I8b91f8ce0139334e765d6dd55e1afefbbe5366c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 20:18:15 +00:00
Thomas Hartmann
1ea773f187 Help: Show home page when activating index or content
Instead of showing the last page this will always show the home
page when activating index or content from the help menu.

Task-number: QDS-6392
Change-Id: Ic158d22ba3739f5db513e04ebde00fdadc24a9d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-01 19:25:39 +00:00