Like you can read in https://www.sqlite.org/isolation.html after an
update they same value can be show up for an iterator advancement. This
would be lead to an delete. So the last value for update is saved and
then compared in the delete method. If they are equal the delete is
skipped.
Change-Id: Ic0aa6619f6a4a520eac77be4e5a83cbe533d102d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This prevents that it is changed by accident. It should be anyway not
accessed outside of tests and the storage.
The reinterpret cast is defined behavior.
It would be nice to make the constructor private too but it is used widely
in the tests.
Change-Id: Ib0e8393cc950a651138c1e87c1b6a7b3e5a836f2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The ids were sometimes casted, sometimes copied to integer values. Now
the cast is moved to an extra function.
Change-Id: I3dcdbde05461f2fca700cc9020758738266d5fd2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fix the connection editor not picking up all the slots of a model node
due to setting a wrong expression in the QmlJS::Document.
Change-Id: I2d28e1e779c5293991397ebc2a061c35234d9cae
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Only used internally now, other usages were changed to
defaultEditorTypes().
Change-Id: I39f272dd0610c14070a16b7f9df1c7ef0adb17fd
Reviewed-by: David Schulz <david.schulz@qt.io>
Makes it possible to set an external editor as the default handler in
the MIME type settings.
So far that is ignored though - in that case all functionality falls
back to the default IEditorFactory instead.
Change-Id: I9bd2a1366f64f16fa648451600b4045323f87bd0
Reviewed-by: David Schulz <david.schulz@qt.io>
As preparation for both being selectable as default editor type for a
mime type.
Change-Id: Ie34ad25caa7fe0cc0b740c96743db9bab378bf24
Reviewed-by: David Schulz <david.schulz@qt.io>
The Client might be already deleted when the text editor codeassist
calls cancel on the processor.
Change-Id: I6b0b484a086456ed9d0543f530aea0fae32c523a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The old document is already deleted after closing the last editor.
Checking the document before updating the ui prevents it in that case.
Change-Id: I7e65fd1203b6e843ae6dc93d2c304974d5b48a69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The list of supported image file formats of the asset loader
was missing an entry for the jpeg extension.
This is now fixed by generating this list out from the result
of QImageReader::supportedFormats with the addition of the
.hdr format.
Fixes: QDS-5713
Change-Id: I65ccbe4c02e1b4eb725b6bb14d154bbfddf8fa9c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Force QApplication use in puppet if widgetApp is set to true in
the project.
Task-number: QDS-5686
Change-Id: Id1be1f1e6b7239015c4c33f2e3866f78b0f878a7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Widget was the default apptype in Qt5, but in Qt6 the default was
changed to gui, so projects with qml modules that depend on widgets can
no longer be launched. Notable example of this is QtCharts.
Added "widgetApp" qml project property to allow users to specify if
they want widget or gui based application.
Task-number: QDS-5686
Change-Id: If0787421c79d4ba24a0f8513c8538126bcf29b4e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This also allows a bit smaller minimum width for the dialog.
Also, did a bit of cleanup.
Task-number: QDS-5500
Change-Id: I3660190ac0a73dd1da1c7d6f8ee76660b1fba6be
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
ElidingLabel with elided mode set other than Qt::ElideNone will not show
in case QFormLayout has QFormLayout::ExpandingFieldsGrow field growth
policy
Change-Id: I26db57fbeb2c921e054cf7dc18229ebddcb04530
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Since the AVD manager moved into the "Devices" option page, the SDK
manager tab was left alone in the QTabWidget. One single tab looks
strange and uses more space than needed.
This change turns the SDK manager area into a QGroupBox, which is
consistent with the rest of the Android Options page. This patch also
adjusts the margins and spacings of the SDK manager widget to fit to the
rest of the options page.
Change-Id: Id1ed38862e8f9e984f53cdfb59492e30902162a7
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
transforming list of args to set can change order
of arguments as well as count, which can make
application unable to run
Change-Id: Ib8164e0b7661511f738bdc3b21e74fbaaa6a5252
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add an info message when sdkmanager is reloading the packages, and also
don't expand the summary widget when the widgets are not active,
which can be when the packages are being reloaded or when the licenses
are being reviewed, this will give more space for reviewing the licenses
instead of having the summary take most of the settings page space.
Change-Id: I6acf3f6edc3b3d3fa78f0ba00308a21f8bb4fa72
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Amends 825c9ea64f to work also for member access via pointer.
Change-Id: I8ee68d0f6d93c65c2f82a63bce5baef2aa2159de
Reviewed-by: David Schulz <david.schulz@qt.io>
Text marks for diagnostics should be deleted when the client dies. If
they somehow survive assert when creating a tooltip for those text
marks.
Task-number: QTCREATORBUG-26585
Change-Id: Iaebf0d2aba66d2a6c250f8dad7856ef03b1dcacd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This works around the issue that we only looked for qmltypes in the
directory the binary ends up being stored in. This did not work
for macOS and Windows as those are stored in subdirectories due
the platform specific ways binaries are stored there.
Now we also look in the directory where the qmltypes should be located
on these platforms.
Task-number: QTCREATORBUG-24987
Change-Id: I23d46e68f8fad0b4e2e8a01fc7c41360f1e6961e
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Still trying to ramp down non-QtcProcess interfaces.
Change-Id: I6b4ae6788f5021959ff3eb35bbade2157a6d67fa
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
ICore::settings() lives longer than anything in TextEditor.
Change-Id: I67df38f291f43763bdd236ea611db614ac515c97
Reviewed-by: David Schulz <david.schulz@qt.io>
in the global settings.
Change-Id: I2f90388c138c92f03f78044e225574ded640d4b9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The built-in code model treats the "local uses" result state as an
indicator of whether to provide quickfix operations. It's unclear what
kind of side effects would result from removing this condition, so we
always run the built-in variant of the "local uses" code, and only
refrain from actually updating the selections in the clangd case.
Amends 0c53c2daef.
Fixes: QTCREATORBUG-26649
Change-Id: I9e1a3e3ad08bf13bcb35efe996a61aa34302b166
Reviewed-by: David Schulz <david.schulz@qt.io>
Snippets collection managed the snippets with persistent iterators to
the "end" of the active snippets. Qt 5's QList was nicely updating
iterators even on non-const operations, but that has changed in Qt 6.
Don't use iterators, simply work with the count of active items.
Fixes: QTCREATORBUG-26648
Task-number: QTCREATORBUG-24098
Change-Id: Icc13274daf0e87d0562d80d7bc763c863d5da075
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
