Commit Graph

76860 Commits

Author SHA1 Message Date
Ali Kianian
a0e87e458b Sections could be non-collapsible
A property named collapsible is considered for Sections. The default
value is true for this property.
The section would be affected by the user collapse request if the
collapsible is true (Single collapse by clicking, and colapseAll
request). Otherwise, the section will not be affected by user
requests.

Task-number: QDS-7527
Change-Id: Ic4c9d0489d4b8c9ec90a0c71c755fa4c52935d39
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-10-18 06:22:55 +00:00
Marcus Tillmanns
742f92d246 Docker: Use host.docker.internal
DockerDesktop on Windows and macOS provide the hostname
host.docker.internal to reach the host machine. We use that as its
more likely to work for different setups than trying to figure out
the host ip yourself.

Change-Id: I9f594d0e97e7f35ceb580ac3e3304de999bfea9c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-18 05:39:58 +00:00
Rainer Keller
3499cd79c7 McuSupport: Delete unused widgets
The takeRow() function does not delete any widget. New rows are inserted
using newly created widgets. This results in a memory leak of hidden
widgets.
This change deletes the widgets when removing them from the layout.

Change-Id: Idda877c3cf5c20fc40bfbedb26da11270752e821
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 04:36:08 +00:00
Rainer Keller
cb1ca97ded McuSupport: Set initial parents for created widgets
Change-Id: I2e1575e848b7480dbabf1193fccfba2596c0f431
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 04:35:30 +00:00
Orgad Shaneh
ac28843c3a Themes: Use lighter link colors in dark themes
Fixes: QTCREATORBUG-28152
Change-Id: Id387d20373a3e19a36af9ec8f8c44798e1008ed1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-17 16:21:43 +00:00
Eike Ziller
66b99b5086 Fix translations of FolderNavigationWidget after moving to Core
It moved from ProjectExplorer::Internal to Core, and there is no reason
to throw the translations away.

German translation is fixed separately.

Amends dc5717bd06

Change-Id: I7a0a88c70e3454374de0b994fa1c20557c9a24e8
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 13:59:48 +00:00
Eike Ziller
86beb2a950 Fix translations of file properties dialog
After inlining the UI file. Context changed and moved into the namespace
"Core::...".

German translation is updated separately.

Amends 568f83d964

Change-Id: I0540a533113f3f38ab527a6c6d8614c2699a6578
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 13:56:23 +00:00
Alessandro Portale
ceee8f4505 Squish: Fix if statement with empty body
Change-Id: Ibf8ab419e26f896e3eabfb9c42c86ca87cd2801d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-17 13:37:44 +00:00
hjk
5b287c9210 ProjectExplorer: Avoid prefixing schemes with slash
Without that I get folder nodes named  "/ssh://user@12.23.45.67/..."

Change-Id: I03f87c650478781fe934e8a647a8883f024b7a2b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-17 13:19:19 +00:00
Eike Ziller
7d8a140f05 Beautifier: Fix enabling of options
Set the path to clang-format after connecting with the path chooser,
otherwise setting the initial enabled state breaks.
Broke when inline the ui file.

Amends 4933697d9a

Fixes: QTCREATORBUG-28297
Change-Id: I4c6ff7c4515edf13569cf5cd125623005f2967ad
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 13:12:01 +00:00
Christian Stenger
0264aa2a21 QtSupport: Restore some more object names
Change-Id: Ia88dd8e5d3b512227f4d81e01573881afdfbe58c
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 12:38:51 +00:00
Yasser Grimes
b587110cf0 McuSupport: Fix path to QtMCUs not changing
This change will prevent creating a second fileChooser when parsing
QtMCUs package.

Task-number: UL-6612
Change-Id: Ib63ae77a051122ff2ba8656dedbe7ee6fd43e499
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-17 12:34:17 +00:00
Marcus Tillmanns
5b3efd61c7 Utils: Move deviceshell script into .qrc
Change-Id: I6acb542163ebe39aaea8a1f1c1b84d355f25eccc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-17 11:50:51 +00:00
Christian Stenger
bdf3c2d576 Squish: Slightly tweak the validation of Squish path
The settings validated so far only whether the given path is
an existing directory.
Check at least the most important indicator whether this path
can be considered valid or not.

Change-Id: I01a35a4e694e309b0fd304c869b6e9d31211f38d
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-17 11:17:55 +00:00
Eike Ziller
06402e0dc6 Re-add "Toogle Bookmark" icon into touch bar
Instead of "Edit Bookmark" which was not intended to be there.
Also move it behind the "navigation" items, since these are probably
used more often.

Amends ac47d51bfb

Fixes: QTCREATORBUG-28108
Change-Id: I47c443772488b7f9e29c8fadf01011d4ddfd5686
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-17 11:14:05 +00:00
hjk
bf57568880 RemoteLinux: Fix RsyncDeployService::setDeployableFiles()
It previously did not set, but appended.

Amends 515845b815.

Change-Id: Ida3bd66e188ad4b1bbf0ea7686ac101a3f61c28e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-17 10:28:31 +00:00
David Schulz
c7cef250b3 Docker: fix device path mapping
Amends 1fa3255242

Change-Id: Idd2e0916769cd822b97e1fc851d8f706316cca83
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 10:06:52 +00:00
Robert Löhning
a16e74fe96 SquishTests: Fix type of Git.ChangeSelectionDialog
Amends 729805e7fd

Change-Id: I79f67e5d233734ab25da1ff8a2d135061fa139e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-17 09:35:56 +00:00
Robert Löhning
bf45aa4d24 SquishTests: Update tst_git_clone
Reverts f5f684a609

Change-Id: Iad797f87333e8d793e34c4e7df1f68c5f6508f82
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-17 09:35:39 +00:00
Mahmoud Badri
fdffb6c7d9 QmlDesigner: Fix crash when bundImporter is nullptr
Change-Id: I54436b0199babe53dcaec61c74b34ed72e80ea7b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-10-17 09:17:53 +00:00
hjk
88837631de Utils: Remove a few QFileInfo uses from FilePath::relativePath
Change-Id: I0896678688cc9f7b1d635890eff0603a89f3b2e3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 08:53:35 +00:00
Robert Löhning
d95977db90 CPaster: Restore some more object names
Change-Id: I590baed6d2a2ea4a8dd56f471ac7d4d0a015c725
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-17 08:51:23 +00:00
Marcus Tillmanns
6961790085 Utils: Fix theoretical use-after-free
Change-Id: I909f2dcd71c2286036f43fce6fc8aa61c55a6695
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-17 08:12:58 +00:00
Rainer Keller
2857c73df3 McuSupport: Hardcode the title of the groupbox
The main McuPackage does not provide a title anymore. It was removed in
df92e79da4.
Since then, the title was empty and the second group box showed a faulty
text. This change hardcodes the product name as it is not going to change
very often.

Task-number: QTCREATORBUG-28302
Change-Id: I6180579c9dce2f2f8aa939fb99088b4867d699fc
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-17 08:11:52 +00:00
Mahmoud Badri
b983b8aa52 QmlDesigner: Implement unimporting bundle materials
Fixes: QDS-7904
Change-Id: I08642c25a2844547d0104a7b3d9fda6afe47cd38
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-10-17 08:05:50 +00:00
Alessandro Portale
ca4566f3e8 QmlProfiler: Remove access to non-existent TimeInPercentRole
Change-Id: I4b909164d7d69e1fb1902ffde2a89ffdda455751
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-10-17 07:42:33 +00:00
Alessandro Portale
e36ff27403 Tracing: Fix several occurrences of "Unqualified access" in QML code
Courtesy of qmllint via qmlls.

Change-Id: I28c0a8f7ec17a93831fd1f5d9d2de5547a633965
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-10-17 07:42:28 +00:00
Christian Stenger
86d41d58a8 Squish: Restore some more object names
..and adapt test slightly. Fixes generic highlighter test.

Change-Id: I72de310d55ceadc684d15d4e257cd1d90fcf836b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-17 07:16:53 +00:00
Eike Ziller
ddd697c371 Don't clear the clipboard at shutdown
No idea how or why that was done, but it is destructive.

Fixes: QTCREATORBUG-28317
Change-Id: I4fe34ce6b40b81c52bbac31ce384b4e2eb3ad983
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-17 06:58:36 +00:00
Leena Miettinen
de357a138e Doc: Update docs after CMake preferences were moved to separate category
...from tabs in Build & Run and Kits categories.

Task-number: QTCREATORBUG-27876
Change-Id: I4f808eaaa32fa978e3ef06d0a3f2a9739d8ef726
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-10-14 14:21:40 +00:00
Orgad Shaneh
7c25d1a895 Git: Pass only files after -- on Blame
It works, but is likely to break at some point.

Change-Id: I97952a7cb6cd3569adc694db7537fab807bda0ea
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-14 14:01:53 +00:00
Eike Ziller
8db0d3b0ff Fix lupdate issues
- missing Q_DECLARE_TR_FUNCTIONS
- some full qualifications needed for confused lupdate
- avoid breaking some translations from former TaskListPlugin,
  VcsCommand and highlighter settings refactoring

Change-Id: Ia3b34095512a7bad6903f0aff6095313ee39e3e4
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 13:26:45 +00:00
hjk
ec430787e5 CMake: More FilePath in Deployment data
Change-Id: I898a621a34558a28d4688a33aeb9bb9148df6901
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-10-14 13:01:15 +00:00
Marcus Tillmanns
a1e960a27c Utils: Fix iterateWithFind
The change of runInShell to take QString + QStringList meant
that the caller was no longer able to fine tune the argument
escaping. This lead to "find -exec ... \;" being escaped incorrectly.

Changing back to CommandLine fixes this.

Change-Id: I55b09bd745c09912a2a0b4e43432824a99c0dd4e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 12:52:03 +00:00
Christian Kandeler
679a726330 C++ support: Consider project-specific target triple
... before creating project parts.
Otherwise we can get wrong includes and defines from the compiler.
Amends 9c86e6746f.
Also do not add -m32 or -m64 for non-x86 targets.

Task-number: QTCREATORBUG-25615
Change-Id: I02da9251c77d45fc8827990a2d59c3ae2c262591
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-14 12:30:14 +00:00
Orgad Shaneh
183dfb48a7 VCS: Rename function
Change-Id: I593e1db222e2124f3db367620171f3a101b4b8eb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-14 12:24:18 +00:00
Marcus Tillmanns
22c4e9318a Docker: Remove unused function
Change-Id: I683de49c08411087e47be84265cbab62d4d0738e
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 12:06:41 +00:00
Orgad Shaneh
967e8cf260 Git: Respect text encoding in project settings on diff
Fixes: QTCREATORBUG-21794
Change-Id: Ib4be9811c0ab1cba5cad4adbfe740a6d99f420d1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-14 11:21:17 +00:00
Miikka Heikkinen
7a967d385e QmlDesigner: Add unimportFinished signal to BundleImporter
Change-Id: I6d7ab5716f1bf6fe48f454d0c95c29ebd5d181de
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-10-14 10:56:40 +00:00
Marcus Tillmanns
359ad56e17 Docker: combine escapeMountPath function
Change-Id: Ib04f8245d2da096a9d9fdbdf9b5243ca80d52bfa
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 09:52:22 +00:00
Marcus Tillmanns
9aa1d56f56 Docker: Fix isValidMountInfo
Improves checking if a requested mount is actually valid.

Change-Id: I37638d26ddd46776e6375481cf1d73ed0ad24210
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 09:49:58 +00:00
Marcus Tillmanns
0b40e4b032 Utils: Fix FilePath::toFileInfo()
Change-Id: I91f75511758e606c9e9ff1338b272e6b03c26986
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 09:49:48 +00:00
Marcus Tillmanns
24d11e66b4 Utils: Fix FilePath::isChildOf
Previously isChildOf would only look at the path.
But if the two paths are from different devices
it would mistakenly return true if the paths were
similar.

Change-Id: Icdb1aebe61167183ec85fa56ae0708681a59a9f8
Reviewed-by: hjk <hjk@qt.io>
2022-10-14 09:49:10 +00:00
Christian Stenger
2d84e8b28e Squish: Inform server if global scripts get configured
So far, this had been just a visual representation.
But, global script folders have quite some deeper meaning
than just some convenience inside the IDE.
So, if the user adds or removes global script folders
inform the server that this has been done.
As on it, fix model mapping.

Change-Id: I239de61c6b49006dd2f1e0275138aaa3022d1482
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-10-14 09:19:53 +00:00
Christian Stenger
737d418989 Squish: Construct CommandLine instead of arguments list
...when preparing the runner process. Gives more control on
how the arguments are used.
This allows to pass arguments as "raw" arguments to avoid
CommandLine internal quoting.

Change-Id: I1cdf8bafa53d8618db8ab4711b04404154d3b90e
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-14 09:19:38 +00:00
Leena Miettinen
c51ca1fd82 Doc: Improve quality of Squish plugin icons
And add the button name to text to help users find it in UI.

Change-Id: I3d7096ac13855b697c97f6affe146a088241259a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-14 09:16:45 +00:00
hjk
9e4eabb410 RemoteLinux: Dissolve AbstractRemoteLinuxDeployStep::createDeployService
The previous setup doesn't buy much in comparison to new + setDeployService()
combo. Making that explicit now opens the path to simplify the two-phase
creation (i.e. move setInternalInitializer to the service c'tor).

Change-Id: Ib66c7d02efcddd6909fe612a786034e2728cdedf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-10-14 09:12:40 +00:00
David Schulz
01b07c0563 LanguageClient: deactivate documents on client shutdown
Change-Id: I0a3aa89b1390f3cb7d5816bb85d9fd538fb3f90b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-14 09:08:11 +00:00
Marcus Tillmanns
1b6728538e Clang: Fix compile_commands path setup
Change-Id: I2af0935ad022714f8e929c483455a8800e9f7cca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-14 08:53:28 +00:00
Alessandro Portale
f079a36200 Utils: Re-increase font size for DetailsButton on macOS
Fixes: QTCREATORBUG-28266
Change-Id: Iab9ef85cb30e5c75f20bda34f7ceee7a0363aa1c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-14 08:43:33 +00:00