Some unusual contexts went unnoticed so far.
Change-Id: I6017d8ae92310ee3b56538d1fa5c52f0de0a4c8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It should be still exported as it's a part of
FileData class, which is also exported.
Amends b677fbe992
Change-Id: I0d53dff2c355cddf7d1f3d001cb7b71210c75223
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
...in Release builds
Signed Release builds are now deployed correctly by giving
androiddeployqt the --release flag during the Deployment step
for Release builds.
Unsigned Release apks are now correctly built under the release
directory by giving androiddeployqt the --release flag during the Build
step for Release builds instead of determining build type from whether
or not the package is signed.
Fixes: QTCREATORBUG-28163
Change-Id: I319bc95325c88fb84a5997c9237df65eb7983c0e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Moving all initializations that are not influenced by the document to
the TextEditorWidget(Private) constructor. So we do not reinitialize or
double connect unintendedly.
Change-Id: I42f4e8166c21aec9c8b780033b12eb8dae5f72a6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Suffixed are meant to be different for both editors.
Amends 2d360db2c3.
Change-Id: I4bf8f2b066dbf420eba38a56301d6e24a685caf3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Needed to keep the QCoreApplication::translate for now as the class
has a Q_OBJECT creating a different context.
Change-Id: I1b1d836be675bdcd2802070032a7ace92838498c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Also use path() instead of toString(). While this doesn't change
anything as long as there is no remotely running QbsSession,
path() would be the better choice then.
Change-Id: Ief98536b34fe615f6b0be03cb3072df7b69f293b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Add static PatchTool::confirmPatching() and reuse it
in two places.
Use Tr::tr() inside PatchTool.
Change-Id: I70779619dbb58ab6e46a585bbeff51588ccb2f53
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If the user presses enter when having focus on the TextField inside the
StateGroup rename dialog it will submit the change and close the dialog.
If the user presses escape it will reject the change and close the
dialog.
Task-number: QDS-7764
Change-Id: I8626c7b9ca9bf6d087c226343b3e6833641da54c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The values coming from a CMakeConfig do not contain
the device they are relative to.
This transforms the FilePath to be relative to the device
that the cmake executable was run on.
Change-Id: I7bfdf065ddb4acfc751ac6456f1c32398393e2ad
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Squish uses the test case entries inside the suite.conf
only for sorting and determining the run order.
In fact all folders inside a suite that match the common
pattern will be used.
Adapt our handling accordingly.
Change-Id: I57121bb7715c648b6f0416012c71227261e140b9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reading and writing using QSettings was quite a bad idea.
Introduce helper functions to read and write the content
of the suite.conf and ensure correct parsing of the values
for the AUT or the test cases.
Change-Id: Idc8b0935c7eb2603a476c358e3f2ba76d3d29d33
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the cursor is already at that position move the cursor to the start
of the line edit. This mimics the editor behavior that home moves the
cursor to the relevant position for that line, and if the cursor is at
that position move to the actual start of the line.
Change-Id: Ieedbc0de0f93b0ffa3f3b64ccbcb04471b004e8e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Stop using MaximumXXXType in events where they might be saved into
trace files. It makes older traces incompatible with new traces if
new fields are added since new versions treat them as valid events.
Instead use UndefinedXXXType that doesn't change if new fields are
added.
Add checks for event types greater or equal to MaximumXXXType where
they are missing so that older versions do not process new
unrecognized events.
Fix opening old traces by checking missmatch between quick3d event
and the range type.
Fixes: QTCREATORBUG-28146
Change-Id: I8950da2d636ef1fedf4500916896a9ecae222166
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Previous implementation uses MaxMessage and MaxRangeType constants to
specify events with undefined message or range type. This causes
backwards compatibility issue if new message or range types are
added, because those constants are also written to files when saving
profiler traces.
Add UndefinedMessage and UndefinedRangeType constants and use those
instead of the MaxMessage and MaxRangeType constants. This doesn't fix
opening old traces, but the same problem won't happend again with new
traces.
Also update profiler autotests with fixed data.
Task-number: QTCREATORBUG-28146
Change-Id: Ief003d39f871dd1ff2cc908e6a4d4b4678fd0868
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Makes it easier to shuffle them around.
Change-Id: Id80064a05ff6d2b76ec9033b4e0065f0bd0d81ae
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Less impedance when interfacing the rest of the code.
Fixes
warning: comparison of integer expressions of different signedness:
‘std::vector<....>::size_type’ {aka ‘long unsigned int’} and
‘qsizetype’ {aka ‘long long int’} [-Wsign-compare]
Change-Id: If5e1e770e2ed170aa4259963fa7ca0d6642190d9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The QNX Plugin did call kit->isValid() for every Kit, even
if it is not a Qnx Kits.
This patch turns the check around to first make sure that the Kit
is a Qnx Kit, before validating it.
Change-Id: I47bc20ffd1387deab3ab5ec3a56d9536b76d515f
Reviewed-by: hjk <hjk@qt.io>
For some reason lupdate doesn't find the right context and adds a "Tr"
context. Fully qualifying the call helps.
Change-Id: Ib993ad2d742a88352c9c2021184100eaa659b9b6
Reviewed-by: hjk <hjk@qt.io>
Enables the removal of static function scope variables.
Change-Id: I337468c1525546a5cad9e95ae4a859de18ee514d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When a QtcProcess is the first thing using a dockerdevice
the container was not started and the call would fail.
Adding updateContainerAccess to withDockerExecCmd
makes sure that the container is started.
Change-Id: I7e05df1aa5e05dc55606970214109b13b142181e
Reviewed-by: hjk <hjk@qt.io>
