Otherwise pyside6-project cannot find uic or rcc or might use those
tools from another pyside installation.
Change-Id: I34eff2fc2627b07a18a705e5d658bd7cf8ce9350
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Avoid manual termination and killing - use either
QtcProcess::close() or default QtcProcess d'tor.
Both will employ internal reaper for terminating
the running process asynchronously.
Change-Id: Ib1de1125da0c25b4f5c5b7ac0827336f99881679
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When we call QtcProcess::stop(), the terminal process invokes
stopProcess() method. However, if it doesn't emit done() then
subsequent call to waitForFinished() will timeout with 30 s.
This should fix the 30 seconds hang when debugging in terminal
after pressing the red square button.
Change-Id: Iea1f9ade85dc8a4414dc49d7c8a2cbe80f0b5756
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
There's a QTabWidget and a list of RunControlTabs, whose indexes got
confused in several places.
Fix this and decrease the likelihood of the problem occurring again by
never using indexes for the RunControlTab list.
Fixes: QTCREATORBUG-27743
Change-Id: I8a83b0c802fe76a09b4eba0da999a52fdeb6ddac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... when in clang-cl mode.
We observe strange behavior when keeping the MSVC /std:c++xx syntax,
namely that files that are not specified in the compilation database
appear to get parsed without a language version. The problem does not
occur when passing the flag via "clang:".
Fixes: QTCREATORBUG-27764
Change-Id: I0035e5fef6dfd37fbbe396b538f38fc29b23923b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This was broken by our compiler command line optimizations, resulting in
"-x" rather than "/T" appearing for MSVC/clang-cl toolchains and causing
clangd to assume C instead of C++ for some files.
Change-Id: Ib98db88ac90e4e45a7016a7edcb80a279df372aa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Because the project storage is integer id based the string based API
isn't fitting well for the new approach. PropertyMetaInfo can be easier
mapped to the project storage.
Task-number: QDS-7197
Change-Id: I49bc650abdaacf4b039d76c2514b5ad05ec84abe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Delete it later instead.
Fixes: QTCREATORBUG-27803
Change-Id: I1108a87bc762a7da690b8999c9e73e127d79d3c4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Fix UrlChooser ItemDelegates not getting the hover event due to a
MouseArea overlayed on top which also accepts hover events. This issue
wasn't there in Qt 6.2.4 and only happend since Qt 6.3.1
Change-Id: Ifc43fe70fbefab9696a17a59966afdaf47b93829
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
- The settings depend on the setup and a table is easier
to browse.
- Describe the "Build device" field.
Task-number: QTCREATORBUG-27560
Change-Id: I5ec5534f45a069ac92b0c42f5233c8e9cb1648b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There is no big benefit of calling readDataFromProcess()
when the last argument is false. Simplify
runSubmitMessageCheckScript() and use QtcProcess::exitMessage()
for error message reporting.
Change-Id: I4ddaf3e72a2b5d49b47a2024da84862d92ab49fc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
... for a temporary kit created by the importer.
The way the importer works is that it sets up a random kit (with a
default toolchain) and then overwrites toolchain and Qt version. If the
new toolchain is of a different type than the original one, the debugger
will not match anymore. Fix this by calling fix() on the changed kit and
adapting the DebuggerKitAspect so that it sets itself up from scratch if
the current value doesn't match the toolchain.
Fixes: QTCREATORBUG-27758
Change-Id: Ib0539f07c0c38728de89a49299b7d2439afc5744
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Change the behavior of the output pane when an error occurs in the
QML live preview to avoid focus lose.
Change-Id: I78326af5060c775837d7a2d930c1fdd73b500f16
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
The QtSupport plugin tests copy qmake into a separate directory. If that
qmake is from a MinGW Qt, the respective .dlls are missing, and the test
interrupts/blocks.
Fixes: QTCREATORBUG-27793
Change-Id: I1ac02c31b6b74cf382285b8a5246292f82f979e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In order to avoid runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".
Change-Id: I921396628e5615e7c2d87045d2e787388dbddcc6
Reviewed-by: David Schulz <david.schulz@qt.io>
This fixes the runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".
Change-Id: I5c54ec10cef6bfd43a905e4e48fea05cb7b49297
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Some of our auto tests fail, so add an EXCLUDE_FROM_PRECHECK option for
add_qtc_test, which sets a corresponding label on the ctest, and exclude
these when running ctest on COIN.
Disable the Googletest based unittests for now, they are inconsistently
failing on CI, e.g. sometimes timing out after 60 seconds for tests that
usually take only a fraction of a second.
tst_perfdata from the perfparser submodule also fails. Temporarily
disable it explicitly, until the EXCLUDE_FROM_PRECHECK change can be
merged there.
Change-Id: I7e9d7aded75bbe8800f82f7aa125c181271a2a1f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
... and a few unneeded Utils:: qualifications.
Change-Id: I900061baed6afbb5a4ce7c2fd6a346a44f6d0945
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We change DockerSettings to have a single owner.
Since DockerDevices are destroyed after the plugin
is unloaded, we have to make sure to remove the
settings from devices during plugin teardown.
For this we store a list of created devices in
the factory, and call their shutdown function when
the plugin unloads.
Change-Id: Ic9c7d8ad9437c48d68f20c9a8f8ad7449b3cb972
Reviewed-by: hjk <hjk@qt.io>
For users who want the full area for the configuration widgets or don't
see output there because their build system doesn't put it there.
Fixes: QTCREATORBUG-26069
Change-Id: I4ffa73be88e5c7cc058227bc681f87e4c0a642bd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Increase the timeout to default 30 seconds when
waiting for finished. Apparently 2 seconds were
sometimes too short. We still ensure that waitForFinished
didn't timeout but finished eariler.
Change-Id: I12ca647b45537174c7c66d271e7c8a477184f2ff
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We show a summary of errors/warnings with icons in the status bar, if
the "Progress Details" are toggled off. The change that fixed the size
of that details widget to a grid, to prevent constant relayouting of the
output pane buttons while indexing runs, broke the size of the build
result summary.
The size was adapted in
ProgressManagerPrivate::updateStatusDetailsWidget() but that is only
called when FutureProgress::setWidget is called. When the build manager
later makes the warning/error details visible, the size was left at the
minimum size of 20 pixels, leading to the widget being cut off.
Amends b4f2ac0dd4
Change-Id: Ia41cf3db7e4485dff4712412976c1d4f5dd315b2
Reviewed-by: David Schulz <david.schulz@qt.io>
As per 8ad7ab2d2a, we prefer to open non-
project sources in a project-specific clangd, rather than the fallback
client.
However, we do *not* want clangd to open files from "foreign" projects.
Checking for the existence of a client for a specific file is not enough,
as we might be in the process of loading a session or the respective
project might have clangd turned off.
Change-Id: I2d5cb7027c6a3ad23e99606d6d6742d67fbc5384
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This is unneeded when followed by waitForFinished().
Change-Id: Ia30161da73ea877ba8973903a391100f29be8410
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Handle failed to start case inside done() handler.
Change-Id: Id138f0ef1fc58b6e335e08d8222e99c29c06b942
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
