Commit Graph

76860 Commits

Author SHA1 Message Date
Christian Kandeler
fd47b37298 ProjectExplorer: Do not remove "-Xclang" from command line
... when retrieving built-in header paths.

Fixes: QTCREATORBUG-22136
Change-Id: I2e403392b14b4cdea89fc33eb503fff303618d71
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-23 07:52:06 +00:00
Jarek Kobus
b77645d133 tst_QtcProcess: Don't use errorOccurred() in tests
Change-Id: I71657e111ab09b599480874ed22e714142697c19
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-23 06:39:19 +00:00
Henning Gruendl
5903d82c0b QmlDesigner: Fix hover color for ButtonRow
Use the default background color for ButtonRow buttons on global hover.
This needs to be done to distinguish between hover and global hover on
ButtonRow buttons as we unified the two colors as an attempt to make the
UI a bit less noisy.

Change-Id: I63f9c730367e9b906a772a63210c7ca548647352
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 17:34:15 +00:00
Thomas Hartmann
a0d474f2de QmlDesigner: Create transitions with proper versions
The versions were hard coded which leads to issues.

Task-number: QDS-6760
Change-Id: I94c3599348b996bb700da636cd63e74ea4c02be6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 16:32:07 +00:00
Thomas Hartmann
5fa46d6659 QmlDesigner: Add createModelNode without explicit versions
This makes it easier to create properly versioned ModelNodes.

Change-Id: I2a81021daa5e57af6740e447826124f1554a2c78
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 15:19:41 +00:00
Thomas Hartmann
b63675db6e QmlDesigner: Show metainfo when node is created in debugview
Change-Id: Id377b3e29f0a953a206dc3aa08008bb87f12bf0a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 15:13:55 +00:00
Mahmoud Badri
cc1bf95dc2 QmlDesigner: Ensure material lib node exists on project launch
In this commit material library node is created on model attach.
A timer keeps monitoring until it is suitable to create the node.

This will properly move materials into material library for
projects created with previous QDS versions.

Also removed unnecessary handling on new material dragging, as
rewriter now works properly with material library creation.

Fixes: QDS-7178
Change-Id: Idf6f41906e02bc064961d8de9841ba1644bd3552
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 14:16:23 +00:00
Thomas Hartmann
9caa28754c QmlDesigner: Use single transaction to move items into a layout
Change-Id: Ic8eb3907d06843e7ad0d7b0117154b0b7a987808
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-22 14:12:57 +00:00
Thomas Hartmann
092a1fc6a3 QmlDesigner: Support reparenting to new nodes in transactions
When we reparent to a new node that was created
during the same transaction, then this node has
no position. In this case we have to delete the
reparented nodes and they will be created
as part of the creation of the new node, since they
are children.

Change-Id: Icd1d02f29f529fc0f00809f7ecebf3eabfdc9a5c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-22 13:56:38 +00:00
Tapani Mattila
42ab928a27 CorePlugin: Prevent double warnings for overwriting files
Task-number: QDS-6824
Change-Id: I935b2b1076a4e765230a7462c470d7c134063249
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-22 13:40:09 +00:00
Jarek Kobus
e49e0f87cd QtcProcess: Connect to done() signal instead of finished()
Change-Id: Ie9005e2dc225907e46bb46086a663763b58c5152
Reviewed-by: hjk <hjk@qt.io>
2022-06-22 13:00:19 +00:00
Miikka Heikkinen
2cb45cbb6b QmlDesigner: Reduce number of preview requests from material editor
Removed preview request call from setValue, as it is called in long
loops during initial project load and added the calls outside those
loops where they already weren't there.

Fixes: QDS-7175
Change-Id: Ia83814a0de6fe801d954373dc8ce0e4920e8a6a6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-22 12:44:28 +00:00
Piotr Mućko
c1a223549b McuSupport: Show toolchain packages in UI
For new implementation toolchain  packages must be added
to rest of traget's packages to be visible in UI.

Change-Id: I6804a114e05caac1d864ceffb378f3f61481c433
Reviewed-by: Dawid Śliwa <dawid.sliwa@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-22 12:34:27 +00:00
Jarek Kobus
37a820f67a LldbEngine: Don't call blocking waitForStarted()
Connect to started() signal instead and continue
setup in its handler. Handle failed to start case
inside done() signal handler.

Change-Id: I2c2eb14bf2948c23bae1e35a7581f52d25ab1dd4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-22 12:17:42 +00:00
hjk
8066ce8a6f Remove a the necessity of a few weak vtables
For background, see QTBUG-45582.

Change-Id: I6c4758ce62149437c26971056b465d5dbd2b13b0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-22 11:41:36 +00:00
Piotr Mućko
bc2aee1af5 McuSupport: Test Qt MCUs package legacy creation
Change-Id: I8e724e11f8342ef02a8ee7246fbf35e65e0166a1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-22 10:57:49 +00:00
Miikka Heikkinen
359f4f1767 QmlDesigner: Fix material editor/browser texts
Fixes: QDS-7083
Change-Id: Ib4a5269e275c7811a5645bbff54e3b0ec95ec302
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-22 10:44:59 +00:00
Jarek Kobus
4686db5590 NodeInstanceView: Fix potential leak of process instances
Don't leak the process when d'tor of NodeInstanceView was called
after successful start of the process and before process finished.

Change-Id: Ib1e0192ebfa20b6e5e43c9247a18e9092c64b2d6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-22 10:44:59 +00:00
Miikka Heikkinen
41986d7942 QmlDesigner: Show IconButton tooltip also when button is disabled
Fixes: QDS-7076
Change-Id: If412827e22c6f71a9f073d1c868dcdb325870c1d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-22 10:44:50 +00:00
Jarek Kobus
bbbb1fd0a5 NodeInstanceView: Connect to done() signal instead of finished()
Don't block the caller thread when starting the process.
Handle failed to start case inside done() handler.

Change-Id: I57e2fd1e069c3c6285603cbe30f42bad9d80cecd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-22 10:44:49 +00:00
Jarek Kobus
fdf81b8768 QmlEngine: Connect to done() signal instead of finished()
Change-Id: Iffccd6425ff5bf3b47064b6883ecab7474a987f7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-06-22 10:42:29 +00:00
Jarek Kobus
418ce762df PdbEngine: Don't call blocking waitForStarted()
Connect to started() signal instead and continue
setup in its handler. Handle failed to start case
inside done() signal handler.

Change-Id: I9878490e8d30cf189c63800db658afae50141ce0
Reviewed-by: hjk <hjk@qt.io>
2022-06-22 10:20:28 +00:00
Piotr Mućko
73a0929bba McuSupport: Create board sdk packages
Adapt legacy implementation and pass appropriate data
to new implementation in McuTargetFactory::createPackage.

Change-Id: I13e0896e219cea2629e15de2a6885df457249790
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-22 09:59:47 +00:00
Eike Ziller
5c5b3cac94 Beautifier: Build with Qt 5
Amends 283673a5d9

Change-Id: I3ce759193a29d1c0dbc7d6ed7762503b3700b229
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-22 09:48:43 +00:00
Eike Ziller
4c4f787e84 COIN: Fix installing Qt after script updates
'wget' is now imported by one of the python scripts

Change-Id: I8e4fe32f813550586d19ccb76a55ec7ed13441c7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-22 09:47:05 +00:00
Miikka Heikkinen
62f34622df QmlDesigner: Improve puppet reset handling in material browser
Ensure just one reset call for cases where multiple materials are added
at once, and detect reset completion from root instance completion
notification instead of reset trigger notification, as it comes later
and catches all puppet reset cases.

Fixes: QDS-7119
Change-Id: I99baa718bd1c85b4581f07ce75193213110e8e96
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-06-22 08:49:21 +00:00
Miikka Heikkinen
604342c3af QmlDesigner: Add some delays to material browser refreshing
Import change causes puppet to reset, so bit of delay is needed there
before triggering material browser refresh.
Also added similar delay to refresh done at model attach as it seems
puppet reset can sometimes be triggered after attach as well.

Fixes: QDS-7172
Change-Id: I47f7af54e55af074fb2b9e8cdb9e78fb051a16cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-06-22 08:48:54 +00:00
hjk
73e072c7bb Git: Modernize executable search
Change-Id: I3bc1293aab74fcff5574d9a339a52776c891b6cf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-06-22 08:37:45 +00:00
Cristian Adam
61f04d260c scripts: remove deployment of libclang-cpp
All the clang binaries that we ship (clangd, clang-tidy,
clazy-standalone) are compiled statically and libclang-cpp
is not needed anymore.

Change-Id: I486fc0d1a55a18916c0abf56ec6a966321ef2b46
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-22 08:29:14 +00:00
Cristian Adam
f4ea9e09ec cdb: Use separate qtcreatorcdbext suffix for arm architecture
This would allow arm64 to coexist with amd64 on the same installation.

Change-Id: I578aab3d363bf93c2f61d4a7c93576ce19fba4b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-22 08:28:51 +00:00
hjk
cb0ff08518 Designer: Inline formclasswizardpage.ui
No change of translation context yet, just removing a form with
a single widget (and setting of object names etc).

Change-Id: I00a23b63caeff18e1199e6232d1afe6d89696bb7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-22 07:22:54 +00:00
Jarek Kobus
253ef8f606 StdIOClientInterface: Connect to done() signal
Instead of connecting to finished() signal.
This should also handle a failed to start case.

Change-Id: I000625adcceff94cf374cb2bfa9a994650cc261a
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-22 06:51:21 +00:00
hjk
fb36cb99f9 TextEditor: Inline behaviorsettingspage.ui
Less code, indirections and allocations.

Change-Id: I41011f90255a035eabe8f755fed6213f8f773a7e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-22 06:33:30 +00:00
hjk
9341733b37 Utils: Document escaping rules for % and / in FilePath
Change-Id: Ief9e739e167f724b1626c3478ac4d6f94fc3bac0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-22 06:33:09 +00:00
Jarek Kobus
a78b38653a MergeTool: De-pointer process
Get rid of unused m_merging field.

Change-Id: I0e6d80f6422881ad37982a6946fa3916b4574094
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-06-22 06:30:15 +00:00
Jarek Kobus
94adc1a566 MergeTool: Don't call blocking waitForStarted()
Connect to done() signal instead of finished().
In case the process failed to start it will delete
itself from inside done handler.

Change-Id: I277779904d571759bf3877860d64e80ad304c2da
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-06-22 06:30:04 +00:00
Jarek Kobus
35c3d9430b QueryContext: Connect to done() signal instead of finished()
Change-Id: I642138a90c4e13fcdb4dbb065e26aa5e3d509b9e
Reviewed-by: hjk <hjk@qt.io>
2022-06-21 15:49:09 +00:00
Jarek Kobus
d8ad6b2a9e tst_QtcProcess: Connect to done() signal instead of finished()
Change-Id: Ie01349b1f9ec8189d6503df3ed0b2e1e1252d0f6
Reviewed-by: hjk <hjk@qt.io>
2022-06-21 14:54:57 +00:00
Jarek Kobus
e3f27b3d53 GdbEngine: Don't call blocking waitForStarted()
Connect to started() signal instead and continue
setup in its handler. Handle failed to start case
inside done() signal handler.

Change-Id: Iaf184ed3e934b1bd5f8128a6aa9c72e9f27e0f56
Reviewed-by: hjk <hjk@qt.io>
2022-06-21 14:49:06 +00:00
Thomas Hartmann
53642c9a22 QmlDesigner: There can be also document messages from the puppet
We have to check if the rewriterView()->errors() are actually empty.

Change-Id: Icbcc82aa9229078fd51c975e48de3e1f06c29f4d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-21 14:27:23 +00:00
Marco Bubke
3dca62ac1e QmlDesigner: Fix crash for dangling target
It can be that the target is a dangling pointer.

Task-number: QDS-7134
Change-Id: I51b7c9109b0f9193c31ee645144e2a24d1244ba9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-21 13:52:10 +00:00
Marco Bubke
20bc8b8243 QmlDesigner: Install busy handler for every database access
Even for pragma changes the statement can be getting busy. To prevent any
exceptions in that case we set the busy handler directly after opening
the database.

Change-Id: Id10aab20d812d5224f8031fa895c396762858fdf
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-21 13:52:00 +00:00
Marcus Tillmanns
627f6a2916 cppeditor: Show hints for qmlRegister... diagnostics
This fixes passing the hints from FindExportedCppTypes to
the actual cppeditor so they can be displayed to the
user.

Fixes: QTCREATORBUG-27243
Change-Id: Ibcb68296f044a9c6a96f40945d8a0e964be7f042
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-21 13:33:19 +00:00
Christian Kandeler
bbbae099a7 ClangCodeModel: Move decl/def switch functionality to dedicated class
Change-Id: Id583ac58933e35e979083311907331b627d3c067
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-21 13:28:55 +00:00
Christian Kandeler
1a3f915586 ClangCodeModel: Fix following virtual functions
Amends 79b8e5397d.

Change-Id: I8c4e3c7cb8cb26d51cdf77c15891110c6b213d46
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-21 13:28:41 +00:00
David Schulz
dacb4ec82d TaskList: merge into project explorer plugin
Change-Id: I6097f3ea40a6a7c3ced0f59b15789046184e2e90
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-06-21 13:28:05 +00:00
Christian Kandeler
ea868c8b46 ClangCodeModel: Check system for clangd suitability on first run
Turn off clangd by default if we think the system does not have enough
memory. Inform the user and let them override our decision.

Task-number: QTCREATORBUG-19297
Change-Id: Ib9715c2f089c10d7a2a559a25180e9a943c118b1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-21 13:23:37 +00:00
Thomas Hartmann
281c534894 QmlDesigner: Make inErrorState() private
This method should be only for internal use, since it is
different from errors.isEmpty(), because the rewriter is only inErrorState
if parsing/rewriting fails, not if there is a semantic error.

Change-Id: Ib021e5e80750a4edcb4661755e85e6880fd6617c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-21 13:02:06 +00:00
Henning Gruendl
2de2a4808a QmlDesigner: Fix FontComboBox drag'n'drop
* Fix URL schema to also work under macOS
* Avoid setting font name and further processing if error during font
  loading occurred

Change-Id: I9d07a3daad8f7c8c464422b0cf3f94d61e4b231d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-21 12:22:56 +00:00
Thomas Hartmann
db8dbe25e0 QmlDesigner: Add a wizard for a ui.qml .qml file pair
Task-number: QDS-5963
Change-Id: I16ee8361779f11ca2f24f35877869f3e83279d10
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-21 12:16:40 +00:00