Commit Graph

80147 Commits

Author SHA1 Message Date
Jarek Kobus
c7f24f9f13 ShellCommand: De-virtualize addTask()
Provide executedAsync() signal instead.

Change-Id: I8f04dc90875e5f27827ea553a9f23f41656cc4db
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-14 07:39:37 +00:00
Thomas Hartmann
f98ed790a1 QmlDesigner: Start to Use NodeMetaInfo in ReadingContext
We keep the old code path for now and throw an exception
if there is a divergence. The old code path is supposed
to be removed before the 3.6 release.

Change-Id: Id5458cdb452341295c5901caf706d224e57837b0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-07-14 07:02:52 +00:00
Jarek Kobus
85071d8e8d ShellCommand: De-virtualize environment()
Provide instead a protected setter, used in VcsCommand c'tor.

Remove a forceCLocale arg from setProcessEnvironment() method,
as it is used only in VcsCommand context when
ShellCommand::ForceCLocale flag was set. Move setting
C locale env directly to the shell command, just before
the command is executed, so that we are sure the flag
was already set.

Modify env directly in VcsCommand c'tor with regards to
SSH_ASKPASS variable.

Change-Id: Icff555ade4984368f7ce79f762d1bb5d3614076a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-13 19:29:10 +00:00
Tim Jenssen
68bb3b99a9 tracing: get rid of Qt5 code
Change-Id: I31205ed7c70de4617575f2d05065d47183bd222f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 17:13:46 +00:00
Fawzi Mohamed
fd89043de2 qmljs: (QString -> Utils::FilePath)++
convert more QString containing paths to Utils::FilePath

Change-Id: I1219d7d147993e48cfa641dc9bea72ab38c90f51
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 17:13:23 +00:00
Yasser Grimes
0bb272d411 McuSupport: Use System header paths in module mappings
Previously only HeaderPathType::User was allowed for mappings when the
headers and qml files are joined (the case for Qul), but "Qul QtQuick
include" is of type HeaderPathType::System causing the import not found
error in QTCREATORBUG-26751

Task-number: QTCREATORBUG-26751
Change-Id: Ie40ad32c77bb00ad2c01fd1ae28330669db1e785
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: Dawid Śliwa <dawid.sliwa@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 16:12:51 +00:00
Jarek Kobus
0da525d65c VcsBase: Cleanup some Utils:: in cpp files
We are using namespace Utils in these files.

Change-Id: I0526f7e4fff2fe0d24d1e2b9fa087298d5331955
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 16:01:35 +00:00
Jarek Kobus
89e7201048 VcsBase: Hide VcsCommand class
Make it an implementation detail.
Introduce VcsBaseClient::createVcsCommand() method instead
for instantiating VcsCommands.

Replace all occuriences of VcsBase::VcsCommand in public API
with Utils::ShellCommand.

Change-Id: Ie438cc3a5e867b3ee8f9e935b56b2f16ea453f8a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-13 16:01:28 +00:00
Thomas Hartmann
aeea22257c QmlDesigner: Add support for Behaviours
A Behavior will be added as a normal ModelNode to the default
property, but we store the property name in behaviorPropertyName.

The value of behaviorPropertyName cannot be changed after the
ModelNode was created, since I do not see any use case and it keeps
things simple.

Change-Id: I69ba1d4d706432cfbbd35b001238f623e6e0b4fd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 15:33:07 +00:00
Cristian Adam
c505d6a72e ClangTools: Use CtrlC Stub for clang tools on Windows
We got a report that using a clang-tidy would launch llvm-tokenizer,
which would not close when clang-tidy closes.

This resulted in zombie processes which would significantly
affect performance.

Change-Id: I1952be668b6352970cdb70c7fa622df77c2d175e
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 14:47:36 +00:00
Jarek Kobus
ec48545628 ShellCommand: Avoid code repetition on process setup
Move the common setup part into runCommand().

Change-Id: Ib17ef5fd89502f76e5cb03c1d5cb82c746c672a0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 13:55:40 +00:00
Jarek Kobus
aebf6a9466 ShellCommand: Remove workingDir arg from 2 methods
Set a working directory for the process to run
before calling runFullySynchronous() or runSynchronous().
Make workDirectory() a private method.

Change-Id: I30f8354a3e409a06170f481cea4e97e3772da252
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-13 13:55:34 +00:00
Leena Miettinen
86c6d1d09d Doc: Describe new way to access global settings
From project-level To-Do and Clang Tools settings.

Task-number: QTCREATORBUG-27560
Change-Id: If91dfe81a87af3de3f6b52c160b8b1df4789c20b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 13:41:07 +00:00
hjk
01e75d8b63 Squish: Use LayoutBuilder on ObjectsMapEditorWidget
Change-Id: I5c6e32ba7a27584f54531c5aacbc627e98b729ba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 13:30:39 +00:00
hjk
764d8376ba QtSupport: Remove unused BuildLog dialog
Change-Id: I5202a0554d044d162d4c0723f591f7479dffff22
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-13 13:29:51 +00:00
hjk
9478a31a55 Squish: Convert to Tr::tr
Change-Id: If05727960ffa4181de6588e098c151072af43500
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 13:29:38 +00:00
Thomas Hartmann
3cba432750 QmlDesigner: Track MaterialBrowser usage
Change-Id: Idc70434ffaa633353e87b373660df03863db8d95
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 13:11:31 +00:00
Sergey Levin
4a1a0eaa39 Core: Close ICore::showWarningWithOptions dialog on pressing Esc button
Change-Id: Ic09202799bde9cb4fbc3ca4e9836ca0c0cc499f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 13:03:33 +00:00
hjk
ab90298fde ToDo: Convert to Tr::tr
Change-Id: I2bd081fd484f851234c7e54114a15488271e0df1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 12:56:47 +00:00
hjk
3651c385b7 UpdateInfo: Inline settingspage.ui
Change-Id: I66a6305ea5c8485355b52321b7bba4216c8f7ad5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 12:45:23 +00:00
hjk
0d7e270852 Utils: #include <QUrl> in fileinprojectfinder.h
Needed for MSVC:
 C:\Users\qt\work\build\qt_install_dir\include\QtCore/qhash.h(111): error C2079: 'QHashPrivate::Node<Key,T>::key' uses undefined class 'QUrl'

Change-Id: Iafa83ea103fbb89744fc37ca4396e356d29be9bf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-07-13 12:45:15 +00:00
Thomas Hartmann
1627acd659 QmlDesigner: Track MaterialEditor usage
Change-Id: Ie8daf34bf21d9b12711704be4fdea9b291307f02
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 12:42:38 +00:00
Eike Ziller
550a7ecc6e BuildConfiguration: Do not update environment cache in constructor
Updating the environment cache calls into the virtual function
BuildConfiguration::addToEnvironment (via BC::baseEnvironment()), and
that is not working in the constructor yet.

Move the call to updateCacheAndEmitEnvironmentChanged to
BC::doInitialize.

This fixes the build environment for the first CMake run on a newly
created project. CMakeBuildConfiguration::addToEnvironment adds the PATH
to the Ninja installation from the online installer. If that is missing,
CMake will fail with a missing build tool, if Ninja isn't found anywhere
else.

Amends 65e043961e

Task-number: QTCREATORBUG-27495
Change-Id: I7c952db9029ab78e0aa9ea267444af163f5941ac
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 12:32:03 +00:00
Eike Ziller
e2d5936a76 Help: Convert to Tr::tr
Change-Id: I3f9ca195488f7cc90e7f58eb15263dde1bc911c4
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 12:30:46 +00:00
hjk
d262e665ca ProjectExplorer: inline editorsettingspropertiespage.ui
Also removing the spurious extramargin.

Change-Id: Ic52c1afccd479a84fc7278b4d2cd4070bdc7193e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 12:21:46 +00:00
hjk
db7b523a94 CppEditor: Inline cppcodemodelsettingspage.ui
Change-Id: I97f27121714adaca00aaa1347d460968be395afa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 12:04:00 +00:00
hjk
81dfcb4859 ProjectExplorer: inline codestylesettingspropertiespage.ui
Change-Id: I8682685d554fce5d618da913d35720465ac52278
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 11:35:39 +00:00
Thomas Hartmann
c92216aea5 QmlDesigner: Add QML files from assets_imports
Otherwise they do not show up in the project explorer and
more importantly we do not generate the proper cmakefiles.txt.

Task-number: QDS-7279
Change-Id: Ib6cbd839cee2ec5ded09e57d2097b75f1a1e68e9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 11:30:00 +00:00
hjk
04befed8c3 CppEditor: Inline cppquickfixprojectsettingswidget.ui
A practically empty grid.

Change-Id: I6d23794244519de4c019aab6530482e28de964c5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 11:22:36 +00:00
hjk
b1f9cdac35 Qnx: Move to Tr::tr
Change-Id: I43b49d325a129c180869140c4ae1774f7f89d2fd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 10:52:18 +00:00
Eike Ziller
f19957c6dc Help: Inline generalsettingspage UI
Change-Id: Id67a4714aa09e19a2a97c2cb0fa641ddee0584e3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 10:30:28 +00:00
hjk
6f6d4015ea ClangTools: inline clangselectablefilesdialog.ui
Just a Vbox.

Change-Id: I27618d7ba9a22011dff8c3486a944fbbdaf90a1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 10:19:18 +00:00
Thomas Hartmann
e43e08d77d QmlDesigner: Add lookup for alised types in NodeMetaInfo
Aliased types like T.Button require a special code path.
Those lookups are only required for the rewriter and are not used
by application code, since we strip the alias qualification.

Change-Id: Ic74c352655e640b063bb01f03a699182af506de7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 09:52:03 +00:00
hjk
802de0eb5e Utils: Collapse most of porting,h
Taking the Qt 6 branches, leaving some dummies until downstream
adapted.

Change-Id: Ib9b86568d73c341c8f740ba497c3cbfab830d8a1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-13 09:44:09 +00:00
Leena Miettinen
ab10372b09 Doc: Update info on deploying to embedded Linux
- Describe the "Override deployment data from build system" option
- Remove docs for the obsolete "Check for free disk space" deployment
  step
- Move docs for the "Check for a configured device" deployment step to
  QNX topic because it does not appear for other types of devices
- Update screenshots

Task-number: QTCREATORBUG-27560
Change-Id: I3791b8e7021ba2a1e88c2c56d7eb38ef208a9967
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 08:43:56 +00:00
hjk
480da99508 Squish: Inline deletesymbolicnamedialog.ui
Change-Id: I668d3ff676c2af96b01b3c1baaf7d312f5a91423
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-13 08:08:31 +00:00
hjk
074282cae4 Todo: Inline todoprojectsettingswidget.ui
Change-Id: I942d1687a6a34a269ce4abd9233975febb4516e8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 08:08:21 +00:00
hjk
e96b5c152b Squish: Inline opensquishsuitesdialog.ui
Change-Id: I18b322fe8b21b481f0289295df1c3cfff6f60473
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-13 07:36:07 +00:00
Leena Miettinen
fda487717f Doc: Update Bare Metal and MCU screenshots
Task-number: QTCREATORBUG-27560
Change-Id: I0848327874055f606b206ca81655c03b919516ae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 07:26:22 +00:00
Leena Miettinen
d6cdce0de5 Doc: Update info about debugging
- Update screenshots
- Fix option names
- Show existing screenshots in more places (where they are
  discussed in text)

Task-number: QTCREATORBUG-27560
Change-Id: I16a45e5e05b8b50932431844e36851f693966201
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 07:26:07 +00:00
Leena Miettinen
7bb5ea287d Doc: Update screenshots
Task-number: QTCREATORBUG-27560
Change-Id: I6899b4a1206fe2f13ffad0bbd4f14a2bdeef7f82
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 07:25:50 +00:00
Leena Miettinen
d8c55cadf5 Doc: Update more screenshots
Task-number: QTCREATORBUG-27560
Change-Id: I03abbd1d90494d06cf4087c1a85cce2cf1102912
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 07:25:36 +00:00
Jarek Kobus
d1c98e43b5 TextEditorWidget: Fix createMimeDataFromSelection()
When omitting separator lines take the selection start
position instead of the position of the block where
selection starts.

Amends c98bd449523dc05f8875e96d06cf7c21e18eef0d

Fixes: QTCREATORBUG-27813
Change-Id: I6067a3ef6396d50162d8e253fe4a825d47d326b9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 07:23:07 +00:00
Eike Ziller
11b0cab178 Project settings: Fix missing IDs for global settings links
Change-Id: Id99bf5f9d45dd399c589011ca724914046305c53
Reviewed-by: hjk <hjk@qt.io>
2022-07-13 07:19:27 +00:00
Jarek Kobus
d44056f9d8 Adapt to upstream changes
Change-Id: Idbe054570ef3af558d1c9cb2a18a1824502fe265
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-13 06:53:25 +00:00
Thomas Hartmann
e5906945ce QmlDesigner: Add more info to RemoveNodeRewriteAction
Change-Id: I3ace796f81580f1eda1359a244c5e5bee3b01ac5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 06:50:21 +00:00
Thomas Hartmann
7354d8a462 QmlDesigner: Fix tests
We do not allow rect as id, since it is also a QML type.

Change-Id: I348071b9b1f6c3e72d3934770196421ce72d36b5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-13 06:50:07 +00:00
Christian Stenger
915cfc93d9 Squish: Remove unused capture
Change-Id: Icef1df3f8e708a0192d8eaa176ed6202e2fa3ae9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-13 04:29:59 +00:00
Marco Bubke
5c4a5126d6 QmlDesigner: Move synchronization types into extra namespace
Change-Id: I4f0574fcdcd5df4c0122028d1b032e910a9e28b6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-12 19:53:14 +00:00
Marco Bubke
e6617f520c QmlDesigner: Provide local propertries
It returns all local propeties in a sorted order.

Task-number: QDS-7276
Change-Id: I030d63b64e66b0c06b33904e5b157ed8aa060ae5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-12 19:53:08 +00:00