The constructor for CommandResult takes a reference to QtcProcess.
If by mistake a pointer was used this results in constructing a new
QtcProcess and using the copy as input for CommandResult.
With explicit constructor we will get a compiler error.
Change-Id: Ib3a61b9164bd7d5dfb0f567c2d03f16b7d12f2c2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
QCoreApplication::translate() takes a context parameter, tr() does not.
We want the first one.
Amends: 48affa1889
Change-Id: Ibca327a39097dfcdb81a30e561161d3275c61d1d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Store a pointer to WorkspaceLocatorFilter instead of base
ILocatorFilter and avoid later downcast to WorkspaceLocatorFilter.
Change-Id: I729f60356b287f3b4bddf016e21761a372993928
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This makes it possible to have plugin tests defined in the
plugin pimpl, like a lot of the other stuff we currently
have there. This is meant to replace IPlugin::createTestObjects.
The basic idea is to reduce the number of ways things can
or have to be done when creating plugins.
Change-Id: I137c66b91cdf461a502cf22063b6f63e6163e876
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Default values shouldn't have complex initializations anyway,
these end up in each instance on user side.
Change-Id: I81394c3df353b34b19454130f58bd646318feccd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
By copying the ${IDE:ResourcePath}/package-manager to
${buildDir}/.qtc/ the problem with hardcoding paths
to old an Qt Creator version can no longer occur.
This also fixes the issue with remote projects by reffering
to the code residing on the host.
With the above issues fixed, enable "Package manager auto setup"
by default.
Change-Id: Ia49654a3b9059f83886e64d065019b2d55e9299c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
qml2puppet only enables the qmlruntime feature if it
was built against a Qt 6.
Task-number: QDS-9088
Change-Id: If573cae305ef18c11101a591e6c1e38f133b7914
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
List respective tr files and while at it shuffle some
of the listed files to match common sort order.
Change-Id: I73845ad1dae5e8c86d3741067f40b7b2b37e2a6e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We use a value of 200, which is also GCC's default.
Fixes: QTCREATORBUG-28770
Change-Id: Id02b324cd2ffa81a709441a5d93856bcd06501c3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
..when expanding variables and macros.
Fixes the plugin unit test on Windows.
Fixes: QTCREATORBUG-28744
Change-Id: I8a047854d6d43e901b01b10660e29b7d6544d0b7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
During API review, it was decided (and implemented) that REQUIRES is the
better/more descriptive keyword than MIN_VERSION.
Change Creator's wizard accordingly.
Change-Id: I831cdc956204b1e379c3815104698d3f881abf6c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
When editing e.g. CMAKE_PREFIX_PATH in the initial configuration
settings it was resolving the path(s) in there, thinking that it was
relative to the project directory.
Fix that after editing the resolved file path was set as the new value,
instead of the raw unexpanded data.
Fixes: QTCREATORBUG-28779
Change-Id: I14d097e3a3a51b78006dd30a67b08477cfe0f2d8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The wrong Tr::tr could be executed by code indirectly including a *tr.h
file from another module.
To Translate in a header file, use QCoreApplication::tr().
Change-Id: I30e67245991d2c2f0eeb01ab356555bdb9841af0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
4.8 was released end of 2018 and the setting is not critical.
Change-Id: I02856e98303debd3a1adc28d49b28c5d728ad553
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Align with the rest.
Change-Id: I48ac1cae738b909d90fd123128c1959f3635278e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This is now in line with the other menu buttons in the editor toolbar
like the language client button or the python interpreter and repl
buttons.
Change-Id: If22d3e9c87274eee2fefe8e30f6b0648be5d60c9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
For references to the module-own context, use Tr::tr().
For references to other modules, use the right context name (with "::"
prefix).
Change-Id: I6dce8f1ceccb23c44d93f1826402cd3be8e98e5a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Move the .toString() uses into DeploymentData::addFilesFromDeploymentFile
Change-Id: Ic9ef22da1918ca105c92f0231960dab27b0d80bb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The file name is not supposed to be the button label.
Fixes: QTCREATORBUG-28746
Change-Id: I45ee2a860da8f7ffefc6d72c0d85b7f6a261489c
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
It adds an indirect dipendency to QmlCompilerPrivate too. We stick to Qt
6.5 because the private API changed.
Task-number: QDS-9049
Change-Id: Icb0b406fc47759763384e167c0cabbffc1c9e186
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
