Commit Graph

80147 Commits

Author SHA1 Message Date
Tasuku Suzuki
fabb53c728 VCS: Clean up code for vcs toolbar
It has been hidden since 5d316a4919

Change-Id: Id6808dc5546bb5cf500032b4b03ab3fc06c14501
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-16 23:22:26 +00:00
Tasuku Suzuki
43eacc1ae5 VCS: Add a button to open settings on Commit Form
Change-Id: I4e1b47e9c6d3276b0c153c24cc24daeb3846814e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-16 23:20:27 +00:00
Thomas Hartmann
866f8b3557 QmlDesigner: Adapt DynamicLicenseCheck for new plugin
Change-Id: I2547589cea1c01e70e1f8c40f89f66783b3dbd18
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-16 17:12:40 +00:00
Thomas Hartmann
ee84f974d4 QmlDesigner: Move UI for feedback to QmlDesigner
* Moving the QML UI to the QmlDesignerPlugin
* Adding menu action to trigger feedback

Change-Id: I94823beaf3896ab33dfb0ed414202e6fe267a35e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-16 16:38:50 +00:00
Thomas Hartmann
92777297a5 StudoPlugin: Add QTC_ASSERT to avoid empty project names
There have been issues with invalid properties in the telemetry backend.

Change-Id: I8ddd7740e927e83b363a8d5a87a24836ca573c73
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-16 16:38:07 +00:00
hjk
6a1a6d85b8 iOS: Tr::tr
Change-Id: I547af218546927622414999e5b9019ab62916e7e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-16 16:11:20 +00:00
Alessandro Portale
8f2d48e8a3 ProjectExplorer: Tr::tr clean-up
Tr::tr a string that was missed, and some extra qualifications to help
lupdate.

Amends: c5f7f5ab0a

Change-Id: I65b98d20ed3c1f8781823c4ee6677052d1cf0fa3
Reviewed-by: hjk <hjk@qt.io>
2023-01-16 15:23:02 +00:00
Artem Sokolovskii
5d9912b058 ClangFormat: Remov unused functions
Change-Id: I294e190cdd76467cb79b58bc818a240cdead8bbc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-16 14:22:49 +00:00
hjk
7cd2026fa2 Utils: Re-add some safety net in FilePath::setPath()
Amends c08317b5a6

Change-Id: I3b9bc61346aa60280beb3b29c33c0f76017e407a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-16 14:16:12 +00:00
Christian Stenger
cc89b79bc2 QbsPM: Fix handling of executable path
To be able to act correctly the internals of FilePath need to be
formatted in UNIX style.
Kind of amends c08317b5a6.

Change-Id: I5a0c7b06005901575d47b9de327eeb657dbe3090
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-16 13:32:35 +00:00
David Schulz
f7f9d5d405 Python: Fix crash on switching interpreters in run configuration
This happens if the project contains ui files, pyside with pyside uic
and the python language server is installed. It is caused by pointers to
already deleted extra compilers in the pyls language client.

Change-Id: I877f20292c9c850c151fa94149b5a46d4836c3de
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-16 13:13:01 +00:00
Jarek Kobus
d96c7a2d0d CppCodeStyleSettingsPage: Reuse Layouting::TabWidget
Change-Id: I82ad373f1acebc6d62da3d58619b9a6cc11d7638
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-16 12:57:05 +00:00
hjk
c5f7f5ab0a ProjectExplorer: Tr::tr
Change-Id: I8f1b463c5cc7a53627f7a9ad261998b92f13e56a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-16 12:10:24 +00:00
hjk
e373fe6aa9 Utils: Avoid temporary strings when hashing links
Change-Id: I5d5cc5ed35fea7692d1c0bfdd9091928b5d46487
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-16 11:12:03 +00:00
Eike Ziller
514a62b9b2 ExamplesListModel: Remove unneeded override of data(...)
It seems to have been a workaround for taking tags into account for the
filtering, but that is done completely different nowadays, and not with
the DisplayRole.

Change-Id: Iff73c1a33de4a40c4919794a8644fdc4af710ba1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-16 10:43:46 +00:00
Eike Ziller
2f70875ee3 MarketPlace: Fix issues pointed out by static analyzer
- Use static regular expressions
- Don't mix iterator and const_iterator
- Use const Qt container in range based for loop

Change-Id: Iaa3a6a1eda28c6b962f28bd09bfaa53e6f5f8453
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-16 10:33:46 +00:00
hjk
237d1b2c8e QmakeProjectManager: Simplify makefile extraction logic a bit
Change-Id: I7b28bb1889e243e390c705d66cf460d33299b3d1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-16 09:24:57 +00:00
hjk
cb7182ee44 Qmake: Remove ArgumentFlag::OmitProjectPath
Last user went away with  344a8f5622.

Change-Id: I54c6378da553a6ee6b36c8cfc3021e2f390ded50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-16 09:23:07 +00:00
hjk
4a21700175 QmlPreview: A dedicated class for the QmlPreviewRunWorkerFactory
Change-Id: I994f339ac1ca35e9b1dc7e2572682c4bcdb485ea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-16 09:12:45 +00:00
Eike Ziller
9256340e5b CMake: Fix missing path to Ninja from Qt installers
In the configure environment for MSVC toolchains.
The MSVC toolchain actually overwrites the PATH environment (triggered
via kit()->addToBuildEnvironment(result)), which it shouldn't.
But this is a minimal fix for Qt Creator 9.0 that also is in line with
what BuildConfiguration::baseEnvironment() does.

Fixes: QTCREATORBUG-28685
Change-Id: I0cb8e3c84419403672175bd581c16d90902e23ba
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-16 07:43:38 +00:00
Alessandro Portale
c151835834 CppEditor: Rename some ts contexts to ::CppEditor
Removal of Q_DECLARE_TR_FUNCTIONS needs translation context changes in
.ts files.

Amends: f7bcd4f574

Change-Id: I9a1dfa6340942fd45b21a0a236845cfc72d60c28
Reviewed-by: hjk <hjk@qt.io>
2023-01-16 07:20:14 +00:00
Tasuku Suzuki
b7efb22aa9 Git: improve "The commit subject is very short."
- Hide it when commit subject is empty (initial state)
- Delay the check 500ms for commiter to focus writing commit message

Change-Id: Ia111bb01d2819750e053e06875d529a14d1ac07d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-16 04:02:30 +00:00
hjk
7ecc507b75 AutoTest: Fix test compilation
Also amends 33cdb052ba

Change-Id: Ic4cf8671cf97c9d94fe933b9d29cb515355f5e6b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-13 15:51:56 +00:00
Alessandro Portale
9414083ed5 CompilationDatabaseProjectManager: Fix recent FilePath-ification
Amends: 33cdb052ba

Change-Id: Id2a7133aaee9e4618683066ce116090c522f04d5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-13 15:24:57 +00:00
Jarek Kobus
9438575beb ProjectExplorer: Move settings structures out of Internal namespace
There is a public exported API that returns these structures,
and different plugins use it, so there is not point in keeping
them inside Internal namespace.

Remove some unused includes.

Change-Id: Ia9d3fc83738c38ae37f04ae0f518ec5d972c9d85
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-13 15:06:19 +00:00
hjk
7f85a2f331 Beautifier: Tr::tr
Change-Id: I4b27d0f33d9cad8720837c560fb0c9fb97c96cf2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-13 15:03:43 +00:00
hjk
2f144a56cd ProjectExplorer: Simplify AppOutputPane widget nesting
A TabWidget in a tight layout in a widget doesn't look different then
a TabWidget.

Change-Id: Id042deace1b2ae66a57678fb34d45ee47938716f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-13 14:48:35 +00:00
Amr Essam
2640190f23 QmlDesigner: Enable create effect even if asset library is empty
Task-number: QDS-8694
Change-Id: I18311cdac01d656120dde15151f6d9d5ff40da04
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-13 13:17:47 +00:00
Christian Kandeler
a3109a53c0 Valgrind: Fix wrong include
Change-Id: I038ccc618d2ea639af6613f53c951bbceddf977a
Reviewed-by: hjk <hjk@qt.io>
2023-01-13 13:00:49 +00:00
Artem Sokolovskii
34638aa497 ClangFormat: Add use global settings check box for a project
Change-Id: Ie2872de3574aaad058a9fca17247db00e9559ba7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-13 12:55:42 +00:00
hjk
e7c536011f Prefix Tr::tr contexts with ::
To make outliers better visible in Linguist

Change-Id: Ic35ea2a858b7e3576d9a416fb494fddb616eaaa1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-13 12:00:17 +00:00
Miikka Heikkinen
f2b6b669a3 QmlDesigner: Disable add texture/light probe if no valid material lib
Both material library node exists and QtQuick3D imported must be true
for these menu items to be enabled.

Since this information is only needed in context menu, update the
flag only when context menu is shown.

Fixes: QDS-8524
Change-Id: I66221bf953b3b542cf7827b46e8c307a9b33acba
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-13 11:24:58 +00:00
Jarek Kobus
eab76c5007 Differ: Initialize EqualityData fields by default
The last two fields were not initialized before. Make the struct
internal in function.

Change-Id: Ib416aa26b17626ec55d76cb944ff9d763beaa190
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-13 10:51:05 +00:00
hjk
33cdb052ba FilePathify some testing code
Change-Id: I3739a6eb3c2172078e9519e8186daf94ec74d99a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-13 10:46:13 +00:00
Christian Stenger
274bb27cf3 AutoTest: Redo handling of data tags with spaces
This basically reverts commit 7684571e10 as it broke running
the test inside the debugger.

Change-Id: Iacd46e2b9fb5af813fbf17156fd847375d750480
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-13 09:58:57 +00:00
hjk
2ce413112b Utils: Push FilePath::toString border line a bit further
... in SaveFile

Change-Id: I80164853b8a756af8c74038b0375c423a6f500e2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-13 09:50:11 +00:00
hjk
6585b3668c Beautifier: Drop a few FilePath::toString
Change-Id: I226ead540072b8ad0b12e5e9c4cc594d4e1029d2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-13 09:21:32 +00:00
Eike Ziller
2688a9629c Merge remote-tracking branch 'origin/9.0'
Conflicts:
	src/libs/utils/pathchooser.cpp
	src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp

Change-Id: I7ae3f91618c4a4ccb088679caea72b2a81590960
2023-01-13 09:16:25 +01:00
hjk
ccff024a66 RemoteLinux: Use dedicated classes for run worker factories
I put the normal run in the debugsupport file for now, I plan
to squash all three afterwards.

Change-Id: I855772f7dff8c8ccce07193733c26468fec40b85
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-13 07:17:38 +00:00
Tim Jenssen
4aea4ea693 Merge remote-tracking branch 'origin/9.0' into qds/dev
Conflicts:
  src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp

Change-Id: Idc7be1f8871df51f7372ea66f81178cfe3e68846
2023-01-12 16:42:15 +01:00
Patrik Teivonen
1b6d434c9c Coin: Update instruction yamls to run qtsdk scripts in Pipenv
Install the Python module dependencies for qtsdk from Pipfile and run
the install_qt.py and bld_sdktool.py script inside the Pipenv virtual
environment.

Change-Id: Id84733b822964ed2099883de3708f9da2e2d1818
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-12 15:22:50 +00:00
hjk
44a9f5a63a Qmake: Use FilePath in QtVersion::reportIssues
Change-Id: Ia848248525238c316d6f6f120d915b9bdb28b8fe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-12 15:13:02 +00:00
David Schulz
ccb6176a33 fix compile warning
Change-Id: If87725fa32a108d43b3198e5a38424092781863c
Reviewed-by: hjk <hjk@qt.io>
2023-01-12 14:47:16 +00:00
David Schulz
3677932266 ClangCodeModel: reuse Id for restarted clients
This is needed to keep annotations hidden after the restart of clangd if
the user disabled them in the text mark tooltip.

Change-Id: I69a668f2ba71f1dda83eca74a064af7ec1f92e77
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-12 14:45:12 +00:00
Miikka Heikkinen
6af8487203 QmlDesigner: Support drag from content library to assets view
Simply adding the paths as urls of the mimedata makes assets view
handle drags from content library just like any other file drags.
MIME_TYPE_BUNDLE_TEXTURE data is not actually used currently at all,
so a duplicate path is not needed there.

Fixes: QDS-8536
Change-Id: I11644d85d98435ba0d4d56b806e9a96b218837fb
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-12 14:33:01 +00:00
hjk
7c35363cda Utils: Simplify part of OutputLineParser::absoluteFilePath
Change-Id: I65be5e622b2a2bde8cbd25c8642c87f889ee5bdd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-12 14:32:54 +00:00
Marcus Tillmanns
21ef25a0f5 Utils: Add FilePath.hasFileAccess()
FilePath::hasFileAccess allows a user to test if a specific device
can access files. This is faster than calling "exists()" as it does
not have to actually check anything on the device.

Task-number: QTCREATORBUG-28531
Change-Id: I94b5b9e0ae020b81f126c61fd06bb25f3d4a88cb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-01-12 14:06:09 +00:00
hjk
b3bc499ebd QtSupport: Some FilePathification in the OutputParser
Change-Id: I618bb47608593b5a60636c5e740f4d19e68e4f5a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-12 14:01:14 +00:00
Tim Jenssen
2df52c4b8b qmlproject: fix qmlViewerAspect
- add its own settings key so it gets saved into the project settings
- read the correct placeholder text, commandLineGetter is set too late
  and would also create a loop (qmlViewerAspect is used to get it)

Change-Id: Iee3458cfe84e3f6b6750aa14d9d89347da21b37c
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-12 13:46:09 +00:00
Jarek Kobus
a661dc5db4 DiffEditorPlugin: Avoid code repetition
Change-Id: Ie78bb992ff145a970e1cc03f59f228851fd43b08
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-12 13:44:51 +00:00