Commit Graph

80147 Commits

Author SHA1 Message Date
hjk
3d158d73ca QMake: Constify some accessors
Task-number: QTCREATORBUG-28355
Change-Id: I25d168934da7bbc1aa6e22ac7c6bdbbfe3c3ed61
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-29 16:36:43 +00:00
Jarek Kobus
8fdbbccf3f SubChannelProvider: Pass PortsGatherer
I've cut a bit too much in the previous commit. Bring back
passing ports gatherer into SubChannelProvider.

Amends 302268c4d4

Change-Id: I5bf79300c7930348495757e3f9e4ab164512860e
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 16:12:56 +00:00
Jarek Kobus
d29fa0f3ba TaskTree test: Detect test timeout
Detect, if test has timed out before checking other results.
When the test timed out, the task tree may still be running.
This helps in analyzing the test failures inside precheck
button.

Change-Id: Iccad85dbb8b3d621165ab8b0c5a1b82a1d6808cb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 15:23:30 +00:00
Mahmoud Badri
b5befc6945 QmlDesigner: Fix content library sections not collapsing after search
Also enabled the auto expand for textures and environments tabs

Fixes: QDS-8443
Change-Id: I190f919ccb2cff90c7cd151e65b77ebd52f0a87c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-29 14:55:31 +00:00
hjk
d1c7fbcb1a Core: Remove QString overload for GeneratedFile
Adapt the only remaining user.

Change-Id: Iddd8b3a51e4eccbf04272bfb2db4cab44aa6e106
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-29 14:48:02 +00:00
Thomas Hartmann
be97b35959 QmlDesigner: Add tool tips for animations
Task-number: QDS-8312
Change-Id: Ic580dd43c4fdb0d7f33c937c1bbe1ecfb963250a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 13:51:50 +00:00
Thomas Hartmann
19f1c6c32f QmlDesigner: Add tool tips for positioners
Task-number: QDS-8311
Change-Id: Ie981d3a7806381237844707f6018278d5bb05354
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 13:51:17 +00:00
Jarek Kobus
302268c4d4 ProjectExplorer: Remove ChannelForwarder
It seems it didn't do anything useful.

Change-Id: I7a3cfb7b98734d7bc2d39243559b9cfc34952186
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 13:35:38 +00:00
Jarek Kobus
ac966d7bb9 IDevice: Provide default implementation for signalOperation()
Don't repeat implementation returning nullptr in derived classes.

Change-Id: I437f5d206464bf92706cd135d793438f46455ad6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 13:34:31 +00:00
Christian Kandeler
ac760f8e4a Core: Properly consider text codec when rewriting header files
The code blindly assumed the current locale's codec when reading files,
potentially breaking the content.

Fixes: QTCREATORBUG-28164
Change-Id: I390b3d4e615e5ca853faef2c6159988cc6246337
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 13:17:20 +00:00
hjk
9dc5a9ec00 CPlusPlus: Code cosmetics
Rename a few 'fileName' into 'filePath'. Remove unneeded includes.

Change-Id: I850e06cb4f58ec8dc70aa389f2521be8f5247b5c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 13:00:11 +00:00
Tim Jenssen
cdbdde7d37 QmlDesigner: crash fix on shutdown
Change-Id: I6e20a99189c81fcb8ec0b0474a219ac1056731bc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 12:51:27 +00:00
Jarek Kobus
bb34f507dc ChannelForwarder: Remove unused private fields
Change-Id: I25a34f6ba0a88b95b798f928940dfbf094c2ac34
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:49:34 +00:00
Jarek Kobus
ef6020ae0f QtcProcess: Set Starting state a bit later
To avoid resetting it back again to NotRunning
in case an assert triggered.

Change-Id: I4ba52bb64fd3b782013cf47d9149bef7f8a231af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:49:24 +00:00
Jarek Kobus
b31249d753 CrashHandlerDialog: Use Layouting
Change-Id: I6579c05b20e598c28c0ef68bd6f4f76d160ee950
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:42:20 +00:00
hjk
83720540a1 CppEditor: Convert parts of ModelManagerInterface to FilePath
Change-Id: If7503b6d6732e1735eb8d48ece6e80886d10c647
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-29 12:27:10 +00:00
Jarek Kobus
9a32aae706 ChannelForwarder: Remove unused m_fromUrlGetter field
Amends 19d93d29a9

Change-Id: I8b693a4e70210365415ebf8c6ed55742cf20d594
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:15:54 +00:00
Christian Kandeler
2f8e962f83 Debugger: Do not force cdb when no toolchain is configured
... in the kit settings widget.

Fixes: QTCREATORBUG-28458
Change-Id: I75907bfeeff56173fb9d92045345ba0ca15584b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 12:11:37 +00:00
Miikka Heikkinen
34b966c21d QmlDesigner: Show informative message when texture library is not found
Fixes: QDS-8444
Change-Id: Ief36595fda27b075ef3362d6f393655c56fd9940
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-29 12:03:28 +00:00
Miikka Heikkinen
26c1747ae6 QmlDesigner: Fix issues with adding texture as light probe
Changed resolving the currently active scene environment to be done
on demand instead of trying to track it realtime, since resolving it
is relatively cheap operation, so it doesn't cause noticeable delay
at context menu opening. The alternative would be to implement multiple
different notification handlers in ContentLibraryView, which would slow
down all operations and would be much more complex to ensure all edge
cases are covered.

Fixes: QDS-8437
Change-Id: Ib33cd1ad549d836b9d780f9b0f92e70d223e2a25
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 11:06:54 +00:00
Aleksei German
86ed12e729 QmlDesigner: Add StateGroups to Connections
Task-number: QDS-8027
Change-Id: I72ce5bfd2505269ad750ee5fbd5b13669891290f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 10:54:17 +00:00
hjk
8249eabbad Utils: FsEngine micro-optimizations
Mostly for shorter code, but also save a few cycles due to less
string construction and run time dispatch.

Also, make testFilePathFromToString() test two paths instead one path
twice.

Change-Id: I50a3145bca1a4b262a15e96173ea7ebd9cb678ad
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 10:17:41 +00:00
hjk
f7d022009b QMake: Use FilePath for sysroot
Less roundtrips.

Change-Id: I0f98629398170f5d1d4ccd60cfaa0d54f8e2b9f3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 10:11:18 +00:00
hjk
669242b9d8 QMakeProjectManager: Progress towards reading remote .pro files
Change-Id: I26d6d47ac7cd44ec2877243d562de1d90ba45054
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 10:10:52 +00:00
hjk
3537c9974e Utils: Use .path() instead of .toString() in some local cases
Same effect, but "better" conceptionally.

Change-Id: Ic33bdc097b38176e81413736b2eb44d1fb7d0a3f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 10:10:27 +00:00
Marcus Tillmanns
452e1ca232 Docker: Ensure workdir for processes is reachable
When starting a process, make sure that the working directory is
reachable.

Change-Id: I911239d03afd916411d7fb03da806211349ff7e4
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 10:03:34 +00:00
hjk
50f6afe4d0 QmlProjectManager: Use a PathChooser for the fallback qmlscene
Allows to browse for binaries on the target instead of having to
specify a proper fully qualified remote path manually.

Change-Id: Iaf9dc5c4fe921a7188ef2178f10403fa01e69d03
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 09:51:08 +00:00
Riitta-Leena Miettinen
49546c4f48 Doc: Add M401 and M402 code syntax error and warning messages
Fixes: QTCREATORBUG-28482
Change-Id: I3a8976c0c96c102c9f745a1643d3a02e062658ac
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 09:50:58 +00:00
Eike Ziller
c3b05f1ef1 German translation: CMake
Change-Id: Ied82a653d6e1cc6336e501c79728ceb085c7d49d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-29 09:13:57 +00:00
hjk
9a9061a04a QmlDesigner: Fix warning about unused parameters
Change-Id: Ia244ae89613e67d7baede8b3e55b0ca981e60056
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-29 09:02:43 +00:00
hjk
03a91f9f98 CppEditor: Remove Snapshot::remove(QString) overload
... and fix fallout.

Change-Id: Ibbf865c3e4158fc98bb9b5372ce0633807b85576
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 08:25:16 +00:00
Xavier BESSON
3694d00dce Optionally use qmlformat for Qt Quick auto format on save
Task-number: QTCREATORBUG-28192
Task-number: QTCREATORBUG-26602
Change-Id: I22a3917e8a4de4aaf297e9d9d622bdede782c6a6
Reviewed-by: Xavier BESSON <developer@xavi-b.fr>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-29 08:06:34 +00:00
hjk
a157de7877 Utils: Fix expansion of macros in FilePath
In the New Project wizards, we do have e.g. %{ProFile} that should
expand to {scheme}://{device}//{path-to-pro}, not to
{}://{}//{schemedevicepath-to-pro} or similar.

Task-number: QTCREATORBUG-28355
Change-Id: Idbad709f3fce583f21186a1d43f27ecac15be2ea
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-29 07:28:50 +00:00
David Schulz
0bd6d7a69f LanguageClient: move completion rerequest logic
...from the code assistant to the language client specific assist
implementation. This further reduces the complexity of the code
assistant.

Change-Id: I08ba5eecea826d3ccfe7f1f5a8791a085299d6ef
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 06:04:30 +00:00
David Schulz
8ff969d149 Core: optimize search result item text generation
Do not append an alignment string if no additional information needs
to be aligned.

Change-Id: Ia40c1b683fe20af275974d98a74d56b10970e908
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-29 06:03:55 +00:00
Cristian Adam
5b6bf29143 CMake: Add a preset for a minimal CMake configuration
This "cmake-plugin-minimal" preset contains the set of plugins that
I usually need to build to be able to test the CMakeProjectManager
plugin.

Change-Id: I8bb02879df38c40be38c4a2bf4e85e0623f2dca5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-28 18:22:45 +00:00
Thomas Hartmann
5705194bc7 QmlDesigner: Fix build for tests
Updating the NodeMetaInfo mock.

Change-Id: Ia3a87095413bb58430d978bb831ed8b808596093
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 15:56:16 +00:00
Mahmoud Badri
397e5f3022 QmlDesigner: Prevent content lib scroll when context-menu is open
Fixes: QDS-8441
Change-Id: Idfc3400fac43668d14cd5ff85cb42d745ef97dfe
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 15:42:45 +00:00
Orgad Shaneh
157f2bcd39 Merge remote-tracking branch 'origin/9.0'
Change-Id: I231d35f492713f317773b79478b5f7fb97a4fe50
2022-11-28 17:29:19 +02:00
Andre Hartmann
8e5c84e3dd Git: Disable instant blame for modified files
Change-Id: Iae24a8bbcbdb3663367ee863e8cc27ad92942e17
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-28 14:37:11 +00:00
hjk
196e73fa16 CppEditor: Convert AbstractEditorSupport interface to FilePath
Change-Id: I47439e154bc28d40e112b7eef46fa1f57a8b3fce
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-28 14:02:05 +00:00
Cristian Adam
d852ec53a1 GitHub Actions / COIN: Update Qt to 6.4.0
Amends 169f2c4af6 due to the task
number QTBUG-108593.

Change-Id: Id3ab685632e32fad953d837d2f7ab357b034d739
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-28 13:53:25 +00:00
hjk
f68db427ef CPlusPlus: Migrate Macro to FilePath
Change-Id: I94e8702e81e809e4d8318572cc070a0531edaefa
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-28 13:11:28 +00:00
hjk
3c8c5b08a8 Android: Simplify 32bit detection logic
Change-Id: I379e8903294dce644bd9f0214b596b56e5d7d81e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-11-28 12:34:13 +00:00
Christian Kandeler
aed633712f CppEditor: Prevent /TC and /TP with Objective-C files
This is relevant when clang-cl is used to compile Objective-C projects.

Task-number: QTCREATORBUG-28369
Change-Id: If8ae4dfaa07bf2ec81fbbec358663617c430b9e2
Reviewed-by: Frederik Seiffert <frederik@algoriddim.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-28 12:32:41 +00:00
Henning Gruendl
5b19c034ed QmlDesigner: Remove error states editor
Remove the error "Unable to assign [undefined] to QUrl" thrown by the
states editor.

Change-Id: Ic48deddbe698f161f486003ccaf9eb22d0ee65a9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-28 11:46:24 +00:00
Henning Gruendl
4b72ac3022 QmlDesigner: Fix states editor dialog not closing
Task-number: QDS-8439
Change-Id: Idf633b345de6e4f124b2f621699615ac6d764ceb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-28 11:45:57 +00:00
Thomas Hartmann
84104499b7 QmlDesigner: Add missing ItemLibraryItem property
Change-Id: Iab3a50ac67002e4a2f3807ee920bce892cd087cc
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-28 11:32:13 +00:00
hjk
a146403596 Utils: Make FilePath::refersToExe(...) return the found item
... and use in on the CMake side.

Change-Id: Ib215ebc4f87beb67b6a302d0c42e7b955a2fa5b7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-11-28 11:30:38 +00:00
hjk
9e0ed9eeac QMake: Remove one occurrence of QDir::cleanPath
Depends on host system.

Task-number: QTCREATORBUG-28355
Change-Id: I2f44bbbb96a080154838d9677e3c8aee2dba5e18
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-28 11:17:08 +00:00