Commit Graph

43481 Commits

Author SHA1 Message Date
Ulf Hermann
2aff7963b4 Don't use qSNaN()
signalling NaNs are generally undesirable as they with trigger a signal
on any further arithmetics operation done to them.

Change-Id: Icebae3d4eb22c8294b11da234a2ba5c7e31b9733
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
2015-12-10 14:12:20 +00:00
Robert Loehning
b2321e04f1 Squish: Finish update for tst_qml_js_console
Change-Id: I5efd9e93a22beed24e770c2015e7239576be6438
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-10 11:37:56 +00:00
Alessandro Portale
b327f1a78c MiniSplitter: Make it actually themable via SplitterColor
The CE_Splitter drawControl code in ManhattanStyle wasn't used. This
patch removes it, changes MiniPliter::onPaint to use the theme color,
and adjusts dark.creatortheme's SplitterColor so that actually nothing
changes visually.

Change-Id: I0b94bd2125fd037c2c21dad195f31d092332db43
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-10 11:33:02 +00:00
BogDan Vatra
957c0af570 Immediately return the default device if is found
Task-number: QTCREATORBUG-15422
Change-Id: I7be44fbe43c320c171ffb724ffd25414e184fd9a
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-10 10:47:31 +00:00
Christian Kandeler
255611f3e7 Debugger: Fix qbs build.
Change-Id: I2cad7082821bd43fdb35986b20a00d3ccbb41b62
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>
2015-12-10 09:40:26 +00:00
Orgad Shaneh
d4d0b889a0 Debugger: Completely ignore *running message on Windows
They appear with each newly created thread, which makes them unreliable during
startup, and useless later.

On startup, we issue -exec-continue and expect running. But unrelated *running
messages appear, and the state is changed to RunOk, although exec-continue is
not done yet. This results in "UNEXPECTED STATE" error logs.

Trust only response ^running.

Change-Id: I5e75fcd19928dab83d83ca71e9497021766460e9
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 15:41:59 +00:00
Tobias Hunger
f6683332a6 Fix configureAsExample
My last commit broke that.

Change-Id: Ib601965120d13abdea4007158f1a6829a72c6690
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-09 15:25:40 +00:00
Christian Kandeler
00e6798211 Debugger: Use PathChooser::pathChanged() signal in some places.
Instead of PathChooser::rawPathChanged(), because the associated slots
use PathChooser::path() rather than PathChooser::rawPath().

Change-Id: Idcf0709583ccf285d07f45b2b3007951d918fb04
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 14:53:17 +00:00
hjk
c8c792538e Debugger: Modernize RemoteSetupResult construction
Change-Id: I414fd2b55e632d7b200c1b3691df087cb83e8a95
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-09 14:43:22 +00:00
Ulf Hermann
3158981ba5 Debugger: Don't reset script evaluator in QmlCppEngine
If we don't set it, we shouldn't delete it, either. The QML slave
engine will handle that.

Change-Id: Idef54e6bbb4124ed195d88a367ef07c9bb8f6b3d
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 12:06:32 +00:00
hjk
33651877d8 Move QmlConsole to Debugger
Now it is closer to its only user and possibly reusable for no-QML uses
there.  We also drop the QML/JS syntax checker. The application being
debugged can already tell us about syntax errors. There is no need to
duplicate that functionality.

Change-Id: I2ba151f9f4c854c6119ba5462c21be40bddcebf9
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 12:06:26 +00:00
Orgad Shaneh
0e76b99108 Debugger: Output pending commands also on non-critical timeout
Change-Id: I964c3feb8b093b0e09b5bfc73f21897ac0335bbb
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 11:45:03 +00:00
Alessandro Portale
16a4961343 Core: Octagonal error icon
Resembles more the traditional stop sign than the previous hexagon did.

Change-Id: I4bd602ce1cddc4e485da689c72d9dce39ba07683
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-09 11:44:05 +00:00
Ulf Hermann
d039237660 Qml Inspector: Implement and use setObjectIdList()
This way the items highlighted in Qt Creator are also marked in the
application when the inspector is active.

Change-Id: I89c3270cf5c108c1549ea01704bfd0e4b7a44ca5
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 10:33:02 +00:00
Ulf Hermann
e4594eec13 Debugger: Log connection failures to QML/JS console
The debugger log is not very accessible and people may want to see this
message.

Change-Id: Id5e5a6d84f3576df3756d1fabc9f5801dcebac6e
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 10:32:59 +00:00
Ulf Hermann
f8f60a343b Qml Inspector: Add some coding style
Change-Id: I94e0c19734bee06531756df21aee26354a5aeaeb
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 09:19:09 +00:00
Ulf Hermann
58e8e28181 Qml Inspector: Use QPacket instead of unversioned QDataStream
Change-Id: I29d0635ff4f9afd4b5077e669e622c73f9184d25
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-09 09:19:06 +00:00
Ulf Hermann
b27a541c61 QmlDebug: Remove inspector "reload" functionality
It isn't used and rarely works.

Change-Id: Ied10c1500da0e24cc780aa737581c90354817d85
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-08 14:52:09 +00:00
Orgad Shaneh
f0007fa557 TaskList: Document relative path behavior
Change-Id: Idda420cfbd2fa701e45e0072730d83d6b8735232
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-08 14:13:28 +00:00
Alessandro Portale
09d03825fc Core: Better warning/error/info icons on non-toolbars
The warning/error/info with shadow and transparent mark work
well on our toolbars but not anywhere else.

This patch creates a separate set of these icons with better
contrast, filled marks and no shadow.

Change-Id: I96787753dffd80b325336f0adc8e3be054c34618
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-12-08 13:05:54 +00:00
Ulf Hermann
ee6399fd2e QmlJS: Flash the console when warnings are printed.
Change-Id: I9333e9d20a8d742ef0a0fcf2164bc6a127f77768
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-08 10:05:23 +00:00
Jochen Becher
2f44c0e843 ModelEditor: Fix converting file names to element names
Change-Id: I3c739479ad1fe226876f99f9703b339827a2859b
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-08 10:01:13 +00:00
Jochen Becher
0750fd6de5 ModelEditor: Store last used toolbar in diagram
Opening a diagram will automatically show the toolbar which was lastly
used for that diagram.

Change-Id: Ia78225ca0bd3d9fbebfcfd22691bcc702e69e5ea
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-08 10:00:54 +00:00
Orgad Shaneh
90ab6e9b94 TaskList: Make relative paths relative to the tasks file
... instead of relative to the project directory.

This is much more intuitive.

Change-Id: I2e8224fe998f7b762425a26970d5de85909a5d47
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-08 09:53:07 +00:00
Orgad Shaneh
6412cda77f TaskList: QString -> FileName
Change-Id: I87ac1623447eae1a7fa3b96c0d50896ec8d6266c
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-08 09:53:03 +00:00
Alessandro Portale
bdd0ec9373 ProjectExplorer: Cleanup buildstep icons
Replacing differently themed icons sets by a single one which
gets themed at run-time.

Change-Id: I66b5e2972419e41b3f101ee0301da30409bb975c
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-08 09:13:03 +00:00
Alessandro Portale
93a6ecfb07 Core: Improve themeing of LineEdit icons (search, clear, ...)
...by providing a specific theme color role PanelTextColorMid.
Also, this fixes the opacity of editclear.png and magnifier.png

Change-Id: I0293eaa397a0b64595ddd66f608bdfe9f7b8e705
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-07 16:48:25 +00:00
Eike Ziller
6221a5b591 Merge "Merge remote-tracking branch 'origin/3.6'" 2015-12-07 14:57:28 +00:00
Ulf Hermann
a8aa527500 Debugger: Don't manually break the connection error message
The message window can do that by itself and in other places we may
want to print the whole message in one line.

Change-Id: I5f0891c7b81717182d17b83f5a62ab06ad168801
Reviewed-by: hjk <hjk@theqtcompany.com>
2015-12-07 14:55:50 +00:00
Eike Ziller
9554495bb1 Merge remote-tracking branch 'origin/3.6'
Conflicts:
	src/plugins/baremetal/gdbserverproviderprocess.cpp

Change-Id: I1ba618db9db6669edada6477c05a1b56b7b5b430
2015-12-07 15:55:35 +01:00
David Schulz
11cb55a21f Debugger: Make sure handles are closed correctly.
Change-Id: Iede1548f29418d6707c9cdf1465bfb663bc00615
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 14:25:35 +00:00
Robert Loehning
89d8693107 Squish: Work around bugs in tst_cli_output_console
Change-Id: Ief5f731b3ff84dcbd34f4200acbe2646847c0f1c
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 13:41:20 +00:00
Christian Kandeler
f97e5f1545 Fix Qt Creator executable installation for qbs.
Commit 59ac67c0bb broke this for non-OS X.

Change-Id: Iac23a3e37bd9964af4ffb79be256f59c0b0fedb9
Reviewed-by: Jake Petroules <jake.petroules@theqtcompany.com>
2015-12-07 13:26:05 +00:00
hjk
7c08f5a9b0 Debugger: Further improve base class dumping with LLDB
... in the presence of empty base classes. This now actually makes
the Inheritance dumper test pass.

Change-Id: I92ada5da46accb6e7eaff58ce5dc329484ef0909
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 12:38:50 +00:00
Marco Bubke
19d9dc0ce3 Clang: Use line and column instead of offset for diagnostics
Offsets can be get wrong because of the utf8 <-> utf16 differences. Line
and columns are not that sensitive to it.

Change-Id: I2e3e8c000621b6d694a4ada6df176f29427794f5
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
2015-12-07 11:10:05 +00:00
Robert Loehning
a4231de01c Squish: Update tst_qml_editor
Change-Id: I403b64fc60e3d4f1ad0635ce86190ea89ab49de5
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 10:21:24 +00:00
Robert Loehning
4d4eb4da22 Squish: Remove pointless tabs from tested code
Change-Id: I030aeff529c24730a13087fd9554d1f60a0e7462
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 10:20:22 +00:00
Ulf Hermann
be5b1ab2a7 Timeline: Don't set the zoom slider to externally updated when it isn't
In particular, the value seems to be an int and so we have to round the
new value before comparing it. If it then is the same as the old value,
valueChanged won't be called and the flag won't be cleared.

Change-Id: I64e26ca322afe1093c689d498c9110e524ff2964
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
2015-12-07 09:22:49 +00:00
Ulf Hermann
e339fd50b0 Timeline: Zoom around fixed point when using zoom slider
The idea of centering on the selected item is somewhat
counter-intuitive and leads to unpredicable behavior.

Change-Id: I203038d5f3103468037378132b9bdc04a1f194d3
Task-number: QTCREATORBUG-15440
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
2015-12-07 09:21:44 +00:00
Denis Shienkov
7607fae2bf BareMetal: Use the Qt5 signal/slot connection syntax
Change-Id: Icb51db0fbd77bbaba913a16eb468b0edafa047bb
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Tim Sander <tim@krieglstein.org>
2015-12-07 08:54:56 +00:00
Denis Shienkov
6e2738af0e BareMetal: Do not use QPointer if it is not required
Change-Id: Ib7162ae6b40d06bfb54705fd4b53bde2ce78083c
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Tim Sander <tim@krieglstein.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-12-07 08:49:41 +00:00
Marco Bubke
c209aaf22e Clang: Fix highlighting issues
...for macros, typedefs and enums.
	
Change-Id: I926e7238695caefd7f4463dbe0cf5b428aa98c1a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
2015-12-07 08:41:03 +00:00
David Schulz
ea8665c2e2 CdbExtension: Make sure watches group is initialized.
This fixes a crash that occurs when a debugger was started
without an active watch and a watch were added afterwards.

Change-Id: I0219a750bae7b433240b22f99b2e8fd8655ca331
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 08:32:47 +00:00
hjk
2714a7e981 Debugger: Remove spurious quotes in gdbbridge.py output
Breaks the parsing and might trigger an endless loop.

Task-number: QTCREATORBUG-15352
Change-Id: I832d26441d8be3339b4de6d59a33c97f1d7124c5
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2015-12-07 08:17:01 +00:00
Eike Ziller
b6e4e966f4 Locator: Remove whitespace from start and end
It is not very intuitive, and can easily happen when copy&pasting into
locator.

Change-Id: I51d226b8e834c43eedc042035a9b90aa7ee4844f
Task-number: QTCREATORBUG-15399
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
2015-12-07 08:05:06 +00:00
Jochen Becher
4a06fc63a9 ModelEditor: Allow relocation of ends of relations in diagrams
Change-Id: I8dbf536731cb24819f70dc6acacc4658fd257259
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-04 19:12:30 +00:00
Tobias Hunger
fb99157abd Core::Id: Handle empty strings passed to fromString()
Return Id() in that case. Currently we can convert the invalid Id
to a string, but when we try to convert that string back to an Id
there is a soft assert.

Change-Id: Iad8443ff65a643030bd47446ec2dcf2889d2e4eb
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-12-04 12:57:00 +00:00
Alessandro Portale
03c07b80fd Core: Unify the close icons
Use the same image file and recolor it as needed,

Change-Id: I914819a53ca05d83ca5b88adf44706b460b48ac0
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-04 10:47:32 +00:00
Leena Miettinen
2e341ffdfe Doc: fix QDoc command in a tutorial
Change-Id: Id511edfce884130a7c93dc8f51eb156a10b5b73f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
2015-12-04 10:41:25 +00:00
Robert Loehning
6c4504159a ResourceNode: Fix directory separators
Change-Id: I589397178cf4ad749825f004638a2d9852d7f0c3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-12-04 09:57:25 +00:00