Until now std::vector::at() was used to access the elements. This is
handy for debugging since an exception is thrown for invalid indices,
but it does not stop Qt Creator from crashing because exceptions are not
caught.
This is especially a problem for the parser, which has to look ahead via
LA(n), which accesses TranslationUnit::_tokens.
With this patch, explicit bounds checking is done before accessing the
elements and thus calls to
std::vector::at() // bounds checking, throwing out_of_range
were replaced by calls to
std::vector::operator[]() // no bounds checking, not throwing out_of_range
Measuring the parse time for the Qt Creator project shows that there is
no slowdown. In both cases, with and without the patch, about 15s are
needed on the authors machine.
Task-number: QTCREATORBUG-10453
Change-Id: I32b12a526ff7199bcadfc21a3deb5354063a3e3b
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Dumper was working, but the default constructor doesn't do
the parsing already nowadays.
Change-Id: I098b0a03ad7d994b5746f3a4a6c39d29133509b0
Reviewed-by: hjk <hjk121@nokiamail.com>
Disable valgrind autotests for now. The people responsible for the
plugin have to decide which ones can actually be used on Windows and
which ones cannot.
Change-Id: I579de6258c73845a1935a9c220346879251bc478
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Would be nicer if there was a global way to tell GDB to not produce
"adorned" output...
Task-number: QTCREATORBUG-10344
Change-Id: I5355ebea0570f76415fdacfed34e1311825f57b9
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk121@nokiamail.com>
Only methods as programming functions are affected. Besides renaming
some actions like "Switch Between Function Declaration/Definition" this
mostly touches (api) code comments.
This is a follow-up patch to commit 872bfb7.
Change-Id: Icb65e8d73b59a022f8885b14df497169543a3b92
Reviewed-by: hjk <hjk121@nokiamail.com>
Fix Qt Quick Designer product name. Fix a typo in a test message.
Change-Id: I668af65da835017ebc876810a8d2c7d638290c77
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
MEMBER was added in Qt5.
Task-number: QTCREATORBUG-10068
Change-Id: Ic6c15a0e5ee8981ab98e4c12fc1521dc281b731f
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
If two files from different (sub-)projects include the same header file,
and the defined macros differ for both files, the header file will be
parsed with only the appropriate macros for the including file.
Task-number: QTCREATORBUG-9802
Task-number: QTCREATORBUG-1249
Change-Id: I560490afa287b3bb1e863bce1bb4f57af36ad56e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Valgrind doesn't work on Windows, and the compiler flags for those test
apps are incompatible with MSVC
Change-Id: I9c17c29759d18434ef4a14cc57bcfde8405d770f
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
QTCREATORBUG-10045 which tst_openqt_creator found was fixed.
Change-Id: I804427276d37ca97ce4577e40cfa73d515218de5
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Until endFormatScope() is called, continuation lines keep the last
format.
Change-Id: Ic68ae6d716519f537189ebae763da4dc2c30978d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Petar Perisin <petar.perisin@gmail.com>
QStringList is movable in Qt 5.
Task-number: QTCREATORBUG-10211
Change-Id: I6b94acd37bbf8ca165960c50fd3da81408ccbb1b
Reviewed-by: David Schulz <david.schulz@digia.com>
Only one kit in use now. According to dt it's gonna stay this way.
Change-Id: Id52f04db438eda8d9eebf79264c7ddd28a0f497e
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Branch information is now listed in square brackets.
Change-Id: I4f38f2a93b8029ed319fae3a7c32adc0aba50660
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
