Commit Graph

50929 Commits

Author SHA1 Message Date
Nikolai Kosjar
8c7079dd24 Beautifier: Fix leak of GeneralSettings
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4f06b0 in operator new(unsigned long) (/home/nik/dev/creator/
ut/4.2_asan/bin/qtcreator+0x4f06b0)
    #1 0x7f4ac0e5d068 in
Beautifier::Internal::BeautifierPlugin::initialize(QStringList const&,
QString*) /home/nik/dev/creator/ut/4.2_asan/src/plugins/beautifier/
beautifierplugin.cpp:214:25
    #2 0x7f4ada1bb769 in
ExtensionSystem::Internal::PluginSpecPrivate::initializePlugin() /home/
nik/dev/creator/ut/4.2_asan/src/libs/extensionsystem/pluginspec.cpp:
1001:10
    #3 0x7f4ada1694b1 in
ExtensionSystem::Internal::PluginManagerPrivate::loadPlugin(ExtensionSystem::PluginSpec*,
ExtensionSystem::PluginSpec::State) /home/nik/dev/creator/ut/4.2_asan/
src/libs/extensionsystem/pluginmanager.cpp:1404:9
    #4 0x7f4ada15b2b6 in
ExtensionSystem::Internal::PluginManagerPrivate::loadPlugins() /home/
nik/dev/creator/ut/4.2_asan/src/libs/extensionsystem/pluginmanager.cpp:
1239:9
    #5 0x7f4ada15ac6f in ExtensionSystem::PluginManager::loadPlugins() /
home/nik/dev/creator/ut/4.2_asan/src/libs/extensionsystem/
pluginmanager.cpp:362:12
    #6 0x50a97c in main /home/nik/dev/creator/ut/4.2_asan/src/app/
main.cpp:517:5
    #7 0x7f4ad65b282f in __libc_start_main /build/glibc-Qz8a69/
glibc-2.23/csu/../csu/libc-start.c:291

Change-Id: Iff1fd908d9a59b98e895599b1d73ca16536eee11
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-18 17:44:45 +00:00
Leena Miettinen
659baae978 Doc: Edit .gitignore, because doc file target dir changed
It is now /doc/qtcreator/ or /doc/qtcreator-dev/

Change-Id: Ifce996b2d5b82502e578db9a6db058fb714e4ec9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-04-18 13:44:30 +00:00
Eike Ziller
b3298529e7 Merge remote-tracking branch 'origin/4.2' into 4.3
Change-Id: I4f4d3df2b57fdc30f1775244dddfe4299555bfc8
2017-04-18 14:40:17 +02:00
Leena Miettinen
071e52c7f9 Doc: Update build and run instructions
The search field in the Examples tab in the Welcome mode seems
to be case-sensitive, and the keyword is "ios" in lower case
letters.

Also added information about what to do if the example list is empty.

Change-Id: I5797266244f0550f3c78aa302a2c7b22a46f5c09
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-18 10:06:28 +00:00
Orgad Shaneh
530c248051 Core: Fix compiler display name for MSVC2017
Change-Id: I0a0a6e2899373241dac0cdec5154ea7f22efd0c2
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-18 08:43:13 +00:00
Alessandro Portale
bc35392123 Core: Handle an invalid theme id from the settings
Don't crash if the settings contain an outdated/invalid "CreatorTheme"
entry.

This change makes ThemeEntry::themeSetting() validate the entry. If no
theme with that id exists, it returs the default/first theme instead.

Task-number: QTCREATORBUG-17517
Change-Id: I87658fade33ba4d956d3a4c5591dd86db4051426
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-15 22:23:04 +00:00
Montel Laurent
4fcbf91d30 Use toByteArray() directly
Change-Id: Icaa88b711285307a6d242067eaca9db852ded04f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-14 14:57:58 +00:00
Montel Laurent
5d27bc747b Use QFileInfo::exists(...) which is faster that QFileInfo(..).exists
Change-Id: I0d2e61d84c74e60ef4f54074a4ca00f2d0835562
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-14 13:18:28 +00:00
Montel Laurent
f976dc96fd Reserve some elements
Change-Id: Iceef4e9a6f213a747045db3b06a5608d77652f98
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-14 13:18:17 +00:00
Montel Laurent
f18ae4ff6f Don't use return keyword when not necessary
Change-Id: I4b9fad1eee60e942ddbccda53a4af27e978df498
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-14 11:02:14 +00:00
Christian Kandeler
660c4ced86 QbsProjectManager: Fix collecting unreferenced build system files
We cannot use std::set_difference on a QSet, because those are not
sorted.

Change-Id: I6238a2bd06bcc6e5dba64572f0c3b0caaa57a7eb
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
2017-04-13 09:21:37 +00:00
Christian Kandeler
4b39baa8c1 QbsProjectManager: Add project file nodes for sub-projects
They got lost somehow during the project tree refactoring.

Task-number: QTCREATORBUG-17859
Change-Id: I1d1178c3d0932322604e7035f15dcc4490309ca9
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-04-13 09:19:36 +00:00
Christian Kandeler
b520a90644 QbsProjectManager: Add unreferenced build system files to the right node
They ended up as children of the root node somehow during refactoring.

Change-Id: I2da3ac74369fd9456b62839f1498f84f0034a85c
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-04-13 09:19:04 +00:00
Robert Loehning
d6ecd65c1c Squish: Clear General Messages before running tst_codepasting
Change-Id: I78514e5a8553349abdf2558bba6c4a15ad280eba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-12 21:21:44 +00:00
Thomas Hartmann
c50fbf2450 Fix Toggle Right Sidebar shortcut on Windows
Ctrl+0 is used for the left sidebar on Mac,
so it should be save to use it for the right
sidebar on Linux/Windows.
The original shortcut (Ctrl+Shift+0) is used by Windows 10
and therefore does not work.

Task-number: QTCREATORBUG-17857
Change-Id: I832135c3779508b9789b5be4757e1bbc9bd255eb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-12 16:18:44 +00:00
Christian Kandeler
399a1c9c7d Android: Fix build with namespaced Qt
Change-Id: Iecd44b8da2a5d35f6f98ea4a9b142853b73f25fd
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 14:50:21 +00:00
Christian Stenger
a01507e90e CPaster: Fix pasting to KDE paster
Add minimal handling for credentials.

Task-number: QTCREATORBUG-17942
Change-Id: I5f3821fa944fa7800bd1f51947f46d301e2b00b8
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-12 14:17:20 +00:00
BogDan Vatra
d4ca232d54 Android: Improve application output window by adding filters
- allow the user to choose the visible log levels
 - allow the user to choose which activities/service(s) logs are visible
 - wakeup the device (API 20+)
 - use only the most recent logs (API 21+ add "-T 0" to logcat params)
 - use logcat -v time format, which is the same on all Android versions

In the future we can even allow the user to choose which parts of the
log line are visible, e.g. time, log level, TAG, PID, Message

Task-number: QTCREATORBUG-16887
Change-Id: I07ce00aff59a479660f5ac6da75eef973ba3f627
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-04-12 13:57:34 +00:00
Vikas Pachdha
8dc98995fa Android: Force Gradle build post SDK tools version 25.3.0
Task-number: QTCREATORBUG-18013
Change-Id: Ic912427783d079f5f6bf06e3bf9a44657d24a96f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 13:54:24 +00:00
Vikas Pachdha
70be880bcb Android: Use avdmanager tool
android tool is deprecated since sdk tools version 25.3.0.
Use the new avdmanager tool

Task-number: QTCREATORBUG-17814
Change-Id: Id6f495f14e12d0069df08164cac1929b76d9e932
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 13:42:10 +00:00
Vikas Pachdha
05b77e8468 Android: Use sdkmanager tool
android tool is deprecated since sdk tools version 25.3.0.
Use the new sdkmanager tool

Task-number: QTCREATORBUG-17814
Change-Id: I96446f5a64c1c400066b4ac7771c8c7e1bf567ed
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 13:41:48 +00:00
Vikas Pachdha
2b5f5abb2b Android: Add system image information for each platform
Groundwork for the new sdk and avd management tool's integration

Task-number: QTCREATORBUG-17814
Change-Id: I3e46f6d3aa56c0f16dd66d0b1d731043e180e012
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 12:45:42 +00:00
Vikas Pachdha
198c83ea70 Android: Add Android tool manager
Refactor the use of android tool and groundwork for the new sdk
and avd management tool's integration

Task-number: QTCREATORBUG-17814
Change-Id: I6a5920f9ba92508f904cd8cf28bf62c82de2d820
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-04-12 12:45:30 +00:00
Christian Stenger
f173dc82df AutoTest: Provide more details on failure or guess
If a test case cannot be started or does crash while executing
these information might help to sort out configuration problems.

Change-Id: I406d5e69475d05931d4c4c4738f8528c6d74c585
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-12 11:57:36 +00:00
BogDan Vatra
750f25d9e6 Fix release builds debugging
Add gdbserver all the time, except when the user signs the package.
Even then the user can "Force debugging" by checking the checkbox.

Change-Id: I274243786f3d6d6b88f41e532bebc24213f5e9db
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-12 06:33:55 +00:00
Tobias Hunger
598100c765 CMake: Do not try to update project data when an error occurred
Do not try to update project data when an error occurred in server-mode.

Change-Id: I6a1cf4b6e79fd6ddf5329195861f34cd7f1ca44d
Reviewed-by: Florian Apolloner <florian@apolloner.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-11 14:46:14 +00:00
Alessandro Portale
c2483427f1 Utils: Keep correct palette for dark themers after suspend
Sleep, hibernation and user sign-in can cause a ThemeChange event. That
event resets the application palette, discarding a palette that may have
been previously set.

Dark themes in Qt Creator want to set and keep their custom application
palettes. So, this change sets the custom application palette on each
ThemeChange event that is send to the main window.

Task-number: QTCREATORBUG-14929
Change-Id: Ic9fb0111cfa0e8171b819d687f280c3db6cc8f2c
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-11 13:22:54 +00:00
Thomas Hartmann
5cf8fbabda QmlDesigner: Fix Crash
Task-number: QTCREATORBUG-17998
Change-Id: Ic0ad46455a0e56af3082c1d9ce8995a7f07c2238
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-11 12:44:55 +00:00
Leena Miettinen
3e665f7aaf Coreplugin: Fix UI text capitalization
Change-Id: I8738078198e0be0f010b9bce0f6688fd925eae15
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-11 11:51:46 +00:00
BogDan Vatra
d3cb2cae50 Use QVersionNumber to compare versions
Comparing strings will give us strange results e.g.
23.0.20 > 25.0.0

Change-Id: Id709ebfe45454064a18706e2df5d01ed5a3e8551
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-11 07:32:30 +00:00
David Schulz
ca039a6eae Debugger: Adjust dumper test after cdb output changed
Change-Id: Ic8cb64ce1af6d6a5e74ad018813fea47555b1cfb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-11 07:32:20 +00:00
David Schulz
34f1349c93 Debugger: Fix assigning values to locals
Change-Id: I366f597ee54e3c3d916bac2879c4c02b59ee2e83
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-11 07:32:14 +00:00
hjk
873559b9c9 Debugger: Check presence of current working directory explicitly
Change-Id: Iba6037907761702fa825764757dd00fce4a91082
Reviewed-by: Vadim Evard
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 10:25:10 +00:00
David Schulz
17485c0678 Debugger: Optimize python output handling
Change-Id: Ia97e8adaabbffe49acec44575621a4f4243c5cea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 07:07:38 +00:00
David Schulz
c00bb1dcfb Debugger: Pass uninitialized variables to the python dumpers
Reduces accessing uninitialized memory

Change-Id: I025e9070b9b17a806237619b484cb27230e7f494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 07:03:23 +00:00
Kari Oikarinen
8c86400329 Qmake: Fix deploying versioned shared library symlinks
If in a .pro file VERSION is set with less than three version
components, for example "1.0", qmake on Linux still creates the .so with
the following links to it:

- libexample.so
- libexample.so.1
- libexample.so.1.0
- libexample.so.1.0.0

Creator only deployed first three of those.

Pad the version number with zeros to three components in order to find
all of them.

Change-Id: I0ca3b7cb9d2150e7e9a5c22a5522678aec085b95
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
2017-04-10 06:00:47 +00:00
Jake Petroules
83fd207a64 Qbs: use the separate QNX OS type
... instead of detecting it via the device type.

Amends e69c2eb2

Change-Id: If7bd19412e723c268d93e16d46828925b74d6a4b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
2017-04-07 15:58:44 +00:00
Tobias Hunger
0951589420 Project: Unify handling of displayName
Unify the handling of displayName with a proper changed signal across
all projects.

Change-Id: I7e503528854b85f6f38de4b0943775f82a0d6123
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-07 14:49:51 +00:00
Tobias Hunger
28c8da4f90 Session: Emit signal when project's displaynames change
Task-number: QTCREATORBUG-17957
Change-Id: I3fcbe2171e359f71434c6162d012e64f70efce99
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 14:31:26 +00:00
Tobias Hunger
5972f7fac6 CMake: Deduplicate targets in server-mode
CMake server-mode does report targets for each "PROJECT" that was
encountered before the target was defined. So it reports several
copies of the same data all the time. Deduplicate that information.

This fixes files being duplicated in the code model and the project
tree.

Task-number: QTCREATORBUG-17955
Change-Id: I95daa0f48e37587234d7e04e9bed6d20884f8be0
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 11:45:06 +00:00
Tobias Hunger
06ccc35b3b CMake: Clear error flag in CmakeBuildConfiguration
Remove/refresh the error message in the CMake build configuration when the enabled
state changes.

Task-number: QTCREATORBUG-17948
Change-Id: I0f210fc572dde40a9adfee7ec2d934926d576d61
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 11:43:45 +00:00
Robert Loehning
4f78b1e4db ModelEditor: Fix copy/paste mistakes
Change-Id: I580d3f7a97ab81fcc6aaca1b83c0f25b1d8d1ce6
Reviewed-by: Jochen Becher <jochen_becher@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-07 10:24:27 +00:00
Robert Loehning
6344815d0d QmlJS: Abort if file could not be opened
Change-Id: Ic2175c2b8dc6ec8ce378db07bdd2b667b15f70cb
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:23:33 +00:00
Tim Jenssen
76dc24c3b7 QmlJSEditor: avoid jumping cursor while editing
Writing a property made the cursor jumped to the beginning. Now we
only set the cursor if the textedit has not the focus and no code
completion open.

Change-Id: I7e5d41d5f7f9d75ebc90506d276ccaeb193c64b2
Task-number: QTCREATORBUG-15680
Task-number: QTCREATORBUG-17413
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2017-04-07 10:21:46 +00:00
Tim Jenssen
c643095f17 QmlJSEditor: cleanup updateOutlineIndexNow
It was called to often - it was already connected in setEditor method.
Change outlineModelIndex() to be just a getter and call the
updateOutlineIndexNow() where an update is necessary.

Change-Id: I6f30bfaff74237416c1aef5418860179c1f8ebf7
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:21:21 +00:00
Tim Jenssen
2c1c51bbea QmlJSEditor: remove modeUpdated method
It does not say what it does, it is better for understanding
to call the direct method instead.

Change-Id: I2150d4c84254f684474e353995b466b59d4844c0
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:20:52 +00:00
Tim Jenssen
17fbbda57e QmlJSEditor: use initializer lists
Change-Id: Id02f4313cd789fabd1223c6934e1aa5a39ed43ca
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:20:10 +00:00
BogDan Vatra
063253d89e Copy gradle from Qt location if available
Task-number: QTCREATORBUG-17814
Change-Id: I4252c9dfc2a2d7208dee04b734e12d77c82f5eae
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 10:13:37 +00:00
Orgad Shaneh
b1180280d0 ProjectExplorer: Fix infinite recursion
If some ProjectNode doesn't override supportsAction (like CMake), then the
fallback is FolderNode, which calls the root project node again...

Change-Id: Ie7a469d6aaaae38c8c2ff56e33fed27cf1477b49
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 08:44:34 +00:00
Orgad Shaneh
d186d85bcf ProjectExplorer: Fix clang ABI detection
Change-Id: I809f8b747ffb64ed128fd0f957d13d670604d050
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 08:27:23 +00:00