In case the base class is defined outside of the file with the
derived class we are missing the correct entry point.
Work around this by getting alternative entry points beforehand
and using them if we cannot find a valid entry point.
Task-number: QTCREATORBUG-17522
Change-Id: I07ef87b2fcdac4f78240da9e57eaa518ff0f4d20
Reviewed-by: David Schulz <david.schulz@qt.io>
Preparation for later detection and displaying inherited functions
for Qt tests.
Task-number: QTCREATORBUG-17522
Change-Id: I2af1f758a837049ef676840b03f9cd73a2cb9873
Reviewed-by: David Schulz <david.schulz@qt.io>
Projects view has changed and so has functionality of adding a new kit.
Change-Id: I44377822b8b850fd17be24e12f7e5d0104be568d
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
* Icons are not the final ones.
* I fixed a couple of glitches and cleaned up the code.
- Action for copy and paste/delete were not properly updated
- Delete had no icon
- Using std::function for action predicates and operations
- The context menu has no icons. This way we avoid having to define 2
icons.
Change-Id: Ic23cbc78ba299c19e07e8de775eb813aae55db9b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
We made a implicit const cast. Like it is said C-style can be harmful
because they are not const safe etc..
Change-Id: I6b41c10c18d37af4caf58574359fdce7d4a420ca
Reviewed-by: hjk <hjk@qt.io>
This makes the code a bit simpler, at the cost of the factories not
having access to the fully specialized RunConfiguration anymore. This
is apparently never used and the factories can still use the Id to decide
what to do if they really need to.
Change-Id: I7d94f85e984ac87e62c6d341c1038e1538aa15df
Reviewed-by: hjk <hjk@qt.io>
The check is already done by numberOfChildren.
Change-Id: I2dfad4e283546acb87d17ec63e47c43a0b0d467d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The value name is already set in fromNativeValue
Change-Id: I82cdaa33133cde431d23a0f20bd5c3d6d938cf7f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Our compilers support some features which are part of the C++ 14 feature
set. Some off them are silently compiled with the C++ 11 setting.
For example:
[foo=bar] {}
is actually working with GCC but is part of C++ 14.
Change-Id: Icf2c3806e26c675f8251768c6ad54ba4da186d11
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This has the nice property of dropping trailing zeroes and allows us
to simplify the code a bit.
Change-Id: I4ac98743960ba552c8e3e72e02f594ba910ab81b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The way to extract them from Qt is somewhat funny, but this leads to
clearer messages in the debugger log and other places.
Change-Id: Ib458d5ec796a2e69a6543d405593be8e54016946
Task-number: QTCREATORBUG-17492
Reviewed-by: hjk <hjk@qt.io>
Prepend "win32-msvc" to the result list. Projects based
on Qt 5.8.1 will then no longer be misconfigured with ARM
toolchains.
Change-Id: I734ee530e4fe2c5253f946568c2ab973e51d3cae
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
For traces that start at a high timestamp, we want the timestamps to
still have some meaning. Without context the formatter will only
print something like "5h 25m" for all of them, which is not very
useful.
Change-Id: I7ec37659083f967c9ed03a843f6b7c9430214670
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This tests that the file name is correctly stored in the model and it
removes the detour via the model manager.
Change-Id: Icc592b6383edcb18bfe31a81eb7ae0736a4f5508
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There is no need to keep empty events at the bottom.
Change-Id: I072b50329a9f277005cbfa45350c060abd7e7a36
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
As time labels are formatted with a precision that matches the context
we are generally interested in the right part of the string if it
doesn't fit into the cell. Therefore, elide left. Also, the label
corresponds to the line left of it, so put the margin to the right,
rather than to the left.
Change-Id: I953b1bc674e131dbfcf873774127c6360163f20f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
10^12 doesn't fit into a 4-byte integer and we want to adjust the
minutes when printing hours, not the hours themselves.
Change-Id: I722403b8cb7f6817aed1b6a5e3c406349fe1bd53
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Do not crash when setting custom executable without ever visiting
the runconfiguration before.
At that point the chooser is still a nullptr.
Task-number: QTCREATORBUG-17505
Change-Id: I27fb19845adf9c7ec0ad5a9435c8d86a573a2532
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It is not an error. SDKTool can be used to create new files.
This reverts commit 274d3a8c79.
Change-Id: I4af46b4deb5fe356a9c1050cc9557d43f3a91a6e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
realloc is not being listed by Clang Code Model
Task-number: QTCREATORBUG-17490
Change-Id: I006fee04579706fbf5edf8b890bd7be8e090d01f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The ExpressionTextField is part of every control, but is only required
if the action is triggered in the menu. Therefore we only create
the ExpressionTextField on demand.
This significantly speeds up the property editor since
the ExtendedFunctionButton is part of nearly every control.
Change-Id: I67a6ab86e70401c53bbe42a16aa1e12d725f16f6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This is required for the TextEditorView to get the
notifications from the model.
Change-Id: I8d548e3018f217466f15a469d428894e66e74c39
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This is required to avoid blocking the ui while typing, because
the model is updated.
It will take 400ms without changes to the text until the model
gets updated.
Change-Id: Id428a52c15aeb8f0b802ee0448be8e6777a7402a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
When a section in the item library is colllapsed, then
the designer should remember this. This was already implemented,
but the feature stop working, because of refactoring.
Change-Id: Ib4465b87ade7b0c8ff501dea9893ee98caaae753
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We use a property to control the state and ensure the animation
is not triggered by the initialization.
Change-Id: Icf88e63e6fda34826da6be70369902fa168ea48c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
In C++ noexcept(true) is the default for destructors.
Instead of poluting the code base with noexcept(false),
we catch the exception inside the destructor of the transaction.
Typically the application code does not anything special to handle the
error, so showing the error message is good enough.
If the application code wants to handle exceptions commit()
has to be called instead of relying on RAAI.
Change-Id: Ic73cacb197737698454eca9270d07fd897c97ca8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We get editingFinished twice. By checking visible we able to ignore
the second signal.
Change-Id: Ic5ab91e153b1d658a68321436c71b914e065c6dd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
