In 4.2 the IDevice constructors need to set the device icon, and I
missed a few constructors. This should fix it.
This patch will not apply to master, and should be skipped when merging.
Change-Id: I66cf529dfe539a90a753dd15e8f069e1f11e8176
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Generated files are not available, so clang will stop with an fatal error.
Change-Id: I80754015a1daf48cbf2ce8e06526c75b05b2901c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
You had to set the no alive timer environment variable.
Change-Id: I1994087a68d8293963f9f48fa1632f7c6822b146
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Because of the ancient compiler support we cannot use
std::make_reverse_iterator. If we support newer compilers we can revert
this patch.
Change-Id: I9b20ab1e53a0e9784b0455eafbbfd966797ad91e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We need the generated UI header but we don't have a build directory. So we
provide clang with in memory represations of the file.
Change-Id: Ie9db97bbea2222b0203a0457baa1f1fc7ad97213
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Otherwise we call virtual function in the base class.
Change-Id: I35a3d9a59dc6558b9386ccfa7169cef5f2e15e10
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
std::unique_ptr is in the standard and QScopedPointer maybe gets
depreciated in futur. So lets use std::unique_ptr instead so we don't have
to change to much code later.
Change-Id: Id479b0e80adaf3da4e408198d43c5dfd09a8c66d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Because of C++ linking problems we introduce QTC_NO_CLANG_LIBTOOLING as a
workaround to disable Clang LibTooling. Use QTC_NO_CLANG_LIBTOOLING=something
to disable it.
Change-Id: I2dc9947d69d94292e08dacb1558bef56f5ebbbe3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Using llvm_config --cxxflags can be potential dangerous. We should test
every configuration if it is compiling. It has the advantage that we don't
need to care anymore about incompatible flags to the used clang version.
Change-Id: I3bbddb1935dca9896c64ebafd1fbe72840db8bd4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The help system used to be confused by types from QtControls2, since
they have often the same name and version as the ones in QtControls.
This patch resolve the issue by looking for a number in the module
name, and then using the url found as helpId.
Task-number: QTCREATORBUG-16851
Change-Id: I48196d90b0fea5edf50751900864a39075894866
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
This fixes a broken switch statement by removing it completely.
Change-Id: I3d0184bb408125eecb6a8e728fabe593233115c3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
People are known to put things like passwords into environment
variables, and we pass the environment hexencoded to the debugged
process, so it might be overlooked when logs passed around.
Better not have the data in the log to start with.
Change-Id: If93a42a291b8b62c38d01e606cc0e49b8f2e3e95
Reviewed-by: Filipe Azevedo <filipe.azevedo@kdab.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Clang Format options differ somewhat from the Artistic Style
and Uncrustify options.
Also, the "Format entire file if no text was selected" is enabled
by default and also applies to Uncrustify.
Change-Id: I19d6badbd71275a185894e8c5dff96826d378afb
Reviewed-by: Lorenz Haas <lorenz.haas@histomatics.de>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
No need to require the project managers to do this. Also, it is easy to
forget.
Change-Id: I96f7a5e5547418678af9653e5753c372f0880e5a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
... to a shortcut to the Kits setup page.
This duplicates the functionality from the context menu but can
be directly spotted.
Change-Id: Ia5c2e1208346dc7191a04fbb9c2569ccab9aab31
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Invalid events with binding loops could trigger a null pointer access
as the the check for creating the nodes for the binding loops render
pass was somewhat stricter than the check for populating them.
This is largely an academic problem, though, found by coverity.
Change-Id: I7f2681960f23e4a31977faa0d538bc257fa4cf2c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Support for the Qt Quick Controls 1 has been removed.
Change-Id: I6fc64cea94ee64cabb19935124bb9e8fdc3d1089
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
