Commit Graph

50019 Commits

Author SHA1 Message Date
David Schulz
01df962d6a Python: install python language server with --user
Change-Id: Ifd8e19ea7d52d85ec0c497e5cbfe24300571398e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-25 12:50:35 +00:00
David Schulz
10c94994db Python: close all info bars after language server setup
Change-Id: I607f7cb5a31f3db0c7d7d77011860a1ea87eb8d2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-25 12:50:24 +00:00
Eike Ziller
088d5c0f77 TextEditor: Fix HTML escaping of tool tips
Tool tips without help ID were HTML escaped but never shown in a HTML
tool tip. Just always make them rich text. Line endings in plain text
must be changed to "<br/>" as well.

Change-Id: I9fd378e2c9a58ddf5834d67927fe3da9157cfbc7
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-25 12:40:15 +00:00
Eike Ziller
3476dbd560 LanguageClient: Show markdown tool tips as plain text
We tell the language server that we do not support markdown, but some
(haskell-ide-engine) ignore that.
Show the text as plain text.

Change-Id: I1a61346b497cc04dce6c0da4221e949a16c61acf
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-25 11:56:53 +00:00
Eike Ziller
7f0654e35c TextEditor: Do not show F1 in tool tips that don't provide help ID(s)
Like it is the case for the language client.
Utils::TextTip::configure uses QVariant::isNull to check.

Change-Id: Ie1e47284a9062e79efcf0debf68486b05bce48ef
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-25 11:10:05 +00:00
Eike Ziller
80a3c7248e LanguageClient: Remove unnecessary function re-implementation
Change-Id: I44862986a5ecc808b834d7c6d76191cbd9fd07a6
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-25 11:09:46 +00:00
Laurent Montel
1e22a22403 modeleditor: remove unused forward declaration
Change-Id: I7c9c6856318145214ce9e76feeb721abed3b4e61
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-10-25 09:19:14 +00:00
Laurent Montel
69007ab116 diffeditor: remove unused forward declaration
Change-Id: I9da0e889262e37efae29ee7214edd5d95697e13d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-10-25 09:19:01 +00:00
Miikka Heikkinen
1fe204565a QmlDesigner: Add support for move gadget to 3D edit view
This proof-of-concept move gadget is based on the move gadget
in studio example of QtQuick3D.

Change-Id: I1b596443a3e99c16ed214bc464c5367a0f7aa503
Fixes: QDS-1125
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Pasi Keränen <pasi.keranen@qt.io>
2019-10-25 07:51:09 +00:00
Eike Ziller
44ddca544c Fix focusing of already open output pane from separate window
If the focus is in a separate window and the shortcut for an already
open output pane is triggered, we should set the focus there and
activate the window, not close the output pane.

Fixes: QTCREATORBUG-20083
Change-Id: Ia9f9fbe137c9ac1ad3e9d148cc410ca093275916
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-25 07:14:57 +00:00
Alessandro Portale
659ba2f892 WebAssembly: Set a restriction checker for WebAssembly Qt Versions
Task-number: QTCREATORBUG-22828
Change-Id: Ifaf1624b1fb53b4a9a58883b6b968fff2ae8fab6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-24 15:31:10 +00:00
Mahmoud Badri
3c78d4d74d Enable object selection in the 3D edit view
Clicking an object in the 3D object selection view, selects it in the
creator side. Multiselection (i.e. Ctrl+click) is not implemented yet.
Also selected object is not highlighted in the view yet.

Task-number: QDS-1124
Change-Id: I0b10162539ecedc40ed117896e385975c52b04a9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-10-24 09:07:38 +00:00
Christian Kandeler
0ddd473cc0 Target setup page: Handle slow kit manager
It has been observed by users (though not reproduced here) that the
target setup page would apparently appear before the kit manager was
finished setting up the initial kits, leading to an empty kit list on
the target setup page even after the kits were finally loaded.
We now take this possibility into account.

Fixes: QTCREATORBUG-22353
Change-Id: I83cdc3da45785c3badfac484a54f34859191cc37
Reviewed-by: hjk <hjk@qt.io>
2019-10-23 16:01:46 +00:00
Christian Kandeler
40f02011b0 Fix some memory leaks
Found by Address Sanitizer.

Change-Id: I989da71e24d737e36a88b83a1f382ce2d67e3307
Reviewed-by: hjk <hjk@qt.io>
2019-10-23 11:49:29 +00:00
Christian Kandeler
fdca8f6265 Qnx: Fix progress bar in Qt library deployment dialog
Amends d7178b88c4.

Task-number: QTCREATORBUG-22885
Change-Id: Ic60e37382073c9d867afa93b28c7cf3df423fb25
Reviewed-by: hjk <hjk@qt.io>
2019-10-23 11:19:06 +00:00
David Schulz
608bbccc63 Revert "Enable visibility settings for binaries" and fixup
Since we are currently not able to fix the build with all build system
and platform combinations
this partially reverts commit b128d498b2
and 6463a686f6

Change-Id: Icfb9ab6096ad1204e595522be12146b91d570f49
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-23 11:01:52 +00:00
Richard Weickelt
313d16bba4 Update Qbs module
[ChangeLog] Updated Qbs to version 1.15.0.

Change-Id: I542fe7a7eb5e60fe6138213e04b69356c02d7a0c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-23 09:14:34 +00:00
Christian Kandeler
a4863bd238 "Add Library" wizard: Fix display glitch
Fixes: QTCREATORBUG-23049
Change-Id: Ic7e694707e6e0565866b86838f1302719a933854
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-10-23 08:29:21 +00:00
Miikka Heikkinen
30b37a989a Ignore asset file suffix case when importing 3D assets
Change-Id: Ic742f5c6bec82718d99d472a26271cf500594e63
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-23 07:35:36 +00:00
Miikka Heikkinen
94ce6853c1 Fix widget order in import dialog so spinboxes can receive mouse focus
The label needs to be created before the spinbox or the label will
block the spinbox mouse events, as the tail end of the labels overlaps
the non-checkbox control column to avoid unnecessary cutoff of the
labels that do not have any non-checkbox controls.

Change-Id: If7a7fd671b0dbb3f4c1ab5570217455e4978765e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2019-10-23 07:35:12 +00:00
Eike Ziller
1a6e441f1b Locator: Ask before creating files
With the option to not ask again.

It's too easy to create unwanted files when mistyping names in Locator.

Fixes: QTCREATORBUG-23078
Change-Id: I082d3e112db404813c7d8f46edb7a16836a98a92
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-23 06:11:24 +00:00
Christian Stenger
f68588a585 RemoteLinux: Correct clean shutdown when debugging
If the inferior stops by itself and the debugger
tries to shutdown it had ended up waiting forever for
the additional workers (e.g. ports gatherer, channel
provider,...) to stop.
The debugger appeared as finished but the runworker was
still in a running state until the user would hit the stop
button of the application output pane.
Make the gdbserver essential to initiate a clean finish.

Change-Id: I16b2ebe5feadc88bb76ce34b49ac5d3456d0867c
Reviewed-by: hjk <hjk@qt.io>
2019-10-23 06:07:50 +00:00
Christian Stenger
1b655f76ad AutoTest: Fix gathering Boost test cases
When multiple test executables are defined inside a
single project file all or selected tests did just use
the first defined target which in turn led to execute
only the test cases of one of the executables or none
at all.
Take all targets into account and make Run All and
Run Selected work correctly for this scenario.

Fixes: QTCREATORBUG-23091
Change-Id: Idf0dd99f9a8782072cbc5792c937232673fee445
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-23 05:37:26 +00:00
Christian Stenger
6df9e8f8be McuSupport: Fix missing include
Amends 6bdc6c1584.

Change-Id: I13a927c872aac3b7e76d8d2604dbe7a0a8dfadcf
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-10-23 04:48:37 +00:00
hjk
8d03546d6b Mcu: Compile fix
Change-Id: I45134ffc02adfe770127bd6648ed378fdd616264
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-22 14:52:51 +00:00
Alessandro Portale
6bdc6c1584 McuSupport: Split up McuSupportOptionsPage
Move the non-OptionsPage code into a new file for comprehensibility.

Change-Id: I306ae669ec9fdd941f777426420859ee2eb89e95
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-22 14:35:34 +00:00
Orgad Shaneh
82859399e6 QtSupport: Simplify detection of qmake executable in PATH on Windows
Instead of enumerating the directory, search directly for the executable
first, like it is done on UNIX.

Change-Id: I6465d85efa20d97622afc227eaadcbc14b3e22f5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-22 13:27:46 +00:00
Orgad Shaneh
d73632c6f3 Main: Remove unused include
Change-Id: Ifeef80bfc6465c5544118a74e774a5442c4f8374
Reviewed-by: hjk <hjk@qt.io>
2019-10-22 13:27:27 +00:00
hjk
67c74fbe29 ProjectExplorer: Do not return early on parsingFinished assert
This is a hack, not a proper solution. In theory, this here should
serve as a lock.

We currently get start - start - finish - finish sequences when
switching qmake targets quickly, keeping the run button disabled.

The whole setup here is unfortunate. Parsing inherently depend on
more than the project alone, it's roughly per-Target. So keeping
track of it in the Project complicates it.

Change-Id: I57d361ce21088d8e1ec53ce75f83ff3bd04851e1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-22 13:20:38 +00:00
Cristian Adam
6463a686f6 Build Fix: Workaround symbols inclusion from PCH headers
Broken in b128d498b2

Tested with MinGW 8.1
Tested with VisualStudio 2017

Change-Id: I8f43efe43016ea95866ee018ac9a47373a37373b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-10-22 12:18:09 +00:00
Nikolai Kosjar
90982bf2e2 Clang: Remove duplicated targets arguments
We always set the target explicitly (in a certain way), so exclude the
target arguments coming from the build system and the (possibly manually
specified) platform codegen flags of the toolchain.

Change-Id: I74bbec67f5960f05b50cf9c5aa11875c71a5161f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-22 11:46:56 +00:00
Nikolai Kosjar
8f6eb41cad Clang: Ensure that platform codegen flags get also filtered
Leave the function addExtraCodeModelFlags() around as it's used by
ClangPchManager::ProjectUpdater::toolChainArguments().

This allows us to filter out excess target arguments in a follow-up
change.

Change-Id: I742d713dd1ca6c391ba77c52555dcf4e94cc2ff9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-22 11:46:42 +00:00
David Schulz
6e3de85b33 Debugger: always hex encode the value of assignments in cdbext
Fixes assigning negative values to locals

Change-Id: Ief6e7f47e8e6f0a5d38458396164dfcd24e408a5
Fixes: QTCREATORBUG-17269
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-22 11:46:04 +00:00
Ulf Hermann
1a2bac60ed PerfProfilerFlameGraphModel: Make Payload::m_numSamples mutable
This is necessary to make the class movable.

Change-Id: I85decaa9f5c520aa3272a018ceca3aba642e1565
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-10-22 11:42:19 +00:00
Orgad Shaneh
734b6a5fdd QtSupport: Use QLoggingCategory for Qt version manager
Change-Id: I27b98ff853d7b5d437cab0df61243146220dadc8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-22 09:54:20 +00:00
Cristian Adam
8ee22dd597 CMakeProjectManager: Fix clang code model when CMake PCHs are used
CMake gives the path to the cmake_pch.h[xx] file as relative path
to build directory. Making it absolute fixes the code model.

Fixes: QTCREATORBUG-22888
Change-Id: I2fdc080be779f22b737788be2074254290994aaa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-22 08:12:26 +00:00
Eike Ziller
78e5a8a80a Fix crash in QtVersionManager
Introduced in 9c2568b8e8
Range-based for loops that modify the original container must
work on a copy.

Change-Id: Ib917014ab259c20b282cdc85e7ca6583f7844de5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-10-22 08:03:09 +00:00
Eike Ziller
b3b813c13c QmlDesigner: Fix cmake build
Amends ac84f8a457.

Change-Id: I0bac2e5ed5328396bbe75c2b7013d81afdcc1bd3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-21 13:18:35 +00:00
Thomas Hartmann
49379bfda7 QmlDesigner: Add and dispatch ValuesModifiedCommand
We already have valuesChanged() which notifies that a
property of the C++ QObject has changed.

This patch adds valuesModified() which notifies that values
in the data model should be changed.

While valuesChanged() only changes the so called instance value,
valuesModified() does change the internal data model and as
a result the QML code.
This is done in NodeInstanceView::valuesModified().

This enabled the qml2puppet to acutally change values,
like a property editor would.

Change-Id: I2493b9e626c4b194e332a7a096de3dbf2195514a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-21 12:47:28 +00:00
Ulf Hermann
b4bc204a7d CtfVisualizer: Avoid compile warning
Column::COUNT should not show up as actual column, but the compiler
doesn't know.

Change-Id: I68eea5c73a95bd45378f88c505f0cefed62ce8ab
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-10-21 12:26:56 +00:00
Christian Kandeler
33e24ac83e QmlDesigner: Fix warnings about unused variables
Change-Id: I659cc1246632b91ace8d025e5d02cf5c20f8d1b9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-21 12:21:07 +00:00
Christian Kandeler
79aedfbb7a McuSupport: Fix warning about unused variable
Change-Id: If0905e2937b02806cf000d9f9d270d87f0a0a370
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-21 12:20:43 +00:00
Thomas Hartmann
5e225f85eb QmlDesigner: Fix Coverity scan defects
Change-Id: I07a61fe4498ae0b28baaa969f0decfa5689b4443
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-21 12:13:13 +00:00
Thomas Hartmann
ac84f8a457 QmlDesigner: Implement Quick3DNodeInstance wrapper
We use Quick3DNodeInstance as a proxy class to wrap QQuick3DNode.
The access to private API like QQuick3DNodePrivate::setIsHiddenInEditor()
is restriced by such proxy classes.

Change-Id: If5191c3b730359000cf983c3af206dcffa07be74
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Pasi Keränen <pasi.keranen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-21 11:30:19 +00:00
Tobias Hunger
b128d498b2 CMake Buildsystem: Enable visibility settings for binaries
This should not matter, but makes the add_qtc_executable targets
match up with the PCH, so that they should build a bit faster.

Change-Id: Ibecaaf7fd98d5b927d52e4956b1bea4a5775afba
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-10-21 11:20:14 +00:00
Thomas Hartmann
fab360d83d QmlDesigner: Start and end transaction for spin box dragging
Using the spin box focus is not safe enough, but using
transactions on the dragging works nicely.

Change-Id: Iffc15b4ca44cb473b257f58e548ff86ebd56bbf2
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-21 09:39:28 +00:00
Christian Kandeler
6fd29da2cb Target setup page: Un-queue connection to kit manager
If we have a project with two enabled targets and we remove both of the
associated kits, one of the targets temporarily becomes the active one.
If the activeTargetChanged() signal gets queued, then the receiver will
be called with an invalid target pointer, as the target has been removed
in the meantime.
It is unclear why the signal was queued in the first place. Presumably
the original reasoning is no longer applicable after various
refactorings.
This amends (and effectively reverts) commit c13b20f160.

Task-number: QTCREATORBUG-23075
Change-Id: I3c63c763319734a4d52b3bb221919b20fd123dbe
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-10-21 09:19:01 +00:00
Alessandro Portale
1646c266d6 qml2puppet: Fix CMake build
Change-Id: If14e60e5a12526f68561bf9b54c5a181fb7b4534
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-10-21 09:12:29 +00:00
Alessandro Portale
f6d2315824 WebAssembly: Add registered MinGW path to toolchain environment
The build system of Qt for WebAssembly on Windows requires MinGW in the
path. If a MinGW toolchain is registeded (e.g. via Sdk installer),
append it to the path.

Change-Id: I5c33cb5c4df636be99f815e307806efc07e18a11
Reviewed-by: hjk <hjk@qt.io>
2019-10-21 08:32:20 +00:00
Pasi Keränen
c2c8b9a5d6 Add edit camera controls for 3D edit view
Add edit camera controls and grid helper to 3D edit view.

Task-number: QDS-1127
Change-Id: Ice5ea0fcca18d59dc8a2907710e16c6688b90628
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-10-21 08:27:16 +00:00