Commit Graph

50019 Commits

Author SHA1 Message Date
Nikolai Kosjar
4750969c2b ClangTools: Move run settings to projects mode
Make the global run settings available per project in project mode and
thus remove the diagnostic config selection from the
selectable-files-dialog:

 * Extract the classes RunSettings and RunSettingsWidget instead of
   duplicating stuff.
 * Ensure to pick up the old settings
 * Add some convenience buttons/links in projects mode allowing to
   restore the global settings, to open the global settings and to
   navigate (back) to the analyzer mode.

Change-Id: I1b91b6f8e58a87a025774e4643c46e176b2a8885
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-27 11:46:35 +00:00
Cristian Adam
642be63991 QNX: Use the QNX_CONFIGURATION_EXCLUSIVE envvar in QnxToolchain
QNX_CONFIGURATION_EXCLUSIVE is responsible for license checking
failure when qcc was probed for capabilities.

Change-Id: Ib7efa9eba3b2f3cb131899aa6cb75e632446342c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2019-09-27 09:43:12 +00:00
Eike Ziller
bdea56794f Fix build (Q_DECLARE_TR_FUNCTIONS)
Change-Id: Ifb2fe780ceaf3accef7ef0e46cf139d38115940e
Reviewed-by: hjk <hjk@qt.io>
2019-09-27 09:18:40 +00:00
Eike Ziller
2d95c90592 macOS: Fix window state after going out of fullscreen
If you went out of fullscreen with the shortcut or menu item, it would
not restore a previous maximized state, but instead resized the window
to the smaller non-maximized state. So,

1. open Qt Creator and resize to some non-maximized size
2. double-click window title to maximize
3. Window > Enter Full Screen
4. Window > Exit Full Screen

now returns correctly to state 2, not 1.

Change-Id: I076321070d011d73bfe888c0a4a5ade24c1057d6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-27 08:21:13 +00:00
Eike Ziller
3a401f3314 macOS: Fix compiler warning
The new value is available since SDK 10.12

Change-Id: I2d171680dbf3ae7b7951bfa36990ab52a3b19e9b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-27 08:20:58 +00:00
Mahmoud Badri
05d53c1454 Correct playhead position after releasing out of range
When dragging the playhead and releasing it out of the range of the
timeline, the playhead took wrong position.

This happens if the timeline does not start at frame 0. The value of
timeline.startKeyframe() is already taken into account by
mapFromFrameToScene() in setPosition(). Therefore the offset was
added twice.

Task-number: QDS-1074
Change-Id: I72ec13176af473ac9851580e2367117f98ddfc65
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-09-27 08:14:06 +00:00
Mahmoud Badri
da39f3d7fc Correct edit keyframe dialog title and fix its size
- Make sure the edit keyframe dialog's title appears correctly.
- Disabled resizing of the dialog.

Change-Id: I2374e2f71e99b49b00c9600787a798e457b8ec01
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-09-27 08:13:14 +00:00
Mahmoud Badri
0ffe31bec3 Playhead range check and status bar improvements
- distinguish between playhead and keyframe value on the status bar.
- update the status bar frame value when a keyframe is being moved.
- when changing or deleting timelines, update the status bar.
- when changing timelines, make sure the playhead is within the new
timeline's range.
- keep playhead in range after changing timeline's start/end.

Task-number: QDS-1071
Change-Id: Id9758e3097d34df9334d6284a6a56ba38b509a31
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-09-27 06:40:20 +00:00
Cristian Adam
fa0979a626 QNX: Add C compiler in the compiler selection dialog
QNX compiler can also do C, and it's needed for properly configuring
a CMake project.

Change-Id: I68edf35d7e288400f48b59c258065e6f82d17fc4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-09-26 15:09:19 +00:00
Cristian Adam
9caca851f4 QNX: Add C compiler in the compiler selection dialog
QNX compiler can also do C, and it's needed for properly configuring
a CMake project.

Change-Id: I68edf35d7e288400f48b59c258065e6f82d17fc4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-09-26 15:09:14 +00:00
Alessandro Portale
718af236de CMakeProjectManager: Export CMake*Aspect and CMakeConfigItem
Allow other plugins to set CMake specific Kit options.

Change-Id: I038e9fabc3d2cb8cc463adafebecd51b21ef3d05
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-09-26 15:06:41 +00:00
Mahmoud Badri
c6b0c549cc Allow setting a keyframe's time in the Edit keyframe dialog
- rename keyframe context menu item "Edit Value for keyframe..." to
"Edit Keyframe..."
- add a field to set the frame, this allows accurately setting a
keyframe's frame.
- allow showing the dialog by double clicking a keyframe.
- several relavant tweaks.

Task-number: QDS-1072
Change-Id: I3c6a490c335911b2f6fefd3e788468686e827969
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-09-26 13:47:46 +00:00
Eike Ziller
505e9e10a1 Merge remote-tracking branch 'origin/4.11'
Change-Id: Ie9859185470ae46e49a25e732336c4a95eaad4ed
2019-09-26 15:23:51 +02:00
Eike Ziller
8263f73a4a Merge remote-tracking branch 'origin/4.10' into 4.11
Change-Id: Iad66b08f8d6d7f14319674ae6bb26cdba43b3bfa
2019-09-26 14:59:33 +02:00
Eike Ziller
d635c3d630 Help: Support multiple pages in external window
Task-number: QTCREATORBUG-20558
Change-Id: I811a749edad7a900c5990d80089409e4076bb9f1
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-26 12:56:56 +00:00
Christian Kandeler
2a98005779 Update qbs submodule
To HEAD of 1.14 branch.

Change-Id: I2549c89428490c2588f06003496296c54c6ededf
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2019-09-26 12:52:39 +00:00
hjk
4323da700a Debugger: Try harder to restore dock widget sizes
This is bit of a hack: The dock widget sizes were actually restored
but when previously non-existing docks were affected, a re-layout
was triggered, resulting in different sizes. This can be avoided
by instantiating all dock first.

Fixes: QTCREATORBUG-22415
Change-Id: I4c0b27f5bab5864e93e303db758d8b909a51a425
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-26 12:06:19 +00:00
Eike Ziller
2152d4750c Help/litehtml: Fix selection drawing for CMake documentation
Don't rely on litehtml calling draw_background for the root element.
Manually draw selections first, then let litehtml draw as before.

Change-Id: Ic9efd11b564dec1742aa6b6ffcb58133504681ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-26 09:31:20 +00:00
Eike Ziller
b4928395d7 Help/litehtml: Fix submodule build on Windows with CMake
In debug mode. Mixing debug and release is not supported in all
configurations, so just enable code optimization flags in debug.

Change-Id: Iafa8c49825e02c35a9998bf84832710964ae7601
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-26 09:30:52 +00:00
Eike Ziller
c3a41d5f51 Fix CMake build
Python plugin now depends on LanguageClient

Change-Id: I0b7f679a4ad459e36ccdf1ab9cd5823fadfa8cd3
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-09-26 07:51:21 +00:00
David Schulz
e232dfe2e6 Python: Check for Python language server after document was opened
Show an info bar entry with a one click solution to setup a language
server if the python which is most likely to be used for this file
has an installed language server.

Change-Id: Ia52bb043b543699527740951f68cc6be546833df
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-26 07:35:11 +00:00
Mahmoud Badri
b0f796e4e3 Prevent timeline bar item from going off limits
When dragging a timeline bar item or one of its edges, confine edges
so that they do not go beyond the timeline limits.

Task-number: QDS-1074
Change-Id: I029cfbe02cf07d1f9e5e5119283d2b94fca2b2f6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-09-26 06:58:53 +00:00
Cristian Adam
501e630df1 CMake Build: Build fix for MSVC
designerintegrationv2 needs to depend on Qt5::Widgets so that it will
get the Widgets PCH, which will not cause linker errors at Designer.dll

Change-Id: Id8a4847c5bf3fc235ca980282fb6497acc84b66f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-09-26 06:14:29 +00:00
David Schulz
ea5eb8890a LanguageClient: make client selector exclusive
Change-Id: Icc97a3d7a651881613ba91b60db8784274462424
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-26 06:09:52 +00:00
hjk
ae9925cdc1 Debugger: Mark docks as default-visible when resetting a perspective
Change-Id: I562a71de04335e8b4d34f90e7df3127fbb01ac5b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-25 13:20:36 +00:00
Alessandro Portale
a38adc0056 GccToolChainFactory: Handle .exe suffix in detectForImport()
Allow detection of gcc compilers with .exe suffix.

Change-Id: I15e1050e872be0bac8934ecd4aa81914644948b5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-09-25 09:55:20 +00:00
hjk
a82b40e037 Debugger: Move convenience function to only user
Change-Id: I50952521bdd45faa8a31da674e7ea5f0796d75d9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-25 08:06:03 +00:00
hjk
b63034b551 Debugger: Move showModule{Sections,Symbols} to DebuggerEngine
A bit closer to where the functions are used. No real change.

Change-Id: Icbad68bd31d85caa59980316537ee532faf2d7ef
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-25 08:05:51 +00:00
Eike Ziller
1bbc62f9e4 Merge remote-tracking branch 'origin/4.10'
Change-Id: Ic7144b8ae429707cd120719f3445b624c0b83564
2019-09-25 08:30:27 +02:00
Orgad Shaneh
e43288baf4 Revert "Qmake: Show real effective make call on Make step"
This caused passing "-f Makefile.name" twice to make.

This reverts commit aa198b7e88.

Change-Id: I8fb2a014a76d3c6d9857881aa91b2664866269cd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-25 05:20:20 +00:00
Cristian Adam
f88ad0e9d0 CMake Build: Allow building with Qt5 and Qt6
Emulate Qt5's functions/targets with Qt6 equivalents.

Change-Id: I6bfc5c8a649f0ddc5f1117bc5b2d0f41cb72c821
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-09-24 16:05:23 +00:00
Eike Ziller
4ea0d22d4c Help/litehtml: Don't call cmake from qmake build
Change-Id: I42a3384dd02e8f7b714a820673d5db094642f668
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-24 13:56:35 +00:00
Eike Ziller
284eab836c Help/litehtml: Fix text search in presence of multi-byte characters
std::string::size is returning byte-count, not character count, in
contrast to QString::size. Do not mix.

Fixes: QTCREATORBUG-22970
Change-Id: I865ca0c13a08fb500b6526ba6ee3207359e75107
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 12:58:21 +00:00
Eike Ziller
3b2209b870 Help: Get rid of special CentralWidget class for help mode viewer
Change-Id: Id733eb0449cdaed5901e4144089c8adaaf07d7a9
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 12:57:56 +00:00
Eike Ziller
4f19046d75 Help: Remove OpenPagesManager::instance()
It's owned by the HelpWidget now, and should be accessed through that.

Task-number: QTCREATORBUG-20558
Change-Id: I99118bb966922e6b4d356cf892d7604365357785
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 12:57:29 +00:00
Eike Ziller
4610759aed Help/litehtml: Use antialiasing and higher-quality image resizing
Change-Id: Ib0e48130c94e2cfdc25560339376c0ed130c56fa
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 12:11:58 +00:00
Eike Ziller
88d759d50f Help/litehtml: Keep top position also when zooming
Change-Id: I65e12d4fca33719bc1a3ae08f7871d08d8d9c449
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 11:57:37 +00:00
Eike Ziller
e20d90d9e3 Help/textbrowser: Keep text at the top visible when resizing and zooming
After resizing/zooming scroll to the position of the top element before
the resize. This allows us to remove the hack that delays jumping to the
anchor of an URL as well.

Fixes: QTCREATORBUG-4756
Change-Id: Ife29ba1cd0ad60448052b4d06a5dce7cc6bdf4ed
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 11:46:52 +00:00
Cristian Adam
1e9b1dcaec Clangbackend: Use Qt debugging instead of std::cerr
The arguments passed to libclang were only passed to std::cerr,
which and never reached Windows logging.

On Windows the clang*.exe have a qMessageHandler which forwards
the message to windows logging and std::cerr.

Change-Id: I97b0856ae2b3f44a991c9d292a15db9f3b071a0d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-09-24 11:30:44 +00:00
hjk
bcaeb73e68 ProjectExplorer: Store parts of active build config in runcontrol
... on runcontrol creation to prevent later access. Adapt some users.
There are more to come.

Change-Id: I2a3fe5eea0ada4eff7d08b79a6f49694e6962c8a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-09-24 11:20:51 +00:00
Eike Ziller
bef986f3fd Help: Move OpenPagesManager::createPage to HelpWidget
Removes some unneeded indirection.

Task-number: QTCREATORBUG-20558
Change-Id: I65d8d31e10300da3015f388ac490b8be6e090f29
Reviewed-by: hjk <hjk@qt.io>
2019-09-24 09:21:08 +00:00
Orgad Shaneh
4ae6c2a89b Git: Fix log for repo/project
Broke by ad6968f45f.

Change-Id: I06ff8384a088f6d9137b9711f855efa8d6bf4a74
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-24 07:00:17 +00:00
Orgad Shaneh
76c0149ceb ProjectExplorer: Fix typo in variable name
Copy-pasted in 2 other plugins.

Change-Id: I1a76ce7490505f43e2d5fe0fe4cc57d480607db9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-24 06:59:29 +00:00
Christian Stenger
2249765041 Allow compile with bundled QtScript
Qbs has QtScript nowadays bundled as submodule. Use it
for qmake builds as well if the used Qt does not have QtScript
present.

Change-Id: I4eabdbe7ea502953b0213ad39c8b72220f2d966f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-09-24 04:42:06 +00:00
Christian Kandeler
4702faba06 Wizards: Add the ability to remember user choices
Wizard authors can now provide a persistence key to values where that
makes sense.
For now, we make use of it for the build system type in all wizards and
the minimum Qt version as well as the virtual keyboard settings in the
QtQuick wizards.

Fixes: QTCREATORBUG-16657
Change-Id: I179930665bd163b1cf198467ab8b43bc72f8ec4a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-23 12:48:56 +00:00
Cristian Adam
2e63d2c7d3 Fix build of clangrefactoring backend on Windows
Broke in ccab835455

Change-Id: Ic5db7597cb6cc3c798987997d8fe50c4d801ec8e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-23 12:19:20 +00:00
Orgad Shaneh
aa198b7e88 Qmake: Show real effective make call on Make step
Include custom Makefile.

Change-Id: I4b3b4d4fb64eea97ab4630ff6909c7df67291ba5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-09-23 11:55:29 +00:00
Orgad Shaneh
57404c9551 MakeStep: Rename m_makeArguments -> m_userArguments
These are the arguments provided by the user. Full make argument may
contain also some automatic ones, such as job count and Makefile.

Change-Id: Ief03623daa9c9bbc54ca6ad2dcf1492510fe531b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-23 11:52:11 +00:00
Orgad Shaneh
471e78a99c Qmake: Update effective qmake call on project parsing finished
If the project has MAKEFILE = Makefile.$$VAR it wasn't reflected when
VAR was set in Qmake arguments.

Change-Id: Ieb1cbfee9a0def89a5c9b6259e8acc87751b0f3a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-09-23 11:52:01 +00:00
Eike Ziller
0491c1c06c Merge remote-tracking branch 'origin/4.10'
Change-Id: I4a22cdf4d7d5aab2083d5f9f7baaa38e510f83fd
2019-09-23 12:31:58 +02:00