warning: prefer using 'override' or (rarely) 'final' instead of
'virtual' [modernize-use-override]
Change-Id: I6dac7a62b627fa1353b4455e1af92f869c2571cc
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
The color was not renamed in this inline css.
Change-Id: Ib23977fcc9f3c5925ef5183dba0fc2c0216ab465
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
They aren't in the global object pool anymore.
Change-Id: I4f0ae69ebabe33f0276dbfd7137a4f8adbaad489
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This makes navigation the project a lot easier
and the layout of the side bars can be locked.
Change-Id: I3ad7b85cb8704aedf8f5ec9ea9b2930c5a0986d1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Allows adding of multiple files
* Files are copied
* Files are added to the project
* Supported file types can be extended
Change-Id: I41d1d18c4a3fc9c6c50e0629070d9a2cbf082976
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The non const overloads of first() and last() do detach
if the reference count is higher than 1.
Therefore we use constFirst() and constLast() instead.
Change-Id: I737cfc428f1c21f16185b9b51175e181c0ec7068
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Using Utils::StyledBar, and getting rid of one stylesheet.
Change-Id: Idf4db461e6beb60e15cae9b295f13ec489146f4f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Keep the style responsibility add the widget. So coloring the
background with a helper widget is enough here.
Change-Id: I24bb82786e2a8ef4af01b9719d2bad4aa1997f1f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Applying a .css style overrides the text editor background color
from the theme.
To avoid this we cannot apply any .css on the integrated text editor or
its parents:
* Only apply the center widget .css to the tab bar.
* Apply the scrollbar.css only to the scrollbars.
Change-Id: Id9b009a208ea2830c64be8174dbb548ada692560
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The form editor is now handling even initial warnings.
There is no need for an extra warning widget in the DesignModeWidget.
Change-Id: Iac85c1968e8040ee5f11435fa2876ce2d152c194
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
- rename Theming -> Theme
- made derived colors as Q_INVOKABLE methods available
- rename registerIconProvider -> setupTheme
- inside *.qml files use a singleton import instead of a context
Before this change, every request for a theme value copied the map into the
Qml context including the convert of values QVariant -> QJSString
Change-Id: I1c483fb591336b519d5adab8ad37b42bc5a06720
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Before it was done in DesignModeWidget and the design mode had to be
opened once to show the actions in the Qt Creator options.
Change-Id: I62de2dcab66149b8470261002b019894fb345c8b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
- moved switchTextFormAction to shortcut manager
- renamed createDesignModeWidget
- remove unncessary DesignerSettingsKey::TEXTEDIT_IN_DESIGNMODE
(supporting it in future would be too much effort)
- using delayed registration inside QtCreator
(which does not bring more speed, but more time for the codemodel
in case of opening a qml.ui file directly)
Change-Id: I1fd05f161e4bf4659c5a2fb09705b1f67d6f8e36
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The integrated text editor requires a couple of fixes and features
in the error handling.
The errors are now handled by the model and not the document management
anymore.
The text editor does not get disabled if there is an error. Instead
we show the error in a status bar.
The form editor is blocked if there is a QML an error and we show the
error message inside the form editor.
Change-Id: I4bfb9b33b09e444ec1de31dd531ce83b32cbcf88
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Icons are not the final ones.
* I fixed a couple of glitches and cleaned up the code.
- Action for copy and paste/delete were not properly updated
- Delete had no icon
- Using std::function for action predicates and operations
- The context menu has no icons. This way we avoid having to define 2
icons.
Change-Id: Ic23cbc78ba299c19e07e8de775eb813aae55db9b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This is the first iteration but the text editor is not connect
to the others view in all expected cases.
Change-Id: I2fa29a23f9ce1d98d3d6cc8eabddb788525e39cd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Setting objectnames to reduce possible influence to other
widgets.
Introduce a background QWidget to set the background color.
AutofillBackground was not working for unclear reason.
Change-Id: I4acd5b7ed5ff9d63b5320b133a82099c5888b839
Task-number: QTCREATORBUG-17172
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The QmlDesignerPlugin::hideDesigner() jumped again to selected node,
which came after the DocumentWarningWidget already set it.
Change-Id: I6e84342208c6405e8b25b516cd411b30bc48fcdb
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
This assert is not critical and just indicates
an unnormalised file path.
Change-Id: I3ed7dbe8daae034e5faf44f1bc5aee7ba30e44d0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
With this patch the Qt Quick Designer supports:
*Flat
*Flat Dark
*Flat Light
*Classic
I did not test the dark style.
I added a template engine for the .css files. The syntax for the .css
files
is identical to the QML syntax.
Known issues:
* The icons in the property editor do not play well with the
Flat Light style. We have to get proper Core:Icon support for the
icons
and most icons have to be simplified/flattened to fit the new style/
theme.
* Some colors in the connection editor are still dark and hardcoded. But
this looks ok together with all themes.
* The highlight colors are not taken from the theme, yet.
Change-Id: I94f2b75f92db8e131c2b15867dbabe9ae4b2f25a
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
- fixed cases where the user got the one and the other
dialog
- not only the first error is shown, the user can browse
Task-number: QTCREATORBUG-15772
Change-Id: I27786b0e4f9c987646a69d8d7d9ff33e3702587a
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
- no behavior changes
- moved a slot to a lambda
- Using QPointer instead of raw pointer to trigger
assert if dangling pointer is accessed.
Refactoring the code might accidentally trigger a
delete of the QWidget.
Change-Id: Idf711da92e13cf81dd718ae9e034bca7f6d26220
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
- the "move" code needs to be inside the warning widget,
this also fixes the problem of wrong position at startup
- the patch removes knowledge about the DesignModeWidget and
uses a signal
Change-Id: I9a861ab955d16e85d7af36f1b56ddb82578b8da4
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>