Clang expects these to lie in "../lib/clang" relative to the clang
executable.
Change-Id: I216860876591dca1fd728e4b1e79b4b07c965620
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Previously, the code depended on the device to send the whole "ps"
output back quickly after "ps" was written to the shell. If the output
was not there by the time the input was considered written by Qt
Creator, we would mis-parse the port and generate wrong conclusions on
if the process was actually running or not.
By filtering the correct line from the ps output on the device and
outputting a clear negative result when none is found we can determine
the "running" status of the process more easily. Each output line
directly corresponds to the state of the process at the time when ps
ran. We buffer the output in order to guard against lines being broken
up during transmission.
Change-Id: I0e1726b7f0d725d982a0f2d60d0c8ab7d59fc371
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
We don't need to do this for plain character literals as we allow
casting those to QString now.
Change-Id: I25569cfb8a2ff618176b7d5ab048f03ecaaee460
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This removes the need for blocking queued connections and runAsync(),
reducing the risk of deadlocks and eliminating unguarded concurrent
access to various members of AndroidRunner. No mutex locking is
necessary anymore as all communication between the two threads is
either done on initialization, before the worker thread starts, or
via queued signals.
Change-Id: Icc2fcc2c0ce73d1c226bc4740413e57490d1cbc6
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
operator== and operator!= should work if one or both of the ports are
invalid. operator> and friends are undefined if either port is valid
and should in fact trigger the assert.
Change-Id: I4e4c840fc243cf6c36bfa7beca9f6296336ba1d9
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The toplevel CMakeLists.txt file should always be visible in the project tree,
otherwise there is no way to fix problems that stop creator from reading the
project structure.
Since the cmake configuration may add that file itself, creator needs to
check before adding that file. All other files are taken straight from
cmake, which makes sure they are unique.
See the minimal project attached to QTCREATORBUG-16671 for an example
triggering this issue.
Change-Id: Iff3e307134b023e6955f47657e998a5981b03da0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Fixes a crash when re-opening a cmake project.
Change-Id: I5fc747f19787594964fe55c19e29e944c4a5092d
Reviewed-by: Benjamin Zeller <benjamin.zeller@canonical.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This Fixes an issue when trying to open bookmarks in an external
windows.
Task-number: QTCREATORBUG-16524
Change-Id: I216f1d4f308a05abcbb4e074368dde30f0e05064
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This reverts commit 3c63b621d9.
This is no longer necessary because Qbs determines the version automatically.
Change-Id: I80161ddf366091eca8bb1e1b29657371e9a7b0fb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This is unnecessary now that Qbs handles the linker automatically.
Change-Id: I8c6270f74355bfa274717a7791daf8d1f4721e00
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If ProjectMacroExpander doesn't resolve it we fall back to the generic
ProjectExplorer resolution, which is likely to pick the wrong project.
Task-number: QTCREATORBUG-16724
Change-Id: I201b722c5fe184905f744a1f344ec46941f92ae3
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Sort the file list once, otherwise there might be some
inconsistencies with files lists like "AAA.c AAA.h aaa.c aaa.h"
* Append a newline to end of .*files and *.includes as this otherwise
happens when adding files later
Change-Id: If2b5e81d0f61c1a08c60e8151305534ef991865a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Handle getting output from application's process inside base class
and just process output inside the sub classes.
Additionally this is a preparation for being able to process output
for debugging tests as well.
Change-Id: I8a2289dc7faab25afe08530b5021a0318f3ba6a6
Reviewed-by: David Schulz <david.schulz@qt.io>
... and not on every single frame.
Task-number: QTCREATORBUG-14983
Change-Id: Id0724d3362ceca222cfdaaba60987b1269c8a5ae
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We can break the loop early under some conditions where we know that
the result cannot get better anymore.
Task-number: QTCREATORBUG-14983
Change-Id: Id047e6b3b990807db98a14e6fb36824abbecf101
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It doesn't make sense to distinguish between them. When the content
changes, the labels, the number of items, and the "empty" state
change.
Change-Id: I65f77f65828626fd76bfd968abf67b608b6e267b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
That one was accidentally removed in 0b3abfcf6a.
Change-Id: I01d2654175260f9efd1d01e5997170ce0d1faf0e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Take up to 2/3 of the main window size.
Task-number: QTCREATORBUG-11843
Change-Id: I9bcb8c839190cceab0e6213cb943c5f021bcb1e7
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Unset the "smooth" property of the image to prevent centered images from
being rendered to non-integer coordinates.
Change-Id: Iab0bdb971fa11dba7d3935d66a8b9b4bbd2739e1
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
..and remove the own ones.
Change-Id: I513bb78f07d405aa9699157db292085a847adbe7
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
QMT_CHECK are replaced with QTC_ASSERT(, return) guards to not crash
operator[.*] are replaced with at(\1)
Change-Id: I7e520a808550ed271ba5005dd6f5b084225ac8fe
Reviewed-by: Jochen Becher <jochen_becher@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
When given an empty string as executable and some non-empty arguments
QProcess might emit error() but not errorOccurred(). This was fixed by
2f0ffba638bdb868a810bc0349c240b6b6e172cd in qtbase, but we cannot rely
on that being present, yet. Thus, avoid passing empty strings as
executable.
Change-Id: Ia1bb5ebceb6edeca1e54489d12b838f3cea8851e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
LLVM is normally not compiled with RTTI so we get link errors. We should
use "llvm-config --cxxflags" but before we can use it we should be sure
that we don't break something.
Change-Id: If45afcd625273230960a2c2065877f2512a53209
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Actually we maybe should use llvm-config --cxxflags but before we do
that we should evaluate possible compile breaks.
Change-Id: I534605c6f61217bfe985bef22af7d1dc9ac79637
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
To HEAD of master branch. Also do the necessary API adaptations in
QbsProjectManager.
Change-Id: I4709b7a0f35537f5b6f9fd04f4d95be16aef2c8d
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
This is a cherry-pick of 20db17e4f0 from
4.1. The problem also occurs in 4.0 and as another version of 4.0 might
be released, we should fix it there, too.
Change-Id: I3cf42abfa9d0ea5812495be6e2728264dc115ba9
Task-number: QTCREATORBUG-16708
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This adds a hover handler which will preview images
from within project resource.
Change-Id: I88bcb56a977e41ed4dc5bfe165e2c80d4396a21f
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The only place where we needed it was {prev|next}ItemById, and that is
better done with a lambda.
Change-Id: Ie28b31479d5158b6fb85e3fb0e5ce3a02f7ff39d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
