On macOS funnny things happen if two popups are open at the same time.
Change-Id: Ic83d9e93184fd3f6a5f7e1a8d497da805eeeb6c6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Depending on the build configuration of Qt and Qt Creator there can
be various kinds of messages and we cannot reliably determine their
number in advance.
Change-Id: I162cc02a72200026d3cbe7498fa705911f4cda39
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The default Qt:red for the lineedit in Utils::PathChooser is unreadable
in dark themes. This change ensures that the color comes from the
current theme.
Change-Id: I7b890bb18e4b996cf0a8f0ac3286da87dd33f5f2
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
These icons are useful in other situations (e.g. QmlDesigner)
Change-Id: I31751b8ca8fea34c532d54d423e5fef07b370a4a
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
If the document that FindExportedCppTypes is to search is not in the
snapshot, skip over it (instead of passing the shared pointer with a
null-value inside).
Change-Id: I462e3d22aa4e1cc51e710c75ae0f9399c151240b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Instead of starting Qt Creator to get a debug server we can just
simulate the hello message on a locally created connection. That is
enough to make the client manager signal "connectionOpened()".
This way we don't get excessive timeouts on this test.
Change-Id: I89fa12b1bdda41a62dec47de042224f26fee79a9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The height calculations would subtract the second row's itemHeight from
the bottom row's height, which made the second row stay in place even
if the bottom row's itemHeight was 0.
Change-Id: I93479dcef0230e2b722c147e3c8b25484620a11b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Keep the old syntax for registering toolchains for new kits
via the SDK tool working.
This should make for smoother sailing for our users, as we can
not foretell which combinations of Qt Creator and Qt installer
(with SDKtool calls) will end up on the machines of our users.
Change-Id: Ib0fb99759ab9dcd75c64c556e18c27e900bf6236
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Using a themed text color instead of a hard-coded one and making sure
that ManhattanStyle does not tweak it.
Task-number: QTCREATORBUG-16643
Change-Id: I4bac9b29ee3c293270f39438664d617ac7591c8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This change adds even more stylesheet code to make the background white,
and the editor text black.
Task-number: QTCREATORBUG-16556
Change-Id: I48cf5c825a7600406c289c25ba7c421cd3634a97
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
There is no reason to hardcode the mapping from theming color roles
to QPalette roles, since such a mapping can be easily defined in the
theme itself.
I added optional color roles for each QPalette role.
Themes that do not change the palette do not have to take care at
all and themes that change the palette define only the QPalette roles
they require.
Change-Id: Id195052c96117b7a1a8d7d7d6acacd44e66e22f3
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
If the user wants to undo, first save the file silently. Then the user is
still able to cancel the undo operation.
Task-number: QTCREATORBUG-16647
Change-Id: I61ac42ff41f3f7758d662692bc92850766beab8e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Remove QLatin1{String|Char} where possible
* Use initializer lists for QStringList
Change-Id: I8479f87f4fc909b5d74d854956885564209538e4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
At least LLDB reports sometimes out of scope variables as such.
Report them as "out of scope" instead of letting the common
struct dumper fail and report its generic "not available".
Change-Id: Ic9d0d196894ef811fab8e6a586bf55d80cd02e45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Using a lambda in the connect was wrong here, as the m_currentEngine
member may change before the body gets executed. Indirect to a member
slot again, which then can use an up-to-date m_currentEngine.
Change-Id: Ice906a31d2ba0655daffda67ae378acc98aa3698
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The toolbar border/separator lines for flat themes need to be a bit
lighter.
This change introduces StyleHelper::toolBarBorderColor and puts it into
use for drawing all toolbar borders.
Change-Id: Icef20759ce282e768f6ba867474e506b9230b864
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
It's not really needed. The Null-ness is equivalent to a failed
fromMap() which we execute on all usage paths anyways.
Change-Id: I72bb7fb55b7f26680fa68da8eef751ca96380ecd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
it was a regression when everything switched to fusion style
Change-Id: I87a660afd268ed76608edad8edc93f29db243748
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
It could only handle combinations of "Regular", "Bold", "Oblique",
but fonts can have their own sets of fancy style names.
Actually set the selected style name on the font and save that
in the settings.
Task-number: QTCREATORBUG-16620
Change-Id: Ibf8cd6f2ac0d3ff1c0fd100e9db627937c0eb1ec
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Different families can support completely different styles and sizes,
and sizes also depend on the selected style, so these need to be adapted
when changing familiy or style.
Task-number: QTCREATORBUG-16620
Change-Id: I53a2bfb5e867bf7ea66825a9470ff6c9e73b2040
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The Fusion style does not play well with the custom background in
our delegate. I simplified the background in our delegate
and removed unrequired .css code.
Change-Id: Ia3872d7df8b8c031b29199794e509933322c1d98
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
replace invalid characters with '_'. To allow pasting of text with
invalid chars inside
Change-Id: Ibc0d3dde2252235a931b51ad73ae2eef527be547
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Unit test applications do not typically require any input, and
having their output appear in a tab (which also contains history
etc.) is convenient.
Qt Creator disables "Run in terminal" by default for projects
that have `QT += testlib`.
This change does the same for qml test projects, that have
either `CONFIG += testcase` or `QT += qmltest`.
Task-number: QTCREATORBUG-9475
Change-Id: I6da1b239ff1757be4d280f852e7f3537c44867ee
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
