All elements of a zoomed diagram must be dran anti-aliased. This change
removes the extra handling of drawing vertical or horizontal lines
without anti-alias. The complete graphics view is drawn anti-aliased
instead.
Change-Id: I6fc041b6d70da5a7a7bcb8e97d07990517380b90
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This enables the text to contain links which the user can click on to
follow.
Change-Id: I892d1d915a48974e72adb0e712d46220560f5537
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Makes it possible to not query the user on every checkout if he wants to
create a local branch.
Change-Id: I22d8ef03fb98648cafb3f11a008bb24c291cb807
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Regression was introduced with 3f11ef9216.
The original check asserting 'that != 0' is still needed without
dynamic_cast, as d-pointer of 'other' can be statically 0 for
default-constructed Runnable objects.
Change-Id: Ibee898ffc61fb2f4a6a6276390fdf6d517fde546
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The issue was re-producible with e.g.:
void g()
{
// Type 'foo.' as fast as possible in the next line
}
This led to "foo->" with completion results as if there was no "foo." at
all in that line.
We relied on a correct position for
translationUnit.sourceLocationAtWithoutReparsing(), but the just typed
characters were not yet reparsed. And we do not want to reparse at that
point since takes too long. We already determine the utf8 position for
the dot character, so simply use that instead.
This completes commit 17c1325cc4.
Change-Id: I669888b5c17ee63b2aec7b16c9921f9d79e281f9
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Do not crash when updating the Git path settings.
Task-number: QTCREATORBUG-16305
Change-Id: Ia6b7f529aa243b5e0b2778aeaddbbd86da9e265a
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
This is run in a background thread, so there is no need to keep the UI
alive.
Change-Id: I81267b918ef2350a180b0a8ee55244feca2406b4
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
More natural and easier to extend to use parameter packs later.
Adjust users.
Change-Id: Ic167196cc969d18bb1615084397e884f769d1e85
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If there are no completion items, do not add snippets since these will
otherwise pop-up at undesired positions, e.g. when:
1) Typing float/doubles: 0.
2) Typing file suffix in include directives: #include "stdio.
Task-number: QTCREATORBUG-16188
Change-Id: Ie1c29826dc62dc447b2ff57b0c5537eb9d9511ef
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
To reproduce, create a conflict and configure a custom mergetool that does
nothing:
git config mergetool.my.cmd true
git config merge.tool my
Then execute merge tool from Qt Creator. The merge tool process hangs
while asking how to handle the unchanged file, and can only be killed
externally.
Change-Id: I4d2a91061bd7549e308f6a25f106e6a7afc5cadb
Reviewed-by: André Hartmann <aha_1980@gmx.de>
std::size_t is a undefined unsigned integer type and std::ptrdiff_t is a
undefined signed integer type. So sometimes the compiler doesn't know
which to choose because both could represent a integer.
Change-Id: I669cd44c6f16854dfe3f3cc44edbfc422e1cbd6a
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Currently debugging tests is enabled only for C++ based projects
and starting QmlDebugger although not needed feels wrong and results
additionally in a fail message which might be confusing for users.
Change-Id: I1f62b67ea6d3d8bb56d9723ea1132257d0b96b9b
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
When setting a tracking branch, creating or deleting a branch.
Change-Id: I58dd06912fbf23900674a8714224ee414f1da4b7
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Connect was missing
* The check box contains the opposite truth value of the setting.
Change-Id: If6ef86e0e1107ce537ee05ddf983131f65ee9e20
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
It was an oversight that we haven't done this before.
Change-Id: Ic338503f6c1ca5e6c52c9af3bdbdb92b7776cac1
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
rewritertransaction.cpp:84:56: error: invalid use of incomplete type
'class QmlDesigner::RewriterView'
Change-Id: Ibbd757ef99a75633337722caa54630baba929cc6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
readmessageblock.cpp:95:36: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
Change-Id: I24c5125f2116e5538b7d0e2389e66bf5d318640a
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Now the ref-qualifier (& or &&) of the function declaration
is propagated to GUI. For example, 'Refactor' -> 'Add Definition'
preserves the ref-qualifier.
Change-Id: I8ac4e1cad4e44985e94230aabbd9858a7e929fee
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The current code always ends up setting the token to T_GREATER_GREATER.
Change-Id: If75ff1f5bccffd5918ec2bf491724cd0981220ae
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The semantic checks are slow and sometimes we knoe that they
are not required.
Change-Id: I43cae131e4c5f47d2a61d34975913dd8cb6370fc
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Those checks are slow and not required for moving and resizing.
Change-Id: If9ad047cf2401d39f729134beb813e095ef96abd
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
QGraphicsScene:items() is deprecated and returns incorrect results
if the scene contains items that ignore transformations.
We have to use the overload that takes a QTransform instead
and define itemsAt for convenience.
Task-number: QTBUG-49627
Change-Id: I388c62dd23a61c569ec6b99d756f4fbe1024e5db
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
If you write "all" it should mean "all", and "load" order makes more
sense than "alphabetic".
Change-Id: If90b665d714efaf0919ad418fbbe02c50a0fced2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
We have a more intelligent placing of double quotes, that should
eliminate some of the incorrect/unwanted placed closing quotes.
Additionally we introduced an animation and highlight of automatically
inserted text. So it should be definitely clear that the closing quote
is going to be removed.
If there is still someone who gets annoyed by this reintroduced behavior
there is now a setting that lets you control the deletion of
automatically inserted text.
So it is safe to reintroduce the deletion of closing quotes on
backspace.
This reverts commit 4a0b2039c0.
Change-Id: I92500ac218dc4c2e07a3b0ad01b06e6baa2e2c6c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We default to "foo()" for e.g. a member variable "m_foo", but other
coding styles require "getFoo()".
Task-number: QTCREATORBUG-16452
Change-Id: I9ccfdf88e4c469bc1c06fde855ad754faf2bd238
Reviewed-by: André Hartmann <aha_1980@gmx.de>
...and make it a bit more readable since we are going to make some
changes there.
Change-Id: Ic1d0c47a36ef4547a4842508c2404e9fc12f5220
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Remove automatically inserted characters only when the cursor wasn't
explicitly moved or the editor hasn't lost the focus after the
completion.
Change-Id: I9e995dc4ce79194b073b1bce3fa4dbc025a09a94
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
