Commit Graph

44349 Commits

Author SHA1 Message Date
Ulf Hermann
85b8ae4b8c Utils: Extend FileInProjectFinder to also find directories
Change-Id: I7b9f0252e25b2cde9cdadb0a939e2a367c4b47be
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-01-08 10:20:55 +00:00
Ulf Hermann
8964de84d3 Remove qmlsceneCommand() and qmlViewerCommand() from BaseQtVersion
qmlviewer is QtQuick1 and not supported anymore.

The qmlscene command is in general not a property of the Qt version but
of the target device, as we generally assume Qt binaries to be
preinstalled on the target and qmlscene is executed on the target.

DesktopQtVersion retains a method to retrieve the qmlscene path as there
target == host and having the method available enables us to warn if the
binary is missing.

Also, QmlProjectManager needs to pick the qmlscene command from the Qt
version if it's a desktop Qt.

Change-Id: I2ee0f993e60b96d672080db2db0a6abe5ca933e3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-01-08 09:13:56 +00:00
Ulf Hermann
8880b32426 QmlProfiler: Show more useful arguments in attach dialog
Without "CanvasFrameRate" the QML profiler won't be very useful.

Change-Id: I8bff2b600db31bd1092c1a5f79e27e4177c97086
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-08 09:11:01 +00:00
Alessandro Portale
17e6c0ab97 QmlDesigner: Don't blur the form editor items and background pattern
When zooming in, or generally in dpi scaled mode, it is not desirable to
have blurred items or blurred edges on the background pattern. Design
tools don't do that.

If an item is painted smaller than its natural size or if it is rotated,
it should be painted with interpolation.

Change-Id: Ie221db47a8f9a807c99ba8e0c96a2cc8d5115d6f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-01-08 08:33:19 +00:00
Orgad Shaneh
53b2df46e0 Gerrit: Set current repository every time the dialog is shown
Task-number: QTCREATORBUG-19562
Change-Id: I17918e08f7d3092ffe54ab359bf2b41c51813367
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-08 08:13:53 +00:00
Orgad Shaneh
1decef8fc9 Gerrit: Deduplicate detection of current repository
Change-Id: Ib3a63f71dd45c45b20eab51a2a0bf9c21ba8754a
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-08 08:13:48 +00:00
Eike Ziller
ca8b727e42 Attach progress details to the toggle progress details button
The popup is corresponding to the button (and the summary progress bar),
and that automatically also moves it away from the right border a bit.

Task-number: QTCREATORBUG-19308
Change-Id: Ie6f72f19552285586395776b175ca142f56c7d6e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-01-08 08:11:35 +00:00
Robert Loehning
e4b07d6f74 Android: Fix typo
Change-Id: I5f732957d893ab94cd7486658019407137069891
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-05 17:53:29 +00:00
hjk
2d108079bd QmakeProjectManager: Remove unused QMakeStep::forced() accessor
The m_forced state is completely handled in the step's implementation,
nobody accesses it.

Change-Id: I05e15a53b08462e9c82d3f498e26aea0303a4ecf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-05 16:52:53 +00:00
Robert Loehning
517b35c9d7 Android: Initialize members
Change-Id: Iba2ec7c99d4083edf92601a8a7f2e5074f30cd7b
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-01-05 16:48:34 +00:00
Nikolai Kosjar
a44d7b9ced GLSL: Run qlalr generator on demand with qbs
Done-with: Christian Kandeler
Change-Id: I67cbed82afa238d31cb7070e35ec980ae9b9b32f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-05 16:01:17 +00:00
hjk
1a8f5312a1 iOS: Remove unneeded declaration and include
Change-Id: Ice187c2b20f4ae6e61d56e9d0ba07608f66219e4
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-01-05 15:42:54 +00:00
hjk
cd78648bd6 AndroidQmake: Remove some unnneded qmake specific qualification
Change-Id: I00ef10a5b2479355fb7f44e1a3159841bc68dfa7
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-01-05 15:40:36 +00:00
Nikolai Kosjar
5972e27169 Clang: Ensure to clear all affected translation units on project part change
The ones that were already dirty were not taken into the account and
used the old project configuration.

Change-Id: I949d1ca8c23bbdb18eec78e5a708199beff6f735
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-05 15:27:44 +00:00
Nikolai Kosjar
8ced936e79 Clang: Enable QTC_ASSERT() output
We had all debug output disabled by default, even the one generated from
QTC_ASSERT and friends.

Change-Id: Ie41eac49c2c3da25f584e43d7c9a292715b3f355
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-05 15:27:07 +00:00
Nikolai Kosjar
31f61592e4 Clang: Inline some functions
Change-Id: I923919f206f038cf8cedf709b4047cbc22a990ee
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-05 15:26:41 +00:00
Christian Kandeler
e9cbb83b46 Update qbs submodule
To HEAD of 1.10 branch.

Change-Id: I226d9d3f99ba119bfd16be690adb246c48c8e160
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
2018-01-05 11:46:16 +00:00
hjk
c3d87e81c5 ProjectExplorer: Return BuildTargetInfo from availableBuildTarget()
... including build target name and display names instead of
returning QString build target names and producing display names
via displayNameForBuildTarget()

This is a mechanical intermediate step on the road to use
Target::applicationTargets().list uniformly as source of build
targets.

Change-Id: I7b0b1fb398d5061b0cec0b86890f9eaf0bb53a19
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-05 09:34:29 +00:00
Christian Kandeler
af62a9590c QbsProjectManager: Fix reparsing after switching build configurations
After switching to a different build configuration, property changes in
the build config widget would no longer cause project reparsing. Likely
caused by e52ebbf217.

Change-Id: Ifebec74475def49885232ad71d4de01f51568fcb
Reviewed-by: hjk <hjk@qt.io>
2018-01-05 09:25:36 +00:00
Orgad Shaneh
94086e53bd Theme: Minor cleanup
Change-Id: I3dd776c1e67a3d8af67304917b25db848e64deb0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-01-05 09:03:18 +00:00
Orgad Shaneh
add1bdf43f Theme: Fix parsing of colors without alpha
Use QColor(const QString &) ctor instead of manual parsing.

Uncovered by a19005fc38 which made the
locator highlighting black.

Change-Id: Ic11483613510e3cf97eede396e9b7d53bbc3ff61
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-01-05 09:03:10 +00:00
Christian Stenger
b74fdc2e74 AutoTest: Fix updating when directory filter is toggled
Change-Id: I22dc2d1383280ea985127b69de114c93c4de3e68
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-01-05 07:23:35 +00:00
Ulf Hermann
5ea2493830 Add a qmlsceneCommand member to iDevice
qmlscene is a target binary. Thus, when we need it, we should look for
it on the device, not in the Qt version.

Change-Id: I8bda1608a2e645a216e657a83450a7c6d5b74301
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-01-04 14:00:17 +00:00
Ulf Hermann
5bd0ee0b4c QmlProfiler: Process remaining events if connection drops
When the connection drops while receiving a trace we can easily process
the buffered events. The trace client test case has some traces with
trailing open ranges that can be recovered this way.

Change-Id: I8b2ecc135b0cabff18923fbc8f3f14b5cb3a96ee
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-04 12:41:04 +00:00
Ulf Hermann
098fc76b63 QmlProfiler: Update traceClient test for queued debug messages
The order of messages changed due to debug messages being queued and
inserted so that the time ordering is maintained now. The updated
check.dat serves as a test for the queueing.

Change-Id: Id4c978a6e7fb9fa50933081217ce34e2cea5c217
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-04 12:33:13 +00:00
Eike Ziller
ca0d008808 Add option to not build sdktool (QTC_SKIP_SDKTOOL)
Change-Id: I3106bbc3bec7b6532a9fff1705a55ae3eaa0c3d6
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-04 08:56:51 +00:00
Eike Ziller
f8f882ecdf Fix focus handling in android manifest editor
If focus gets set on the editor widget, either the current focus widget
of the current page (gui/text) should receive application focus, or the
page itself (where the gui page should defer that to its first input
widget).

Change-Id: I8a35c2e9ca06fe694069b594788f7f40307abbda
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-01-04 07:41:46 +00:00
Marco Bubke
d9bd062325 Clang: Cleanup ClangTool
Change-Id: I34b943b1ffbc778d539acf16720d76e3cdef024e
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-03 14:45:43 +00:00
Marco Bubke
ab60cfd3a4 Clang: Clear SymbolCollector before updating new project parts
Change-Id: I82e9bb4f66a7597bb911fbc97d6022ff3fdb0b35
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-03 14:45:17 +00:00
Marco Bubke
3c43e5d7ec Clang: Collect source files
Change-Id: If0183cafd00ed7e42bacbdb72a1d65624dc03cee
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-03 14:45:04 +00:00
hjk
32f2169f77 ProjectExplorer: Add a IRunConfigurationFactory::addFixedBuildTarget()
To be used for "special" build targets (Custom executables etc) that do not
depend on the project. This reduces user side boiler plate in a couple of
cases and is a bit clearer than the magic {QString()} result anyway.

Change-Id: I105b6ab952981143b2abf9b218fed30cee80b648
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-03 14:04:00 +00:00
Ulf Hermann
4a5bd323a9 QmlProfiler: Retain event types between sessions on same connection
The server won't re-send the event types. We need to keep them until the
connection goes away. Otherwise we get invalid event types and soft
asserts when trying to look up event types for new events. Also, when
clearing the event types, also clear the server type IDs. Not clearing
those constitutes a memory leak.

Change-Id: I564b0c4cf0ed754549d2b8ede63c97fa01affcec
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-03 13:51:47 +00:00
hjk
63ed6321fb QbsProject: Use base Project::isParsing() function
While the base function is not virtual the "hiding" re-implementation
effectively appears to do the same. So drop it.

Change-Id: I4ab0e0690b948ce3f590c87262d10622b169450e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-03 13:48:44 +00:00
Friedemann Kleint
91530a3e0c Find: Remember the find flags per completer entry
Replace the QStringListModel used by the completer
by a special model storing a struct of the text and find flags.
On activating the completer, the flags are applied.

Change-Id: I05031641647692196ce60dcad36fc8970131f516
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-03 12:24:30 +00:00
Alessandro Portale
b3dd52b30f Welcome: Relax the SideBar spacings a bit
I got a new Laptop with 720px screen height (actually 1440px with 200%
scaling). That causes an unpleasant scrollbar in the SideBar, even with
fullscreen maximized Qt Creator.

This makes the spaces between the three content blocks shrinkable.

Change-Id: I188a38580cc59b410ecf25fa2422a8d94a44b9f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-03 12:20:20 +00:00
Hannes Domani
ce86831781 Debugger: Fix memory leak of ModulesModel
Change-Id: I79f13ca747aefbbf6f2b518aa7c14b6082373af1
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 12:06:47 +00:00
David Schulz
ffe120a43f Debugger: imitate windows gdb all uppercase PATH env variable name
Task-number: QTCREATORBUG-19547
Change-Id: I57295b7febd7e017408d5d75ebec7020a7cbb32f
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 12:04:49 +00:00
Ulf Hermann
359e4c88c9 QmlProfiler: Stop run control if connection to external app closes
We don't have control over the application's life cycle in this case, so
we need to use the debug connection as indicator.

Change-Id: I3f30194e12c10c6585a58133c5148dbea9e6761f
Task-number: QTCREATORBUG-19496
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 11:54:23 +00:00
Ulf Hermann
0ebdeccb83 QmlProfiler: Set scheme for URL in attach dialog
Change-Id: I2d96753c52f34f5d1b7a1f5de7792de748b3f507
Task-number: QTCREATORBUG-19496
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 11:54:16 +00:00
Andre Hartmann
adc8638de0 BaseFileFilter: Rate full matches higher than fuzzy matches
Searching for "qmap.h" should not have "qcore_mac_p.h" as
first search result and "qmap.h" somewhere later in the list.

This is only a partial solution for QTCREATORBUG-19531, as the
filter might be called multiple times (for "All Included Files"
and "Files in Any Project"). So the final result list may contain
the best results in the middle.

Task-number: QTCREATORBUG-19531
Change-Id: Ib5322824d3e0e8106c2f197169342f18923a894a
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-01-03 10:39:30 +00:00
hjk
8e92c28573 QmlProject: Remove unneeded reimplementation of rootProjectNode
Change-Id: I0ffd72ae6be2cc94daf3e84a713c55088d463ab1
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-01-03 10:35:37 +00:00
Ulf Hermann
2b99623605 FlameGraph: Verify that window is exposed in test
Change-Id: I54b434d41f25227b48be21c60e82ff5294aae1c1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-01-03 10:34:24 +00:00
Robert Loehning
e07bf2f682 Make missing uses of IDE name configurable
Change-Id: Ie89293b80adfacea19bcb949e4524f16fbb223f9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-01-03 10:26:24 +00:00
hjk
cb457e0eb1 Android: Remove unused declaration
Change-Id: Ia50a379fe0b341b584e89ae7c331ad45f8c7523b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-03 08:49:46 +00:00
hjk
a61d560bfb QmakeAndroid: Some cosmetics
Change-Id: Ia2ddd8c000a15f4e5a162b0c21386e700dbc4da7
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 08:42:51 +00:00
Andre Hartmann
6a9c45ab71 CppIncludesFilter: Change default shortcut from 'a' to "ai"
Reason: 'a' is also used for "Files in Any Project",
so there was no way of using both filters exclusively.

Task-number: QTCREATORBUG-19531
Change-Id: Icba0e993b004eb72b8cc419f52b171c5289bc0a1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-01-03 08:30:43 +00:00
hjk
181c88a274 QbsProject: Remove unneeded reimplementation of rootProjectNode
Change-Id: I4a6df04902297d76df5b164ea271e0c3bb00fd4b
Reviewed-by: hjk <hjk@qt.io>
2018-01-03 08:25:56 +00:00
hjk
3d22629ec0 BareMetal: Inline two functions into their only callers
Change-Id: I86c9cb8a8e6d51e7401e8a926f65c6d0dc364b89
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-03 08:02:08 +00:00
Ivan Donchevskii
b861e31f1a Clang: macOS: fix unknown integer types
Always exclude clang include paths which do not come
with libclang used by code model.
This solves the issue with GCC that uses system clang
include folder on macOS.

Task-number: QTCREATORBUG-19397
Change-Id: I3b4845248a3cf03a95fbd4038856f8fb31346bfa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-01-03 07:56:53 +00:00
hjk
23296e0084 Autotool: Move buildDirectoryChanged connection
... to a place where the potential receiver already exists.

It had not even a chance to work before.

Change-Id: Id6ca2fe522636dcd03b81c5da513f48549b8eb76
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-01-03 07:43:19 +00:00