Which allows easy navigation to any parent of the current selection.
Task-number: QTCREATORBUG-19203
Change-Id: I97179a4800afd92a21bd0fa466fbfda4ac1a5846
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
We have to ignore Qt::KeypadModifier.
Task-number: QTCREATORBUG-19272
Change-Id: I0233812e3c7e4623a00ef077f9a5057db5ba8b93
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This fixes any crashes related to uncaught exceptions when
reparenting in the navigator.
Task-number: QTCREATORBUG-19272
Change-Id: If087b866059cd285413d54f57d7c4199bfc50ba7
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
For Xcode 9 boot the second device instead of creating a new simulator
app instance
Task-number: QTCREATORBUG-19270
Change-Id: I68d1c319f8b5e709fc20462098db0c89a66566eb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Add function that casts QObjects of a given container to a desired type
and return the result via the same container with the desired value
type.
Change-Id: I45949c982c8dbdd0cce069d62cd2db5c8517f9f5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The runControl associated with a tab might become nullptr. That was
already handled in some places. Do so consistently now.
Change-Id: I899cc467a213f2a991967fa98a5819a98412d387
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The pointer passed in was assumed to be non-null, but that does not need
to be the case.
This should make the function more robust in face of errors. The RunControl
passed into the method is taken from a QPointer. So if the RunControl is
destroyed, that pointer may be nullptr.
Task-number: QTCREATORBUG-19269
Change-Id: I42e7b9d5582df2ee0830c8f92af4e4a97e7d6417
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This prevents the user from changing settings while the project is parsing. Those
changes would get lost.
Task-number: QTCREATORBUG-18988
Change-Id: Ie04c6750c8aea3fe5543168ae4838f42fe488ca2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
... to make signature the same as in other cases, which is needed
later to make RunConfiguration::initialize(Id) virtual instead
of the current static RunConfig *createHelper(Target *target, Args
...args) template.
Change-Id: If3a8fdd67bc6fe49dd7f53881cc91c1a2914f7cb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Same (or similar, in case an explicit path is configured) message
is triggered by the base class, no need for duplicated here.
Change-Id: I1a3e3c386674e98dc0ddd31f1156f7e8254a53c2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It's typically query handled after stop() (triggered by process
finished), clearing the list then would essentially discard the
result of the operation.
Change-Id: I12fb09249f8437009d3365fadcca222855468cd7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Most other signatures look like {...}RunConfiguration::initialize(Core::Id),
make this here the same, even if the Id is unused (or, rather always
the same) so we can use a virtual function in the base RunConfiguration
at some time.
Change-Id: I5d3d4a7bf856bb0cc31f8e26bc0e5a80fd1a4066
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Most other signatures look like {...}RunConfiguration::initialize(Core::Id),
make this here the same, so we can use a virtual function in the base
RunConfiguration at some time.
The formerly use extra projectFilePath argument can be retrieved
by (old) pathFromId in case of BareMetalRunConfiguration and hard-coded
to QString() in case of BareMetalCustomRunConfiguration.
Change-Id: I8f7389c1d1dcf54ae02ba8a58ed1cc74f65b0b82
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The SCXML editor has been introduxed a couple of versions ago, and it
got quite some maintenance in the meantime.
It is time to mark it non-experimental.
Task-number: QTCREATORBUG-17637
Change-Id: I7c0b0fb52e4ce5749b38fdb303f9900433d44c5d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's 40 bytes nowadays, no need to copy for accessing e.g.
single bools.
Change-Id: I3c729cb5679e725caa4faea97cdcf7ec27262dc0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This causes the same kit to be processed repeatedly, which should not
cause harm, but waste CPU cycles.
Change-Id: Ie42272aacec6d8350398b65973570282c0c8d287
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Use the old importer when cleaning while switching to a new importer.
Change-Id: I8fd3af32271b839502571ee3806903abd927ef0a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
class Foo {
void funcInside() {}
void funcOutside();
};
void Foo::funcOutside() {}
Search for Foo::func in the locator. func was not highlighted.
Change-Id: I923bd3ef2df47c5fa030b8899d1b4df7437b1820
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
We were initializing reference but then accessing shortString.
Change-Id: If2d824f96b505b8f0131373916759cd868b07bdb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We do want prevent throwing again for reset if we already have thrown an
exception but we want to throw if there was no exception.
Change-Id: Iaf9fffb872ccd579a8ccde02381b5e5d30d5c4cb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If the id of a selected item is changed
we have to update the selection indicator.
Task-number: QTCREATORBUG-19267
Change-Id: I1f6b8f93fcf083972471837fd2837386adfabbad
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The device is needed to properly interrupt the inferior with cdb.
Change-Id: I96f3a7393770be9821d8edd7123c458399d4494a
Task-nnumber: QTCREATORBUG-19253
Reviewed-by: hjk <hjk@qt.io>
Using Utils::StyledBar, and getting rid of one stylesheet.
Change-Id: Idf4db461e6beb60e15cae9b295f13ec489146f4f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Hides the implementation detail that this is fetched from the object
pool from most places.
Change-Id: I0ea06c877fade50f62b62011bbc0d2f89fa8e885
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
The same functionality should be available in the file system view.
Change-Id: Ib31cb84924e767ebe06f595bf638a5e674d4f8b5
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Moving aspect data closer to real Value semantics fixes
the regression introduced by 890c1906e.
Task-number: QTCREATORBUG-19186
Task-number: QTCREATORBUG-19192
Change-Id: Ieaeef3995ae06a817f266c1e2514f9e5793bd4e8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... into two, each handling one type of RunConfiguration only.
This is temporary to allow easier removal of boiler plate.
Change-Id: I0c8427eaeef07dff06dce7824a87b222f8f05019
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... from RemoteLinuxRunControlFactory to create a setup where
one factory is responsible for one type of RunConfiguration only.
This is a temporary measure to allow streamlining the create/restore/
clone boiler plate.
Change-Id: I27b987b87001867b66ce797969c779fd207c5a98
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Combo boxes on Qt/macOS add an implicit spacing to their containing
widget, which lead to a gray border around the tree view.
Move the combo box into a separate widget to avoid the border around the
tree view, and paint the background of the file system view to avoid a
gray border around the combo box.
Change-Id: I9cb8329f585d48016896d558e817c3d978a78669
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
