Commit Graph

44349 Commits

Author SHA1 Message Date
Robert Loehning
69c4f8c6b5 Clang: Remove unused variable
Change-Id: I972190b2777dccb142fcd9b382dc6367786dbaf1
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-23 09:08:58 +00:00
Robert Loehning
93c616b23f Git: Remove unused variable
Change-Id: If7656e0938380714bff655c80e6d0082a427ef71
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-10-23 09:08:24 +00:00
Leena Miettinen
25102f7f8f AutoTest: Fix UI text
Change-Id: I856b505d748cb8f6c95c06b3c2bb8f6f483f77da
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-23 07:20:14 +00:00
Christian Stenger
a1b486011a Debugger: Fix placing of finished message
This message had been displayed on the Application Output pane before.
Restore this behavior which broke with 597488be.

Change-Id: I29dcae877f2f19bce05e0ec1f32274b1e7cca25f
Reviewed-by: hjk <hjk@qt.io>
2017-10-23 04:37:01 +00:00
Marco Bubke
51f1ce7810 Sqlite: Add journal option to database constructor
Makes tests much easier.

Change-Id: I8b5892ff0deb2e22ac0e874dda0d8d20a32fd2e6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-21 13:39:40 +00:00
Eike Ziller
ae34bde4fa File System View: Disable "Open Projects" if directory has no projects
Change-Id: I4172b9aaee296fc0656f348aae20883f849d7556
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Florian Apolloner <florian@apolloner.eu>
2017-10-20 20:32:11 +00:00
Alessandro Portale
e180244e85 AutoTest: HighDPI adjustments for TestResultDelegate
- Remove the gap between background rect and division line.
- Consider the QWindow when drawing the icon

Change-Id: Ie10f862f556049ec1bce78a6abe8f6170bd3abaf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-20 17:56:10 +00:00
Nikita Baryshnikov
9a61bf2a5f Locator: make sure that parent dir is always first
in FileSystemFilter

Change-Id: Idb4e0510b6d7e9e5de3fc32880c1fc1d423902ac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-20 17:10:01 +00:00
Marco Bubke
ce4d7e9d0e Utils: Fix smallstring move assignment
Before the string was simply swapped with the other string which can lead
to an unexpected behavior for xvalues. Now the destructor of the source is
called and it is default initialized.

foo = std::move(bar);

bar would now hold the value of foo.

Change-Id: Ibea3f18333a168634b7faf2fdaf9b5b52c82d5cc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-20 14:36:37 +00:00
hjk
35fa833f29 Debugger: Make AttachToRemoteProcess use the remote interrupt mechanism
... instead of trying to interrupt a local inferior with the same pid.

Change-Id: Ia5a3aa719f2df408f13dde48744c0d79a629addb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-20 14:34:39 +00:00
Thomas Hartmann
59c5e65de1 QmlDesigner: Fix synchronization of integrated text editor
We always jump to the node offset even if the curser is inside the block.
Before the selection was not synced if selecting a parent item.
The selection was never synced if the root item was selected.

Task-number: QTCREATORBUG-19027
Change-Id: I0f7b4099488b6335588498f64e28e186898a7d25
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-20 14:32:30 +00:00
Leena Miettinen
506b372c76 SCXML Editor: Fix UI text
Change-Id: I2d6794682dfb05eaa3a926f33fffa039947afa87
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-10-20 14:17:34 +00:00
Leena Miettinen
01b8da891c Finding: Add a period to the end of an error message
Change-Id: I9b10ad5af08d5d9e97fa1511e3a066f499440cb5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-20 13:45:03 +00:00
Thomas Hartmann
99eca09faa QmlDesigner: Fix API for frames
Change-Id: I2a7486da5a9213f9e16289ba437be7ac39cf9d7e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-20 13:33:03 +00:00
Thomas Hartmann
d65f26557e QmlDesigner: Fix crash
If the keyboard is used (delete) the list can be empty.

Change-Id: I7f67388d1af84091c8bc8b9a54345bb02dbf6ee2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-20 13:32:48 +00:00
Thomas Hartmann
781f15cfaf QmlDesigner: Export Theme
Change-Id: I7871e3add97742a00e128f57bdc2a15bde55ef30
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-20 13:32:38 +00:00
Leena Miettinen
6c94391e93 Debugger: Fix punctuation in message
Change-Id: I048c2b9f295050cd5a5c6ad9fdebacf7e22c5f9f
Reviewed-by: hjk <hjk@qt.io>
2017-10-20 13:21:47 +00:00
Leena Miettinen
3cd6910315 Nim: Add period to the end of error message
Change-Id: I6ba6ca4f1e551329784cb44a3a2c48eef65c3b47
Reviewed-by: hjk <hjk@qt.io>
2017-10-20 13:16:46 +00:00
Filipe Azevedo
dbd812e641 Fix multiple connections on runner restarted
Change-Id: I5ea243d9f5d2266500378381b78c0b2610261f14
Reviewed-by: hjk <hjk@qt.io>
2017-10-20 13:16:20 +00:00
hjk
d91a004b24 Debugger/QNX: Use the new DebuggerTool portsgatherer
Change-Id: Id40f79d79079ee0745dc07ca7e46fdaef44f02a7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-20 13:15:15 +00:00
Leena Miettinen
9d3607c669 Clang Static Analyzer: Fix a tooltip
Change-Id: Ieedd0b28ef46dfa935c29b3010cd178c8aa17f9a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-20 12:51:29 +00:00
Christian Kandeler
d8d26f94b5 QbsProjectManager: Consider "force probes" setting
...in the "equivalent command line" widget.

Change-Id: Id0b4758b49848a313b5a938c66be5ce4c99ef550
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-10-20 12:48:12 +00:00
Leena Miettinen
af97d0ce62 Android: Fix UI text
Change-Id: Ifae94cbd89c2af06b2c44c6a3872a24726b30c59
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-20 12:38:15 +00:00
Eike Ziller
1cbc20a693 File System View: Do not try to sync with bogus editors/documents
Documents that do not have a file name associated or are marked as
temporary should not be synced with, to avoid unnecessarily switching to
the "Computer" root. Examples are the VCS log and commit editors.

Change-Id: I6bc970eb026bf257b405fbc329aed3a5f4a456c0
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-20 12:10:07 +00:00
Eike Ziller
e652865365 Fix line number handling for file based locator filters
We need to create the regular expression based on the split off file
name, not the whole search term.

Task-number: QTCREATORBUG-19129
Change-Id: I4df375e992ce2b9a64a9c8f2c12b953f66a9444e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-10-20 10:08:01 +00:00
hjk
9dadffd997 Debugger: Move disassembler style connection closer to its only use
Change-Id: I1ed462d41663e15cd05ee0d65b2080bfba179de7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-20 09:24:05 +00:00
Christian Kandeler
be9a2be7eb Update qbs submodule
To HEAD of 1.10 branch.

Change-Id: I8083c634995ea9dd7d26521fb854ba6fbc3f9e39
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
2017-10-20 09:10:02 +00:00
Eike Ziller
bbb74daf18 ModelEditor: Fix mixup of const vs non-const iterator
And prefer const iterator

Change-Id: I2fed0e1b80fc942c6a12800560d33bf7b608c831
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-20 08:11:01 +00:00
Tobias Hunger
3dc8498bc7 QmlPuppet: Fix run of QmlPuppet
Add QT_HOST_BINS to PATH before starting the puppet. This is necessary now since
the kits no longer add this via the Qt version.

Change-Id: I155b01b43517a3fd0b2936ff33709d9e6fad3f88
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-10-20 07:42:38 +00:00
Andre Hartmann
1d53110402 Designer: Modernize
* Remove QLatin1{Char|String}
* Use member initialization
* Use range-for
* Use nullptr

Change-Id: I51c24c0a2066861f59731585f19d61b28c76c0a3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2017-10-20 06:34:40 +00:00
hjk
959c13e298 Debugger: Remove some old debug code
I doubt this has been used in the last five years.

Change-Id: Ia81cacfead1d15f77cb7e1e438ebcd59a238af70
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-20 06:23:31 +00:00
David Schulz
72c283afc8 TextEditor: Add data container for editor widget paint event
The container is used to initialize and group data that
is relevant during a paint event.

This conatiner will be used in follow up patches as an argument
to subroutines.

Change-Id: I00c8bafff526e2d90776e7ea75621fc5e4c2981f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-20 06:17:27 +00:00
Alessandro Portale
1c0dc848e0 Git: Reduce the minimal height of the Gerrit dialog a bit
The current Gerrit dialog is too high for my 1366x768 screen, and
therefore it either misses the title bar or the confirmation buttons.

This change reduces the minimal height of the "changes" and "details"
sub-widgets proportionally.

Change-Id: I548e1e04bb47b881bee55e28bf362a84ae11a87c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-10-19 23:00:30 +00:00
Ulf Hermann
f846e488dd ProjectExplorer: Make sure toolControlChannel URLs come with a scheme
QML Profiler won't accept URLs without schemes anymore.

Change-Id: I54995ae7e9c1bcdb9f55fe5d56a45931f14cf890
Reviewed-by: hjk <hjk@qt.io>
2017-10-19 16:26:21 +00:00
hjk
f1a4a10cfe RemoteLinux: Use the optional PortGatherer from the DebuggerRunTool
Change-Id: I4a79abff197ea72df421fbafe11823480719f4a6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-19 16:02:42 +00:00
hjk
f521b2428d Debugger: Let the DebuggerRunTool optionally handle the PortsGatherer
Less code in the target implementations.

Change-Id: I759f082eba5eab7f4e8252c0d7b5ec64059ba860
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-19 16:02:34 +00:00
Eike Ziller
c99b8c2fd1 DocumentManager: Avoid unneeded allocation of potentially large list
Change-Id: I454f2cbf78e76ba7e86febcd9aa0ecd003edb3fa
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 15:58:30 +00:00
Eike Ziller
981071d486 ExternalTools: Remove unneeded temporary container
keys().count() is the same as size() directly

Change-Id: I6606ebf431e6f472ba4bd346c5851fa6aa99ffdf
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 15:58:18 +00:00
Eike Ziller
e26ac60f17 FileInProjectFinder: Avoid multiple construction of QFileInfo
Change-Id: Ic2db308ed6938d0ad67c84152eed209ac0e76bd9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 15:58:10 +00:00
Eike Ziller
30f0b6857a ExtensionSystem: Avoid using iterators from temporaries
Doing it can lead to unexpected results

Change-Id: I602cf6a4692c9e0c0adb4564679478ea25bf8829
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 15:58:02 +00:00
Ulf Hermann
03c184c607 RemoteLinux: Generalize QML tooling support
The only thing about RemoteLinuxAnalyzeSupport that's actually specific
to the QML profiler is the debug services preset.

Change-Id: I1360f9555b18b74d9a86799900b58ce69e3bc205
Reviewed-by: hjk <hjk@qt.io>
2017-10-19 15:53:35 +00:00
Ulf Hermann
8e4b35b0b1 QmlDebug: Add a services preset for QmlPreview
Change-Id: If50aba7544c082d99cf03d2cf3c309fc99488803
Reviewed-by: hjk <hjk@qt.io>
2017-10-19 15:53:18 +00:00
Ulf Hermann
f9ec311177 ResourceEditor: Export all node types
We need the node types to figure out the qrc path a specific source file
will appear under in the application.

Change-Id: I712810a9fe8b64f9b03422000961f3c0622ec9ac
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 15:53:06 +00:00
Ulf Hermann
56366cfd72 RemoteLinux: Set scheme on QML server URL
The connection manager won't accept URLs without schemes anymore.

Change-Id: I647a87a73afae394c5c52a827a7359919be7e43f
Reviewed-by: hjk <hjk@qt.io>
2017-10-19 15:52:54 +00:00
Tobias Hunger
e8360c875d Environment: set LANGUAGE variable both with LC_MESSAGES
As LANGUAGE takes precedence on LC_MESSAGES variable sometimes

If LANG is not set to C now en locale really should be used for messages
by gcc. This fixes parsing of gcc header paths and error messages on non-
english locales

Change-Id: I96db16b555b8ff22b041b6e965558b342ef1a378
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-19 14:56:54 +00:00
Joerg Bornemann
a181c3e4d7 QbsProjectManager: Fix detaching of Qt containers in for loops
Found by clazy.

Change-Id: I9ccca922f6aa8b6a8f1c16c6e62db8dae3c4cc6f
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-19 14:48:18 +00:00
Tobias Hunger
acac4f029d ProjectTree: Clean up connects
Change-Id: Ib9adb893b804db868625331ecae71b6188cc9d25
Reviewed-by: hjk <hjk@qt.io>
2017-10-19 14:41:53 +00:00
Tobias Hunger
2d07ffdc7f QmlDesigner: WS fixes for puppetcreator
Change-Id: I14eefc6caf9a88fd6748b3b4450cfd826916874d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-10-19 14:41:32 +00:00
Joerg Bornemann
e71912b45b QbsProjectManager: Avoid allocations in string comparisons
Use case-insensitive comparisons instead of converting toLower() first.
Found by clazy.

Change-Id: I0d32b0ba7ccb5493d1c86d41044b09c8baed3dc8
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-19 14:22:59 +00:00
Joerg Bornemann
235f9be955 QbsProjectManager: Avoid allocations when checking environment variables
Use qEnvironmentVariableIsEmpty instead of qgetenv(...).isEmpty().
Found by clazy.

Change-Id: I62054e68c3b51c69be4ce6605ed6aef20633c9a9
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-19 14:22:53 +00:00