Commit Graph

44349 Commits

Author SHA1 Message Date
hjk
85d429266a Revert "Debugger: Remove special handling for event dispatcher files"
This reverts commit c75b8f22fa.

The feature was actually useful. Right now, debugging tends
to stop there, not only in a place people typically don't
expect, because it's not "their" code, but now also with tons
of "Semantic issues" markers which makes the file look
really evil.

Change-Id: I9ebd6a7fe31de1e03d63e08db4da31069a65578f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-23 10:11:03 +00:00
Nikita Baryshnikov
f2d2a6c6ff ProjectExplorer.Kit: do not warn if icon path is empty
Change-Id: I0dff382a1b80c511a72667839bca429114f4a279
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-08-23 09:50:18 +00:00
hjk
c128731ff2 Debugger: Use a QUrl for Qml server port and host
Host and port reasonably belong together, using a QUrl makes that more
explicit and follows the lead of the Qml profiler in that area.

Change-Id: I754cb17d165ce6b2f25c655eeebfd8ac8f5a93c7
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-08-23 09:13:40 +00:00
hjk
60614d6ce1 WinRT: Use new core functionality to get free port for Qml debugger
Change-Id: I187f15760a2c81e02518e8c684b0990acf4b21eb
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-08-23 09:13:28 +00:00
Eike Ziller
7ef365d756 Do not disable "required" plugins when testing
"Required" is only the Core plugin, and that should never be disabled.
Fixes the weird issue that running "qtcreator -test WinRt" on
non-Windows platforms failed with "Core plugin is disabled".

Change-Id: Id349f406e4bde876ae5513c75d39b4b4c052b8ba
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-23 09:01:53 +00:00
hjk
cfad538acf Debugger: Fix attaching via app output pane
Task-number: QTCREATORBUG-18604
Change-Id: Id41f3fe1bf08965cfdaf21a7059fc2f1db49ecc7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-23 08:18:21 +00:00
Orgad Shaneh
a7ffd67a91 OutputWindow: Activate links only on left button click
Change-Id: I650da02a6f084d1db3be3891a575d4f97df06aef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-23 07:42:00 +00:00
Nikolai Kosjar
95b5477cc4 Clang: Avoid access to a not yet created document processor
That could happen when registerTranslationUnitsForEditor is called with
visible documents that are not those that we are registering. In that
case, processSuspendResumeJobs() would request the not existing document
processor and throw an exception, thus preventing parse jobs.

Change-Id: I9e9aeefcb1fbb70ec0cfe21e1b2fc849286a8f0d
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-23 06:58:46 +00:00
Dan Cape
9a25e31ae8 QNX: Add QNX Abi to the library collection function
Since QNX was split into it's own Abi (QnxOS), it is no longer
piggybacking on the UnixOS Abi. When this change occurred,
there was no change done to collectLibraryData function so on
QNX we were no longer seeing libs created from projects that
were subdirs of a main project.

Related QnxOS change: e69c2eb

Change-Id: Ibb4ff8932ca5d6eea317946aecb53f58ddccc0ea
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 21:00:13 +00:00
Eike Ziller
51e8a1730a HostOsInfo/FileUtils/PersistentSettings: Fix build without QtGui
Interesting for command line tools that want to pull this in but not
QtGui (e.g. sdktool)

Change-Id: Ic2f5c1f3126869cc38bf672345750d7d966560fd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2017-08-22 13:32:43 +00:00
Eike Ziller
19cbd1ac48 Sdktool: Report settings write errors instead of silently failing
Change-Id: Icf344652593bc868dce8f66e8f4ab11970c87204
Reviewed-by: hjk <hjk@qt.io>
2017-08-22 12:44:35 +00:00
Andre Hartmann
63a75e3f4a PathChooser: Modernize
* Range-for
* Remove QLatin1{Char|String}
* Member-init

Change-Id: I8c928a21cd1187e83264c88e1c62d81d82ed088f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 12:37:13 +00:00
Eike Ziller
de7e0c58f8 FileUtils: Remove unused includes and forward declaration
Left over after moving functionality to dragsupport.cpp/.h

Change-Id: I909be9eb42fb96989e9469278b416e25f3ac7f62
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 10:39:30 +00:00
Eike Ziller
91f508c272 Utils: Fix typo in pri file
Change-Id: Ibf35bbfe6836bac524e61f11747f1b0fb164e112
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 10:30:09 +00:00
Nikolai Kosjar
0db7ad77a0 Clang: Fix built-in's ExtractFunction action
Since

  Clang: Provide highlighting for identifier under cursor
  commit ca72c29462

the LocalUseMap, used for some refactoring actions, was not updated
anymore. Fall back to the built-in implementation for the LocalUseMap
because it contains pointers to built-in AST that clang obviously can't
provide.

Task-number: QTCREATORBUG-18607
Change-Id: I08762fe457835d4d83aca719febcb3497ee9696b
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-22 10:01:31 +00:00
Nikolai Kosjar
a9ddbb61a4 CppEditor: Show precompiled headers in code model inspector
They are displayed in:
  1. Invoke the inspector dialog:
     Menu: Tools > C++ > Inspect C++ Code Model...
  2. Select "Project Parts" in the top level tab row
  3. Select "General" in the lower tab row

Change-Id: I9042fb7706bde713af808ca687cae8a5d06736ae
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-22 10:01:22 +00:00
Nikita Baryshnikov
0a548fe2bc ScxmlEditor.TransitionItem: fix signed overflow warning
transitionitem.cpp:247: warning: assuming signed overflow does not occur
when assuming that (X - c) <= X is always true [-Wstrict-overflow]
     if (idSnap >= 0 && idSnap < m_cornerPoints.count()) {
         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Icc0b21c21326663f801ffef2b82fdd4b2679bf07
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-08-22 09:34:47 +00:00
Nikita Baryshnikov
bd4428eb84 AppOutputPane: fix coverity warning
Change-Id: Ifcfb826c474bb38cf33cfb8a029e60288aa49053
Reviewed-by: hjk <hjk@qt.io>
2017-08-21 17:09:42 +00:00
hjk
c0e417dcbf Debugger: Move the server start script handling to separate worker
It's currently only used via Debug->Start Debugging->Attach
(misnomer...) to running debug server, and only honored by GDB.

Moving it to a separate, centrally created worker makes makes it more
widely available and reduces the need for 'custom' handling in
the GdbRemoteServerEngine.

Change-Id: I39de7a5d8b64fc35d4bf93878e38c1866db90379
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-21 13:25:28 +00:00
Nikita Baryshnikov
8de69d7b5f Replace QLatin1String, QStringLiteral ("") with QString()
Change-Id: I21e6165e7e8858df8436c04c9afcc1be5242bda4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2017-08-21 09:27:21 +00:00
Eike Ziller
240aff88ab Fix that plugins were wrongly indirectly enabled when testing
Since the disabling of all plugins except tested onces was implemented
as an afterthought, it did not update the indirectly enabled plugins.
Instead, update the list of enabled/disabled plugins in the
optionsparser like for the -(no)load options, and trigger the update of
indirectly enabled plugins afterwards. Also take test dependencies into
account when indirectly enabling plugins directly.

Change-Id: I59d6c05de69a3073576155f7bd6201f1cd44697c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-21 09:17:27 +00:00
Robert Loehning
b9167a192f ProjectExplorer: Don't hide empty resource files like empty directories
Task-number: QTCREATORBUG-18748
Change-Id: I4de59743c42b99ce0b402f814b4cd0ba5d299338
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-18 12:28:45 +00:00
Christian Kandeler
8353d76df4 Update qbs submodule
To HEAD of 1.9 branch.

Change-Id: I3eaa6ab3f2b82c8235280752864c00d58c95507d
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-08-18 12:28:22 +00:00
Ivan Donchevskii
9c9baaac04 Clang: add unit-tests for follow symbol
Change-Id: I336fe29052237ede6f5c578daf01557400d9027c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-08-18 12:10:02 +00:00
Ivan Donchevskii
32d38789f9 Clang: implement followSymbol in TranslationUnit
Follow symbol in current TU or dependent files
Current algorithm tries to do the same as built-in
follow symbol but better.
Currently clang-based follow symbol has some limitations:
- following function usage may return the declaration
instead of definition because we don't have header
dependencies in backend
- overrides are not searched because of the same reason
and the amount of dependent files (parsing 250 files
takes a while)
- some includes are not handled correctly, in that case
we return failure and ask built-in code model to follow
(example: <QtGui> or other qt includes)

Change-Id: If35028ee0b5e818fdba29363c9520c5cca996348
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-08-18 12:09:51 +00:00
hjk
db005bf5eb ProjectExplorer: Workaround for displaying startup failures
Failures during RunControl construction currently get not to
the user as the Application output pane is not yet available.

In theory it should not happen, rather the condition should
be checked to disable running entirely, but in practice it
can happen e.g. in the BareMetal setup right now.

To avoid pre-release code restructuring, force a message box
in such cases.

Change-Id: I703c47b270d153afff34e08dad7833540a5983a2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-18 10:11:14 +00:00
hjk
98c48a4779 BareMetal: Don't crash if no GdbServerProvider is found
Change-Id: I78bca87f9e24d23f8faf26340e3dd585300efe86
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-18 10:10:31 +00:00
hjk
c6ff65fd65 Debugger: Don't wait for app output for Qml debugger port retrieval
We know the port in advance nowadays.

Change-Id: Iacd6f2c8ef04665606a77625be77744a358bb560
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-08-18 09:38:58 +00:00
Eike Ziller
94a9b4b0ea Merge "Merge remote-tracking branch 'origin/4.4'" 2017-08-18 09:23:27 +00:00
hjk
5b6c4f63b0 RemoteLinux: Remove RemoteLinuxQmlProfilerSupport::m_outputParser
It's not necessary and not used anymore.

Change-Id: Ibf5f8b691a0228b90c045154dd98ee83d4300861
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-08-18 09:11:42 +00:00
Nikolai Kosjar
8d847daa4b Clang: Do not add parentheses when completing "using N::function"
Task-number: QTCREATORBUG-17444
Change-Id: I7a99d35af9e6471b0d4ebe19385727247b31efb7
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-17 16:20:07 +00:00
Eike Ziller
a0a42ff7bd Merge remote-tracking branch 'origin/4.4'
Conflicts:
	src/plugins/debugger/gdb/gdbengine.cpp

Change-Id: I8a7c8ca07d6d6005f5d39b8f1477ebbc7a299fbf
2017-08-17 17:29:25 +02:00
hjk
cf1edc1fb5 Debugger: Restrict scope of stored signalOperation
It's only actively alive between the attempt to stop, and being
stopped. Having it stored in 'global' member variable was a
workaround in pre-lambda times.

Change-Id: I169745afd7985ed9038edff763026c32f82f6126
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-17 10:04:34 +00:00
Christian Kandeler
a4aa79a4f8 QmlJS: Rename variable called "interface"
Easily conflicts with a macro of the same name in windows.h.

Change-Id: Ia6dfb294092497c48816e71ff901e9c3b2c8359f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-08-17 09:53:39 +00:00
hjk
ef1b0f999d Debugger: Fix assert handling for devices without signalOperation()
That's not a full solution, but fixes the reported crash.

The core of the problem is that BareMetal devices do not provide
signalOperation() (which is ok) and this code path should not have
been taken to start with.

Change-Id: Ib903b8d7f0728c5b3cb217b567247e66b751c5c3
Task-number: QTCREATORBUG-18694
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-17 09:01:20 +00:00
Christian Kandeler
2f762508b0 qbs build: Clean up template replacement code for app version header
This amends 0db3e0fb0b. The code accidentally worked correctly, but was
based on a wrong assumption and was confusing and misleading.

Change-Id: I0617708a758e8d6082ed46635311bb156b22692d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-17 08:54:34 +00:00
Christian Kandeler
0db3e0fb0b qbs build: Fix display of copyright year in "About" dialog
The template was not properly replaced.

Change-Id: I1aa0f01fcd13475293b88ddacb357f3783642e6b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-17 08:31:27 +00:00
BogDan Vatra
3a16aaa639 Android: Add android-clang to suggestedMkspecList
It is needed for android-clang qt builds

Task-number: QTBUG-60455
Change-Id: Ice1c552754214fe4ec47b970da86087d03e30530
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-08-17 08:18:16 +00:00
hjk
10d505b4e4 Welcome: Scroll view on filter update
Task-number: QTCREATORBUG-18261
Change-Id: Ib7060af4cc787e4da55a860d0ae528e535fdcda7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-17 08:10:55 +00:00
hjk
06569e5f3a ProjectExplorer: Order projects in session alphabetically again
Task-number: QTCREATORBUG-18337
Change-Id: I716369a1012f93c6c676e89c3b32cd1a406996a5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-17 07:57:50 +00:00
Robert Loehning
1acc482130 QmlProfiler: Initialize and reset QmlProfilerPlugin::m_profilerTool
Change-Id: I6efa81c1c89610f50f0057fccce438176bff3120
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-08-16 17:33:26 +00:00
Vikas Pachdha
a4d8105497 Android: Support API level 25 and 26
Task-number: QTCREATORBUG-18690
Change-Id: Ifa25d95c75e854be1b88065925dd77296720f183
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2017-08-16 11:26:15 +00:00
Nikita Baryshnikov
2a62a72c69 QmlProjectNode: fix coverity warning
Change-Id: I83d2684f4adb9f969824e202da2261b37a699a68
Reviewed-by: hjk <hjk@qt.io>
2017-08-16 11:13:39 +00:00
hjk
49ffe0fb40 QmlProfiler: Disconnect some signals on shutdown
It's a workaround, not a proper solution (as indicated by the
SOFT ASSERT: "d->m_profilerState" in file qmlprofilerruncontrol.cpp,
line 144 triggering) The state manager (and possibly more)
is referenced from potentially running run controls, that are ramped
down after the plugin.

Task-number: QTCREATORBUG-18736
Change-Id: Ia20b168fe640c818276a777e1d23feab0cacd565
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-08-16 09:06:22 +00:00
Vikas Pachdha
cdffb378fd Android: Fix QML debugging
Specify the qml server address and use correct default loop back
address in qmlengine

Change-Id: I9b77cb3385041bbe79900e7f7a188ca26124bacc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-08-15 14:40:25 +00:00
Ulf Hermann
d571b5051e QmlProfiler: Tests for QmlProfilerDetailsRewriter
Change-Id: I26b7f71fad35d569e0fc70fe4f5eaf2796e607cf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-15 13:46:05 +00:00
Ulf Hermann
dc912be7ea QmlProfiler: Properly prepare the file finder on every start
We want to examine the current list of projects, also if we don't have a
specific runConfiguration. Also, after repopulating the file finder, we
need to clear the cache of file mappings, as they might have changed.

Change-Id: I351789fe999009d443ca5ade9b365bfd490e0e23
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-15 13:38:31 +00:00
Ulf Hermann
6a626595dc QmlProfiler: Rename QmlProfilerDetailsRewriter::clearRequests to clear
It also clears the lookup cache.

Change-Id: I9fdd9136084a17f427336d6ce2d37d724b9b20d2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-15 13:37:59 +00:00
Ulf Hermann
65c11e43df QmlProfiler: Add some sanity to details rewriter's PropertyVisitor
Take care of possible integer overflows and apply coding style.

Change-Id: Ib3922f30c102575ab773f7708864886fc0b53d15
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-15 13:37:51 +00:00
Nikolai Kosjar
ff21d3464d Clang: Blacklist override warnings from Q_OBJECT
Task-number: QTCREATORBUG-18621
Change-Id: I20d4fd7a93e0557334135bf7bcbd2f6517a6ede6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-15 13:19:44 +00:00