... and make use of it.
With gcc 7, the new option -Wimplicit-fallthrough is introduced and
added to the -Wextra set, triggering dozens of warnings in our sources.
Therefore, we annotate all obviously intended fall-throughs. The ones
that are still left are unclear and need to be checked by the respective
maintainer.
Change-Id: I44ead33cd42a4b41c28ee5fcb5a31db272710bbc
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
...since this is not yet implemented and confuses users.
Change-Id: I16e41f3308607aeaf1fb4a8d38ca276781c88952
Reviewed-by: David Schulz <david.schulz@qt.io>
Reducing display of unwanted line annotations while typing in small
files.
Change-Id: I51864bbc3056ad792d5ee4b96f63e954dfba79dd
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Backport the master commit (cherry-pick).
Apply clang fix to the old code model
Do not replace the text after cursor if
the proposal does not contain it or
if proposal matches 100% the text after it
Task-number: QTCREATORBUG-18471
Change-Id: I10c90580d46d2d2c899dc1ed8fe4d7df0531691a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Realistically, we only have UTF-8/plain ASCII messages, and if not then
the conversion should happen when the message enters the "creator eco
system" as there's potentially information on the actual encoding
present, not at some random consumer further down the chain.
Change-Id: Ie21199b99255f5c4d28fce3da7db2fd6c3bcfb3a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... instead of onFinished(), which is on its way out. Should be the
right think in theory and not make a difference in practice as
the code appears to be unused right now.
Change-Id: I5ef415fc0fab8902e8e31e75354a5943d99b2182
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
For the Clang Code Model, this assert is not valid as it does not
require the semantic info.
Change-Id: Ia28253354baa531c620c1bd4dead16ef88a95f1b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
That centralizes all the focus setting, raising of windows, etc. This
was for example already done wrong when opening links in help mode and
external window.
Change-Id: I5036b5caa751d1f36dc442078624a31fb8f573ee
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
When using the "Web Search" locator filter ('r') or "Get Help Online"
from the context menu on build errors in the issues pane, we already
know that we want to show the URL in an external browser, not help mode.
Task-number: QTCREATORBUG-17795
Change-Id: Ie7faa527907124251a60e7618747d81a6003fa19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
A header file was indirectly included in debug mode.
Change-Id: I9142fc9b92fd6db1182c6602a0ac4a723aa2c9f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
RunControl::setRunnable is meant to go in the long run, individual
RunWorkers are better suited to handle their needs (and only their
needs) than trusting a one-Runnable-fits-all-workers-in-RunControl
setups.
Change-Id: I6bdb32cc69581503dd252af83b75428c0de2f648
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
QGraphicsObject is a QObject and significantly heavier
then QGraphicsItem. There is no need to use
QGraphicsObject in our case.
Using QGraphicsItem instead is simply good practice.
Change-Id: I65f9db85eace25fd0e7873093e903d923eb338dc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
I also removed the hard assert.
Change-Id: Ia15d9f82fb63e7d8dd6acf8547b9e96bad838d3f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If QtQuick Controls 1 are missing there is no reason to
build QmlDesigner.
Change-Id: Ic8777fef6addc460b05c8218d96aa13379f02cea
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This change shall solve a lot of Coverity findings
Change-Id: I1e699f7363426e9b6008fc77d3f498fe3d968b4f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
If I remove the switch cases gcc produces a warning. Coverity recognizes
the cases as dead code and produces a finding. Maybe Q_UNRECHABLE is
modeled in Coviery to suppress dead code issues.
Change-Id: Idae2c088ba95b3e00cb4ef788d075fe7e0d4b6a5
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This enables us to mark perspectives as disabled.
Change-Id: I52b2434f33f8550b6d2459f915dfd8cdb1389140
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Less code, and it's what most other targets do nowadays.
Change-Id: I2cf55d1a32ad10427ce2508536d03bca8921b451
Reviewed-by: David Schulz <david.schulz@qt.io>
Make declarations equal in case they differ only
by argument const and/or volatile (13.1.3.4).
Task-number: QTCREATORBUG-18475
Change-Id: Id0561fda3b9081b92716a8739ba9963e90b5d709
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
