Commit Graph

44349 Commits

Author SHA1 Message Date
Marco Bubke
451123beea Clang: Clean up keyword highlighting
Change-Id: I8c2737718282d047e487b8ed82a40dc256d39ce5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 10:06:59 +00:00
Nikolai Kosjar
e6bf399003 Clang: Stop highlighting keywords in preprocessor directives
Task-number: QTCREATORBUG-15516
Change-Id: I30046ae7c1a73144985639800227012bf5a4e357
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 10:00:02 +00:00
Christian Kandeler
7ffdcd102d QbsProjectManager: Make the configuration name explicit
This is a prerequisite for being able to import builds.

Change-Id: I22bd8f201db943335edadc899bfe9fa64d39e845
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-14 09:11:56 +00:00
Nikolai Kosjar
e63841cf3e CppEditor: Fix nullptr access
...for invalid code.

Task-number: QTCREATORBUG-18355
Change-Id: If5d4d90a7dbaa770008e4e6c54c7ff3a86c6da89
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 09:07:17 +00:00
Marco Bubke
3fb25b28e3 Clang: Cleanup IPC code
Change-Id: I29571801b4093337e2c7cc1eec51cfcd07b3bdc5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 08:46:21 +00:00
hjk
f97875a870 Utils: Make Port::number error out with -1 in the invalid case
That's more consistent with 'default' cases QUrl::port() and internal
Utils::m_port representation.

Change-Id: Ia6ee413f92e94c202f70d734e79976a0cda0d9ef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-14 08:43:20 +00:00
Eike Ziller
937bb39ff2 Work around slow painting on macOS
This got prominent by removing the OpenGL based QQuickWidget from the
Welcome mode.
Basically painting is very slow to the point of unusable when there is
no OpenGL widget in a window. The moment an OpenGL widget is in the
widget hierarchy of a window, painting is much faster. This is
especially notable on HiDPI screens, e.g. using 1.5x or 1x scaling on 4k
monitors.
This is also reproducible with older versions of Qt Creator when using
additional editor windows or diabling Welcome mode.

Restore the status quo by adding a dummy OpenGL widget to welcome mode
on macOS.

Task-number: QTBUG-61384
Change-Id: Ia1a4738dd2070d70d8be42d4d717099d3933248b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-14 08:40:47 +00:00
Alessandro Portale
646abdd445 Utils: Make the progress indicator themable
Ensures a consistent visibility with light and dark backgrounds.

Change-Id: I8e825ccf05248abb2c94c4cd3af56d0226bc7e96
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-14 08:30:03 +00:00
Eike Ziller
0316219f8d asConst: Simplify with C++11/14 and fix for rvalue refs
add_const is available since C++11, add_const_t since C++14
Use universal reference && to enable uses like

for (const auto item : Utils::asConst(foo->items())) ...

Change-Id: I17ee19dae22a306ccf92035f43e60e91b32dffd7
Reviewed-by: hjk <hjk@qt.io>
2017-06-14 07:30:57 +00:00
Christian Stenger
6621f5594f iOS: Fix compile with Qt5.6
Change-Id: I0ee2e97b94da72140631df01c6ddf59252e5138e
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-13 13:40:48 +00:00
Christian Stenger
931d334392 AutoTest: Clean up includes
Change-Id: I55a2ac8d3d625cbdd6b03c6a0ee11996e45cf981
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:50:30 +00:00
Christian Stenger
c1555b1d7e AutoTest: Provide way to access the original test output
When running tests the original output is processed and not presented
to the user at all. For crashing tests this could mean that output
was not able to get processed completely (e.g. when having XML as
output and relying on well-formed code)
Unhandled output could also lead to incorrect results.
This patch adds another view to the results pane which contains
the complete output of the last test run.

Change-Id: I923496e9c440de4ea68bee55415777ea5c2379c2
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:50:22 +00:00
Tobias Hunger
460e1d7e93 CMake: Add "test" target to cmake builds
Always show a test target for cmake projects. This will show even
if there are no tests in the project. But I think it is more annoying
*not* to be able to run tests via the locator when tests are available
than getting an error message when attempting that with a project that
does not have tests.

Task-number: QTCREATORBUG-18323
Change-Id: Iba85aa868cb9bfe6c3f44a7ffff620d081d3082f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-13 12:47:44 +00:00
Tobias Hunger
e78324dc17 ColorSchemaEdit: Make layout of color selection dialog cleaner
Add some section headers, make widgets align with more other widgets,
get rid of useless margins and make hiding elements not leave random
amounts of space between elements.

Change-Id: I3d2ce7a00a92cdff5af5b7aa5e2784460d388c85
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-13 12:47:27 +00:00
Tobias Hunger
190f2d9e8d Mobile platforms: Do not use QLatin1String in BuildSteps
Change-Id: I3d67e94e7dc2d86ac1eba641562ee4a045f95d6c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-13 12:46:51 +00:00
Tobias Hunger
05e0b001d3 ProcessExplorer: Remove QLatin1String from AbstractProcessStep
Change-Id: I1eed445b2e0400272ded021123420eee279ea1df
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-13 12:46:41 +00:00
Tobias Hunger
9f4583756b ProcessExplorer: Do not use QLatin1String in ProcessStep
Change-Id: Ic72e1cfe6d164d5f137ce4451033a9992bc2fd13
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-13 12:46:36 +00:00
Eike Ziller
a456375187 Do not put locator manager into object pool
Users should use the static interface (and they do).

Change-Id: I2b8f6a379a45975d94fc8e77f86df9a16f2c9cf1
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:42:21 +00:00
Eike Ziller
247639d9c3 Remove 1-1 dependency between locator and locator input widget
Add possibility for filters to set a new search text when accepting
an entry.
Move placeholder text update from locator manager to widget.
Propagate filter update through signal-slot connection instead of directly.
LocatorManager::show is the only place left that directly references the locator widget.

Change-Id: Id61354d9f166c2af8c9d5528ad8998c7c6b8e1ab
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:42:13 +00:00
Eike Ziller
9f83808dc0 Add missing includes in projectmanager.h
Change-Id: I75df00be7832e5da350bf19cac8ef99f8cd17386
Reviewed-by: hjk <hjk@qt.io>
2017-06-13 11:29:32 +00:00
hjk
19a47fed29 ProjectExplorer: Remove various RunControl::report* functions
The interface has now moved to the RunWorkers.

Change-Id: I1ebf74c081697b8e44926ab00053417f9f60647d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-13 11:07:15 +00:00
Alessandro Portale
a1d4b63f8d CPlusPlus: Add a property icon
Properties have been so useful in Qt for Years, and they will
continue being so. Properties deserve a proper icon.

Change-Id: Ifd19c97470a48a033bbe4017855f7b150befb365
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-06-13 09:53:28 +00:00
Marco Bubke
be42d40c44 Fix text style name for output argument
Change-Id: Ibfc3584b60a073ba6518f78d2aa67b69bd6dd2a2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-13 09:16:40 +00:00
Christian Stenger
3cd688ca44 AutoTest: Avoid full rescans if not necessary
The file system watcher triggers way too often as it
acts not only for removal or addition of files, but
for any change like mtime or similar.
Doing always a full rescan is painful, so limit this
as much as possible to the files that have changed.

Task-number: QTCREATORBUG-18315
Change-Id: Iba4705ff58c34e998d8cf1b40761758c6fd65680
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-13 07:24:35 +00:00
David Schulz
e01f434722 ProjectExplorer: Fix build after removing wince* sources
Change-Id: Ic2e0149ceb6f83485c2ee81cc3e58cc1822e7c58
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-13 05:14:59 +00:00
Tim Jenssen
62f62fbe7a prepare "new file dialog" for bigger icons
Change-Id: If448374c2b62a1dd51469d0c54f250ba6a49c5b6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-06-12 21:22:32 +00:00
Alessandro Portale
29c95e3c3f ProjectExplorer, QtSupport: Remove wince* sources
WinCE support has not been maintained since a while.

Change-Id: Ieb388f981451a1178e70960f41e9db4bb3c789f9
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 19:37:46 +00:00
Jake Petroules
5f45bb34ce Fix deployment target on macOS
According to the README, the minimum version is 10.8, but the code did
not reflect that reality.

Change-Id: I2bbaeefe614cba5b5fa8413b68202bb75f346d70
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 17:11:57 +00:00
Thiago Macieira
80bdcb95de Add unnecessary break to switch statements that don't fall through
GCC 7 can't tell that it's unnecessary, so it complained.

 registerhandler.cpp:528:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

Change-Id: Ia3e896da908f42939148fffd14c6a15f3ec05524
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 16:19:49 +00:00
Christian Kandeler
cbc5b21110 QbsProjectManager: Introduce QbsBuildInfo
We will need to pass additional build info data in order to
support importing builds.

Change-Id: Ic62d0da246f5a19b53632ef3dc61b1f4fc434e5b
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 15:10:55 +00:00
Alessandro Portale
d023014a5c ProjectExplorer: Remove unused cesdkhandler.h/.cpp
Must have been unused since a while.

Change-Id: I33adfe26d084f4990eef0b68371cf100e7e47e3e
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 14:48:44 +00:00
Tim Jenssen
c63494217d fix infinite loop on environment modify()
Task-number: QTCREATORBUG-18335
Change-Id: I9d92f4e85a86a7b498e80d206c5b9ef2d36a17f3
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 11:48:32 +00:00
hjk
4c29a31930 Ios: Convert to RunWorkers
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.

Done-with: Vikas Pachdha
Change-Id: I9deaef48735c1c63c41dfae39d67f59387295273
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 10:37:12 +00:00
Robert Loehning
a3735eada4 BaseQtVersion: Check return value of QFile::open
Change-Id: Iba199ec29e4e8f4e74ffe6e76262eac0538c65ea
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-12 09:58:48 +00:00
Tobias Hunger
90c7427b15 ProjectExplorer: Make settingsaccessor more clear
Do not hide two strings getting concatenated inside long string lists,
use nullptr instead of 0.

Change-Id: I9b873295a24c1f5b0a9ce2c43ace050e3ff2329c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:36 +00:00
Tobias Hunger
623a9fc694 ProjectExplorer: Use member initialization in BuildStepsPage
Change-Id: I2834d3825b2737d036912e0d4b72fb57a926d139
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:12 +00:00
Tobias Hunger
f86ea447c3 ProjectExplorer: Use member initialization in CustomWizardParameters
Change-Id: Id461feb771990756adcaea98ac2f27f87f1b7ce9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:32:55 +00:00
Tobias Hunger
5e0d4e65db VcsManager: Remove dead code
Change-Id: If23eadb7368824cf1cf6f77602ef056d6d0bcb88
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:32:35 +00:00
Tobias Hunger
5662f721e3 ProjectExplorer: Use member initialization in ToolChain test
Fixes a coverity warning.

Change-Id: Idac478b61abc1ac8e99e748fe5e6ee845c6312ff
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:31:56 +00:00
Eike Ziller
d21dde3b3c Merge "Merge remote-tracking branch 'origin/4.3' into master" 2017-06-12 09:00:10 +00:00
Tobias Hunger
aa0c2a5ef8 ProjectExplorer: Remove unused pointer member from EnvironmentAspectsWidget
Change-Id: I61ffc4e7f003212c8b0b4d2dfc187724ac4aabc8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:23 +00:00
Tobias Hunger
ef72327495 Qmake: Use member initialization for GuiAppParameters
Change-Id: Ib438f41eb2e8c376fc1605046f416cd26f3503da
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:12 +00:00
Tobias Hunger
1c91bcb2a8 MSVC: Use member initialization
Change-Id: I1d9e7f71f807857c8955a3876dcbf775cd69b693
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:05 +00:00
Tobias Hunger
00cb9ee986 Kit: Use member initialization
All users did initialize m_priority with a call to setPriority in
their constructors, but we should not rely on that.

Change-Id: I707aaaf117e2680ba0bb1f2849e66c426b4fb8b4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:59 +00:00
Tobias Hunger
5058f269ef ProjectExplorer: Use member initialization in BuildSettingsWidget
Change-Id: I5949dee22fa6b4d152a65edd55cfc184bec82ab2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:53 +00:00
Tobias Hunger
dabda7966f WinDebugInterface: Use member initialization
Use member initialization to make sure everything is properly initialized,
even when not on windows.

Change-Id: I585476556fd83f493a68b26dcecd26dd772122e2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:49:48 +00:00
Orgad Shaneh
6b0e1bc5f8 Merge remote-tracking branch 'origin/4.3' into master
Change-Id: I83af635dcac98e4fd78b21d8dd9dc3a27a4fdf94
2017-06-12 10:01:16 +03:00
hjk
1d921ae044 Android: Convert into a RunWorker based setup
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.

Change-Id: I7373105603505aa4fffd7fe5ff0145f0128b34bc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 06:38:40 +00:00
hjk
1a82bedc8b QmlProfiler: Merge LocalQmlProfilerRunner and QmlProfilerRunner
Also streamline code paths in the result.

Change-Id: Id7d96343a8f778ba8f415b1a850cc78576afa475
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 06:24:36 +00:00
Orgad Shaneh
8116cb39e1 Debugger: Add missing breaks in switch statements
Detected by GCC7

Change-Id: Ic4a1f0adac486d3f6d0f7da15b24e983c17225f3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
2017-06-10 20:40:31 +00:00