Commit Graph

44349 Commits

Author SHA1 Message Date
Christian Stenger
f173dc82df AutoTest: Provide more details on failure or guess
If a test case cannot be started or does crash while executing
these information might help to sort out configuration problems.

Change-Id: I406d5e69475d05931d4c4c4738f8528c6d74c585
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-12 11:57:36 +00:00
hjk
ee27248a56 Debugger: Streamline DebuggerRun{Control,Tool}Setup
Only one code path needed once we have a RunConfiguration.

Change-Id: Ib65f471a929a0c70694dd142b4f83be7eebbe151
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-12 11:56:44 +00:00
hjk
cd47065bf0 ProjectExplorer: Use a lambda to parametrize promptToStop handling
Less coupling than using virtual functions for better re-use.

Change-Id: Ibbab38175538f65c0f563129c87e01736ed220af
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-12 07:52:58 +00:00
hjk
9ad669b494 Debugger: Remove unused ActionDescription::isRunnable
Change-Id: If09d188bdf3e03929ed0371258a0952709e53643
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-12 07:45:32 +00:00
BogDan Vatra
750f25d9e6 Fix release builds debugging
Add gdbserver all the time, except when the user signs the package.
Even then the user can "Force debugging" by checking the checkbox.

Change-Id: I274243786f3d6d6b88f41e532bebc24213f5e9db
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-12 06:33:55 +00:00
Tobias Hunger
598100c765 CMake: Do not try to update project data when an error occurred
Do not try to update project data when an error occurred in server-mode.

Change-Id: I6a1cf4b6e79fd6ddf5329195861f34cd7f1ca44d
Reviewed-by: Florian Apolloner <florian@apolloner.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-11 14:46:14 +00:00
Alessandro Portale
c2483427f1 Utils: Keep correct palette for dark themers after suspend
Sleep, hibernation and user sign-in can cause a ThemeChange event. That
event resets the application palette, discarding a palette that may have
been previously set.

Dark themes in Qt Creator want to set and keep their custom application
palettes. So, this change sets the custom application palette on each
ThemeChange event that is send to the main window.

Task-number: QTCREATORBUG-14929
Change-Id: Ic9fb0111cfa0e8171b819d687f280c3db6cc8f2c
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-11 13:22:54 +00:00
Thomas Hartmann
5cf8fbabda QmlDesigner: Fix Crash
Task-number: QTCREATORBUG-17998
Change-Id: Ic0ad46455a0e56af3082c1d9ce8995a7f07c2238
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-11 12:44:55 +00:00
hjk
e2e843a30d ProjectExplorer: Move default runnable setting
... to where it belongs, guarded by a check of RunConfigartion presence

Change-Id: Ie2bfdea30fded81f12a6962c9717c8574fc14ba5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-11 12:24:46 +00:00
Christian Kandeler
b2be9b5b0a QbsProjectManager: Add "clean" and "rebuild" actions for products
... and sub-projects. We used to have only the "build" action for these.

Task-number: QTCREATORBUG-15919
Change-Id: I31d06498c0cdadb8a8738be521a98e8b03de32ee
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-04-11 12:15:52 +00:00
Leena Miettinen
3e665f7aaf Coreplugin: Fix UI text capitalization
Change-Id: I8738078198e0be0f010b9bce0f6688fd925eae15
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-11 11:51:46 +00:00
hjk
27c8c74813 Debugger: Move engine construction into RunTool constructor
Makes using code closer to the intended run control/tool setup
pattern.

Change-Id: Id898338008588227e778fe3835b96740996c3691
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-11 11:29:16 +00:00
BogDan Vatra
d3cb2cae50 Use QVersionNumber to compare versions
Comparing strings will give us strange results e.g.
23.0.20 > 25.0.0

Change-Id: Id709ebfe45454064a18706e2df5d01ed5a3e8551
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-11 07:32:30 +00:00
David Schulz
34f1349c93 Debugger: Fix assigning values to locals
Change-Id: I366f597ee54e3c3d916bac2879c4c02b59ee2e83
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-11 07:32:14 +00:00
hjk
49b98f1149 Debugger: Make DebuggerRunTool (more) responsible for output
Make DebuggerRunTool accessible to downstream users, but remove
the non-standard handleApplicationOutput from the run control
itself to move it closer to the base run control.

LogChannel and Utils::OutputFormat should merge at some time.

Change-Id: I47b0f0067e1427b25e47036c3d4bc6ed5eed6189
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 13:13:11 +00:00
Christian Stenger
a585a59f61 ProjectExplorer: Fix compile with MSVC2015
More or less amends a09f762c.

Task-number: QTCREATORBUG-18002
Change-Id: I54d88c4590cdf34ff28dba5041ba10a2686429e9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2017-04-10 12:12:01 +00:00
hjk
9177fd60ca Debugger: Introduce a DebuggerRunTool
The DebuggerEngine cannot be promoted directly as in case of
combined debugging we have three DebuggerEngine at the same
time, but the base RunControl is only (and should be) able to
handle one tool. So introduce a DebuggerRunTool base-RunTool
derived class that's only a thin wrapper on the (master)
DebuggerEngine.

Change-Id: I948833f4cff68c7d6e3dfa43b28328b862d6ae81
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 10:49:16 +00:00
David Schulz
17485c0678 Debugger: Optimize python output handling
Change-Id: Ia97e8adaabbffe49acec44575621a4f4243c5cea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 07:07:38 +00:00
David Schulz
c00bb1dcfb Debugger: Pass uninitialized variables to the python dumpers
Reduces accessing uninitialized memory

Change-Id: I025e9070b9b17a806237619b484cb27230e7f494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-10 07:03:23 +00:00
Kari Oikarinen
8c86400329 Qmake: Fix deploying versioned shared library symlinks
If in a .pro file VERSION is set with less than three version
components, for example "1.0", qmake on Linux still creates the .so with
the following links to it:

- libexample.so
- libexample.so.1
- libexample.so.1.0
- libexample.so.1.0.0

Creator only deployed first three of those.

Pad the version number with zeros to three components in order to find
all of them.

Change-Id: I0ca3b7cb9d2150e7e9a5c22a5522678aec085b95
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
2017-04-10 06:00:47 +00:00
Christian Stenger
21214d4f3f Utils: Fix compile with MSVC2015
Change-Id: I3f5e2c51aa34e9ae7cee4b2ff83fbb58c869f6da
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2017-04-10 05:39:36 +00:00
Jake Petroules
83fd207a64 Qbs: use the separate QNX OS type
... instead of detecting it via the device type.

Amends e69c2eb2

Change-Id: If7bd19412e723c268d93e16d46828925b74d6a4b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
2017-04-07 15:58:44 +00:00
Tobias Hunger
0951589420 Project: Unify handling of displayName
Unify the handling of displayName with a proper changed signal across
all projects.

Change-Id: I7e503528854b85f6f38de4b0943775f82a0d6123
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-04-07 14:49:51 +00:00
Tobias Hunger
28c8da4f90 Session: Emit signal when project's displaynames change
Task-number: QTCREATORBUG-17957
Change-Id: I3fcbe2171e359f71434c6162d012e64f70efce99
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 14:31:26 +00:00
hjk
48c25d4d2b Debugger: Reorganize RunControl creation
Move engine creation closer to RunControl creation, One step closer
to switching orders and making the engine a RunTool.

Change-Id: I37e9c4fcca9381cc0b8fb14b98c892eef8cb1215
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-07 12:05:06 +00:00
Tobias Hunger
5972f7fac6 CMake: Deduplicate targets in server-mode
CMake server-mode does report targets for each "PROJECT" that was
encountered before the target was defined. So it reports several
copies of the same data all the time. Deduplicate that information.

This fixes files being duplicated in the code model and the project
tree.

Task-number: QTCREATORBUG-17955
Change-Id: I95daa0f48e37587234d7e04e9bed6d20884f8be0
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 11:45:06 +00:00
Tobias Hunger
06ccc35b3b CMake: Clear error flag in CmakeBuildConfiguration
Remove/refresh the error message in the CMake build configuration when the enabled
state changes.

Task-number: QTCREATORBUG-17948
Change-Id: I0f210fc572dde40a9adfee7ec2d934926d576d61
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 11:43:45 +00:00
hjk
cd3c5104bf ProjectExplorer: Add a RunControl::supportsReRunning setter
Removes one reason to derive from base RunControls (specifically
ValgrindRunControl).

Change-Id: I81e32a49ef30e79ee7e7b53a54021eaaba43453a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 10:51:35 +00:00
Robert Loehning
4f78b1e4db ModelEditor: Fix copy/paste mistakes
Change-Id: I580d3f7a97ab81fcc6aaca1b83c0f25b1d8d1ce6
Reviewed-by: Jochen Becher <jochen_becher@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-07 10:24:27 +00:00
Robert Loehning
6344815d0d QmlJS: Abort if file could not be opened
Change-Id: Ic2175c2b8dc6ec8ce378db07bdd2b667b15f70cb
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:23:33 +00:00
Tim Jenssen
76dc24c3b7 QmlJSEditor: avoid jumping cursor while editing
Writing a property made the cursor jumped to the beginning. Now we
only set the cursor if the textedit has not the focus and no code
completion open.

Change-Id: I7e5d41d5f7f9d75ebc90506d276ccaeb193c64b2
Task-number: QTCREATORBUG-15680
Task-number: QTCREATORBUG-17413
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2017-04-07 10:21:46 +00:00
Tim Jenssen
c643095f17 QmlJSEditor: cleanup updateOutlineIndexNow
It was called to often - it was already connected in setEditor method.
Change outlineModelIndex() to be just a getter and call the
updateOutlineIndexNow() where an update is necessary.

Change-Id: I6f30bfaff74237416c1aef5418860179c1f8ebf7
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:21:21 +00:00
Tim Jenssen
2c1c51bbea QmlJSEditor: remove modeUpdated method
It does not say what it does, it is better for understanding
to call the direct method instead.

Change-Id: I2150d4c84254f684474e353995b466b59d4844c0
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:20:52 +00:00
Tim Jenssen
17fbbda57e QmlJSEditor: use initializer lists
Change-Id: Id02f4313cd789fabd1223c6934e1aa5a39ed43ca
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-04-07 10:20:10 +00:00
BogDan Vatra
063253d89e Copy gradle from Qt location if available
Task-number: QTCREATORBUG-17814
Change-Id: I4252c9dfc2a2d7208dee04b734e12d77c82f5eae
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 10:13:37 +00:00
Orgad Shaneh
b1180280d0 ProjectExplorer: Fix infinite recursion
If some ProjectNode doesn't override supportsAction (like CMake), then the
fallback is FolderNode, which calls the root project node again...

Change-Id: Ie7a469d6aaaae38c8c2ff56e33fed27cf1477b49
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-07 08:44:34 +00:00
hjk
1779578930 ProjectExplorer: Introduce a 'UrlConnection' for RunControls
Currently used in GammaRay only, but actually more generic and
can possibly replace the HostName connection type.

Change-Id: I78bb5bc454ac39becbb33c3e29e8271e6ac9d6ff
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 08:33:11 +00:00
Orgad Shaneh
d186d85bcf ProjectExplorer: Fix clang ABI detection
Change-Id: I809f8b747ffb64ed128fd0f957d13d670604d050
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 08:27:23 +00:00
Orgad Shaneh
5828205418 Abi: Detect also "windows" as OS
Clang reports x86-pc-windows-msvc

Change-Id: Ibaed516e6d63bc8d99298f72c862d7ac07ca37f9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-07 08:24:47 +00:00
Marco Benelli
d0823cd5e2 QmlJs: fix reformatting of 'signal' statements
Reformatting 'signal' preceded by comments used to bring to a bad
formatted file.

Task-number: QTCREATORBUG-17886
Change-Id: I02e093a4721cd1e75d45b498ea768251aee88ea4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-07 05:32:20 +00:00
Tobias Hunger
107a93ff0d ClassView: WS-only change
Change-Id: If9907e6ba67a9a70765ad3e15f80c9b54bd2575a
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 15:51:04 +00:00
Tobias Hunger
8634aa4cbd ClassView: Adapt to ProjectTree changes
Use functionality available on Project if possible, thus preventing a crash
when trying to work with the rootProjectNode.

Task-number: QTCREATORBUG-17977
Change-Id: I397bbf501dc42b306ca88a67a3b2a0c9a9334d92
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 15:51:00 +00:00
Christian Stenger
1024d25e93 Debugger: Remove output processor from RunControl
The same functionality is available by using signals of the RunControl.
This reverts ca3bcd81 partially.

Change-Id: Id1d4d6e8326be60cdbe7c862dab46f49dbc6abe7
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 13:53:57 +00:00
hjk
4b9320d86e RemoteLinux: Remove unused run mode parameter in AnalyzerSupport ctor
Change-Id: Ib03e076aea32a8b49a1d99ec08ff11801af266df
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-06 12:54:23 +00:00
hjk
ff62ef3d92 ProjectExplorer: Always initialize RunControl's runnable from RunConfig
That's a good first approximation and often enough all that is needed.

Change-Id: If54cdb0e98cda94bc4a4ef24fcc12c78018c4dbe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-06 12:53:57 +00:00
Wolfgang Bremer
60379856a4 Provide human readable debugger states
The debuggerengine has an internal state machine. This change provides
the state name instead of the states number for debugging purposes.

Change-Id: Ic8d63902e83e3905d7880a703302cb597174460b
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 12:44:40 +00:00
Robert Loehning
f9cabade6b DocumentModel: Remove redundant return
Change-Id: I121093f15f27974119e41ecc1db2b5e76c7deb50
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 10:51:36 +00:00
Robert Loehning
ed270e439f CppEditor: Remove redundant return
Change-Id: Ie7e87ddbc3f6eff970da2f68fd8e8d858e5cebf5
Reviewed-by: hjk <hjk@qt.io>
2017-04-06 10:51:16 +00:00
Tobias Hunger
fd48d1fc02 CMake: Do not add empty "<Headers>" folder
Do not show a "<Headers>" folder if that is empty.

Change-Id: Ife37691600accb176b69eba9bc7e323fa1a01ae6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-06 09:48:25 +00:00
Tim Jenssen
a0e524b492 QmlDesigner: fix typo
Change-Id: Iecc75dab66077d43fe22e15f28876c4d3cf6a322
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-06 09:42:53 +00:00