Commit Graph

44349 Commits

Author SHA1 Message Date
hjk
a2d6dc65ff GenericProject: Pimpl and remove uses of global object pool
Change-Id: I2020ab5a72af9dfce5393fa3f91755f914a9e021
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-06 07:59:57 +00:00
hjk
6cfde4c2ed RemoteLinux: Pimple and avoid unneeded use of global object pool
Following the now-canonical HelpPlugin pattern...

Change-Id: I2c02b3dee7238da9fb1e3a9b29afb4cd32424cb8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-06 07:54:24 +00:00
Leena Miettinen
34a2e61dca Clang support: Fix UI text
Change-Id: I99ad82a5d9077b86e5651fef439ac06210115875
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-06 07:46:57 +00:00
Friedemann Kleint
9a950e5a89 Image viewer: Add include <QAction>
Fix broken build (likely introduced by
e1d2d35c20).

Change-Id: I34024e437d4d74ebe4f712718a66cedca8a4b7ae
Reviewed-by: hjk <hjk@qt.io>
2018-02-06 07:40:28 +00:00
Oliver Wolff
74d718c001 Fix MinGW valgrind build
QueryFullProcessImageName is only available on Windows >= Vista.
iSetting _WIN32_WINNT fixes availability on MinGW and moving the
functionality to winutils avoids code duplication.

Change-Id: I0ff1a12a1c092b1ad9cde75b636b52c5b959ce7d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-06 07:30:18 +00:00
Leena Miettinen
88a889d45a Gerrit: Fix UI text
Change-Id: I5be1fc3629961dbc224d65d1bc52efc9a4613d2a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-02-05 16:14:01 +00:00
Tim Jenssen
4f537a5ea3 QtSupport: Add setting for arbitrary features for a Qt version
Change-Id: I9cd296316bd100d6f867ca7bffefb9676dc66c09
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-02-05 14:37:35 +00:00
hjk
ba17b58ede BaseTreeView: Disable resizing columns by clicking on the background
Resizing columns by clicking on the empty space seems to be
controversial, perhaps because it also has the side-effect of
resetting the column resize behavior to "automatic"

Let's try without for a while.

Task-number: QTCREATORBUG-19169
Change-Id: I0b480d6857dba9f247fa3537273073e3c65712d2
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-05 14:14:12 +00:00
hjk
d3eb585db9 Help: Pimpl plugin and avoid use of global object pool
Create a HelpPluginPrivate class, move all previously private
HelpPlugin data and code there.

Make it live from HelpPlugin::initialize() to HelpPlugin destruction,
so it can be used to handle life time of data members automatically,
making use of IPlugin::addAutoRemovedObject unneeded.

Change-Id: I9e381ca20b98f4d9c06687c11b81a64e69ceeb96
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-05 12:42:27 +00:00
Christian Stenger
6f5f07d2e4 Utils: Do not assume qtchooser target as valid
Change-Id: Ia92286cf8dbc810139ab0cb1e7440aa62d290e21
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-05 12:41:59 +00:00
hjk
126674429f Valgrind: Remove unneeded use of global object pool
Change-Id: If1412703d04e63bf08caaabc83f6a4b9999c5e29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-05 11:09:34 +00:00
Eike Ziller
78ce194d95 ModelEditor: Make constants header self-contained
QT_TRANSLATE_NOOP was not defined

Change-Id: Iff31e1c16db9e648d65018a57c9e74cd5c0eb3aa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-05 10:43:58 +00:00
Eike Ziller
dcfa07ba76 ModelEditor: Move export actions to File menu
Only visible when a model editor is active

Change-Id: Ia21045188867b23815bd05432d1fd4699de8bd61
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-05 10:43:47 +00:00
Eike Ziller
e1d2d35c20 Unify zooming actions of image viewer and model editor
Change-Id: I5761ab579beda5b2cd0b725869ed216cb97e900c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-05 10:42:25 +00:00
Thomas Hartmann
ffb2503a59 Add new settings to control new file dialog
* Hide the platform filter combobox
 * Disable the "All Templates" filter

Change-Id: I2af1ccba254ff70f28a60d0a1d49590e87791294
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-05 09:06:01 +00:00
hjk
9b3a074438 Nim: Avoid using the global object pool
Use the pattern that's currently being established.

Change-Id: Ib716b35473fe5060b9ba5beea240ed46cfb1c5c7
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2018-02-05 08:27:45 +00:00
hjk
204d8d141e WinRt: Avoid use of global object pool
Change-Id: I875122569f4e78750993caa11b8635b68d0fc8da
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-05 08:05:19 +00:00
Christian Kandeler
169e963019 Update qbs submodule
To HEAD of 1.11 branch.

Change-Id: I8815038a41402addb966444dd5836bc1b6ff5fd5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-05 07:59:16 +00:00
Nikita Baryshnikov
cbcbaaa2f3 ClangRefactoringBackend fix reorder warning
Change-Id: I7cd957c2c172021768c98b7fa87c5a53fa6da54e
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-03 06:56:59 +00:00
hjk
3d79d80557 Macros: Avoid use of global object pool
Change-Id: I84eb19e3e081fd63d390b7ae065c138bb483201f
Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
Reviewed-by: hjk <hjk@qt.io>
2018-02-02 16:39:06 +00:00
hjk
93a5aa9821 BinEditor: Remove the concept of a current editor
Scales better to multiple views with even less bookkeeping.

Change-Id: Iaa91e614466a59af6f2e567e72e59efe14b7612f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-02-02 14:40:47 +00:00
hjk
75e71d5997 QmlProfiler: Remove a few uses of ActionManager::instance()
The used functions are static nowadays.

Change-Id: I1c7ce9765fba111fd3104cf151a519fd89818081
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-02-02 13:18:27 +00:00
David Schulz
0eb7bab20c Core: make useMacShortcut constexpr
Change-Id: I293b96428784b6efecac6dae4f2f9690af0027da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-02 13:15:55 +00:00
Andre Hartmann
5f69507573 JavaScriptFilter: Use QScriptEngine to avoid endless loops
QJSEngine does not provide a means to interrupt the
evaluation when then engine stucks in an endless loop.

The (deprecated) QScriptEngine does allow this,
so use this for now. As QBS also needs QScriptEngine,
no extra dependency is created. For Qt installations
without QtScript, the JavaScriptFilter is not compiled.

Task-number: QTCREATORBUG-19690
Change-Id: I172b7e7042eea0d40a765c836b2d1c57b6a529e6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-02-02 13:07:49 +00:00
hjk
1611d016a1 Bookmarks: Avoid use of global object pool
Modernize a bit in the process.

Change-Id: I34e71c154b38ede29fc36a25762a515ea6596fb9
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-02 12:37:53 +00:00
hjk
289f2b170a CppEditor: Do not add QuickFixFactories to object pool anymore
Not needed anymore.

Also some cleanup, no 'using' in headers etc.

Change-Id: I8c4547d80d0c0ffd989d1efbc74687c9f56096a4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 12:26:32 +00:00
hjk
c4b3779b42 QbsProjectManager: Cut down visible QbsManager interface a bit
Change-Id: I2c2d50f1ec0c7fdb5e9a629728f8db90cdb43b75
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-02 11:27:40 +00:00
Thomas Hartmann
d404cce06a QmlDesigner: Do not show Backends tab in stand alone mode
Change-Id: I03b591b91b072282e5e69851b62a5623759d4456
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-02-02 11:02:02 +00:00
Thomas Hartmann
99da7ef2b3 Add project tab to navigator
This makes navigation the project a lot easier
and the layout of the side bars can be locked.

Change-Id: I3ad7b85cb8704aedf8f5ec9ea9b2930c5a0986d1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-02-02 11:01:49 +00:00
Christian Kandeler
bc15b47487 Build Qbs QML type info dynamically
... when building with qbs. Optionally also update the copies in the
repository.

Change-Id: I4604eff6de95101a8cb086708d5a9ef24af0fd32
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
2018-02-02 09:14:01 +00:00
hjk
59d2505441 Remove two unneeded uses of ICore::instance()
The functions are static nowadays.

Change-Id: Ic6f6cb9c58319f3b33d8201aefb630b9381b2af3
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-02 07:23:23 +00:00
Thomas Hartmann
ef9ac8f2f4 QmlProject: Add support for setting the environment
This allows setting arbitrary environment variables
in the .qmlproject.
This is required for example qtquickcontrols2.conf
and QT_AUTO_SCREEN_SCALE_FACTOR.

Task-number: QTCREATORBUG-19513
Change-Id: I8421a9fc7f85d24b3564f1b60f383be3838f2af4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-02 07:18:20 +00:00
Ivan Donchevskii
d81580b7a3 Clang: extra clangbackend job to collect full token info
Limit document annotations job to only highlighting data
collection and move more expensive calls into separate job
that runs after it.

Change-Id: Ie792a3f741ac45c81033dd5b3a20ed061604f927
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 07:01:59 +00:00
Ivan Donchevskii
bdd5066665 Clang: introduce more data in TokenInfo
Data added:
- return type spelling for functions
- parent spelling
- access specifier for class fields and methods
- storage class

New highlighting types are added, therefore
types are now categorized by class, struct, etc.

Change-Id: I1739b94a6f777045fde655060d8b9a12b6e0889b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-02-02 07:01:28 +00:00
hjk
730a8186af Core: Compile fix after 974022c77b
Change-Id: Idd26b1da785deec81772dff3134c4c23e63762bb
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-01 17:07:04 +00:00
Marco Bubke
497900eb3f Clang: Handle source dependencies in symbol indexer
Get the source dependencies from the collector and save them in the
symbol storage.

Change-Id: Ibc141970a100625398c1526f5bc644cc14d25c0c
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:06:20 +00:00
Marco Bubke
048224bef1 Clang: Collect source dependencies
It is quite easy because we track the include directives in the
preprocessor callbacks.

Change-Id: I2d7bd67b31f50c0d8d4a46c57e83dffa0c558dc7
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:06:09 +00:00
Marco Bubke
b2d3951bde Clang: Clear used macros and file information for symbol collection
We have to clear them too otherwise we will collect them which can lead
to wrong data in the symbol database.

Change-Id: Iad7b87344caec0f27a5f8f24c214573a274db911
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:06:00 +00:00
Marco Bubke
89b9dfed84 Clang: Add source dependency saving to the symbol storage
The source dependencies are simply a table which connects the include file
with the included file.

Change-Id: I5454e81a2b5b98f05c7ff3f6740a6d45e01772c3
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:05:52 +00:00
Marco Bubke
490523fdbb Clang: Fix index for project part sources
The index has to be unique so that the inserting will be fail. We have to
add integration tests if everything is finished.

Change-Id: I4e20b90f1865d548572d2e634ac934f81da957c2
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:05:39 +00:00
Marco Bubke
c6f65e94c8 Sqlite: Add unique index to table
Some times we need the constraint for an index.

Change-Id: I81332238d36b88196ef03e26b4edcc1307de46e0
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:05:30 +00:00
Marco Bubke
c29ae225c5 Clang: Add source dependencies table
We want to track which source is dependent on which source.

Change-Id: I4b3c14be540974d69cc5026a5d081be1baceb133
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:05:20 +00:00
Marco Bubke
5dd24110f5 Clang: SymbolIndexer is saving the file information to the symbol storage
Change-Id: Id34ce9901c1a938e7ea14da444a9ef1b052286e5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:05:10 +00:00
Marco Bubke
95ce58cf32 Clang: Add insert file information to symbol storage
We use INSERT OR REPLACE because it is simpler than the insert and update
and we provide the primary key by our self.

Change-Id: I868e040918cc6c2ed183cecc746c89bec136f974
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:04:51 +00:00
Marco Bubke
d36fce4970 Sqlite: Export TransactionInterface
Implementing the Database destructor was working around the non exported
TransactionInterface destructor.

Change-Id: Ia53ca95e7dc1141558adf65894b9c120fc88f4de
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:04:34 +00:00
Marco Bubke
70ab43ca62 Clang: Get file informations from symbols collector
We need the same information like file size and the last modification time
to check if a file has changed. This information will be saved to the
database.

Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 15:03:56 +00:00
Marco Bubke
8aef667ad7 Clang: Add file informations table
We could add this properties to the sources table but then we have to
handle null values which makes the SQL statements much more complicated
and most probably slower too.

Change-Id: Ie2a1e4862b0517825292213567725d6c18abfb30
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:59:03 +00:00
Marco Bubke
c0b771f99c Clang: Add macro names the to project part
So we can compare later if the macro names have changed.

Change-Id: I65c5f76e07fced8df6cc7282c03430adffcf5fa8
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:57:44 +00:00
Marco Bubke
8b85b095b2 Clang: Rename defineName in macroName
Change-Id: Iaf8da991032e5ed4726384c051290a77887351fa
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:57:34 +00:00
Marco Bubke
cbe9a665c5 Clang: Fix formatting
Change-Id: I250a3d3ef01ecfcf7bd8d188ab131498e67b538d
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 14:57:23 +00:00