Commit Graph

54723 Commits

Author SHA1 Message Date
Benjamin Terrier
4c62cbd6dc Add detection of MSVC 2017 Build Tools
Rename detectCppBuildTools() to detectCppBuildTools2015().
Add detectCppBuildTools2017(). Like the 2015 version the detection is
based on the presence of a .bat file because there are no entry in the
Windows registry, but it relies on the VisualStudioInstallation
structure like other Visual Studio toolchains.

Task-number: QTCREATORBUG-19053
Change-Id: I875bd466a3009574696fb7ebe54cdc5ff9bcb921
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-30 13:59:21 +00:00
Tim Jenssen
30d123e2ec Wizards: add IconListField
- reuse some code from ComboBoxField throw an abstract ListField class
 - ListField can handle more data like: icon, trToolTip
 - fix disabledIndex in ComboBoxField
 - adjust documentation

Change-Id: I00b6ab787fb2fad97dafff32786cf73c636c772d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-30 11:55:35 +00:00
Tim Jenssen
5c5bac67a4 Wizards: add basic tests
Change-Id: I647227d458540b0271070cc56106165058929d29
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-30 11:53:48 +00:00
Orgad Shaneh
dc8d0f048a Suppress noexcept-type warnings also in qbs build
This amends commit 68589a3fbc.

Change-Id: Idf0e296f7549e8aea7109e0c877e27032b99e9b8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-30 10:53:50 +00:00
Tim Jenssen
585becbf56 Wizards: remove unused defaults
Change-Id: I001ebc7d4b18f79eec48afe08f6aaa07b1883b5b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-27 15:21:38 +00:00
Tobias Hunger
1406bbeec7 GccToolChain: Log what gets reported to code model
Change-Id: Ic6a0252f6109393a2aab8ea96db9a9b583c25394
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-27 15:11:44 +00:00
Tobias Hunger
d8b25ad1d4 GccToolChain: Unify handling of language options
Change-Id: I06896d2b8b0561726d607f4bfaeb5b3ec8e065ee
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-27 15:11:36 +00:00
Tobias Hunger
bc3d4d86fa GccToolChain: Improve retrieval/caching of compiler data
* Use one template to implement both Caches
* Use shared_ptr to the caches. This is necessary to not crash
  when the toolchains get deleted while the compiler is being run
* Pass language to header path retrieval code and use that information
* Add unit tests for cache used by the toolchain

Change-Id: Ic31e7c4c1ed8158af7f2cdfda8104255efb06aea
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-27 15:11:28 +00:00
Christian Kandeler
50047466ab Update qbs submodule
To HEAD of 1.10 branch.

Change-Id: I9eefebdb98a9d68a286b2c8bc309864566a1867d
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
2017-10-27 14:43:31 +00:00
Nikolai Kosjar
5ba40cb7fb Clang: Require LLVM/Clang >= 5.0.0
...for the code model parts and declare 5.0 as the supported version for
the clang static analyzer.

Adapt versions and tests, remove code assuming clang <= 5.0.

LLVM/Clang 5 was released on 07 Sep 2017.

Task-number: QTCREATORBUG-18931
Task-number: QTCREATORBUG-18657
Task-number: QTCREATORBUG-17187
Task-number: QTCREATORBUG-14881
Change-Id: I53b00258ca06a1d2e57f9379dacc54b310687295
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-27 14:21:19 +00:00
Nikolai Kosjar
6de3eb7a1a Clang: Update patches for clang 5.0
Remove a bunch of on-top patches that are already part of llvm/clang 5.
Rebase the remaining ones and add backported ones.

Add also a README providing more information about the patches.

Task-number: QTCREATORBUG-18824
Task-number: QTCREATORBUG-17769
Change-Id: I9f6904b2e6d7c83de175e7b8c194e1a494cd2571
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-27 14:21:13 +00:00
Leena Miettinen
e5959c4bdb Doc: Add links to JSLint Error Explanations
Task-number: QTCREATORBUG-19166
Change-Id: Ia9856529a0bd79450eadb348396f270ebb7d563e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-10-27 14:03:40 +00:00
Christian Kandeler
3d5731c1d6 Fix qbs build
Change-Id: Ia0655f95bf2e6e18e5627682bc50954aaa61568e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-27 13:31:15 +00:00
hjk
81677fca97 Debugger: Move GdbEngine connections to constructor
In constrast to the LldbEngine this did properly disconnect
on restart, but moving it to the constructor avoid the need
to disconnect and follows the intended pattern.

Change-Id: I9a5727c1f6b76c0282de159251803f6ff5e76eb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-27 12:09:55 +00:00
hjk
f318dcde4b Debugger: Move LldbEngine connections to constructor
Doing it on startup duplicates the connections on re-run.

Change-Id: Idccd039b4a005a96b9a20d99e663fc636b2e67c9
Reviewed-by: Filipe Azevedo <filipe.azevedo@kdab.com>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-27 12:09:49 +00:00
hjk
5f09b3234e ProjectExplorer: Make RunWorkerPrivate::runControl const
It's not meant to ever change after contstruction.

Change-Id: I912b58dfb70b40c9763b902650d2c657c28ccc5c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-27 11:57:36 +00:00
Leena Miettinen
fa2e768eae Doc: Describe limiting build output in the Compile Output pane
Change-Id: I1302d0554c8fd8d866a6280c45374802bd08f64d
Task-number: QTCREATORBUG-2200
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-27 11:38:10 +00:00
Leena Miettinen
24a3f266c5 Doc: Describe changes in the sidebar views
The project, file system, and outline views are automatically
synchronized with the item active in the editor.

The File System view has a new navigation menu for moving to
computer, home, or project.

Change-Id: I5cb25e860d3aeabae8a51c935100b3acd5ea357f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-27 11:37:49 +00:00
Robert Loehning
b095dec478 Use specific members of QVariant instead of template
Change-Id: I8c18b71d093ad19a312f1890f6b240fb61c986ba
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-27 10:25:00 +00:00
Robert Loehning
beb91cb84b CustomToolChain: Remove unused variable
Change-Id: Ia1faadee2c5d789c2d7ca9542ebfc77b4269d935
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2017-10-27 10:24:21 +00:00
Marco Bubke
4911d5bea3 Utils: Add predicates for comparison to constant values
Many STL algorithms have value version. So you can only use a predicate:

std::stable_partition(std::begin(list), std::end(list), [](int entry) {
     return entry < 20;
});

With this predicates you can write it in a shorter form:

std::stable_partition(std::begin(list), std::end(list), lessThan(20));

The find helpers are moved to predicates too.

Change-Id: I791b3105ca84ef7c5a519d22589a91b5548cf3e4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-27 09:28:07 +00:00
Tobias Hunger
7a7a12cef2 CMake: Fix build directory
Fix use of build directory vs. workdirectory in tealeafreader and servermode
reader.

Change-Id: I593579f7ad4facd64cf201368cacc4d3a8414fbf
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2017-10-27 09:07:10 +00:00
Orgad Shaneh
6138bc3d41 TextEditor: Fix proposals matching
The regular expression must match the beginning of the string.

Broke by 95310b28f3.

Task-number: QTCREATORBUG-19170
Change-Id: Id95751e35ff48792333745d07a07da50af703f8f
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2017-10-26 18:06:29 +00:00
Tim Jenssen
2918cc59f8 Wizards: fix wrong json files
Change-Id: I185d1b559f53fa91731783c723bfffb78e93886b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-26 17:48:53 +00:00
Daniel Engelke
c27d0bb1cb Add filter box to kit selection in target setup dialog
The kit list gets quite long when having multiple qt versions installed.
To prevent having to search through the whole list when wanting to
select kits, a filter option based on kit names has been introduced.

Change-Id: Id533eb62680de69e956396fc4624b61a8c2de909
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-26 12:52:41 +00:00
Tim Jenssen
bd65ae1def Wizards: remove default values
Change-Id: If58b6b9753ccb3cb3baae8198c6e9e5369840ddb
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-26 11:32:40 +00:00
Tim Jenssen
5dbc9cb370 Wizards: remove wrong used wizard.json property
Change-Id: I37fa72cc4283a745a05a55d4c19a31e7ead59557
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-26 11:32:28 +00:00
Tim Jenssen
2f3acee4e0 Wizards: add a warning about unsupported keys
- parseData methods check that there is no unknown key is used
 - showing the name and type might be useful in warning and error messages

Change-Id: I1371bb3af1ad48ed4b85260f3b1309cdba1cb71f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-26 11:32:03 +00:00
Marco Bubke
2382824d7b UnitTest: Fix google benchmark
Change-Id: I3ea223c161d49c2f78751c07916398682b70767c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-10-26 11:25:27 +00:00
Christian Stenger
35b7dfc37e Doc: Document known LLDB issue
Task-number: QTCREATORBUG-19055
Change-Id: I6d1ea5ab132704e14e9ca89348bdcd0010bfd00b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2017-10-26 10:21:37 +00:00
Ivan Donchevskii
a701ca8342 ClangRefactoring: return ProjectUpdater
Change-Id: Ie90a8acf8ec9641ae9349679da278a3055b79d9e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-10-26 09:48:16 +00:00
David Schulz
2d437325b8 TextEditor: Restructure TextEditorWidget::extraAreaPaintEvent
Change-Id: I832168226bfe254f0540ca1a947bf16170494549
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-26 08:32:55 +00:00
Nikolai Kosjar
09ca12bbde Clang: Remove not existing files from *.qbs
...after merge of the change from 4.5 that provides *.qbs files for
clang libtooling components.

Change-Id: I696a72b3f6b111fb1ac8ff7ab5f5471e24aafe69
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-10-26 08:30:50 +00:00
Marco Benelli
f12e095fd4 Qmljs: check pointer to ModelManagerInterface
Task-number: QTCREATORBUG-19152
Change-Id: I3c511d15af943cc92c35a3c3d823080415940780
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
2017-10-26 08:18:36 +00:00
Orgad Shaneh
1c5d4d9f3b Fix tests compilation
Change-Id: I58cfe84b950e15ad9600aa25fc5e3cacd99626ee
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-10-26 06:15:24 +00:00
David Schulz
0981636943 HighlightScrollBar: Modernize overlay painting
Change-Id: I59da9b106204e27b202b08d0502052f3697c71a0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-10-26 05:56:35 +00:00
Christian Stenger
16f2ea10bd AutoTest: Limit search for test tree items
If searching for a test tree item matching a GTestResult
we can safely limit searching to the subtree holding
GTests only.

Change-Id: Iae27c5a48f24a2e59fc4ccd0c2917520fc22b053
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-10-26 05:24:48 +00:00
Eike Ziller
a3d845815a Fix build error after merge
Change-Id: Idc8bd0cece32fa2095598cef931a369f35d6be11
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-10-25 19:29:52 +00:00
Eike Ziller
7f626b1182 Merge remote-tracking branch 'origin/4.5'
Change-Id: Iceaa4ca40b5318744bde8a76c6d3ccca08df71bb
2017-10-25 16:07:21 +02:00
Eike Ziller
dd60923713 Packages: Deploy styles plugins (new in Qt 5.10)
Task-number: QTCREATORBUG-19150
Change-Id: I6673437a6f1bc322f7b40c10f98982a54aca1306
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-25 14:00:29 +00:00
Ivan Donchevskii
81f5c1c8ec Clang: implement globalRename based on clang Index
Has the same limitations as findUsages.

Change-Id: I8de4df2ecbfd8a4f3073666994398dc43af0d73c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-10-25 13:35:48 +00:00
Orgad Shaneh
175afabbd7 Cdb: Do not crash if no device is set
It still fails with a soft assertion, but at least doesn't crash.

Task-number: QTCREATORBUG-19160
Change-Id: I3779f64e752abf9d3779219552a4a1be648f1dea
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-10-25 13:27:19 +00:00
Orgad Shaneh
c0bffe1db5 ProjectExplorer: Add compiler path when running GCC
Running it from another directory without having its directory in PATH
fails on Windows because it cannot find libwinpthread-1.dll.

Change-Id: I96b976942ace48120b69001f5dddd573195bdfb4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-25 10:49:32 +00:00
Eike Ziller
1a1681bbcc TextEditor: Work around linguist issues
lupdate has issues with resolving non-trivial uses of "using namespace"
(QTBUG-64007)
Move "using namespace" directive to a place where it is better handled
by lupdate.
Also use TextEditorWidget instead of *Private as the context.

Change-Id: I7d3bb8e1bc493196e47085827be31f97e0dce7b8
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-10-25 07:13:45 +00:00
David Schulz
3bea291427 DiffEditor: Remove indirect call to firstVisibleBlock
Change-Id: I37db7e280ea9f327ff8ab33b0f9b1fee813fcba9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-25 06:21:32 +00:00
David Schulz
56260add50 DiffEditor: remove unused member of SideBySideDiffEditorWidget
Change-Id: Ic46fe95bc493c9242b0896737fb324f3816cc0d4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-10-25 06:21:25 +00:00
Nikolai Kosjar
9d19397994 CppEditor: Simplify CppHoverHandler::identifyMatch
Diagnostic tooltips for the built-in code model were determined with the
help of editorWidget->extraSelectionTooltip(), which iterated over all
extra selections. Rely on CppElementEvaluator::hasDiagnosis() instead,
which looks only for the relevant selections of the category
CodeWarningsSelection.

This is not supposed to change any behavior.

Change-Id: I7aea678b347a94a00610057180e305921234b580
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-10-25 06:20:15 +00:00
Eike Ziller
ab1107c497 ModelEditor: Fix another const vs non-const iterator mismatch
Change-Id: I9101b26d8c18ec73fe122ec334299202a76d24b4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-24 16:08:53 +00:00
Orgad Shaneh
cf72850cc3 ProjectExplorer: Remove unused context menu for subproject
Revealed by bae73e7246.

Change-Id: I93e098f595981f31233aeea366709fb428669ccb
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-24 15:02:20 +00:00
Eike Ziller
125604c80c ExtensionSystem: Work around linguist issue
lupdate has issues with resolving non-trivial uses of "using namespace"
(QTBUG-64007)

Change-Id: I1edbd74ecc97476b961fd3c741f1a3d3f22a2bf7
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-10-24 14:36:16 +00:00