Commit Graph

54723 Commits

Author SHA1 Message Date
Friedemann Kleint
766162c23b qdoc2tasks.pl: Print messages continued over several lines
For example:

qtandroidextras/src/androidextras/android/qandroidfunctions.cpp:301: (qdoc) warning: clang found diagnostics parsing \fn bool QtAndroid::bindService(const QAndroidIntent &serviceIntent, const QAndroidServiceConnection &serviceConnection, BindFlags flags = BindFlag::None)
    error: use of undeclared identifier 'QtAndroid'
    error: unknown type name 'QAndroidIntent'
    error: unknown type name 'QAndroidServiceConnection'
    error: unknown type name 'BindFlags'
    error: use of undeclared identifier 'BindFlag'

Change-Id: Ie9a9accf97cdd639b8a8a9ff908a73588fc15ff5
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-21 13:22:49 +00:00
Friedemann Kleint
6854f0580d Add sphinx2tasks.pl for converting sphinx warning logs into .tasks files
Task-number: PYSIDE-363
Change-Id: Ic3935d579cf4b13b46f339e273aad5f5dd30bd6c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-21 13:22:41 +00:00
Tobias Hunger
980fd54ea1 Fix warnings about unused lambda captures
Change-Id: Ib9bcf180fd8ceffbf88836a62fc9532e6f7fc656
Reviewed-by: hjk <hjk@qt.io>
2018-02-21 13:06:08 +00:00
David Schulz
9b5f4a41b9 Clang: fix qbs build
Change-Id: I969b1f3053421c7222fc04c7ba1e8324983506f0
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-21 11:41:07 +00:00
hjk
d7348e0ccf QmakeProjectManager: Pimpl and remove uses of global object pool
Change-Id: I801a3b6b880e1113d12ece0cf70a882b9696811f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-21 11:29:58 +00:00
hjk
3b58153750 Revert "Utils: Add a ObjectPool convenience class template"
This reverts commit f6715fe52b
which introduced this.

It was prepering infrastructure for having ownership of
sets of objects handled separately from the global pool,
but that's not wanted and needed anymore.

Change-Id: I7368da624ea99bb70a6a1cce04677257322dc605
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-21 10:45:32 +00:00
hjk
aac8a2c6d4 Tests: Add a benchmark for Qt signals vs plain callback
While a plain lambda callback lacks a lot of the features of a real
Qt signal/slot connection, there are plenty situations where the
plain callback is all that's needed. Have some benchmark for more
educated guesses on timings.

Change-Id: I0c1fdfd2fd352d75c2af66fd713806bf3dd2d135
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-21 09:53:17 +00:00
hjk
6b7db0bae8 Debugger: Remove use of addAutoReleasedObject
Change-Id: I9a435448e05f56521eaca7f6ba2ac7780950fa18
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-21 08:21:14 +00:00
hjk
7945ba7923 TaskList: Pimpl and avoid using the global object pool
Use the pattern that's currently being established.

Change-Id: Icfb1472cc394f0e371056d5cb23fd22d291dbdaa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-21 08:14:35 +00:00
David Schulz
63cc5491f5 Core: cancel async documentation registration on shutdown
Change-Id: I46bc81cf6326e964309996e0e205fff011f596e7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-21 07:58:10 +00:00
Christian Stenger
075d636655 Core: Fix build without Qt Help library
Change-Id: I8067a8ea6ef6395085673ae08c2242dd4a894d55
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-21 07:19:55 +00:00
Ivan Donchevskii
5e872c0fcd Clang: Introduce OverviewModel for clang
Change-Id: I1473e3f679f4345a04c55f1ee80cfe35e21a4347
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-02-21 06:55:59 +00:00
Ivan Donchevskii
8ffae6a08c Clang: Add cursor range to extra token information
Change-Id: Id410c94c79d61b8f4d5b53f937827356272b9f65
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-21 06:55:39 +00:00
David Schulz
e10b220189 TextEditor: modernize TextDocument
Change-Id: I9ea17165ba4eade89a6119135378793256e13358
Reviewed-by: hjk <hjk@qt.io>
2018-02-21 05:59:39 +00:00
Christian Stenger
f350018999 Welcome: Prohibit rename and delete of default session
Task-number: QTCREATORBUG-19642
Change-Id: I97d9fa84aad510fd8c2d95d3324f77fbcae4e9d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-20 19:39:06 +00:00
Robert Loehning
6cc61be23b Squish: Update tst_quick_creation3
Qt 5.3.1 used to be selected automatically which was wrong when the minimum Qt
version is 5.6. Now, because of QTCREATORBUG-19717, this does not happen
anymore.

The kit using Qt 5.6 should be selected automatically, but since we explicitly
do this, the end result is correct. When QTCREATORBUG-19717 is fixed, we
should not need to select a kit ourselves anymore.

Change-Id: I446b2843cd6e545905ce3a6616f7f8d3204bbafe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-20 18:20:19 +00:00
hjk
6e236d04a6 RemoteLinux: Decorate custom runconfig name with device name
Change-Id: I186adef1b7a7535cd0e06c0ddfe3d5e152c98195
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-20 16:07:27 +00:00
hjk
492a17b65b VcsBasePlugin: Remove last instance of addAutoReleasedObject
Change-Id: I6a622faed0bce39f21c5489afc0df623cb32f801
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-20 15:03:37 +00:00
Ivan Donchevskii
432ae65944 Clang: implement current document filter
Filter is based on full token infos which come
from clang code model after token infos with pure
highlighting information.

Inprovements:
- functions also provide the return type after the signature
- now supports Q_PROPERTY
- all c++ features that clang 5.0 supports

Change-Id: If3e30d238984f39df8d2c3b9ba3ee085c4117f3d
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 14:03:53 +00:00
Ivan Donchevskii
c39f28d5e0 Clang: Fix parsing for files which include qobjectdefs.h
For some reason did not work properly with include guards
before #include_next.

Change-Id: I4a314c0e4ff29487904e2daa64362c3e2a3e1859
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 13:44:00 +00:00
Ivan Donchevskii
dacfc611c5 Clang: Add highlighting types for ObjectiveC
Builtin code model supports ObjectiveC classes,
properties, etc. We can easily get the same
information from clang.

Change-Id: Iede5e177d4932f404e4ccb81ae356eee8faffb71
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 13:34:37 +00:00
Ivan Donchevskii
524d3ea28b Clang: Helper function to get token IconType
Change-Id: I9de562102eded9391ab0d6b895b8d812e259efd6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 12:44:56 +00:00
hjk
9a3dff8934 CMake: Pimpl CMakeProjectPlugin and avoid use of global object pool
Follows the recent pattern.

Change-Id: Ib91fb8e6ab343b5e595b9ed470daa3e55999f37c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-20 12:40:46 +00:00
Leena Miettinen
f05e4d3c8d Doc: Update info about Clang code model configuration
Change-Id: Ib20447e081f38d9f24357a717fd8ebdd489b335a
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2018-02-20 11:31:58 +00:00
hjk
08e73d1a93 Utils: Remove BaseTreeModel::hasChildren re-implementation
Not needed and wrong, as it doesn't handle the case of column != 0.

Change-Id: I0ff62df0547a47ea80e1450b7cca1ecc86da7005
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-20 11:19:47 +00:00
Orgad Shaneh
b114b0c95e DiffEditor: Minor cleanup
There is no need to enclose the argument with parentheses, and there is no
need to cast to QSharedPointer.

Change-Id: Ie8f6e4228e09203d1c42f614ee8a84de4a1e110b
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2018-02-20 11:05:26 +00:00
David Schulz
e19e9a1e90 ProjectExplorer: Fix msvc toolchain detection
Change-Id: I829753f4db9d3278a523f3c5c50b3296a5b11f3d
Reviewed-by: hjk <hjk@qt.io>
2018-02-20 10:22:24 +00:00
Ivan Donchevskii
413c66ec88 C++: Fix crash on '{' press
Introduced by 0629400.
Sometimes typing '{' after class crashes QtC.

Task-number: QTCREATORBUG-19726
Change-Id: Idbbfaaa21837ec4afbe7debbd80ddaa484120f09
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-20 08:27:31 +00:00
Eike Ziller
36c88ba5fb Fix Utils::withNTFSPermissions with void function
Fix up of 9467ed42c3

Change-Id: I24343e5e1440210188742332ec6f725af3412100
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-02-20 08:26:03 +00:00
hjk
38acd39f3a ProjectExplorer: Fix object creation order
95deefb5a revealed some initialization order requirements:
AppOutputPane needs SessionManager,
CurrentProjectFilter needs ProjectTree

Change-Id: Ibd3d14a7d23f55a850db43e031e68c32059e6e6a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-02-20 07:46:09 +00:00
Eike Ziller
23ab27ac04 Remove funny, commented code
Change-Id: Id7203efe0c131ac049b3d238d674db1fede40c52
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-02-20 07:34:29 +00:00
Ivan Donchevskii
1ed7d3c270 Clang: Provide example with clazy warnings
Change-Id: I23cb81d0ffe0d23428ce85ba22d85e1d6c8c1216
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 06:50:19 +00:00
Ivan Donchevskii
cec807f5c1 Clang: Provide example with a lot of tidy warnings
Change-Id: I6d6d2559bb8e2b6c972e88c3af9ce06968e7c959
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 06:50:12 +00:00
Ivan Donchevskii
66c7629814 Clang: Properly handle Q_PROPERTY in TokenInfo
Transform Q_PROPERTY into unique AST node.
Mark different parts with types and search for parent
in FullTokenInfos.

Change-Id: Iaa1ec0c73d34773edf5605d3682bd6a290d195de
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-02-20 06:49:47 +00:00
Thiago Macieira
b5f63a76b2 Fix build: add missing #include for QmlProfilerSettings
qglobalstatic.h:87:18: error: field ?value? has incomplete type ?QmlProfiler::Internal::{anonymous}::Q_QGS_qmlProfilerGlobalSettings::Type {aka QmlProfiler::Internal::QmlProfilerSettings}?
qglobalstatic.h:152:9: note: in expansion of macro ?Q_GLOBAL_STATIC_INTERNAL?
qglobalstatic.h:159:5: note: in expansion of macro ?Q_GLOBAL_STATIC_WITH_ARGS?
qmlprofilerplugin.cpp:79:1: note: in expansion of macro ?Q_GLOBAL_STATIC?

Change-Id: I940917d6763842499b18fffd1514e0f3522f3bbd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-02-20 06:16:35 +00:00
Thomas Hartmann
436b8cdea1 QmlDesigner: Use Core::ICore::dialogParent() for dialog
Change-Id: Ie06e8632ff091ee6cc14dacf242461ceca4eaf9c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-02-19 17:26:05 +00:00
Ulf Hermann
41017d1bbd QmlProfiler: Use a predictable kit in the QmlProfilerTool test
We may not have a valid kit at all, and then the test would fail.

Change-Id: Ie2613e67309121f0df847e76668bc433fd88c315
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-19 17:03:11 +00:00
Ulf Hermann
38064c97b0 QmlProfiler: Prevent kits without device in the attach dialog
We QTC_ASSERT on the chosen kit having a device in
QmlProfilerTool::attachToWaitingApplication().

Change-Id: I04033f032c43f27726545dcdea4533b3ccbe7257
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-02-19 17:02:46 +00:00
hjk
95deefb5ac ProjectExplorerPlugin: Remove remaining used of global object pool
By moving ownership of the respective objects to the
pre-existing private class by making them full members,
following the general pattern used in the other plugins.

Change-Id: Ifea639b68f25f0cbcb06230dc71a16d1dd3ae5ac
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-19 13:41:18 +00:00
Tobias Hunger
8801240881 Qt: Use nullptr
Change-Id: I6f7f2b5c5d33e64d5630104521dd022002347075
Reviewed-by: hjk <hjk@qt.io>
2018-02-19 13:22:34 +00:00
Tobias Hunger
e9ff7ab90b Qmake: Quieten soft-assert
Change-Id: If8c62a7aa17ac46d8e09cf990a57fa9eb1526598
Reviewed-by: hjk <hjk@qt.io>
2018-02-19 13:22:28 +00:00
Tobias Hunger
997ece4361 Project: Remove unused Project::requiresTargetPanel(...)
Change-Id: I7a5298edefd7e26841c4070be23534dd33d093cb
Reviewed-by: hjk <hjk@qt.io>
2018-02-19 13:22:21 +00:00
Eike Ziller
d55271bc50 Increase timeout for relayout in file system view
Possibly a bit less annoying in case this happens.

Task-number: QTCREATORBUG-19800
Change-Id: Ib4fe1cb577ff493a5e7a563d22b645889ce71e88
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-19 11:35:57 +00:00
David Schulz
775b235f45 Core: register documentation asynchronously
Change-Id: I946ce394bc4e21a1c5746fb38dcc81acc1106ba4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-19 11:34:04 +00:00
hjk
da33f94e20 QmlProfiler: Pimpl QmlProfilerPlugin class a bit more
... to be able to remove an unneeded use of the global object pool.

Plus some code cosmetics.

Change-Id: Ifdb0ff9cd40820a34a8951563402a50a594e4fdd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-02-19 10:17:36 +00:00
Ivan Donchevskii
b90f2fb251 Clang: Fix crash in connect() statement
With this patch ClangCodeModel can properly
handle static overloads together with non-static ones.

Code completion still might crash - requires another patch.

Task-number: QTCREATORBUG-19184
Change-Id: I12f0e8cb56b3bed3f5ca1f7a9fe4ca3932b78125
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-02-19 10:12:56 +00:00
Tobias Hunger
8059bf6204 Project: Make setRequiredKitPredicate private
Make calling Project::supportsKit(...) the default implementation.

Change-Id: I0e47972097e760e2ff3be229afb85eff839146b8
Reviewed-by: hjk <hjk@qt.io>
2018-02-19 09:28:02 +00:00
Eike Ziller
41efaf1253 Fix translation issue
The model doesn't have a translation context and it makes more sense to
use the one from the widget anyhow.

Change-Id: I9847e4651bc7482c1e460fddd9c6890178f806bd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-19 09:16:44 +00:00
Andre Hartmann
9467ed42c3 Add a file properties dialog
Task-number: QTCREATORBUG-19588
Change-Id: I75599459beb7e23812ba48670ae968585faefda9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-02-19 09:14:28 +00:00
Eike Ziller
378c438671 Fix usage of tr()
Change-Id: I24ff39ebe8061bb974e92afc02a9387ba9e2eef2
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-02-19 08:51:53 +00:00