Commit Graph

54723 Commits

Author SHA1 Message Date
Orgad Shaneh
73f210dad6 Gerrit: Support certificate validation
Certificate should be validated by default. Only if it fails, and the
user approves, we may skip validation.

Change-Id: I7696cd7dda2d6d7ef1aa616557d5619b63372028
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2017-04-25 12:34:08 +00:00
Eike Ziller
9443f7104b Remove the need to create ISnippetProvider subclasses
Change-Id: I1810aaa945136d9726a66dad41377429a6adc8e1
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-25 12:03:08 +00:00
hjk
5784a96596 Debugger: Extract printing of dereferenced pointers into method
It's used twice, always for 'this', and whenever asked for by the
user's 'Dereference Pointers Automatically' choice, but needs to
be done at different times.

Change-Id: I4dc7340d0a4cb3eb0c7ff17d59e39be0e3870aa0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-25 10:24:50 +00:00
Thomas Hartmann
b952d0420e QmlDesigner: Update item library if error is fixed
If the document has an error (e.g. incomplete type information),
then it is required to update the item library if this error is fixed.

Change-Id: Iee9629879a0d3ee4bbc76dc0701f023e3c12f394
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-25 10:23:58 +00:00
hjk
fa6caa3b02 Debugger: Use proper placeholder in error message
Task-number: QTCREATORBUG-18078
Change-Id: I48cd8c24ca1236c69150f0d93b525a5a85447fff
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-04-25 09:51:48 +00:00
Tobias Hunger
1e178915df AbstractProcessStep: Free output parser chain in error case
Change-Id: Ie0dc094068bfa56f728d84ee13e70efbc980f8b3
Reviewed-by: hjk <hjk@qt.io>
2017-04-25 09:23:21 +00:00
Tobias Hunger
6ef5a36b39 AbstractProcessStep: Make init fail if a process is still running
This should not happen, but better save than sorry.

Task-number: QTCREATORBUG-17984
Change-Id: I3efa8fb38a915ae29366f3ab715077b762d53828
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-25 09:22:49 +00:00
Tobias Hunger
b5ab98dfd5 CMake: Simplify code
Use defined helper method instead of duplicating code.

Change-Id: I1eec61f99875ccd28e6e64bd5ad2bfd7e6e21eb3
Reviewed-by: hjk <hjk@qt.io>
2017-04-25 09:22:33 +00:00
Tobias Hunger
79f5a27568 CMake: Use RCs buildSystemTarget when deciding what to build
Use the RCs buildSystemTarget property when deciding what to build
with the "build current executable only" property set. This makes
the selection more robust.

Change-Id: I0dbcd764a06428b441084e6e4dc680e106c6d3bd
Reviewed-by: hjk <hjk@qt.io>
2017-04-25 09:22:17 +00:00
Tobias Hunger
cad16c4bee CMake: Fix up file group information in server-mode
Server-mode reports a filegroup for all the listed headers and will
provide that without any information on the files (no language, include
paths, etc.).

Fix up file groups like these by using the best (with that being the
settings that effect the most other files) possible information for
these files.

CMake has no idea what headers are, so it has no way to provide any
better information, so Creator has to fix things up again:-/

Task-number: QTCREATORBUG-17971
Change-Id: Ib5ddab23cf725c7e03717b577cc9f9edc5bbfc61
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-25 09:21:16 +00:00
Tobias Hunger
ff46e67971 CMake: Use for instead of foreach
Change-Id: I4e2c929414cf1f7b052ae9f6846f43ae20fcee4c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-25 09:20:38 +00:00
Tobias Hunger
7a388e7b4b CMake: Improve emission of enabledChanged signals of build configurations
Change-Id: I542b93512466727ac4ee66a8ca41e503106ebdcb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2017-04-25 09:20:16 +00:00
scootergrisen
e5cf97f409 Add danish (da) translation for Qt Creator 4.0
Change-Id: Ie3d5f2f418d462df68ad3c646fcbebe225f0c6f6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
2017-04-25 08:16:48 +00:00
hjk
758e50fa45 Debugger: Catch some exceptions related to optimized out values
These could be triggered by declared but undefined and unused
static data members.

Task-number: QTCREATORBUG-18030
Change-Id: I941e8cbe8ce18dca737e59472ed0ee19ace44072
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-25 07:58:13 +00:00
Orgad Shaneh
46b7701398 Gerrit: Replace magic numbers with an enum
Change-Id: I591716865831877eda4a17e9c85169935d633b09
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2017-04-24 20:19:53 +00:00
Alessandro Portale
3624a663d8 Reduce usage of qApp in favor of static function calls
Q*Application classes have unusually many static functions. In many
cases in our code, these functions are unnecessarily called as instance
functions, using the qApp helper.

This patch replaces many occurencies of qApp with the according
Q*Application classname.

Change-Id: I6099a419fa7bf969891269c37ed7a9e817ef5124
Reviewed-by: hjk <hjk@qt.io>
2017-04-24 18:36:28 +00:00
Thomas Hartmann
893d4407eb ProjectExplorer: Ensure the FlatModel is build initially
If the FlatModel is created after a project is opened,
no update was triggered.

This was already fixed, but 8d1f4834b6fe79f992b3a44f8973d32dbc0dddb3
removed the update again.

Task-number: QTCREATORBUG-17690
Change-Id: Ide9499a6579a363f43d6cde2f1a865eddc816d9c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-04-24 14:57:31 +00:00
hjk
07884645af Debugger et al: Move code from DebuggerRunControl to DebuggerRunTool
It's tool specific, so put it into the tool (only) related code.

The additional level of indirection will go again, plus the original
one will be removed once the *DebugSupport classes can directly
use DebuggerRunTool as base.

Change-Id: Ieaa386a0f7d724b09cedaaba8fb7d1e6dc4ad55b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-24 14:48:35 +00:00
Kai Koehne
e720e72a25 Purge default .pro files
Smaller is better. Remove redundant declarations, and regroup things
so that DEFINES are always before SOURCES.

Change-Id: I2d597f0d676cdfbfe4fa473a1431f92be806ee38
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-04-24 13:39:01 +00:00
hjk
ede80222da ProjectExplorer: Let the container node inherit the project icon
Task-number: QTCREATORBUG-17924
Change-Id: I774ad0ed19ca7f8cbcafe7b704e3e5c62137f4a7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-24 13:25:12 +00:00
Thomas Hartmann
2e0e0539b3 QmlDesigner: Turn Q_ASSERT into QTC_ASSERT
I had this a couple of times and this does not seem fatal.

Change-Id: Id6d2101a5dc1bdc652e6ca8557c7dd8450399be4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-24 13:19:22 +00:00
hjk
d63abf5567 Debugger: Fix snapshot view icon size
Do what the other views do.

Change-Id: I27a12715806b5d5f73aaa0b756bb08ef1a66a021
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-24 12:25:24 +00:00
Eike Ziller
c702b543ed Help bookmarks: Remove reading old settings
Change-Id: Iae6b9174871937ba7c04f710b8b7a55ca6027d81
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-24 11:45:44 +00:00
Eike Ziller
4d6e33031b Fix that help bookmarks could get lost
When closing Qt Creator before the help bookmark model was set up, it
would write an empty list of bookmarks.

Task-number: QTCREATORBUG-17537
Change-Id: I638312f21dfa201a617a4eeafb7fa161726a36ff
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-24 11:44:26 +00:00
Tobias Hunger
a1ae4affc2 Project: Remove duplicates from file list
Remove duplicate entries from list of project files. The duplicate
entries used to be visible in e.g. the locator.

Change-Id: I4a58ff11bd37ff39f4c9186ae89a2d384894bc1e
Reviewed-by: hjk <hjk@qt.io>
2017-04-24 11:41:41 +00:00
hjk
e063ca68d0 Debugger: Dissolve Debugger::ActionDescription
ActionDescription was a horizontal layer of convenience functionality
covering (only) ex-AnalyzerBase based RunControl start scenarios
and gets in the way of target/tool orthogonalization.

So continue the path chosen with the removal of AnalyzerRunControl:
Remove ActionDescription by inlining into user code, then orthogonalize
tool-by-tool, then generalize again.

Change-Id: Ib597df3f4ad7b06bef06644458fa13ddca53afdb
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2017-04-24 09:52:48 +00:00
Laurent Montel
2b80f9b89e Don't use return keyword when method doesn't return anything
Change-Id: Ia9757be7cb51fb946557d40134a93acd1aec0a94
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-24 09:38:50 +00:00
Tim Jenssen
ff7e757ddd QmlDesigner: use default initializer where possible
Change-Id: I9bde2421a5cc99b1c815b568fa2a4a2e722b852d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-04-24 09:19:49 +00:00
Tim Jenssen
19e1eacfb2 QmlDesigner: white space only changes
Change-Id: I8df6b1f53fce79fdf9eed022bc189754e668589b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-04-24 09:17:47 +00:00
David Schulz
bd9a80717e Debugger: cdb extension version bump
Change-Id: Ie4460e5d0fafd1f599b24c4a5860510df86dcebe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-24 08:42:55 +00:00
David Schulz
41954de06e Debugger: Fix dumper tests in wow64 env
Change-Id: Iac874ccb0c498065e1f46ebcc66a48ef721f6fff
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-24 08:42:50 +00:00
Tobias Hunger
8793d0f0fa QmlProject: List .qmlproject file in project tree
Task-number: QTCREATORBUG-18057
Change-Id: I6a38093d1b6fdaeac7920746395cfbebc595d062
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-04-24 07:48:35 +00:00
Christian Stenger
e821b98c11 QmlJS: Fix compile using Qt5.6 on macOS
Change-Id: I3d8dd1ad1d149be24d9a3af1c9a5e8bfb4228c67
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-04-24 05:03:38 +00:00
Christian Kandeler
438ff54ad6 Update qbs submodule
To HEAD of 1.8 branch.

Change-Id: I87bfceca8e425284b63644d9d1e541b33a8dcfca
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-04-21 14:29:33 +00:00
Eike Ziller
dae2556d2f Merge remote-tracking branch 'origin/4.3'
Change-Id: I44511e06986b7df6007be7daf7051c895a10794b
2017-04-21 15:30:00 +02:00
Eike Ziller
1891af4b07 Specify Qt Creator's "display version" in qtcreator.pri/qtc.qbs
Currently it is set by passing defines to qmake, which complicates
package build setups.
Set the display version where the numerical version is defined. This
also makes it available to developer builds. Also switch around the
display version and numerical version in the about dialog, since e.g.
"4.3.0-rc1" is more descriptive than "4.2.83".

Change-Id: I26dda427975acdc6cc169f8d625f57918167cf19
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-04-21 13:28:54 +00:00
hjk
ac86b2e8dd Debugger: One more sanity check
Change-Id: I2d788dd48415c4429f9456129e09e8fe1a9dffb9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-21 13:08:20 +00:00
Montel Laurent
158ab3316e Use QString::*Ref method
Change-Id: I63a10f274dd17e08b5b8a2577762cc9f7960b5af
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-04-21 12:04:38 +00:00
hjk
384d141aac Debugger: Use a qobject_cast instead of some static_cast
The underlying assumption may be violated soon, make it
easier to debug if it breaks.

Change-Id: I7511d5677659e266f2d01db8bafb46bcd93d7f7b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-21 11:59:41 +00:00
hjk
230524da16 ProjectExplorer: Dissolve SimpleRunControl
As planned.

Change-Id: I9d9349cdd174c47b2331095fbe545b811e6ca770
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-21 10:36:15 +00:00
hjk
d87afd4b89 Debugger: Make DebuggerRunTool publicly accessible
That's a temporary move to be able to port the per-target
Debug*Support classes one by one.

Change-Id: I3cf5f9ea367a68058add8713ed23f44da080a175
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-21 09:06:08 +00:00
hjk
dfb825e2a7 Debugger: Fix running on RemoteLinux
This (temporarily) works around the start up regression due
to wrong order of merged patches.

Change-Id: I7a386fb06175363aa23862716687764b930c52d8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-21 08:08:37 +00:00
Montel Laurent
86ea365a0b Use const'ref in theses methods
Change-Id: Idfa5ffdcf23d1ef80442276690b8082b8279dbfa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-04-21 07:58:39 +00:00
Orgad Shaneh
c60103fc66 ProjectExplorer: Fix link on linux
Amends 2ff642d8e4.

Change-Id: Ic13306e23871b519ab0c4a1b4f528c97312fb1d5
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2017-04-20 19:45:23 +00:00
hjk
d049a5be19 Debugger: Base magic Qml connection discover on base run control signal
Less debugger specific code and less convoluted paths in debugger
message handling.

Change-Id: Ib298889c386d65f17acbdfc585188097bb20ed74
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-20 14:57:57 +00:00
Tobias Hunger
0dfd08b00e AbstractProcessStep: WS only change
Change-Id: I0b218298aeae9730b74c66e6bf7b2c96048a8b93
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-20 14:02:42 +00:00
Tim Jenssen
e21843e309 QmlDesigner: set splitter handle zero again
Was broken since 6f1d23711d which sets
css only at widgets where it is necessary.

Change-Id: Ia60672136ad8c73791806c920051918dbb23748c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-04-20 13:39:04 +00:00
Robert Loehning
843f310dde Squish: Update "Do Not Save" button
Change-Id: I84ccb2ad012a9dceb4bc27838bfe726ea4d9a127
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-04-20 13:06:12 +00:00
Eike Ziller
5b3ed3f9cb Remove unused "suppressed" property from navigation widget
Change-Id: I7e94b258991b9211156c75a4475b468b585b00f5
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-04-20 12:34:15 +00:00
Leena Miettinen
b41e7d0fd3 Doc: Describe selecting installation location for Qbs builds
A new check box for using the default location and a field for
specifying another location were added.

Updated the screenshot.

Change-Id: I5401df6b022c524a376f85e6b6b2db2b2c0f6cb7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-04-20 12:24:31 +00:00