We store generic error messages in the root node.
Those have to be reset.
Also we have to reset the type icon if there is no error anymore.
Change-Id: Ibe6274f651113f26aef6240bb9efa005862378f4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Use the complete height of the (unexpanded) session label for the click-
to-open region. Also, give some magic numbers a name.
Change-Id: Ie972d669cca943105cdd2e7e99394b61ca0a6e37
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
To HEAD of 1.8 branch. This update is needed to be able to build
Creator from Creator again.
Change-Id: I0d9840e98ee347b7c3233d59fd3a7ac0daeaab24
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
When changing back to the edit mode we have to set the
edit modes text editor as the current editor.
Change-Id: I0bf7edbdf66285443402e2196f8ba655661e6dc4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We always had the problem that the design mode might become
active while type information is still being loaded.
This causes an error message and the user had to trigger
a reload of the QML document.
Due to changes in the project management Qt Creator
starts reading the type information, once the first QML file
is opened.
This triggers the error far more frequently.
This patch fixes the issue by triggering a reaload after 1s,
if type information has not been read completely.
This fixes the issue.
Change-Id: I23ad011294044690fd582e808227c3ccde8bda54
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Applying a .css style overrides the text editor background color
from the theme.
To avoid this we cannot apply any .css on the integrated text editor or
its parents:
* Only apply the center widget .css to the tab bar.
* Apply the scrollbar.css only to the scrollbars.
Change-Id: Id9b009a208ea2830c64be8174dbb548ada692560
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
main.cpp(7): error C2733: 'func': second C linkage of overloaded function not allowed
main.cpp(6): note: see declaration of 'func'
Change-Id: I46bbc86add628e7eadd5930ddf2fe9518b9e7adf
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Always list a "all" and "clean" targets and remove the similar code
in the tealeaf reader.
This fixes the clean-step falling back to "all" in server-mode.
Task-number: QTCREATORBUG-17138
Change-Id: I1ce84f03c2e9829e4bb5f550c10cdef772fabf5b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If the context menu disappears for whatever reason, just open a new one.
Making sure that the context menu stays around when we don't do anything
is not Qt Creator's job, so we don't have to test for it. Also, when
trying to remove the context menu, click a spot that's certainly inside
the screen.
Change-Id: If6e574d84bedf2ab552c8c29d756501e9d2282bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add sdpPath and cpuDir comparison to QNX tool chain comparison.
Ensures that QnxConfiguration created tool chains don't get
removed just because they have the same ABI as another QNX
configuration created tool chain.
This should really be visible in the interface but that can be
done later since this isn't something that can currently happen
with official 6.6.0/7.0.0 SDPs.
Change-Id: Ibbb6a8aa645721028d1512460e51e59633b3cedc
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: hjk <hjk@qt.io>
To HEAD of 1.8 branch, and adapt to changed API.
Change-Id: Ie180b114726134a06dfefe9dc3a6dc27997f246c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The support is not perfect, but I see no reason to
excplitly not allow it.
Change-Id: I6b1d825acde156cc7b50160060e89bb964667ab8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The QML profiler's memory and allocations mode includes allocations from
non-QML code. The space allocated for those in the flame graph shouldn't
just be empty.
Change-Id: I390bf880097d51a19d5027b06bda25dbfaecc09e
Task-number: QTCREATORBUG-17939
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
For some themes this is done anyway, but not for the default themes.
We have to do this to ensure the "base style" plays well with the applied
.css.
Otherwise the combo box might sound out in weird ways and the colors
might have usablity issues.
Task-number: QTCREATORBUG-17933
Change-Id: I4319ed9b965f4b4b3e975f2348fb89ffd9987bc3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The variable was named "CurrentRun:Runnable" in the first
patch sets, but was renamed to "CurrentRun:Executable" later.
Unfortunately, the commit message was not fixed.
Change-Id: I7084e85bb3f4eb8979b4a295bb96f47d62393375
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Also adding a test covering this dumper.
Change-Id: I491dd87e52f65bf3faf21d81436f264507bf0b51
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The designer has to be able to handle this error/warning
explicitly. To be able to identify the warning I added
a special severity.
Change-Id: I99571497f7327a7857244ef48334c14a254c8ca0
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
This adds enough hooks to enable the base RunControl to take over
the task of most of the current ad-hoc "state machine" implementations
in derived RunControls (only exception is "intra-debugger" Start/Stop
handling), including error reporting.
The idea is to migrate "downstream" uses and finally remove the custom
state handling everywhere.
With this setup here, both varieties of RunControls can co-exist
for a while: New-style uses the Tool/Target state handling triggered
by the base RunControl::start implementation, old-style had this
function = 0, so all have their custom start() implementation.
'SimpleRunControl' derived cases (Local/RemoteLinux/Python run)
already use new-style with this patch SimpleRunControl doesn't
re-implement start().
Change-Id: I508f5ed05c557ca7188af92f9d9c8d00e2a4acfe
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
They worked but still had wrong, additional rpaths
to the Qt they were built with.
Remove handling of ClangCodeModel which doesn't link to clang
anymore.
Change-Id: I5c1fa59b3659dc8205b782fa8aac8b700b17a98a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Ensure that target is not empty and avoid storing a path instead of
the real executable.
Change-Id: I408a54befbbb7004773d04f4bdd3898469efbaa7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Using this command without prefix and with the 0n decimal prefix
resulted in unreliable frame selection. Last chance is the hexadecimal
prefix.
Change-Id: I935d88849eb541534d4f311ac6059bcd35aee62c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Amends 124efb32 - this special handling got lost between patch sets.
Change-Id: Ic94145d3310668f1c63abe5443e0d833850227a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
The Flickable's width does not include the scrollbar, which may appear
and disappear, depending on contentWidth, and confuse the timestamp
calculations.
Change-Id: I6d516e6149ee64a129a1393a0780734484354147
Task-number: QTCREATORBUG-17940
Reviewed-by: hjk <hjk@qt.io>
The events in question are overlapping and all match the given
timestamps exactly. As we stop the search whenever we find an exact
match, the results are valid.
Change-Id: I705bfbdfe9105927588cc356e29209bf893a9ed6
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
This introduces a 'TargetRunner' base that it meant as a base
class for classes like the current AndroidRunner, IosRunner,
WinRTRunnerHelper, similar to the existing 'ToolRunner' class
taking care of the tool bits.
This makes a RunControl only responsible for state management
(start/stop control), application output and general user
visible display tasks, delegation most of the real work either
to the the target or the tool.
The usage pattern for creating a run control is now
RunControl *RunControlFactory::create(...)
{
if (barToolOnFooTargetIsSupported()) {
auto runControl = new RunControl(runConfig, runMode);
(void) new FooTargetRunner(runControl);
(void) new BarToolRunner(runControl);
return runControl;
}
...
}
The pattern can possibly be simplified later, for now the goal
is to make it uniformly used.
As first use, "split" SimpleRunControl into a SimpleToolRunner
(which happens to be all its previous non-(Base)RunControl bits)
and the run control bits (its RunControl base).
This will make the SimpleRun*Control* class as such vanish again,
keep it for now to give downstream uses (Qnx/Boot2Qt) some time
window to adapt.
Change-Id: Ifafed4d0577466186280ac5014f4ad9eec78c56c
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
