feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
31,342 Commits 108 Branches 368 Tags
435ec2ba5107764d075c328f76c69a9f94c4c240
Commit Graph

132 Commits

Author SHA1 Message Date
Nicolas Arnaud-Cormos
9b19a9c8e2 Analyzer: refactor global and project tool settings usage. 
IAnalyzerTool has now 2 new virtual methods used to create the global and per-project settings.
No need to create any static factory method and pass a pointer to them to the AnalyzerGlobalSettings
instance anymore.

The Valgrind plugin is now using it, the memchecktool creates the settings for all
valgrind tools.

Change-Id: I3c5845ceb7151130032cfff4ab5b7b36ca2459d9
Reviewed-by: hjk <qthjk@ovi.com>
 2011-12-28 18:26:12 +01:00
Nicolas Arnaud-Cormos
4a8432112a Analyzer: create a run control factory for all tools. 
Having one factory per tool (or plugin) created some bugs:
 * analyzer project settings being created twice
 * per-project analyzer settings widget duplicated
Also, most of the code from the run control factory were copied.

Now, the Analyzer only creates one run control factory shared among all tools, and the IAnalyzerTool
has two new virtual method: canRun and createStartParameters. It simplify the code a bit, and
creating a new analyzer tool is easier (only two classes to subclass: IAnalyzerTool and IAnalyzerEngine).

Change-Id: I4e180846a26b74b2b77cb99bc97534d680a80a4d
Reviewed-by: hjk <qthjk@ovi.com>
 2011-12-28 18:25:56 +01:00
Nicolas Arnaud-Cormos
1571b7f977 Analyzer: no need to pass a start mode when it's implicit in the name. 
startRemoteTool and startLocalTool are implcicitely working remotely and localy, they don't need a mode.

Change-Id: I433ca421f68a1026979489c7f9d86b12251ec830
Reviewed-by: hjk <qthjk@ovi.com>
 2011-12-28 12:06:39 +01:00
Kai Koehne
442f2d6972 Analyzer: Remove redundant onCurrentProjectChanged 
When switching projects updateRunActions is called too.

Change-Id: Icffb3413805e536a0f36a90bb4d45e09b5229b88
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-30 14:15:52 +01:00
Kai Koehne
d84b5d4596 Analyzer: Enable "Remote" tools even when no active project is loaded 
Change-Id: I9eafbb4cd1de0904c7b0dc5a56be5d1d16a650f7
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-30 09:45:09 +01:00
Eike Ziller
fbd47e25ee Merge remote-tracking branch 'origin/2.4' 
Conflicts:
	qtcreator.pri
	share/qtcreator/templates/qtquickapp/main.cpp
	src/plugins/analyzerbase/analyzermanager.cpp
	src/plugins/qmlprofiler/qmlprofilertool.cpp

Change-Id: I3be78f22e7301d61a9c7fc142cbc34a3cebc2cf4
 2011-11-18 10:16:49 +01:00
Aurindam Jana
25d351fa0a QMLProfiler: Menu entries to load/save QML trace 
Added 'QML Profiler Options' menu to 'Analyze' menu to
load and save QML traces.

Change-Id: I468fbcfdf355a1caaa0d53b118f0b8b505cedefb
Reviewed-by: hjk <qthjk@ovi.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
 2011-11-17 13:53:57 +01:00
hjk
8e236db9f5 mostly core and analyzer: more id-fication 
Change-Id: Ic794fdc6a582f4a03d84b6220c59111044c753b9
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-15 18:25:19 +01:00
Daniel Teske
3e305f9758 AnalyzerManager: Fix analyzer actions disabled after build error 
Change-Id: I7a6d29aba5acd2eafccf8b2c2fc08cc4ed6f00f3
Task-Nr: QTCREATORBUG-6318
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-15 12:56:22 +01:00
Daniel Teske
f224667dcf AnalyzerManager: Remove more dead code 
Change-Id: I4a1bdd9c5f4ea0b44e7dc9b5fbf7c87ae4dbc15a
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-15 12:56:07 +01:00
Daniel Teske
571734c600 Dead code in AnalyzermManager 
Change-Id: Ia51e7ed2fb64e89434405841f27842e2f84a917c
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-15 12:55:57 +01:00
Eike Ziller
85cf2b661e Merge remote-tracking branch 'origin/2.4' 
Conflicts:
	src/libs/qmljs/qmljsinterpreter.cpp
	src/libs/qmljs/qmljsinterpreter.h
	src/plugins/debugger/qml/scriptconsole.cpp
	src/plugins/git/gitplugin.cpp
	src/plugins/qmlprofiler/canvas/qdeclarativetiledcanvas.cpp
	src/plugins/qmlprofiler/canvas/qdeclarativetiledcanvas_p.h

Change-Id: Iad59c8d87c72a21c79c047e374c0ab689998af39
 2011-11-11 09:46:25 +01:00
hjk
82f5573626 more Id type fixes 
Change-Id: I3720946ba5485696822976567d83b4d6cb1fb283

x

Change-Id: Iab58bc34bc56371405d132315573b484a533b77c
Reviewed-by: hjk <qthjk@ovi.com>
 2011-11-10 15:57:09 +01:00
hjk
31600758de all: s/info@qt.nokia.com/qt-info@nokia.com/ 
Change-Id: If18afb5d4665924e7d9250dccbc60a65e6daa75e
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
 2011-11-03 10:33:19 +01:00
Kai Koehne
ad9dd78aaa Analyzer: Make sure right tool is shown when triggered via menu 
Selecting a tool via menu while the Analyze mode is active resulted
in the wrong 'default' tool being selected when the tool finally
forces a switch to Analyze mode. This fixes it by switching to
Analyze mode first -> default tool is shown -> selected tool is shown.

Change-Id: I36e770c932b9c13552dc3604db58837a89d637b6
Reviewed-on: http://codereview.qt-project.org/5466
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-09-23 17:10:48 +02:00
hjk
488330255d core: rename uniqueidmanager.{cpp,h} as the class UniqueIdManager is gone 
Change-Id: Iffe04bc3bb0103cbac605f0734bbfd66eb7fd854
Reviewed-on: http://codereview.qt.nokia.com/4215
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-09-05 18:04:55 +02:00
hjk
5e8843846a analyzer: disable start options if there's no project 
Task-number: QTCREATORBUG-5627
Change-Id: Ia8affb07ba1d87c0b333ca3a547fc9eed32062f4
Reviewed-on: http://codereview.qt.nokia.com/2636
Reviewed-by: hjk <qthjk@ovi.com>
 2011-08-04 16:07:45 +02:00
hjk
ef0a19d926 analyzer: less global symbols 
Change-Id: I2f771c7dc2a709611c68b97a5287804d4b8590fd
Reviewed-on: http://codereview.qt.nokia.com/2632
Reviewed-by: hjk <qthjk@ovi.com>
 2011-08-04 15:42:44 +02:00
Kai Koehne
1757228278 New QTC_CHECK warning replacing QTC_ASSERT(x, /**/) 
Warn if the condition fails, but otherwise don't change the execution
flow.

Change-Id: Id7b14c745109b66960add967b2a4ef8d31e1a546
Reviewed-on: http://codereview.qt.nokia.com/2389
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
 2011-07-29 12:19:11 +02:00
hjk
019c5ce6ef analyzer: potential fix for not-up-to-date actions 
I cannot reproduce the issue locally. This removes a test whether
something has changed before updating the actions.

Change-Id: If32a7911a6b7ebde65d6dcd45d1eaae6a09933fa
Reviewed-by: con
Task-number: QTCREATORBUG-5405
Task-number: QTCREATORBUG-5357
Reviewed-on: http://codereview.qt.nokia.com/1526
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
 2011-07-13 15:36:26 +02:00
Eike Ziller
d7c2c23da8 Fix initial layout in analyze mode. 
Task-number: QTCREATORBUG-5414

Change-Id: I4ac8d150f20e35a769e6f7f13db420d81e93e7e2
Reviewed-on: http://codereview.qt.nokia.com/1552
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-13 09:29:34 +02:00
hjk
c96668fe06 analyzer: add 'Locked' and 'Reset to default' actions to Views menu 
Change-Id: Ia5677b250fefe8fcfe731a06aabb6d2f2988a03d
Reviewed-on: http://codereview.qt.nokia.com/1491
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
 2011-07-13 08:48:10 +02:00
hjk
be8337f69f analyzer: remove unneeded AnalyzerPluginPrivate class 
Change-Id: I2fac5e0e8c796d6009ba30da82a5a7a67672851d
Reviewed-on: http://codereview.qt.nokia.com/1517
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-12 12:51:07 +02:00
hjk
868613b5ed analyzer: merge dockwidget and toolbar creation. 
Now that dock and control widgets are always created as late as
possible and both are needed immediately afterward it makes sense
to merge there construction. This also reduces the chance to create
a partial tool gui in an inconsitent state.

Change-Id: Ic7f405d65b2b8f0b4ee3ff0ef991d6e4746bac0a
Reviewed-on: http://codereview.qt.nokia.com/1249
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-07 10:37:04 +02:00
hjk
4823487b59 analyzer: fix control/dockwidget construction order 
Change-Id: Id39c55617c6441b221fc321d71e73168f2b3e4bd
Reviewed-on: http://codereview.qt.nokia.com/1245
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
 2011-07-07 10:36:44 +02:00
hjk
38c7f981cc analyzer: postpone selecting saved tool 
... until the analyze mode is actually selected

Change-Id: I7d03c48a4b4260d54bf3218b3a493ceacd2d2967
Reviewed-on: http://codereview.qt.nokia.com/1243
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-07 10:33:17 +02:00
hjk
8d8d9d4645 analyzer: directly start tools from menu 
Change-Id: I385abbd906e975b75b1c01e597b6e366c5c57126
Reviewed-on: http://codereview.qt.nokia.com/1180
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
 2011-07-06 12:41:44 +02:00
Christiaan Janssen
45212d3c1a QmlProfiler: handling start/stop actions 
Change-Id: I940025ba1f35f6136b4a12936b9e508ccb9d0d1f
Reviewed-on: http://codereview.qt.nokia.com/1160
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-05 13:13:00 +02:00
hjk
a89158b887 analyzer: handle all possibilities to start qml profiler in QmlProfilerTool 
Change-Id: I286bdc4dc3fbab2e784e72f47ff02644cc2899e5
Reviewed-on: http://codereview.qt.nokia.com/1096
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-05 12:12:21 +02:00
hjk
be452fcaff Revert "analyzer: move convenience factory back to base plugin" 
This reverts commit 06a41da04e.

Change-Id: I06a41da04e726ffd35da18d99cd2f46cb99467bf
Reviewed-on: http://codereview.qt.nokia.com/1094
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-05 12:09:25 +02:00
hjk
06a41da04e analyzer: move convenience factory back to base plugin 
Change-Id: Ife82b74ce4b457dd9e6a6cc3749cb629aeeacf58
Reviewed-on: http://codereview.qt.nokia.com/1086
Reviewed-by: hjk <qthjk@ovi.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
 2011-07-04 16:23:38 +02:00
hjk
36a3028b9d analyzer: refactor progress 
Change-Id: If74c8035bc83a8113c2a15dcacefa38afbbbb4d8
Reviewed-on: http://codereview.qt.nokia.com/1056
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:02:36 +02:00
hjk
2086d94866 analyzer: finish split of tools into "tools-with-modes" 
Change-Id: I82b61c07172a33b861a7d6db903ac2516019498b
Reviewed-on: http://codereview.qt.nokia.com/1054
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:02:13 +02:00
hjk
d6bf0c3732 analyzer: remove dummy control widgets 
Change-Id: I9c15e557699f2f321619fb07feea8d4489006c83
Reviewed-on: http://codereview.qt.nokia.com/1053
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:02:01 +02:00
hjk
fd370662ba analyzer: cleanup mode construction 
Change-Id: Icdb89bb581a234820e0c6318f20f8e033ed7b3f0
Reviewed-on: http://codereview.qt.nokia.com/1052
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:01:35 +02:00
hjk
f0a0e5b1ea analyzer: move responsibility for run modes to individual tools 
Change-Id: Iaf2fa9d4c087470649336a453c6a9a7db12d220f
Reviewed-on: http://codereview.qt.nokia.com/1051
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:01:25 +02:00
hjk
daefb0c83a qmlprofiler: simplify plugin construction 
Change-Id: I26fe148669656637a82a30012e8632b105d4f073
Reviewed-on: http://codereview.qt.nokia.com/1050
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:01:13 +02:00
hjk
99d9f065b3 analyzer: refactoring of analyzer manager 
Change-Id: I60268b8bc86e439beb3fca8f4b6a87ea03925bad
Reviewed-on: http://codereview.qt.nokia.com/1049
Reviewed-by: hjk <qthjk@ovi.com>
 2011-07-04 12:01:00 +02:00
hjk
bbe427ac1f analyzer: reorganize local/remote starts 
Change-Id: I6273ea7ea50fd2bddad3a627e4616fe93e8398b9
Reviewed-on: http://codereview.qt.nokia.com/921
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-29 18:44:46 +02:00
hjk
5ab3d58cce analyzer: remove unused DockWidgetEventFilter 
Change-Id: I0ddcd555efc900905703669040f792fb7c4d95c9
Reviewed-on: http://codereview.qt.nokia.com/909
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-29 16:27:52 +02:00
hjk
b6c0f3d8a6 analyzer: refactor AnalyzerManager 
Change-Id: Id925bb638b2757ef079c21192d4e2a8cc8f08694
Reviewed-on: http://codereview.qt.nokia.com/908
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-29 16:27:39 +02:00
hjk
4ead16afcd analyzer: dissolve "Start" menu button 
Icon missing.

Change-Id: I85f9f6361a336260e731f71aab037ac60c4a1aac
Reviewed-on: http://codereview.qt.nokia.com/894
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-29 13:19:37 +02:00
hjk
c43f3c848f analyze: create a top level menu entry 
Change-Id: I17c4d17583d401fb537d5956f5b07a1dc12906e1
Reviewed-on: http://codereview.qt.nokia.com/893
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-29 13:19:24 +02:00
hjk
a9f53ec9c5 analyzer: remove output pane 
It's all dockwidgets now.

Change-Id: Ia47ca9331fdfbe12ca11f77c26afc35e73a2fae3
Reviewed-on: http://codereview.qt.nokia.com/776
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
 2011-06-27 16:17:11 +02:00
Friedemann Kleint
a56162ec6e tr()-Fixes for 2.3: No contractions, spelling. 
Change-Id: I08babdb15bcf7f7ac086e9e12955b780b7591391
Reviewed-on: http://codereview.qt.nokia.com/480
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
 2011-06-14 17:18:48 +02:00
dt_
42e5e5f00a Show tooltip on disabled run actions 
Change-Id: I9b5eaa49e14b71b9d1f8ac84aa7cb7bb4d014cac
Reviewed-on: http://codereview.qt.nokia.com/192
Reviewed-by: hjk <qthjk@ovi.com>
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
 2011-05-27 16:58:05 +02:00
hjk
10317564f1 analyzer: simplify dockwidget setup 
Change-Id: Id450ee1d6ad24707536f9b35e7868e5f8ce9dab2
Reviewed-on: http://codereview.qt.nokia.com/59
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk
 2011-05-23 14:57:53 +02:00
hjk
251bff8a9c analyze: rework 'addDock' 
Change-Id: I3ce22c3f75d5cc631ab22e02f8a52af00452c0c3
Reviewed-on: http://codereview.qt.nokia.com/57
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk
 2011-05-23 14:57:40 +02:00
dt
e5a42e2dc0 Remove unecessary include 
Change-Id: I25171ca3f2d1e69be289ea6c40f5a063b3244868
Reviewed-on: http://codereview.qt.nokia.com/61
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
 2011-05-23 11:56:56 +02:00
hjk
c31bc05e2e analyzer: make output pane not pop up automatically in all cases 
Change-Id: Ief96ab7093d78915087a273f3eff0b4489c3b370
Reviewed-on: http://codereview.qt.nokia.com/30
Reviewed-by: hjk
 2011-05-20 11:00:28 +02:00