Commit Graph

72643 Commits

Author SHA1 Message Date
Thomas Hartmann
d7c330d454 Fix crash when widget was not created
We only create the actions in case the widget is actually created.
m_projectModel and m_sessionModel are intialized as part of the
SessionsPage widget.

Task-numnber: QDS-6332
Change-Id: Ib127de69ca4057c229bf977c012e5cd2b2a53f0d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-01 08:55:05 +00:00
Christian Stenger
869ad16d04 Squish: Remove outdated condition
Change-Id: I89029f50cc0a303111f9960eac3f3c17b4c05fb0
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2022-03-01 08:54:43 +00:00
Björn Schäpers
0803390a83 QbsProjectManager: Directly delete project parser
It holds a pointer to the future which is deleted directly 3 lines
below. And a signal (taskStarted) can come to the parser before it gets
deleted, then accessing the deleted future. Which results in a
segmentation fault.

Change-Id: I468c6477023488d6d922d6bf621cba886740d8f4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-28 19:29:56 +00:00
Leena Miettinen
fc82e593af Doc: Update Qbs settings
Task-number: QTCREATORBUG-26610
Change-Id: I98261c9fa36f34d8b13a2b12a3a545f6662916b5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-28 16:56:58 +00:00
Oswald Buddenhagen
691e3ff12d fix markup
Change-Id: I87f316aeff1d30c6df5758b7384c1020d8f7e55c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-28 16:54:41 +00:00
Leena Miettinen
659d82c499 Doc: Fix broken links when building with Qt 6
Some section titles have changed in Qt 6 and some
platforms and modules are not supported. Where necessary,
use fixed links to Qt 5 docs.

Fixes: QTCREATORBUG-27015
Change-Id: I469a630731f9c37deffe5ca454f5365310aaf713
Reviewed-by: Tommi Mänttäri <tommi.manttari@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2022-02-28 16:05:01 +00:00
Mats Honkamaa
741a2de6b9 Doc: Document toggling visibility of menu items
Debug, Analyze, and Build menu items are invisible by default.
Visibility can be toggled from Options.

Task-number: QDS-6372
Change-Id: I5134868e8cd08c229b6c3a8ff3c53a1cc67949ab
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-28 15:08:45 +00:00
Mats Honkamaa
e19fa8ba96 Doc: Fix link in particle tutorial
Broken link to the particle tutorial project.

Task-number: QDS-6387
Change-Id: I26f59fb1b8f935c384219623621204009302d86f
Reviewed-by: Tanja Remes <tanja.remes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-28 14:43:46 +00:00
Leena Miettinen
8ca2c21087 Doc: Move file about components and properties supported on MCUs
..from Qt Creator to QDS. The Components view is no longer
visible in Qt Creator by default. Moving the file makes it
easier to find its contents during search.

Change-Id: I340d54e990a4e5c09a51b94fe64f3b0e951911ff
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2022-02-28 14:26:51 +00:00
Leena Miettinen
a6c44fdb1c Doc: Remove remaining referrences to Library view
The view was divided into Assets and Components views.

Task-number: QDS-6216
Change-Id: I5a73f60e511bb2936a009bbe6f61004f9d85d348
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-02-28 14:26:45 +00:00
Christian Kandeler
d60c8787cd CppEditor: Only open refactored file in editor if we have a position
It's just confusing to the user otherwise.

Fixes: QTCREATORBUG-27114
Change-Id: I127d97ca165af0eb751cd6479d0ec0ffec480c17
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-28 14:24:31 +00:00
Mahmoud Badri
5d770bc8c4 QmlDesigner: Fix overlap of empty assets placeholder and search box
Change-Id: I959073fb037fad6d960821297d8546951e748343
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-02-28 13:33:27 +00:00
Thomas Hartmann
09f9ed14eb QmlDesigner: Always initialize design mode widget in QDS mode
This ensures all actions are registered after startup and
accelerates opening the first .ui.qml file.Adding

Managing the actions does not belong to the DesignModeWidget.

Task-number: QDS-6326
Change-Id: I02cb4a6d9e5a88d8136eb58fed7882177d7a15e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-02-28 13:14:20 +00:00
Alessandro Portale
736cca6a40 Welcome: Fix issues with handling of mouse presses on tags
1) Handle all clicks anywhere on the item area. If a tag gets clicked,
   handle that, otherwise always open the item.

2) Ensure that m_currentTagRects is up-to-date. It sometimes contained
   the tag list of another item. Now it is handled in the same way as
   m_blurredThumbnail.

Task-number: QTCREATORBUG-27106
Change-Id: I394ceb55987f903d17254225b69cae347021f78c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-28 13:03:55 +00:00
Thomas Hartmann
89194dbe72 StudioWelcome: Show restart dialog if option is changed
Change-Id: Ic52167cecc771718063a27d73874e737597ff7f0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-28 11:48:26 +00:00
Eike Ziller
ea908bb941 Fix Qt5 based build
Change-Id: If6dfe191a1da52e9bd8ff04d86c5fe3dbda426b9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-02-28 11:20:20 +00:00
hjk
a8c36bd547 SdkTool: Change style of test initialization for devices
Easier to see what's going on and easier to extend.

Change-Id: I3c95d4b56fef8ae9dfd017ad98f9c12dbeae2242
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-28 11:17:53 +00:00
Cristian Adam
2f77dc3415 CMakePM: Proper handling of the extra generator
CMake fails if it has -DCMAKE_GENERATOR:STRING=CodeBlocks - Ninja

It expects separate values:
  -DCMAKE_EXTRA_GENERATOR:STRING=CodeBlocks
  -DCMAKE_GENERATOR:STRING=Ninja

Fixes: QTCREATORBUG-27060
Change-Id: Ia2b5bdc425e569118d689b7223fbef5f953d98a7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-28 10:36:17 +00:00
Christian Stenger
59d659b2ef McuSupport: Enable tests with qbs build as well
Change-Id: I2f547e20234b6d31587241daadc7eedeecdc3e15
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-28 10:22:58 +00:00
Christian Kandeler
1ae417fe57 Update qbs submodule
... to HEAD of 1.22 branch.

Change-Id: I8f813794dca90f99bd46edaa8e9931628eacf4b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-28 10:12:12 +00:00
Christian Kandeler
adf97c4b70 QbsProjectManager: Consider cpp.cFlags and cpp.cxxFlags
Amends 0dc87382e9.

Change-Id: Idb65fb3ab5a528c4cb2ad7a49a9ef02c0ab09dc7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-02-28 09:41:59 +00:00
Christian Kandeler
22fb18c0a8 LanguageClient: Speed up DiagnosticManager::showDiagnostics()
- Do project file look-up only if we have diagnostics.
- Move hash access out of the loop.

Change-Id: I9dd03dbfe8d7515e731cbeb0ce51639d9df993b4
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-28 09:40:08 +00:00
Mats Honkamaa
2a4c149e49 Doc: Update docs related to Library, Assets, and Components view
The Library view has been removed and replaced by the Assets
and Components view.

Task-number: QDS-6216
Change-Id: Iad2454196898ca0d6631a6bd6261c02d1bad98ac
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-28 09:05:23 +00:00
Leena Miettinen
8828e6c22d Doc: Update info about custom wizards
Some option values in the wizard used as an example have changed
and some new options have been added.

Task-number: QTCREATORBUG-26610
Change-Id: I7cf3f5f6d45e4854e547a2fd2bb41b24642578ae
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-28 07:47:29 +00:00
Christian Stenger
4e57609dc7 PE: Avoid device compilers while handling local toolchains
...and fix environment used when processing them.

Change-Id: I457c31e195f41ca2edf105229f2818dddd2f5df0
Reviewed-by: hjk <hjk@qt.io>
2022-02-28 05:58:36 +00:00
Thomas Hartmann
49a7ada03f QmlDesigner: Remove superfluous code
Change-Id: I0f2c746130b768844307798007fc1192e0dd2939
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-25 19:53:52 +00:00
hjk
32590af686 Docker: Accept more ways to identify a docker FilePath
Accept (percent-encoded) repo:tag, the image id or the device id as
host() part of a docker FilePath.

Task-number: QTCREATORBUG-26856
Change-Id: I27d374be31d54bab77d129e19884b7f7fd93daa0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-25 15:33:56 +00:00
hjk
4ca780ccb3 Utils: Use simplistic percentencoding for host parts of FilePath
Host parts with true slashes (as possible currently for docker ids
using the repo:tag style) breaks parsing in FilePath::fromString.

This provides a means to use such names nevertheless.

Task-number: QTCREATORBUG-26856
Change-Id: Iba3568c5708fe495d0dd657540f30a2519e7f45f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-25 15:33:47 +00:00
David Schulz
f334bd422e ClangCodeModel: prevent text mark annotations in non project files
Since non project files get opened in project specific clients now, the
check whether we should add annotations needs to make sure that the
marks file is part of the client project.

Change-Id: I2790d0f7feb39162686efd06bb3542684d289b95
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-25 13:01:40 +00:00
Christian Stenger
65a6853aec QbsPM: Avoid QFileInfo for paths that may non-local
Change-Id: I08b0b2c298c8f175e0c0a2d5e87691354afa46e5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-25 12:18:27 +00:00
Christian Kandeler
61351da56a ClangCodeModel: Add convenience function
... for creating a highlighting result from a clangd AST node.

Change-Id: Ie1fcfeee5d6b4c562143fce56498ce92a7b4fddb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-25 11:53:59 +00:00
Christian Kandeler
64a1bf6c43 ClangCodeModel: Properly highlight built-in defines
These are not reported as semantic tokens, so consult the AST

Task-number: QTCREATORBUG-27111
Change-Id: I38efcfbdc3197173a50033a74a1bc631eaa8d2c1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-25 11:53:39 +00:00
David Schulz
4d10a2df36 Editor: only start block selection if alt and shift is pressed
Since it is a selection the shift modifier should be part off the
shortcuts and the old block selection also required both modifiers.
Additionally this prevents creating a block selection by accident when
there are no items in the editor history since alt + arrow left is
mapped to go back in history by default.

Change-Id: I46b0753a737f1e1b3c980d2e959bcf7b4733d790
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-25 10:25:30 +00:00
Cristian Adam
47667772c7 CMake: Enable higher compiler warnings for building Qt Creator
The functionality comes from Qt6 and will be enabled only for Qt6 builds.

/w3 level for MSVC, -Wall -Wextra for the rest of compilers.

Change-Id: Ib62a27e50ce37a6a860ba2bfa1bdb80a7ae60ace
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-25 09:54:49 +00:00
hjk
79726e52d6 SdkTool: Add --builddevice option
Useful in a docker context.

Change-Id: I297654a9d65da2ce7d89b4ed8322d2ea0c80b3a2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-25 09:32:35 +00:00
Christian Kandeler
1a99f41fe8 QbsProjectManager: Call qbs-config directly
It's slightly faster than going through the qbs executable first.

Fixes: QTCREATORBUG-27102
Change-Id: I13297e700fed43b20e1d1185dbdfc16152584d56
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-25 09:30:06 +00:00
Leena Miettinen
ace0a0d9d1 Doc: Add CLI options
Make the wording and capitalization of existing docs more
consistent.

Task-number: QTCREATORBUG-26610
Change-Id: If241a951ce4df757a1b26524dee412ef44bbfa4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-02-25 08:54:18 +00:00
hjk
b178e407a4 SdkTool: Make auto test easier maintainable
Adding new kit items so far required touching test code in several
places.

Also, use more but simpler individual tests to find failing tests
quicker.

Change-Id: I540b93c01a6bdbb85353928713995c262dfc919e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-25 08:41:05 +00:00
Thomas Hartmann
44aba26a47 StudioWelcom: Slight increase in margin in SplashScreen
Change-Id: I5ea3642134ea9ff76e9dc40cc0319933c26f9fc1
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-25 08:34:47 +00:00
David Schulz
967b1d237b ClangCodeModel: remove ClangdTextMark safety net
Since all text mark created by the diagnostic manager get deleted
properly on destruction now, there is no need to react on the client
destruction in ClangdTextMark.

Task-number: QTCREATORBUG-26585
Change-Id: Ifb9b8546c8f0d94debdcf2c8de6081e4e731cfab
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-25 05:34:30 +00:00
Tim Jenssen
b58c57fb3f crashpad: disable calling crashpad_handler on arm64
Currently, the none arm handler binary is hanging and
needs further investigation.
Maybe a complete universal build will fix this, and
we can enable it again.

Change-Id: I60b5623d8dda500a3be3efd095f91a9609600324
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-02-24 16:27:34 +00:00
Christian Stenger
5ce07a2345 Scripts: Fix uichanges script
Amends 394bfb508f.

Change-Id: I6e933f8bc18298b81b99a716e734d84fbd2b7528
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-24 14:35:37 +00:00
Christian Kandeler
86f1864d3c CppEditor: Catch another project pointer access from a thread
Amends 33108795d6.

Fixes: QTCREATORBUG-27044
Change-Id: I53d716355b0784841fd8d965c8af14fe321c33de
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-24 14:28:23 +00:00
hjk
1172eeb060 ProjectExplorer: Introduce device://<deviceid>/...
... to identify a device in a file path.

For use from the sdktool.

This is an addition to the pre-existing way to identify devices
using e.g. docker://<id> or ssh://<ip>/

Change-Id: Ice5481eab550b2fe39eda4c6d74d9c46fa6b6626
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-24 14:27:57 +00:00
Christian Stenger
3ae6f41c3f Squish: Adapt to changed UI
Change-Id: Ie25ba8a72b7fd93f60f04303ed223e7cdf2406af
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2022-02-24 14:04:51 +00:00
Mahmoud Badri
c077f42e23 QmlDesigner: Fix imported meshes don't appear in a model's source
Fixes: QDS-6329
Change-Id: Iec70492d8dfce4f8a0ce05cbd16991f70b9eb985
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-24 13:02:21 +00:00
David Schulz
0ce098ed87 WinRt: enable plugin on Windows 11
Change-Id: Ie935b1baaa4331499143de4eb3fb9bd57b38c347
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-24 10:00:35 +00:00
David Schulz
3cf6d15096 LanguageClient: track all created diagnostic marks
Removing a block results in taking marks of that line out of the
document, but does not delete those marks. So we cannot rely on
iterating over marks of a document to delete all marks for a specific
file. Instead save all marks from text mark creator for a file path and
iterate this list to delete diagnostic marks.

Fixes: QTCREATORBUG-26585
Change-Id: Idc41fce5de4ade68f4a29c23ba02844701b44d3c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-24 05:25:25 +00:00
Thomas Hartmann
ee4757a8e8 QmlDesigner: Use LoggingCategory in ImageContainer
Change-Id: Ibdce399fc2df19883d6ffd12e9441c58d46035ec
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 20:47:09 +00:00
Mahmoud Badri
787bbfaf1c QmlDesigner: Fix path when importing a 3D model inside a component
Fixes: QDS-6319
Change-Id: Ia9dbdf9a2d32eaf996cca2ba84e89ca8111dab1c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 18:48:06 +00:00