We always jump to the node offset even if the curser is inside the block.
Before the selection was not synced if selecting a parent item.
The selection was never synced if the root item was selected.
Task-number: QTCREATORBUG-19027
Change-Id: I0f7b4099488b6335588498f64e28e186898a7d25
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If the keyboard is used (delete) the list can be empty.
Change-Id: I7f67388d1af84091c8bc8b9a54345bb02dbf6ee2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Documents that do not have a file name associated or are marked as
temporary should not be synced with, to avoid unnecessarily switching to
the "Computer" root. Examples are the VCS log and commit editors.
Change-Id: I6bc970eb026bf257b405fbc329aed3a5f4a456c0
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
We need to create the regular expression based on the split off file
name, not the whole search term.
Task-number: QTCREATORBUG-19129
Change-Id: I4df375e992ce2b9a64a9c8f2c12b953f66a9444e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Add QT_HOST_BINS to PATH before starting the puppet. This is necessary now since
the kits no longer add this via the Qt version.
Change-Id: I155b01b43517a3fd0b2936ff33709d9e6fad3f88
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
I doubt this has been used in the last five years.
Change-Id: Ia81cacfead1d15f77cb7e1e438ebcd59a238af70
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The current Gerrit dialog is too high for my 1366x768 screen, and
therefore it either misses the title bar or the confirmation buttons.
This change reduces the minimal height of the "changes" and "details"
sub-widgets proportionally.
Change-Id: I548e1e04bb47b881bee55e28bf362a84ae11a87c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Less code in the target implementations.
Change-Id: I759f082eba5eab7f4e8252c0d7b5ec64059ba860
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Parts of the Debugger engine rampdown mechanisms are
essentially one code path now, don't distribute that
over four classes.
Change-Id: I4c6edbc0db94d1f658b0c1d9c154552f286db876
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Especially when using CMake based projects in combination with GTest
we might have lots of build targets defined inside the same
'project file'. Overwriting the already assigned content is purely
wrong. Instead handle each found build system target on its own.
Task-number: QTCREATORBUG-17882
Task-number: QTCREATORBUG-18932
Change-Id: I3297a9e1da8ae4186fd4267e3485368b1a059314
Reviewed-by: David Schulz <david.schulz@qt.io>
...and maybe other cases.
Since
Clang: fix findStartOfName handling
commit 82d0650b11
the proposal's base position was calculated wrong. As a result, an early
return triggert in CodeAssistantPrivate::displayProposal (call to
newProposal->hasItemsToPropose(prefix, reason)) and no completions were
displayed.
Fix by ensuring that the added code from the mentioned commit is only
called when needed, namely only for function expressions.
Task-number: QTCREATORBUG-19083
Change-Id: I8f23c9b7186f9d81159939c8b3ef475a09bbe760
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Do not unconditionally prepend QT_HOST_BINS to PATH as part of the Kit
setup.
Prepend this directory to PATH in the Qmake- and GenericBuildConfigurations
instead.
Task-number: QTCREATORBUG-18714
Change-Id: I1c1d1362105b82f9c369d989e90d4f7079c2c9a2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Make it clear that emitEnvironmentChanged also updates the cache of the
current environment.
Change-Id: I012c5a2b3d7d4037ed609b26e053ce0ce36f6cec
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Use logic more similar to
BuildConfiguration::prependCompilerPathToEnvironment
Change-Id: I24935cc354f136b19ec71afd6e8a4d795446db4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
