Felt application startup time should be decreased
not increased.
Change-Id: I67129ad7632836771cdca968e736d03bf34594ea
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Avoid conversions when they're not needed.
Change-Id: I7e996bc6e87be4327d75f0d743ff2de38d6ccc32
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>
Don't close the process/thread handles, so that the kernel doesn't free
the resources before ConsoleProcess is able to obtain handles to them
- this would be a problem if the child process exits very quickly.
Also remove the superfluous free(env) for consistency.
Task-number: QTCREATORBUG-13042
Change-Id: Ie25eeab71cd9dfd69831c37e4f02477446486309
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
SmallString is a very simple utf8 string class. It's purpose is performance.
It uses a short string opimization which provides 31 bytes of heap free
memory to save a 30 bytes long string plus null terminator. If the string
gets larger heap is allocated. The grow strategy is 1.5 to improve reuse
of allocated memory.
It uses optionally constexpr to provide string literals.
Change-Id: I7757fb51abfeca200d074cbfce2f1d99edc0ecb0
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
You should not not copy it anyway and it provides problems if you use move
only data types.
Change-Id: If9eab1ca265d89ccab9d947a534820da359d6054
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
We may not access command() from a different thread, since it is not
thread safe.
We can also report the result just through the function return value.
Change-Id: Ib20c062f6541400040868b65308d9b2d2bd382d8
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
parameter cannot be called stderr, if it is not that stderr.
Change-Id: Ifdfbbd650ec7fe6aa9ce560ace96fbe65961c0b5
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
...at the end of the line, just like for the "Apply Function Signature
Changes" refactor action.
* Hovering the light bulb shows the tooltip "Inspect available fixits".
* Clicking the light bulb leads to the refactoring menu, as if the user
hit Alt+Return.
Change-Id: Iaf7b3734c43e21fc28e6b0658f517d98858c0e0c
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Astyle writes it to different streams on different platforms
Change-Id: I3775ec31a9c31574bade79cdd8abfd7d14076859
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
We want the signal from the base class to be sent.
Change-Id: Ic681b3b8527b849f5edd9fec476e5e9e1768408a
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
The number of child diagnostics (notes) can get quite high, consider:
error: no matching function for call to 'someFunction'
note: candidate function not viable: no known conversation from 'X' to 'Y1'
note: candidate function not viable: no known conversation from 'X' to 'Y2'
...
If there are more than 10 child diagnostics (notes), show only the first
7, an ellipsis and the last 3 of them.
Change-Id: Id74e60f5872fb9aab0cfcb956e9b740456937dac
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
If we have a text editor for the source document the errors will be
highlighted in the editor then.
Change-Id: I02ed24783e7079c3d2cb308d8111b399cd77adb1
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Allow for different extra compilers which may get called to generate
additional code for the code model. The build system is expected to
know what files are generated from which source file and the extra
compilers know how to generate the content of those files, without
touching the build directory. the uic adapter is refactored to be
the first such extra compiler.
The extra compiler is run when an editor for its source document
loses focus, or after a timeout of 1s when the source document has
been changed.
Change-Id: I13c110c61120c812f02639a3684144daf8979b37
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Copying of the results is quite costly, so reduce this to a minimum.
Change-Id: I8db3bcd72c34ddd0bdc622ec3f2fd538c9679955
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
...otherwise update existing. This reduces the number of items
that would get created or destroyed especially while modifying
code or just open/close test related documents.
Change-Id: Ia6a03ec33550c8c28e5120422e0f68fa428c1020
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
If the wrong signal was sent the desired slots weren't invoked. The
effect was that clicking on entries in the statistics view didn't take
you to the right source location anymore.
Change-Id: I187c3e53969558fb7992bb44f868c9d8730eaef7
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Change the item view to a QListView and use a model derived from
QAbstractListModel keeping a QVector of entries. Use a QSortFilterProxyModel
for filtering.
This makes cleaning old documentation easier.
Change-Id: I3a0781e0ddff3d0c00126a1b4effe1e1c93e354b
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
When the directory is root (on both Windows and Linux), it ends with a slash,
and yet it is valid (although unlikely to be managed by VCS).
Chop the slash to avoid soft assertions.
Change-Id: I0f206b5a7ee70e9c641ff872fa21662f9d92aab2
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Scan through the build.ninja file once for all targets instead once
for each target. This improves CMake project loading speed for
projects with many targets and a large build.ninja considerably.
Change-Id: I857c48a714dbb39a469f81c1f951a77f2f57578e
Reviewed-by: James Legg <jlegg@feralinteractive.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
We will need them for more things than ui_*.h.
Change-Id: I394aa8646095cdafb426c15746243b27c1c1ab1b
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
QtConcurrent::run is now replaced by Utils::runAsync with more features
and maintainable implementation.
Change-Id: Id7ad1fd723d41cbff62ecc557b85b59d70980934
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Use Apple related terminology correctly.
Change-Id: Ib71fa5a080586027b3be8303ba5b7cf8058e669c
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Avoids global thread pool and is better maintainable
Change-Id: I5d5ffe66918a3e0ec95c1ab7c6b9d964f7a8de2f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
* Disable the BC and give report the cmake error
* Show a warning label in the BC
Change-Id: If5737d033fa2682c264ab7ac1189c59947e3b28d
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Store CMakeConfig in CMakeBuildConfiguration instead of the list of
initialArguments.
Update initialArguments to a list of settings on load.
Change-Id: If58fc38296a4627f40062dd407e684c8a9477f6e
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Read the configuration from CMakeCache.txt files.
Change-Id: I7ddf9c9727420634086c973d0134059aac37ace0
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
