Commit Graph

5 Commits

Author SHA1 Message Date
Alessandro Portale
55615e83f5 Utils: Avoid line breaks in variable chooser tooltip
By wrapping the html into a div with style="white-space:pre".

Task-number: QTCREATORBUG-27553
Change-Id: Ie8c4dcbe48d714fe72949afb841e5b4844e12cd1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-17 07:17:26 +00:00
Artem Sokolovskii
efd25fb43f Utils: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Ic72d173d95376276df8d1f08abdaec8370aff2ba
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-02 08:54:36 +00:00
Alessandro Portale
8dcb5097f5 Utils: Ensure that VariableChooser window title bar stays on screen
Prevent negative y-coordinates when centering the VariableChooser
over the launching toolbutton.

Fixes: QTCREATORBUG-27054
Change-Id: I4212c7120470f8c2014fbe27205de8430cd13a6f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-14 09:01:05 +00:00
Alessandro Portale
81f3452e1c Aggregation/Utils/ExtensionSystem: Make member functions const/static
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.

readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.

readability-static-accessed-through-instance fixes the places where
the originally non-static, now static functions were called through
instance.

Change-Id: I8cf16c01f7988a7c9d073b5f8ede6a9706b94fb0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-27 09:16:08 +00:00
hjk
cec468d78a Utils/ProjectExplorer: Move re-usabled bits of aspects to Utils
Classes involved are BaseAspect and some derived classes,
LayoutBuilder and VariableChooser.

This is mostly mechanical, with various include/using changes
to make it compile.

Change-Id: I624a457f3555f102e541c4c71e33a9423af32250
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-09-23 07:44:42 +00:00