The original version might have missed to recognize a @\r\n
combination or multi-byte UTF-8 code units when they were
split across to readyRead() handlers.
Change-Id: Ib543fa0070b63d25b44be429a3759964d65e878e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Use std::unique_ptr instead, as QScopedPointer doesn't offer release().
Change-Id: Ifbe42dca5b266930e1000a50441995023b89b802
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When resolving a conflit the key line got removed by mistake.
Amends 51998c5239
Change-Id: I74af26d23e7ac0180d1b351d7ecf6d6876499d89
Reviewed-by: hjk <hjk@qt.io>
If the user clicks on a row's column holding a location
information then use this explicitly instead of always
using the first available link.
Change-Id: Ifecbecac632a4bfd4d31614a8c43ab6c80de4819
Reviewed-by: hjk <hjk@qt.io>
We were accumulating copies of the auto-detected system ninja setting
since the QVariantMap retrieved with toMap() was empty as it is a Store
nowadays.
Change-Id: Id983b5f1bf5ff18d6f43a71ebb406520e7655705
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
After encountering the namespace keyword, we have to backtrack the state
change introduced by the inline keyword.
Fixes: QTCREATORBUG-22071
Change-Id: I543976622d1a56b2c61d68da6ec3eee8b6d0d5b3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Palette colors may not be correctly populated depending on the
platform, so use some common available one.
Change-Id: I5f660aaefbd5882a255da4a25c3e15edc3fe3643
Reviewed-by: hjk <hjk@qt.io>
When vanished targets where shown in Projects, clicking on the project
specific settings showed a blank page.
There were hardcoded indices for the target and the misc settings. Get
the right child for the index directly instead.
Change-Id: I725d470ad04f8a227c91938efada76a757a7442c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This allows to get back to a 100% font zoom with the keyboard shortcuts
by zooming to an odd zoom factor by other means.
Change-Id: Ie90853367b17c207e9c47fc108b8d6f451e0f838
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
You cannot use a .shared file to share CMake project settings.
Change-Id: I605ead2f42ed012da789c1eef3a4e6a51de62243
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Since recently cdb seems to report messages without a final new line.
Change-Id: I6b15d6c5668b7a4bec207d56d86da5a0afa77cb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This way the user can trigger the "Show Menu Bar" action when the
Ctrl+Alt+M doesn't work.
Task-number: QTCREATORBUG-30114
Change-Id: I4e1d14b7bf7554ce1a262c4b1d2671f8d0b81b85
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
For now this enables just the single column sorting,
but this is supposed to be enhanced by multi-column
sorting and filtering later on.
Change-Id: I7603ae5c412d7a0a669d1ba4ba7e001a059056f4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Don't call setTableDto() directly from tableInfoRecipe's handler.
Store the new table dto in the handler and update the Gui afterwards,
on task tree done.
Fixes: QTCREATORBUG-30429
Change-Id: Id267c8375bf7c9a107450ac34ecba37d696f45e1
Reviewed-by: hjk <hjk@qt.io>
CMake build disables anything, so we can disable a specific warning
as well.
Change-Id: Ia350d96708f371323499d645f8cc31e07e4d6c9d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If the issue kind has multiple path columns filtering by path
failed as it used just the single path filter.
Use common approach for all.
Fixes: QTCREATORBUG-30420
Change-Id: I60460cebdc4a39b9af57c4f1331cb8cb9eedb67a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Use "convert to", and the standard is ASCII
Change-Id: I0a687f9bcb8f2c97932a03b45e10a80adbd993dc
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Might be annoying when typing in filter field when storing keychain
isn't full functional.
Change-Id: I36a1a8e8e8eefcea381a6392e3df032648ed8dc4
Reviewed-by: hjk <hjk@qt.io>
The commit 1180d5b8a270cfe7bd1c501c892d1c38ee7425de added information
about the ndk and android api level used at build time, ndk version has
already been accounted for in b73d6f3be8.
This now accounts for "platforms;android-xx" and "build-tools;xx.x.x"
packages.
Fixes: QTCREATORBUG-30404
Change-Id: I78b8885b88294404bc29c41a7b9491a331fcd709
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Added missing full stops and capitalization.
Changed "Appman" and "AppMan" to "Application Manager". It is "Qt
Application Manager". "appman" (all lowercase) is the daemon executable,
which I think we never actual refer to in the UI.
Change-Id: Icb9a192084c13f96d9faef0a3d4617a4d194c624
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
