Commit Graph

80529 Commits

Author SHA1 Message Date
Leena Miettinen
be138dee10 Text editor: Fix typo in UI text: temporary > temporarily
Change-Id: I45c7cfb62556f5f3dead9d90e1fe911752ca72a7
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 16:51:43 +00:00
Leena Miettinen
708c629133 Utils: Use double quotes for emphasis in UI text
Change-Id: I00b27ee40ba131ec6472b03ac7f23c93639a9cea
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-24 16:51:27 +00:00
Marcus Tillmanns
a62c5cf89a Utils: Cleanup searchInX functions
Also move some often used types into new file "utiltypes.h"

Change-Id: I3f152d1dc2f96ba0259ad6c098d9ac5ee03a59f1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 15:13:32 +00:00
hjk
7f04a66546 Debugger: Introduce a cache for pre-rendered value columne entries
Change-Id: Ibdcac8a5ccaa3eab0723205b913056530c510280
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 15:08:20 +00:00
hjk
f2f5e4d030 Utils: Save a few cycles in BaseTreeView column width computation
Change-Id: I5e97cae77db58a396424f5081838d2b2f3769ba7
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 15:07:23 +00:00
hjk
f53f006301 Debugger: Use QVarLengthArray for local buffer
Change-Id: I1bca338e0ffb850ca23bf5e1d1cd2fb85227ddda
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 14:58:20 +00:00
hjk
a1e9670541 Utils: Simplify tree view columns width computation
... by using approximations of the value widths instead of precise
comuptation.

Change-Id: Ia7eefad8d79f09d1e0cfda32067d052f56b820a9
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 14:58:13 +00:00
Miikka Heikkinen
26e2342e24 QmlDesigner: Don't change focus on expand when focus is in search box
This is to avoid search box focus loss if search autoexpands sections.

Fixes: QDS-9259
Change-Id: Ief99643d52413fe83d4b5ac5ea3438d6116d64c7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-24 14:41:49 +00:00
Marcus Tillmanns
c6dc54b343 Terminal: Add Shell option menu
Change-Id: I08ea3c52ed28ab65f2dc902051bab9e6975e6a7e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-24 13:37:14 +00:00
Jarek Kobus
58abb397e7 AttachCoreDialog: Use QPromise for async calls
Change-Id: Ib0dd9ceb21711a786dc84acc815d1a5afb557de7
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 12:49:31 +00:00
Jarek Kobus
8eaf73700e TaskTree: Don't call storage done handlers from TaskTree's d'tor
Change-Id: Ie2b04d433be3452f9e668efd3341dedfcb154290
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 12:48:44 +00:00
hjk
97b97825ed Debugger: Also log time stamp when handling output is finished
This helps to put the blame properly on either side of the
communication.

Change-Id: Id83de2bce1984f63427f655dce854ebb008a1a61
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 12:46:15 +00:00
hjk
6cd8bca691 Debugger: Simplify gdb output parsing structure
The base problem is that gdb output is weird outside the 7 bit
ASCII range. Could be true UTF-8, or \x encoded UTF-8 byte
sequences, i.e. three layers of encoding.

Change-Id: Id9ee4bd4a8979624f9682f28064c3ac599afe4b9
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 12:46:01 +00:00
hjk
040ebf8171 Debugger: Suppress a message clogging the log view
Eats time and won't be handled soon.

Change-Id: I777bef10397d0d67daf576862975c4d4f1184504
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 12:45:47 +00:00
Samuel Ghinet
192ac5db61 QmlDesigner: Allow dragging image Assets to the Material Browser
When dragging an image from the Assets Library to the Textures section
of the Material Browser, now Textures will be created from those
assets.

Task-number: QDS-8783
Change-Id: Ibbfb8697705a7d1af7714f3a32caff24282ee7a9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-24 12:45:06 +00:00
hjk
801eb712ba Debugger: Save a few string allocations on result parsing
Change-Id: I5b7614bd22d41f826b4977621d77a9aeba7f961f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 11:54:06 +00:00
Cristian Adam
beabb53422 sdktool: Fix CMake configuration on Qt6 within Qt Creator
Change-Id: I9028ad7aa6018b63c5afedb65add6ce765660bb7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-24 10:24:00 +00:00
Marcus Tillmanns
682ef157d8 Terminal: Add Terminal plugin
Adds a new Terminal plugin that provides a Terminal pane inside
Qt Creator.

Fixes: QTCREATORBUG-8511
Change-Id: I7eacb3efa2463d7df9f383ae3fc33254fb9019a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 10:19:33 +00:00
David Schulz
5b0a177cdf Debugger: Avoid reserving huge strings
Fixes: QTCREATORBUG-26416
Change-Id: I3728a98f0d16f43817d46e5404bd0b65bfd1b9c0
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 10:06:43 +00:00
Marcus Tillmanns
d5a9e28a96 Utils: Add tst_filepath
Moves all tests that are applicable only to FilePath over from
tst_fileutils.

Change-Id: Ic331e1470a7479ee2f8ba38baec84124982a000a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-24 09:45:56 +00:00
Henning Gruendl
d42af9246f QmlDesigner: Update 3D Animation workspace
Task-number: QDS-9184
Change-Id: Ic45d778b0ac3704c8f706fb2a7ab00103cc1d145
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-24 09:37:34 +00:00
hjk
fb9e0397e6 Debugger: Use a QStringView for debugview into output buffer
This is unused unless debugging creator itself.

Change-Id: Ic30fe4970c4b0ec79e977ef932d0516ab1ba0792
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 09:34:57 +00:00
David Schulz
9655c88862 LanguageClient: do not delay requesting symbols in the locator filter
This qualifies as a user interaction and the results should be collected
as fast as possible.

Change-Id: Ia83893fab87c253b9939cfee928aa12866087aa0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-24 09:26:02 +00:00
Henning Gruendl
383315b64a QmlDesigner: Fix DoubleButton state
Fix an issue that appears when pressing the button and moving away from
it but still hold the mouse button down.

Change-Id: I06b456e410352862ea28f04e7cfaf3bdb27ae7d4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 09:16:11 +00:00
Miikka Heikkinen
d3d621a7b3 QmlDesigner: End drag properly in assets and material browser views
If drag is accepted but drag ending is not notified to model, other
views will not know the drag has ended.

Fixes: QDS-9254
Change-Id: I1446bd4b52ce67afc37194c98e5c60e169fb57b9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-24 09:03:40 +00:00
Christian Stenger
ac2d5d761d AutoTest: Fix handling of test results
Broke with d05c5b7d07. The id is
used to identify the application running a test or a global
message like some warnings or the information regarding the
current running test.
Fixes its usage and its display inside the results pane.

In the amended patch the assumption that if the m_id is empty
it corresponds to nullptr TestResultPtr was apparently wrong.
This patch fixes it so that the default c'tor of TestResult
always creates an invalid result, so that it corresponds now
to nullptr TestResultPtr.

Amends d05c5b7d07

Change-Id: I9949aec3fc2b7354de149433b7127933f2d9bf21
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-24 08:38:54 +00:00
Marcus Tillmanns
a8d6229898 Terminal: Fix libvterm -fPIC
Change-Id: Iac8a9a0ec01058edd00399c3de0746d97de6fec3
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 08:37:51 +00:00
Kai Köhne
31740f562c span: Fix debug build with MSVC
std::terminate is declared in <exception>, so we need to include
this header - somewhat ironically - in the non-exception case.

Change-Id: I8ff1c20fd822b8a2a4c85faedf81f783e2779b8d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-02-24 08:19:28 +00:00
Leena Miettinen
2c9ca6008f Doc: Describe Python interpreter selector on editor toolbar
Task-number: QTCREATORBUG-28721
Change-Id: I354c19a72e428e5361eaacb45f79c057affb9cb1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 07:26:51 +00:00
Friedemann Kleint
ebb3b90dce ADS: Use only one logging category
Change-Id: I0366338d5605fea7b4b096605577e90dfa79c389
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 06:41:20 +00:00
David Schulz
78ccdb5c37 Cdbext: fix collecting required modules for python > 3.10
Change-Id: Ib8f5ff953f70cfb1ad15ea29522e02d65c58cafa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 05:24:06 +00:00
hjk
e25bf6e59d Copilot: Merge copilotoptionspagewidget.{h,cpp} into copilotoptionspage.cpp
Too small to be worth a translation unit. Also drop unnecessary Q_OBJECT.

Change-Id: Ife1bce6498eae81e2979c2798f8d4f19da16a11d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-23 15:45:04 +00:00
Marco Bubke
2af1e5b3b2 ADS: Fix warning for global allocation
Change-Id: Icd1a5c7c43b68e55071c9ef2c582d314e616f02c
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-23 15:24:29 +00:00
Thomas Hartmann
e0b75769d6 QmlDesigner: Hide import QtQuick.Controls.Windows
This import is not to be supposed to be used in the QDS context.

Task-number: QDS-8958
Change-Id: I9dbe270f9e9ceefad4c4c45e1e9ecaa2771290b3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2023-02-23 15:07:57 +00:00
hjk
8b243290fb Qnx: Use some placeholder for Qnx configuration names
The authoritive source for that is apparently some qconfig/*.xml file
which is not needed for actual building, so it might be missing
in some otherwise functioning setups.

Change-Id: I2aff53474e7fa0f7ee1c5bd0d8213b648cb894b7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-23 15:07:33 +00:00
Thomas Hartmann
e24242a6f3 StudioWelcome: Enable probing for example download
Without probing enabled the download will not be triggered.

Task-number: QDS-9253
Change-Id: Iae4669a2a088aba1b2078a035be2ac21b2d1bc41
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-23 14:56:27 +00:00
Brook Cronin
57ef24fa77 QmlDesigner: Fix workspaces for 4.0
Change-Id: Id6f599faa203e3260ba4cdd6a3677ddafa1a0a75
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-23 14:42:48 +00:00
Marcus Tillmanns
82194d7e9c Terminal: Add required 3rdparty libraries
Change-Id: Ic477e305f78632f5c454cd639dfc7e41fb643fe1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-02-23 14:18:45 +00:00
Eike Ziller
143835aea8 Coding style: Avoid optional::value()
Change-Id: Ic4769c6f9f016415e01ca5526f6730bc93c6ea81
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-02-23 13:33:53 +00:00
Eike Ziller
c2266981c9 Add tests to Utils::wildcardToRegularExpression
It was unclear if the new non-filepath version that is added to Qt is
similar enough to replace our own version, so just add the new tests
from Qt to check.

Change-Id: I9ac2739500ab3b8557c0e6223489e0fdddd79091
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-23 13:33:37 +00:00
Alessandro Portale
b9a24753a0 Android: Fix opening of package location after build
Fixes and consolidates into one common function the package path
retrieval for the eight combinations of:

(apk|aab)(debug|release)(signed|unsigned)

Fixes: QTCREATORBUG-28791
Change-Id: I6e8c54f555b95aca448032783938f9f7f89bc653
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-02-23 13:10:07 +00:00
Miikka Heikkinen
70b3a6d591 QmlDesigner: Clear content library search field on model attach
This makes it in line with search fields of other view.

Fixes: QDS-9237
Change-Id: Idfb703600582fd5b06e4120d7e7d1e233f2781fd
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-23 13:08:21 +00:00
Christian Stenger
5c4cf2d018 SquishTests: More adaption to changed wizard template
Change-Id: Ib073a8eae3ee87dc46699083799a8316da66b32d
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-23 12:51:08 +00:00
Christian Stenger
0604027834 SquishTests: Fix path handling for pre-installed Qts
There is now a Qt6 and a new possible location.

Change-Id: I4feac6da2756bde77e98ce08f945ddefec7e2fb4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-23 12:51:02 +00:00
Christian Stenger
3a7ab3ce8e SquishTests: Rename helper class
Change-Id: I39890cbd98b7e6ebcc0fdf4722d0311eb6650397
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-23 12:50:56 +00:00
Miikka Heikkinen
d39f469e51 QmlDesigner: Fix focus issues in material browser
Fixed focus loss on context menu close.
Fixed an issue with main view also handling cursor and enter keys when
editing material name.
Expanding a section now focuses the expanded section.
Dragging items from content library now focuses correct section.

Fixes: QDS-9215
Change-Id: I2176c7e52d8855c547db426b55ab739ca8f1db06
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-23 12:38:29 +00:00
Jarek Kobus
ef731faa47 Coding style: Avoid empty round brackets in lambdas
Remove outdated rules.
Use QList instead of QVector.

Change-Id: I11ea6be09080ddccfdcfc3d09f79cbeff448659e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-02-23 12:05:22 +00:00
Miikka Heikkinen
8b5c454881 QmlPreview: Register previewAction properly
To make Alt+p shortcut for live preview work, it must be registered
to ActionManager. We use global context for this action as it should
work regardless of which view is active.

Shortcut is now also available in Settings/Environment/Keyboard, since
it is properly registered.

Fixes: QDS-9229
Change-Id: Iee9671acd58f264bdb7b035d0ff1a343bcbd223e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-23 11:54:30 +00:00
Christian Kandeler
61c09bcefb ProjectExplorer: Do not expand the current entry in the issues pane
The expansion of the current item makes for a "jumpy" user experience
and also runs into a nasty Qt bug when navigating via keyboard.
Instead, we now show all items the same way and provide the details in a
tool tip.
As a side effect, build issues in text marks are now linkified.

Fixes: QTCREATORBUG-26128
Fixes: QTCREATORBUG-27006
Fixes: QTCREATORBUG-27506
Task-number: QTBUG-100309
Change-Id: Id9078c6f798fad31781bb645e06bbc92fc73fba5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-23 11:47:17 +00:00
Eike Ziller
255afd45bf Convert Examples model to FilePath
Change-Id: I56219d2f9516662b32d45fd9b2108a0ad34113cc
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-23 11:10:10 +00:00