The price of having to loop in two places seems small compared
to cleaner relations between the classes.
There's a new hack in the helpmanager to make sure we aren't
looping to often. The hack wouldn't be needed if the (odd(?))
check there weren't there.
Change-Id: Ifed50213b2de8feedfb45c185808d163c00c19ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
And handle the consequences in qmakebuildconfiguration.cpp.
Change-Id: Ic24d99927254e8d16decea49b880a2446bf322e6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
QtQuick.Controls has sub imports like QtQuick.Controls.macOS/windows
that wil lbe invalid on other platforms. In this case we do not want
to mark the original import as invalid, since it turns
off checks in QmlJSCheck.
Therefore moving the setting to invalid into the block that is only
executed for non optional sub imports.
Task-number: QDS-9094
Change-Id: If0ad4e32c14d608f88b8239f390208e51a93fbd8
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Pressing Esc on "New Folder" dialog closes the dialog.
* Pressing Esc on "New Effect" dialog closes the dialog.
Task-number: QDS-8782
Change-Id: Ie9ddc68681716789c678f581a6770931971a3278
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Only update the changed blocks and use sets instead of lists to
store the info and create the diff.
Change-Id: I08d81b326ceebdc6bf2ba322886b7bf5671b2769
Reviewed-by: David Schulz <david.schulz@qt.io>
- Use map for merging intervals instead 2 times list iteration.
- Time complexity O(nlogn) instead O(n^2)
Change-Id: If65391999e1ff191752447935602fcc9847243fe
Reviewed-by: David Schulz <david.schulz@qt.io>
This change makes it possible to bake in settings for bundled/shipped
Qt versions like we have in the QtDesignStudio.app package.
The result is that the installer does not need to write absolute
paths to the settings anymore, so it stays like it was signed.
A signed package on macOS is more and more necessary
and recommended for a while. Especially If the application will
touch files in special folders like Download, Documents, or Desktop.
Change-Id: I3153ffd4229b34a59bdfe740937c21ee93de3e9b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
There is no advantage to excluding the tools by default that outweighs
the risk for them to get out of sync with the rest of the codebase.
Change-Id: I3ad292aa5648a4448babdf5d06c84b3f5ec94482
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Environment::searchInPath() does not know from which device it came.
Therefore it will take the PATH variable as it is ( without the
device://... prefix ) and search for files on the local device.
Change-Id: Iecddb5ee1beb4ac821a9ac592f6edb1fc0f68b54
Reviewed-by: David Schulz <david.schulz@qt.io>
And clean up a bit
Change-Id: Idcc95ec94a437428caf97b7866b2c1e40f9a35c4
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
If declaration and definition of a symbol are present, offer only the
definition, as in the function and class locators.
Fixes: QTCREATORBUG-13894
Change-Id: I6794607c4c45831df53b022bbdad9db7205a890b
Reviewed-by: David Schulz <david.schulz@qt.io>
Mention explicitly that running Qt Creator from the build directory
requires corresponding PATH setup on Windows, and add descriptions for
installing development files and debug information.
Fixes: QTCREATORBUG-26858
Change-Id: I63381c9ae1af3cd4d5db02a77164061b79ac814f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Workaround crash inside a test that may happen if the
test tries to wait for an object when the AUT is gone already.
Check for a clean exit and only if this is not the case
try to continue with the error handling.
Change-Id: I65f3e72cd343ec527ad822de915bc0c49c263153
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Assignment and compare in a while() loop is trouble. Fixed
bug where index always was 1.
Change-Id: I037d8c2290cf44c6200354b7c44950009e26c583
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Remove the Qt SDK detection of conan. This is no longer valid with the
scripts being copied to ${buildDir}/.qtc/. Qt SDK also doesn't ship
conan anymore.
Do validation for conan via "conan --version" and vcpkg via "vcpkg
version".
For vcpkg the program path is resolved for symlinks and for Windows the
target architecture is being detected from the compiler path.
Change-Id: If0da79c952392d5ac9f8352e262b0802d6eb9ed3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- Old icons applied to the actions of the DesignerActionManager
in order to prevent showing texts on the old top toolbar.
- Reset icon is now available only for on state.
Task-number: QDS-8910
Change-Id: Ibd2d703b5e760709e5da81e6a3d3d93d5ba0e104
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The constructor for CommandResult takes a reference to QtcProcess.
If by mistake a pointer was used this results in constructing a new
QtcProcess and using the copy as input for CommandResult.
With explicit constructor we will get a compiler error.
Change-Id: Ib3a61b9164bd7d5dfb0f567c2d03f16b7d12f2c2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
QCoreApplication::translate() takes a context parameter, tr() does not.
We want the first one.
Amends: 48affa1889
Change-Id: Ibca327a39097dfcdb81a30e561161d3275c61d1d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Store a pointer to WorkspaceLocatorFilter instead of base
ILocatorFilter and avoid later downcast to WorkspaceLocatorFilter.
Change-Id: I729f60356b287f3b4bddf016e21761a372993928
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This makes it possible to have plugin tests defined in the
plugin pimpl, like a lot of the other stuff we currently
have there. This is meant to replace IPlugin::createTestObjects.
The basic idea is to reduce the number of ways things can
or have to be done when creating plugins.
Change-Id: I137c66b91cdf461a502cf22063b6f63e6163e876
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Default values shouldn't have complex initializations anyway,
these end up in each instance on user side.
Change-Id: I81394c3df353b34b19454130f58bd646318feccd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
By copying the ${IDE:ResourcePath}/package-manager to
${buildDir}/.qtc/ the problem with hardcoding paths
to old an Qt Creator version can no longer occur.
This also fixes the issue with remote projects by reffering
to the code residing on the host.
With the above issues fixed, enable "Package manager auto setup"
by default.
Change-Id: Ia49654a3b9059f83886e64d065019b2d55e9299c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
qml2puppet only enables the qmlruntime feature if it
was built against a Qt 6.
Task-number: QDS-9088
Change-Id: If573cae305ef18c11101a591e6c1e38f133b7914
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
List respective tr files and while at it shuffle some
of the listed files to match common sort order.
Change-Id: I73845ad1dae5e8c86d3741067f40b7b2b37e2a6e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
