Commit Graph

80529 Commits

Author SHA1 Message Date
hjk
89591b7d3d ProjectExplorer: Make Node::pathOrDirectory work for remote files
Change-Id: I643456c0ba691ed4a89d4c6020dea148f6a47f1a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-19 13:49:37 +00:00
Tim Jenssen
b826acd53e utils: reduce default logging level of filesystemwatcher
Change-Id: I10d55e3f07eb461351b8c13cac01a9b0d5bd8b84
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 13:34:04 +00:00
hjk
cdc88b2571 RemoteLinux: Handle already remote local files
This is a bit hackish to support "true" remote builds.

Conceptually, that's more similar to a "local" (a.k.a.
"Desktop" configurations when it comes to (non-)deployment,
but the Desktop runconfigs are currently a bit too tied
to the host system, and we'd like to have the X11 forwarding
that's already available here.

Change-Id: I750b2cfe6b94ec8f60a0e879f3fe44ddaf86072e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-19 12:55:11 +00:00
Christian Stenger
13cf1ee948 Wizards: Re-enable using qt quick wizard for qbs
Change-Id: Ic1a3dfbb72096470b4cec2d7af967eba111c743f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-19 12:54:00 +00:00
hjk
117b6f1921 ClangCodeModel: Tr::tr
Change-Id: I60aeadd38471cc65de250f66f0f09ba2931b3da2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-19 12:18:42 +00:00
hjk
0454e939e1 Utils: Make all labels created by the LayoutBuilder
... selectable with the mouse.

Change-Id: Ied2677a517239ca55a15daeae088bc09998d2b3b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 12:03:32 +00:00
Burak Hancerli
e6d34ed3eb QmlDesigner: DS crashes on exit
Invalid pointer access.

Task-number: QDS-8751
Change-Id: I983ae84c1b746768d10a06ab6a28eb080fdc48a0
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-19 11:03:13 +00:00
Thomas Hartmann
47c4fff724 QmlDesigner: Fix Select All in code editor
Because of the shortcut overrides we used the "shortcuts"
from QPlainTextEditor which leads to different behavior then
the rest of Qt Creator and a bug.

Without the override we use QActions defined in Qt Creator.

Task-number: QDS-8847
Change-Id: I90e2b86ad9b5c93302652dd7cdfbf2b51e3a3771
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-01-19 11:01:09 +00:00
Thomas Hartmann
1a2de8b40b QmlDesigner: Add logging for urlSpecifics
Change-Id: I556b534e92a9fb9729f6aa610153a4f89122e51c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-19 10:57:03 +00:00
Tim Jenssen
8e69490dad Utils: improve filewatcher
Avoid internal calls of QFileSystemEngine::fillMetaData
which are expensive and especially on Windows trow
GetFileAttributesEx can hang for seconds.
(network drive or one drive which locks files)

Task-number: QDS-8820
Change-Id: I3269ade03d1c1ed65417eebf956080414c5d087b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 10:55:19 +00:00
Tim Jenssen
db7c1c6770 Utils: add Q_LOGGING_CATEGORY(fileSystemWatcher)
Change-Id: I554c50a47197a6a9a84427b62a528d87b9db5f19
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 10:53:36 +00:00
Jarek Kobus
bc7de78c84 Utils: Fix clazy "Mixing iterators with const_iterators" warnings
Cherry-picked from 7bc86a8b8d

Change-Id: I719272e0c094df424c08524e8e32a567d557bb3d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 10:51:10 +00:00
David Schulz
ca2979ca52 LanguageClient: Do not untrack documents before restarting a client
shutdownClient removed the association between the document and the
client, but this is one of the information we would like to keep when
restarting a client. Also we never want to delete the client when
calling restart.

Change-Id: I0558c27ba4b9171c7933edaf2e17847d4e6f62b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-19 10:10:42 +00:00
Jarek Kobus
9ff307253d ProgressIndicator: Remove fwd decl of non-existing class
Change-Id: I175c7811afdb44ed0e61ccc1f16424a1baed34b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 09:55:40 +00:00
Christian Kandeler
7b5c5b774f LanguageClient: Fix renaming with pre-set replacement symbol
If a caller passes in a fixed new symbol name, it must not be overwritten
with one derived from the old symbol name.
The problem can be verified with the "convert to camel case" quickfix.

Change-Id: I3d3aca692cb8e73535e1ef657608fd13d18ee5df
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 09:04:51 +00:00
Eike Ziller
e9320a8122 Fix tab order in "file deleted" dialog on Windows/Linux
For some reason it doesn't like it if the order of adding the buttons
is different, though that works on macOS.

Fixes: QTCREATORBUG-28676
Change-Id: Iea7c595216140dd242cac0aa528699866c4bb1c7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 07:20:01 +00:00
Christian Stenger
534e1f34b2 AutoTest: Only write values that are not default to user files
Change-Id: I0e36cdbc850c148e5fa7c865f3f1136a4dc8a11f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 07:19:47 +00:00
Christian Stenger
435fe5e4db Adapt to upstream change
Change-Id: I0f0de2823eb338cbd327846347f3b3c8e2b61c89
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-19 07:19:08 +00:00
David Schulz
41294e70b4 TextEditor: prevent crash on updating the completion model
Prevent updating the model with something other than a generic proposal
model.

Change-Id: I3880c1ce4ae7cf0aa4fb72d59b75a40db3f53482
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-19 06:28:41 +00:00
Christian Stenger
d9de9db6f8 Utils: Adapt to change in FilePath
Change-Id: Ibd3c53c49390cbf77d8b0563bab7ddff216394c7
Reviewed-by: hjk <hjk@qt.io>
2023-01-19 05:34:48 +00:00
Mahmoud Badri
be15c0b82e QmlDesigner: Enable keyboard navigation in the material browser
Fixes: QDS-8764
Change-Id: I2f0de80a3bbffdb0dafa15315cfe6692d77db2ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-18 17:45:52 +00:00
hjk
1db9135d6d RemoteLinux: Merge tooling runworker related files
... and move definition of supported runconfig to worker factories

This might not be final, but is closer to the other device setups.

Change-Id: If68d4e9d1bfb281879ff8cd46ed6ed6356da8d57
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-18 16:15:33 +00:00
hjk
fa7dd2fd3b VcsBase: Convert to Tr::tr
To reduce the amount of duplicated strings for translators to handle.
The problem is not very prominent in vcsbase, but that's where we
are moving everywhere else.

Change-Id: Icb11fad3bccfea8a1408420e729566a75adccb66
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-18 15:33:59 +00:00
Pranta Dastider
de8c64ab95 QmlDesigner: Update Tooltips for Advanced Section
This patch update tooltip text for Advanced Section fields
in Property editor.

Fixes: QDS-8805
Change-Id: If97f0d42bc53c855fbf6bb1916011d4cbadb95cd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-18 14:27:39 +00:00
Pranta Dastider
5e81f4105a QmlDesigner: Update Tooltips for Padding Section
This patch update tooltip text for Padding Section fields
in Property editor.

Fixes: QDS-8808
Change-Id: I04143d8b822d1978f57aa01598c6df0b483da94c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-18 14:27:36 +00:00
Pranta Dastider
8607436ee6 QmlDesigner: Update Tooltips for Control Section
This patch update tooltip text for Control Section fields
in Property editor.

Fixes: QDS-8809
Change-Id: I1a5d830c9541a7ee25d483eee77d6391e194e743
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-18 14:27:29 +00:00
Jarek Kobus
7e815270f1 TestRunner: Get rid of unneeded Utils:: prefix
We are using Utils namespace in this file already.

Change-Id: Ib4b36782b3272eb4974d8dada4518b0d4eec2f21
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-18 14:01:57 +00:00
Jarek Kobus
39940a7200 TestRunner: Use QList instead of QQueue
There is not a big benefit when using QQueue - QQueue::dequeue()
has its counterpart in QList::takeFirst(). Using list makes
it possible to assign another list into m_selectedTests.
Make use of QList API consistent in this file (use isEmpty(), first()).

Change-Id: I4a320469f5b44c61f8c51196c104a6ca0d0534e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 14:01:32 +00:00
Ali Kianian
d0c2ccac8b QmlDesigner: Fix the bug for using QMap::asKeyValueRange
This feature is available for QT_VERSION >= 6.4.0. So a compiler
condition is considered to switch the code for different versions.
Also, an old unused function has been removed.

Change-Id: I470812213cfb00c28fcf062d214895cfcba68d69
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-18 13:52:33 +00:00
Jarek Kobus
fdebf0343d TestRunner: Merge 2 public methods into one
Merge setSelectedTests() and prepareToRunTests() into runTests().

Change-Id: I908c41483f05eeaec186f362391941a797d66e6a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 13:50:37 +00:00
Jarek Kobus
c9f5098c07 AutoTest: Rename outputReader() into createOutputReader()
Make it clear it's a factory method that creates new instances
of objects, not a simple getter.

Change-Id: I0b44506a27a0353bc524831c305f947510f59e98
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 13:50:20 +00:00
Jarek Kobus
bad66c1fc2 CMakeBuildSystem: Run ctest process asynchronously in main thread
Instead of running it in other thread using blocking interface.

Amends 675a72e296

Change-Id: Ia4c7701fa4cd9efea4aeccd979dfb8cde28a889e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-18 13:33:25 +00:00
hjk
ea41beb90a QmlProfiler: use dedicated classes to create run workers
Change-Id: I70d6b778ce6e4892260d4c826b708eadce6b4017
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 12:51:17 +00:00
Amr Essam
5818f9226a QmlDesigner: Delete qep effect resources files
When an effect file is deleted from assets library, this delete its related
files from asset_imports/Effects, including the main effect folder itself

Task-number: QDS-8455
Change-Id: I4af6f740b209dc17923d3709b6017ef243fc2563
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-18 11:30:26 +00:00
Christian Kandeler
263c5e6b7c Fix crash on session loading
Amends 22da0f2fd6.

Fixes: QTCREATORBUG-28700
Change-Id: I2d9c249fe03abfa1bc3ce53d0d7cff7b8a0329d6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-18 11:28:18 +00:00
hjk
46e660c646 Boot2Qt: Tr::tr
Interestingly, the contexts were predominantly Qdb::*, standardize
on that. Long term we might collapse RemoteLinux descendants anyway.

Change-Id: Id7009ee6b662d6c29f98e3809619b604aeeea7d9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-18 11:20:44 +00:00
The Qt Project
88131d4c93 Merge "Merge remote-tracking branch 'origin/9.0'" 2023-01-18 10:18:07 +00:00
Eike Ziller
4d71a24cb9 Welcome/Qt: Show featured examples in separate section
Task-number: QTCREATORBUG-28546
Change-Id: I9cf42cd11b442f720070c250da789d23001a1375
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 10:17:11 +00:00
Eike Ziller
ad643fdd30 Welcome/Qt: Use separate model instances for examples and tutorials
And get rid of the need to filter the model in a special way.

Change-Id: I42dd80e3b8b122dcd2d5f454d0acde1facf556bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 10:17:03 +00:00
Eike Ziller
e8fdfd9e2c ExamplesListModel: Remove unused/unimplemented methods
Change-Id: I9cecb1f89d07f7b060a2f2b7d228c14c54da8ddf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 10:16:54 +00:00
Eike Ziller
6c6277bc7d ExamplesListModel: Remove direct access of model items variable
Change-Id: I8dc2833f61fe0267953acfa8746151cea893c7f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 10:16:46 +00:00
Eike Ziller
e3acf9262b Make categorized product/example view reusable
Extract a SectionedGridView from the SectionedProducts that are used in
the MarketPlace plugin, and make item delegate and pixmap fetching
function to be used with the model(s) pluggable.

Change-Id: I02aba87b27afd8ad18ff23346d1ac98da906db4b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 10:16:31 +00:00
Alessandro Portale
6d79c5c2b3 Android: Remove "ndkPath" entry from sdk_definitions.json
Since a long while, an ndk within an Android SDK installation resides
under a subdirectory "ndk/<ndkversion>". The "ndk_path" entry in
sdk_definitions.json is therefore redundant, since the ndk version is
already present.

Qt 6.5+ will provide the ndk version number (see QTCREATORBUG-28629),
without such ndk_path, and therefore it is helpful to contruct the ndk
subpath directly from that version number. For all Qt versions.

This change removes the "ndkPath" entry and the code that handles it.

Task-number: QTCREATORBUG-28629
Change-Id: I5a8f204f87a53a610dbeb9d4c39633582ef209c1
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-01-18 10:11:48 +00:00
hjk
4f138c1a21 Boot2Qt: Code cosmetics
Avoid a macro.

Change-Id: I58703581727656a16d5dd6f99ee2ce9413863e9e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-18 09:46:47 +00:00
hjk
bb6764d065 Boot2Qt: Use dedicated classes for run worker factories
Change-Id: Ibe060ab15e57014866e8fa1311c1441238f81c7e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 09:39:13 +00:00
Eike Ziller
561b815d7b Merge remote-tracking branch 'origin/9.0'
Change-Id: I73396bcd07852ff5e01d73b06ebd64ab6af802e5
2023-01-18 10:02:35 +01:00
Mats Honkamaa
2225044dd3 Doc: Add topic on how to create web app navigation
Docs available as PDF in ticket QDS-8721 for easier reviweing.

Task-number: QDS-8477
Change-Id: If15defc67a42a79d5f9e02fe7eb6aa8921277dde
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-01-18 08:50:54 +00:00
Eike Ziller
aff6c4b2d2 Welcome: Remove requirement for subclassing ListModel
By using aggregation for the pixmap fetching.

Change-Id: I6647cc6fa7995581c692050af32e41ba9aa86491
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-18 08:42:16 +00:00
Marcus Tillmanns
ab9935af73 ClangTools: Fix warning
Change-Id: Ic02ff5905988f289fb16c53de9aaeed3dbd25376
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-18 08:42:15 +00:00
Orgad Shaneh
da31e72605 Subversion: Fix unused argument warning
Amends 87e5ac7438.

Change-Id: If4b8d631a5388d98f482097b20169e2200f7675a
Reviewed-by: hjk <hjk@qt.io>
2023-01-18 08:12:28 +00:00