Commit Graph

80529 Commits

Author SHA1 Message Date
Miikka Heikkinen
df3ace009a QmlDesigner: Fix clearing node lock/eyeball
Lock/eyeball status was not propagated to puppet when lock/eyeball
was cleared, as clearing these aux properties instead removes them,
which triggers change notification with invalid value. Fixed by
allowing invalid value to be propagated for these properties.

Fixes: QDS-8735
Change-Id: Ic5c4818afeef71612f9620b3a0af503793a37e90
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-09 12:00:50 +00:00
Eike Ziller
23fa784e9c MacroExpanders: Remove legacy "Current(Project|Build|Kit)" variables
Should use "CurrentDocument:....." now.

Change-Id: Ie47f0e0f77b506bef6fc7a173aec8cfdcf863e5e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-09 11:55:08 +00:00
Jarek Kobus
37fafcabb2 SymbolSearcherTestCase: Remove unused toString()
Change-Id: I2bfca6f112a59008d75f38d6941f6d084aad1491
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-09 11:40:59 +00:00
hjk
a2d2150261 CppEditor: Re-use Symbol::filePath()
Change-Id: Ic958fc0b8916c1afe8b955b140a5cf76e971623d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-09 11:32:48 +00:00
Alessandro Portale
8ee463f311 Android: Remove extra spacings and margins from AndroidSdkManagerWidget
Change-Id: I74f35daa52b779504c859153482aabb5ae49521f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-01-09 10:13:56 +00:00
Marcus Tillmanns
f0540f8392 Docker: Convert isValidMountInfo to expected
Change-Id: I582939990f85c1dc3eed474b3bac0e6b4efe3367
Reviewed-by: hjk <hjk@qt.io>
2023-01-09 09:51:00 +00:00
Marcus Tillmanns
2cfc981860 ClangFormat: Remove setPath() from VFS
setPath was not used anyway. It is also not available in older
llvm versions.

Change-Id: I16f0a8e2ffa827d92a2f1440d27391a51aefa728
Reviewed-by: hjk <hjk@qt.io>
2023-01-09 09:35:10 +00:00
Alessandro Portale
a04b433489 Android: Remove lldb package handling via sdk_definitions.json
The sdk_definitions.json only briefly listed an lldb package. There is
no need to still support that.

Amends: 6bea157c9b

Change-Id: I6344ea6ed9dd80693d02e86033632dfd2582b773
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-01-09 08:30:42 +00:00
Christian Stenger
1802ad77a7 LanguageServerProtocol: Fix compile
Partially reverts bee489f9e2.

Change-Id: Ifdd4e2f85133ef6bf6c7871daedb8ecd64fdfa8f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-09 05:58:28 +00:00
Artem Sokolovskii
deeda4c9ed Android: Update "Android SDK Command-line Tools" version
From v6.0 to v8.0

Change-Id: I85a2b98bba3192abe2dc8f26043d42d768ea8a67
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-06 18:02:46 +00:00
Cristian Adam
a3153c535d CMakePM: Add default kit configuration hashing
This adds a QTC_KIT_DEFAULT_CONFIG_HASH variable containing the hash of
all the default Qt Creator CMake kit variables:
  * CMAKE_C_COMPILER
  * CMAKE_CXX_COMPILER
  * QT_QMAKE_EXECUTABLE
  * CMAKE_PREFIX_PATH

This way when a CMake preset changes any of these CMake variables a new
Kit will be created. Otherwise a previous kit containing different
values will be used.

Fixes: QTCREATORBUG-28609
Change-Id: I77b67e9c8fa15dc3ff2f22c5b63d4ca1c7670fdc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-06 18:01:32 +00:00
Jarek Kobus
b6208ab34a TaskTree: Introduce ParallelLimit
The parallel limit constrains the number of parallel tasks
run in the same time. So, if e.g. a group contains 10 children
and the parallel limit is 6, only first 6 tasks are being started
on the beginning and the rest 4 are being postponed until some
running tasks are finished. So, when the one of 6 running tasks
finishes the group starts the 7th task and so on.

Setting parallel limit to 1 means sequential invocation in fact.

The value of 0 means there is no limit and all tasks are run at once.

Remove the ExecuteMode enum, as this is modelled now by the
parallelLimit.

Change-Id: Ice59318be0915401f05bb5a5804078bdc591d09f
Reviewed-by: hjk <hjk@qt.io>
2023-01-06 15:28:19 +00:00
hjk
fbb8d94e55 Utils: Use hidden friends for FilePath comparison, hash and debug
Change-Id: Ic458d64cecdc811bac6b1cfaeae344f1da1b8211
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 12:54:59 +00:00
hjk
1874906ce1 Utils: Make CommandLine related operators hidden friends
Change-Id: Ifb81bb565f7343739883c06817f3e304bdc5b963
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 12:54:25 +00:00
hjk
bee489f9e2 LSP: Make hash and debug operator hidden friends
Change-Id: I91e7f8d7e9d21faa5d9bcd3f2d43fa61d22ab44c
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-06 12:51:49 +00:00
Dmitry Bravikov
34ff9c97e6 Debugging: Add dumpers for libcpp types: variant, optional, tuple
Task-number: QTCREATORBUG-25865
Change-Id: I262ac708ae040982d2ed4f62e1f95807eaaae718
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-01-06 12:07:45 +00:00
Kai Köhne
b2fc935f33 Fix SPDX-License-Identifier to be on one line
To be able to be processed by tools, SPDX-License-Identifier expressions
cannot be split across lines.

See also E.4.4 in https://spdx.github.io/spdx-spec/v2.3-RC1/using-SPDX-short-identifiers-in-source-files/

Change-Id: I44d95cb2de44f53fdcaa745068e2df7e8e9767b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 11:15:29 +00:00
Kai Köhne
56baf8c058 Remove GPL-3.0+ from license identifiers
Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0,
this applies only to a hypothetical newer version of GPL, that doesn't
exist yet. If such a version emerges, we can still decide to relicense...

While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only

Change was done by running

  find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \;

Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 11:15:13 +00:00
hjk
126d1d009e Utils: Remove two uses of FilePath::toString
The context here (passed as part of command lines args)  suggests
the use of .nativePath(), but if .toString() was ok so far, .path()
(i.e. with forward slashs also on Windows) would change less.

Change-Id: I045c4311c67b8875b87c328fbe57ca79ae0d7f1a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 10:37:00 +00:00
Jarek Kobus
33e8251edf Ios: Pass context object to lambda connections
Change-Id: I69a7a2ff3e91256961b2b501e75fe1a21d9c8b6f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-06 10:28:30 +00:00
Kai Köhne
1be357f4be Remove GPL-3.0+ from license identifiers, part II
The original text before the SPDX change did not include a potential
GPL-4.0, but GPL-2.0.

While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only

Change was done by running

  find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR LGPL-3.0/LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only/g" {} ;

Change-Id: Id5e40d3e174ecea660a09e88a02bd57505f1875d
Reviewed-by: Lucie Gerard <lucie.gerard@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 10:27:36 +00:00
hjk
1f4b6837ba Utils: Make TreeStorageBase related qHash and comparison hidden friends
Also, inline the hashing.

Change-Id: I75859ad5481ab673d6c6f233c6fe67a96f9cda45
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-01-06 09:57:01 +00:00
hjk
ce7b865cf7 QmlPreview: Robustify preview runner a bit
Don't rely on qobject_cast not returning null for eternity.

Change-Id: I0adede2f05a27e4f98ee47e737af38732f1e4c31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-06 08:47:13 +00:00
hjk
c7bb5fcc37 Debugger: Remove spurious waring
Task-number: QTCREATORBUG-27160
Change-Id: Ie69c60688249efcd4d2c2330d6555cf7f708edd2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-06 08:32:09 +00:00
Eike Ziller
adc874f690 COIN/GitHub: Use Qt 6.4.2
Change-Id: Ia66ce7e0a8ebf988c1af9888ddb7e9461f0cac05
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-06 08:28:17 +00:00
hjk
53f46e0643 QmlPreview: Have a dedicated run worker factory class
More similar to what the rest is doing or heading to.

Change-Id: I835ef19810cbce146d3ae22b3881c0e89d1b1fb9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-06 07:59:02 +00:00
hjk
67195f4270 Valgrind: Use named classes for run worker factories
Change-Id: I05009aa2fe4541e10fa56a3a095db030e18b79b5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-06 07:16:25 +00:00
hjk
15d6e1df1b Debugger: Use a full class for DebuggerRunWorkerFactory
This continues the work started with de6c7696d2.

Change-Id: Ifc306347f2346909a9eba39c74449c559a7c2f76
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-06 07:16:17 +00:00
hjk
2f6ac9d797 PerfProfiler: Use named classes for run worker factories
Change-Id: Ib91f307c69bd2b85626aedf958799417cdd354ee
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-06 07:16:07 +00:00
Burak Hancerli
fb14965dfe QmlDesigner: fix for coreApp initialization problem and loadwatcher scope failure
Change-Id: I7a82cdd32757a7d37a0e88fad3e0f83527e49094
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-05 20:18:39 +00:00
Sami Shalayel
dc67907679 Update the qml code model parser
Updates the qml code model from qtdeclarative dev
(commit: 164d8f66d82deea74464c68a2cdd19e5998835da).

Fixes: QTCREATORBUG-28238
Change-Id: I383c98012f1efd56110d43c258fa1b398a6f8255
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-05 15:25:18 +00:00
Jarek Kobus
4e58ffcd13 Task/ProcessProgress: Delete private data on destruction
Change-Id: I81787984ff8dbb541f88922c90e51a68184c392b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-05 14:49:01 +00:00
Cristian Adam
2f39b51bdc CMakePM: Make "Autorun CMake" a global setting
The "Autorun CMake" is only visible in the Tools settings page when
the user clicks on CMake tool.

This is not very visible and it doesn't have to be per CMake version.

Change-Id: I57ded0b2e6a3ecb731bb8bc1495b6b61bc04c8b6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 14:37:50 +00:00
Jarek Kobus
2a2455a6fa Don't call FutureProgress::setKeepOnFinish(HideOnFinish)
This is the default behavior so no need to set it explicitly.

Change-Id: I7248a7a3890fa7fd947b8e42fccc70383d46ca3a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 14:26:03 +00:00
Jarek Kobus
45c98836a9 ProcessProgress: Add setKeepOnFinish()
Change-Id: I327cf309081d432b11a85bd98bc9f42de65313da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 14:22:42 +00:00
Jarek Kobus
fdb9cb905b QMakeStep: Use TaskTree for running qmake step
Change-Id: I8737a0fe3f8857db4e171001a73adde842d05d44
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-01-05 14:14:59 +00:00
Jarek Kobus
acd55c0677 AbstractProcessStep: Provide API for running TaskTree
As an alternative to calling AbstractProcessStep::doRun().

Change-Id: I53142b7470a3e2aed0e219300fb3e0b4621630db
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-01-05 13:53:13 +00:00
Miikka Heikkinen
ac93351c93 QmlDesigner: Respect node locking in navigator and 3D view
If 3D scene root is locked, disable create options from context menu
in 3D view.
Also, don't highlight locked nodes as drop targets in navigator.

Fixes: QDS-8731
Change-Id: If0c8b5497781c2623f2c57966d4689e345b85785
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-05 13:39:26 +00:00
hjk
c022f53b88 QtSupport: Consolidate Qt version macro expander setup a bit
Change-Id: Id8f08d335beb3f6aef682b84f62cd9bdb50dd057
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 13:25:23 +00:00
Alessandro Portale
4e0b4fcc92 QtQuick Application wizard: Add "QDS style project" option
This adds a checkbox labeled "Design Studio style project" to the
Wizard. With that selected, the project is generated via the "General /
Empty" templates of QDS with Qt 6.2 as target Qt version, 1920x1080 form
size, the "Material" QtQuick.Controls style ("Light" Theme) and CMake
project format.

At the same time, the preexisting QtQuick Application wizard in Qt
Creator now also focusses on Qt 6.2 and CMake. TS file generation is
removed for now, can be added later, but then using the i18n setup
feature of QQmlApplicationEngine (instead of a QTranslator in main.cpp).

The wizard now focusses on the QML CMake API. In order to filter the
kits accordingly, the flag "QtSupport.Wizards.FeatureQtQmlCMakeApi" was
added.

Task-number: QTCREATORBUG-28436
Change-Id: I80bc5585f31ec82c64f845701c768f8a07e000da
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 13:09:59 +00:00
Cristian Adam
be1c5cab96 Fix static build of Qt Creator
When is QTC_STATIC_BUILD set to ON add_qtc_library will add a
<target_name>_STATIC_LIBRARY define, otherwise <target_name>_LIBRARY is
added.

Since Sqlite uses two libraries now both SQLITE_STATIC_LIBRARY and
SQLITEC_STATIC_LIBRARY need to be checked.

Change-Id: I07c4de01627754534da7e37d1261db37779df296
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-05 13:07:27 +00:00
Miikka Heikkinen
ff59de94e9 QmlDesigner: Create dragged item to correct position in 3d view
Fixes: QDS-8655
Change-Id: I8ab397e4dc571e50c4495f6690418b177afa4dbe
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-05 12:38:45 +00:00
hjk
4b237c0e98 ProjectExplorer: Return FilePaths for SessionManager::projectsForSessionName()
Change-Id: Ie168973e872ea105c7eb46ff7f58fb34883364b1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-05 11:07:14 +00:00
Thomas Hartmann
c1a16d51a6 QmlDesigner: Remove isQtQuick3DParticles3DModel
The type does not exist.

Change-Id: I03df9f67d49af1ff37a254f3ef17693f5d975ea9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-05 10:27:26 +00:00
Thomas Hartmann
28b6c30bd8 QmlDesigner: Fix lingering merge conflict
Materials are applied to Quick3DModel not QtQuick3DParticles3DModel
(Which does not exist).

Change-Id: I350d9864c7eb3a7b6879e8d58646c7c2c7b8e0d2
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-05 10:27:12 +00:00
Amr Essam
63e885e7a1 QmlDesigner: Create arbitrary type for effects to identify them in qds
Using arbitrary type name because at this time we don't have effect maker specific type

Task-number: QDS-8729
Change-Id: I3f70e241a03e0ce14512af1cafa066ef0a6c90d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-05 10:25:36 +00:00
hjk
ac9023e851 Utils: Make Utils::withTildeHomePath a FilePath member
Gets .osType() right in remote cases.

Change-Id: I6397996062d976d7db690c5729dd4faa1f459563
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-05 10:17:10 +00:00
Eike Ziller
55fa109b59 CMake build: Use version-less Qt targets
Since we do not support Qt < 5.15 anymore, and as a first step
for getting rid of our special FindQt5.cmake.

Change-Id: Icc5dbaf9b0a3a622b1f609ff114b9decb6d2856c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-01-05 10:13:16 +00:00
hjk
894685d501 Debugger: Make calling std::function details skippable
Change-Id: I03415209557589a15d66e2ee4fd531f0f02bf5bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-05 10:10:21 +00:00
Cristian Adam
5e9f8b30d4 Utils: Add defaultValue getter for Aspects
Does the variant conversion based on the aspect type.

Change-Id: I2127a5a4202c3a60b946492b90a78beabaa11aed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-05 10:02:02 +00:00