Commit Graph

80529 Commits

Author SHA1 Message Date
Jarek Kobus
28c507eccb Simplify data structures
Do some cleanup.

Change-Id: If40fefbdb646f0eb434539f8306421a40e47a3ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 18:16:23 +00:00
Jarek Kobus
7ffdada4a3 Adapt to upstream changes
Do some cleanup.

Change-Id: Ibbd9406d202bd6fa0eaf47ecd81f656578407634
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 18:00:48 +00:00
hjk
0ba06e1b18 ProjectExplorer: Use more generous first approximation for isReachable()
There's a correlation between files that a device wishes to handle
and files it considers reachable.

Change-Id: I485ce59c09d9155d5d4db41ddc52f675d6c5d225
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2022-10-06 16:30:38 +00:00
hjk
7a1696a0ac Utils: Add a convienience function FileFilter::asFindArguments
Re-usable in a variety of unix-based devices.

Change-Id: I480ad9b128336059752b99dc1f1ae3b4899a4077
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-06 16:00:15 +00:00
Jarek Kobus
b2ee86ba03 QtcProcess: Small cleanup
Change-Id: Ib3c913185b01ad3f81e883bd3013ccb95a863485
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 15:39:03 +00:00
Jarek Kobus
fa63c68fd9 QtcProcess: Remove virtual leftover
Change-Id: Ib4fa1a115353bf35b0ac310ea9ce4f775d2d1b0c
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 15:38:57 +00:00
Jarek Kobus
512edfc60d QtcProcess: Consolidate the log debug code
Reuse starting() signal for doing initial debug printout.
Keep dynamic properties in QtcProcessPrivate only, so
no need for passing it.

Change-Id: I170ea96c37e1b9904037851799316de629bfb86e
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 15:38:52 +00:00
Jarek Kobus
239788c121 QtcProcess: Simplify emitting guarded signals
Avoid code repetition.

Change-Id: I259cb3e9396c0c84dbc63e7929f949580070c382
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 15:12:40 +00:00
hjk
0e3d1064e6 CMake: avoid running into some code path that breaks later
When trying to configure a CMake project on a remote linux device,
there's currently PATH=/some/local/dir/for/ninja added on the ssh
command line, which won't work with the remote cmake.

Change-Id: I97adb58e4c8b33f74edcc37a7b2cfb00c764b829
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-10-06 14:59:10 +00:00
hjk
47e5997e57 Mercurial: Convert to Tr::tr
Change-Id: I2a6ecd17091ffa0100f982848afbf941c6997db7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 14:28:09 +00:00
Pranta Dastider
75e5f60848 QmlDesigner: Qt Bridge documentation fix
Here the documentation mentioning reverse importing assets from
Qt Design Studio to external UI design tools were removed to
make the information relevant and less misleading considering
the current state.

Fixes: QDS-7708
Change-Id: Ifc484af4c95b82f01ca9f74cc7dba529bd7eaa61
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-10-06 14:20:15 +00:00
Jarek Kobus
db5e3555ac QtcProcess: Add starting() signal
Will be useful for VcsCommand controlling.

Change-Id: I6e0199c7a45948526cfd916907b098472b78219c
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 13:39:46 +00:00
Jarek Kobus
363731a8c8 RunFlags: Add ProgressiveOutput flag
It replaces VcsCommand::setProgressiveOutput() property.

Change-Id: Icebd2205a5b489f60ded1eeee21e2deacbfde1fe
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 13:35:48 +00:00
Jarek Kobus
98c4e342f8 RunFlags: Group flags into QtcProcess related
Some flags directly relate to QtcProcess setup.
Group them together. Reorder other flags to keep
related next to each other. Modify some descriptions.

Change-Id: I8694fb5ca0edd7e770a084d7d1d890d48a13a347
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 13:35:41 +00:00
hjk
fc72461b3d Meson: Inline toolssettingswidget.ui
Change-Id: Iaacc703195fe66200fe64a95f704ba90b7e66504
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 13:33:05 +00:00
Alessandro Portale
928a7d2087 Git: Convert to Tr::tr
Change-Id: I7fb1753109a9263c70c01713f5f4895db6b73662
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 12:32:58 +00:00
Jarek Kobus
b8efc2f14d VcsBase: Use FilePath in editorTag()
Change-Id: I4093fa46a51767afd00a8de2f94986c708dc1efa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 12:06:03 +00:00
Jarek Kobus
9d4017400e Cvs: Reuse CommandResult
Get rid of CvsResponse.

Change-Id: I4f1bf6dfad56f730140a0841769b7246a22aa757
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 12:01:08 +00:00
Jarek Kobus
520e7b3b69 Svn: Reuse CommandResult
Get rid of SubversionResponse.

Change-Id: I171c421d1128b3f98ecfc446a16a9793d90c1be2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 12:01:01 +00:00
Jarek Kobus
1b2fecd5a5 Svn: Move timeoutMultiplier arg as the last one
Make the API similar to runCleartool() and runCvs().

Change-Id: Ib6e93daab4a98537e62802e0689f6516086191d0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 12:00:54 +00:00
Jarek Kobus
87a32429fe Cvs: Replace timeout with timeout multiplier
Give it default value of 1. Move this arg as the last one.
This is similar change to 4bcdfa6b19.

Change-Id: Idb83d47d2412c495ac227f5663d3256b1870d437
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 12:00:46 +00:00
Jarek Kobus
eec0679234 VcsBase: Move RunFlags into separate header
It is going to be used outside of VcsCommand, too.
Use RunFlags enum as an argument to several functions
instead of unsigned.

Change-Id: I355c80a845a9b5982108fbde3412754392dce702
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-06 12:00:35 +00:00
Eike Ziller
3811236903 macOS: Fix opening terminal
The scripts executable flag went missing

Amends a7956df3ca

Fixes: QTCREATORBUG-28251
Change-Id: I9773dee3967edc2ebb0eb49c539b37796a48cf5a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-06 11:44:24 +00:00
Christian Kandeler
7dc2c6b3b3 ClangCodeModel: Rename via LSP facilities
Contrary to our original expectation, clangd's textDocument/rename does
not necessarily yield the same locations as /references. Instead, it can
find fewer or more occurrences, depending on server-side logic about what
constitutes a reference vs what should be renamed. Therefore, we need to
use /rename for proper behavior.

Fixes: QTCREATORBUG-27978
Fixes: QTCREATORBUG-28109
Change-Id: I27d092e807a4aa59dc0674111429c77ca13010e9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-06 11:09:57 +00:00
Christian Stenger
96d60713bf Squish: Fix up wizard resource
Change-Id: Ie923744ef44d3588abb0930c241dbb26d7589de1
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-06 10:56:46 +00:00
hjk
5cdb936854 QmlDesigner: Inline openuiqmlfiledialog.ui
Also replace the grid by a suitable vbox.

Still leaves potential improvements, like getting button order right
used QDialogButtonBox.

Change-Id: Icd294350ad3b6ff137fcd3c7bec4d607a5a1c0c7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 10:42:01 +00:00
Christian Stenger
e489a947a8 PE: Delay initialization of wizards
Other plugins may provide additional wizard search paths,
so wait until they had a chance to register them.
Amends 1cf6b031cf.

Change-Id: I268a42ab22d9c4f48d03589986220781e3623f46
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-06 10:40:00 +00:00
hjk
74e260a40d Mercurial: Inline srcdestdialog.ui
Change-Id: I6866ffbe708600e47dd136e627a6c59207b50815
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 10:37:35 +00:00
Christian Kandeler
55a5216e25 LanguageClient: Inform document manager about renames
So that interested partied can react accordingly.

Change-Id: I0233413aa960b83965428671cebeb591d5ca12b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-06 10:00:47 +00:00
Pranta Dastider
c68a42925e QmlDesigner: Add new comment to document
Here the document is exclusive for the Enterprise Version of Qt Design
Studio. So, I have added a comment at the top, to keep it clear for
the users of other Qt Design Studio version.

Task-number: QDS-7814
Change-Id: I2fdf56ce6bb46e4b0103631747cc57c9d722a603
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-10-06 09:40:22 +00:00
Alessandro Portale
f8f94a0ce1 QmlJSTools: Convert to using Tr::tr
Change-Id: I40595e560fb2499226bd2c914a0b78ed68f830ab
Reviewed-by: hjk <hjk@qt.io>
2022-10-06 08:54:09 +00:00
David Schulz
faa38e5eb8 Locator: Show actions shortcuts in locator widget
Change-Id: Ib4d1e55e6335e691ee9ee85735e69a86b9276f15
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-06 08:16:58 +00:00
Robert Löhning
729805e7fd Git: Restore object names for dialog
Amends ffcf85958f

Change-Id: Ia48b114137d722df5f72add818d5729adff94110
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-06 07:48:45 +00:00
Leena Miettinen
49378ced3c Doc: Describe Squish plugin
Fixes: QTCREATORBUG-27890
Change-Id: Icc203a96f08c785f016130480c45c988d26ac371
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-06 07:07:56 +00:00
hjk
a5803ae555 Meson: Inline toolitemsettings.ui
Change-Id: Ib305c45354e63142587593401fda45d03d42d207
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 06:04:29 +00:00
hjk
bad664163f Mercurial: Inline revertdialog.ui
Change-Id: I1da46c20c1c504d482ef580520f239c789f05dcc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 06:04:21 +00:00
hjk
d843e96be8 Mercurial: Inline mercurialcommitpanel.ui
Also remove a few translated placeholder strings that were immediately
overwritten.

Change-Id: Ia2aecefcb798e191d1407e6a00bdb584430bbe3c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 06:03:02 +00:00
hjk
1f5eb9e62f Mercurial: Inline authenticationdialog.ui
Change-Id: I235c8aaf7d2dd8e49e8a22b81523a322b5f596bc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-06 06:02:17 +00:00
Marcus Tillmanns
8d80623a0f CMake: Delay restoration until devices load
If the devices have not loaded yet, trying to restore
a remote cmake will result in errors.

Change-Id: I08a802441d64b203388334e5cbb6b962d1f0d213
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-06 05:16:36 +00:00
Orgad Shaneh
1748c6e80b VcsManager: Fix detection of top level
Amends 42377c21e4.

Fixes: QTCREATORBUG-28253
Change-Id: Ia10b88790ad02e9be4ff3c84b67c36239c3adf7d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 21:10:09 +00:00
Jarek Kobus
42377c21e4 VcsManager: Use even more FilePath
Change-Id: Ia9dd3de67eb9dc8f5c0331ec9ffe44c993395c33
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 18:25:49 +00:00
Jarek Kobus
64db0009d5 VcsManager: Use more FilePath
Change-Id: I255372c47e6d3ea55e5f8060c3c2fdd9bd155c75
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 18:25:33 +00:00
Cristian Adam
ab7a472b94 CMakePM: update CMakePresets macro replacement function
Moved to a handcrafted function instead of using regex.

This way the Visual C++ Ninja only preset can be processed.

Change-Id: I9b303ee1765db05544d81db7d3b8d9e5223f5f42
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-05 17:54:35 +00:00
Jarek Kobus
6644927c4e ClearCasePlugin: Remove runCleartoolSync()
Replace it with runCleartoolProc().

Change-Id: I04172aa1506cbe20e9c8d870b697b899cfcca7bf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:21:57 +00:00
Jarek Kobus
0b7ee32202 ClearCasePlugin: Introduce runCleartoolProc
Don't use VcsCommand when the only passed flag is NoOutput
as in this case VcsCommand is the same as QtcProcess.
Add runCleartoolProc and implement it using QtcProcess.
Use it whenever NoOutput has been passed to runCommand.
Some codepath, like runCleartoolSync() or ccGetActiveVobs()
has been called from non-GUI thread - be on the safe side
and use QtcProcess in these cases.

Change-Id: I2d29947393bd43af193a53e3f8e89e1b6b4b86fa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:21:38 +00:00
Jarek Kobus
4bcdfa6b19 ClearCasePlugin: Replace timeout with timeout multiplier
Give it default value of 1. Move this arg as the last one
(only 2 non-default usages).

Change-Id: I8c0bee7988436b899c8ae5cb7b96b7fe534d265f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:14:33 +00:00
Jarek Kobus
7591b2f56d VcsCommand: Make runCommand() a static method
And rename it to runBlocking() in order to conform
a bit more to QtcProcess API.

In case of blocking run there is no need to instantiate
VcsCommand on user side. This nicely draw a line between
async usages (i.e. when start() is called and we need
an instance) and blocking ones (i.e. when runBlocking()
is called).

Change-Id: I1ba94ee36c92956d5044236cb9e2dd896bf3cfcf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:13:49 +00:00
Jarek Kobus
688ec935cd VcsCommand: Remove internal terminate() signal
This signal was emitted only from cancel() method and
used only when runCommand() was called. However, with
just 2 public usages of cancel() no-one was used
in conjunction with runCommand(). So, this signal is
no-op.

Change-Id: I2541c6498928d313faafc2fbe47ab609393486d1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:11:17 +00:00
Jarek Kobus
f4233a1c22 VcsCommand: Change the default logic for fully sync
Remove VcsCommand::FullySynchronous flag.
Rename VcsCommand::NoFullySync into UseEventLoop.
By default the command will run fully synchronous
(i.e. without nested event loop). Only when
UseEventLoop is specified, and the command runs in
main thread, the nested event loop will be used.

This change should preserve the current behavior
on all code paths.

Change-Id: Id4bbaf68402ceed5e3fcc6f294521e87eb0b8d4d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:10:04 +00:00
Jarek Kobus
3e69ea863f Subversion: Remove FullySynchronously flag from vcsMove()
This flag is no-op since NoFullySync isn't passed
and we are always running vcsMove() from UI thread,
so it will run fullySynchronous anyway.
See VcsCommandPrivate::isFullySynchronous() condition.

Change-Id: I257cd925c08e7b2406f32889e1086cc36a0473dc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-05 17:09:50 +00:00