This is meant to be the "internal", raw, unexpanded value that does not
necessarily match a scheme://host/path pattern before expansion.
Change-Id: I627afbe1e9682d85c5bb04542c7354760ba9a13f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
With lldb on Windows I had cases when the "OK" button would be disabled
even though I had the files set for both fields.
Change-Id: I510e63d0e27e685df7c5c3f6e6f1d608f0e63bb0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The session contains a list of disabled issue categories, and that was
growing with each start of Qt Creator, accumulating entries for
categories that are added as "disabled by default".
When adding a category as "disabled by default", it would
unconditionally append it to the list of disabled categories. This list
is saved and restored at Qt Creator restart, and then, when the category
is added by the code as disabled by default, it was appended again, now
appearing twice.
Use a set for the disabled categories internally to avoid this.
Change-Id: I0e2fae92d5b78d6bcc13d946f27241ddb8da84b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Even though it doesn't help yet as it's immediately accessed.
Change-Id: I7e3a40a05517130a9f747c82a3d4928378143947
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Amends e8fd863fcc, the global settings() function there was unused so
far, this here starts using it.
Change-Id: I0311baf7e4f86d138fdfafa146bf594b61b237f6
Reviewed-by: hjk <hjk@qt.io>
Reuse it in QnxPlugin.
Change-Id: Ie60e2829dffa90a4097ef2a0cf1ab19220c2631f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Both strings are not null terminated.
Change-Id: Ib9fb88925ef6ba261ae3c1ef69f0450935d31cc1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
ASSERT failure in __cdecl QmlDesigner::AbstractProperty::AbstractProperty(const class QByteArray &,const class std::shared_ptr<class QmlDesigner::Internal::InternalNode> &,class QmlDesigner::Model *,class QmlDesigner::AbstractView *): "a property name cannot contain a space", file qtcreator\src\plugins\qmldesigner\designercore\model\abstractproperty.cpp, line 32
Change-Id: Ie991c86f172f4c1a5c70340f44b524b3e15cd5db
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Make it clear that calling init() on newly added build steps
are always followed synchronously by starting a build queue.
Change-Id: I9918b2e595cdb1d0639490e3edf77e67fb8ae52e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Similar approach as done with ProjectConfiguration
Change-Id: Ia5e1d464b7c5c64d7a12ee12c7673ff453f24390
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Pass QList<BuildItem> instead of two separate lists
with build steps and their names.
Use "continue" when disabled or when init succeeded.
Move the "if (!init)" early return directly into the previous loop.
Append directly the passed items into the m_buildQueue.
Change-Id: Ie1bfc4e0695bf24d5bf25570523fed9b6b8c31e3
Reviewed-by: hjk <hjk@qt.io>
Instead of creating a temporary string we simply call append directly.
Change-Id: I75ffd80a4359a19892b196f5d1ddb50b90c5a2cd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
... to something similar to AspectContainer::toMap() as
preparation for later aspectification.
Change-Id: Ic60060ad1a7eb1aba58ded01221b016c684db073
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Helps to make it easier to reason about the necessity of emitting
*changed signals.
Change-Id: Ieab29b25f5cc2799e193417b9cab02c99501c60a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
