Creating a QTextCursor just for the ChangeSet gives no benefit for the
calling code, but reduces the readability.
Change-Id: I34acb6083b6f7ab54fce042e29cd6e80498338ef
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This reverts 67607e4bc6, which seems
not needed anymore.
Change-Id: I7c995fc158bb26acf3b4a8ad4b810fa427fcf009
Reviewed-by: David Schulz <david.schulz@qt.io>
It does not really seem to be used in earnetst anymore, but
it shouldn't contain the scheme://host decoration.
Change-Id: Ieba416e0a73d247d80d1c5cce79858b1896e13ea
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Qt 6.4 automatically includes GNUInstallDirs, but before that it didn't.
And for the "plain" projects Qt isn't even used. Since the project
templates use CMAKE_INSTALL_LIBDIR etc, they must ensure themselves that
these are actually available.
Fixes: QTCREATORBUG-29067
Change-Id: Id304b829301a33720d8f6c4a9c89157e8fc1c4a9
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
... so that the tests pass with both the built-in indenter and
ClangFormat.
Change-Id: I0f870c507dabd80ccfc35f1d3021b2ddabe422d2
Reviewed-by: David Schulz <david.schulz@qt.io>
The only difference between initiateFinish() and initiateStop()
is that the initiateFinish() deletes the RunControl automatically
after the final state was reached.
Add setAutoDeleteOnStop() property and reuse initiateStop()
and stopped() instead.
Change-Id: I8e842978831b19587a8658b4443c96a04eb7a6df
Reviewed-by: hjk <hjk@qt.io>
... but make it configurable.
Fixes: QTCREATORBUG-29320
Change-Id: Ib377c78e51afb7d06167c66306250a281aa9279c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Use static const if possible to avoid re-initializations.
Change-Id: Ibee9e320dccb90cd928737b809db3b56369961ec
Reviewed-by: David Schulz <david.schulz@qt.io>
Looking up the last visible block is not for free since it calculates
the bounding rects for all blocks between the first and last visible
block. Avoid one calculation by postponing the annotation cleanup after
the paint event and only if we reach a certain amount of cached entries.
Change-Id: Ibfab49301f82237e16d5a69ce1531539907e7ed8
Reviewed-by: hjk <hjk@qt.io>
... and move definition into .cpp.
It is by now only needed there, and we don't want to encourge
re-using bits and pieces of step implementation by inheritance.
Change-Id: I12899c5e6a6c94cc9cfb23a2756621a4213f5dae
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Allow users to specify the tread limit used when scanning
for tests.
By default we continue to use a fourth of the available
logical CPUs.
Task-number: QTCREATORBUG-29301
Change-Id: Ic92a4d0908093c0664aa1ba924e0c17dfd0082f9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Tweak the default range of 0..99 resulting from using
a QSpinBox to some wider range.
Change-Id: Id1a64e283bee96d31df8bbad2f6e8039675df817
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
This is good enough to open Qt5's toplevel .pro, but not much more.
Ideally, prompt() should not be used in files that are meant to
be used non-interactively.
Task-number: QTCREATORBUG-18220
Change-Id: I842d3c1a8c742d55cbe89a8d0980f34d179ec011
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
6.0.1 was released on Qt 6.2 and was the last
version which could be built on Qt 5.14.
How I got to this:
0. Verify on Linux that the test passes with qbs 2.0.2
from Creator 10 to have a combination which is known
to work correctly.
1. Upgrade sources to v6.0.1 and write the tree which
qbs 2.0.2 and Creator 11 generated from those.
2. Run the test with qbs 2.1.0 and Creator 11 and update
the expected tree. This only meant removing a couple
of lines.
3. Verify on Windows that the test passes with qbs 2.0.2
from Creator 10 to have a combination which is known
to work correctly.
4. Upgrade sources to v6.0.1 and write the tree which
qbs 2.0.2 and Creator 11 generated from those. Remove
all lines from the expected tree which were not found.
Most of those contained forward slashes instead of
backslashes.
5. Verify that the result passes with qbs 2.1.0 and
Creator 11
Change-Id: I41579feb719324cf1fc605c73fe1d7566cf82202
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Disclaimer: I don't know why all those lines disappeared from the
tree. I only removed the lines which are not being found anymore
and updated a few more.
Change-Id: I916362247022b2ea84f5fa4255c6df6585311271
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Caching makes the settings page less snappy.
Also fixed searching for qml runtime if not set in
QmlProjectRunConfiguration
Fixes: QTCREATORBUG-29341
Change-Id: Ia3ce72f3e3b857a857f706694794304dcbf1793c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Fix setting the states editor object name on the QQuickWidget instead
of its QWidget.
Change-Id: I90cfa5d312c04eafa95eef6ab49cc52572928db7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
...when trying to execute the server settings wizard.
Change-Id: I221198639aed53fc90146ac536ea83d2dff8002d
Reviewed-by: David Schulz <david.schulz@qt.io>
To reduce the changes done to the document iterate from the start and
back of the replacement text and check whether the document already contains
the proposed changes.
This also fixes the misplaced snippet part in the if else snippet.
Change-Id: I4519ed101cc03e7c49b3a9b775087361c3fd158d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
With links to videos from the learning courses.
Change-Id: Id2f3d32fcbe39c729ae5c3140b064b88f112283b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... in the ClangFormat settings (rather than the default of just
indenting).
As opposed to files generated by the wizard, quickfixes are often touching
existing code, and since ClangFormat works on line granularity, users
will experience unexpected re-formattings when ClangFormat is in indent-
only mode.
Therefore, do the formatting only if the user has enabled it in the
ClangFormat settings.
Change-Id: Icb30f166f2b6fb94113a8f25c4a5f92ff8bca9b0
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Since there is no call to recordData()
with ANDROID_PRESTARTSHELLCMDLIST or
with ANDROID_POSTFINISHSHELLCMDLIST, the recordedData()
will always return empty variant.
Change-Id: I2d96ddee12181c614a0282f5103fba3fc06b6486
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
On Windows it looked like nothing happened when pressing the keypad's
Enter key.
By using the same handling as for the Return key, the terminal works as
the user expects it.
Fixes: QTCREATORBUG-29348
Change-Id: Ia49f0bb98aef8393f208671042d608a124cb431f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Attempting qsb (Qt Shader Baker) file generation for some reason fails
the lights baking process. Since autogeneration of qsb files for
shaders is only necessary to be done once, disabled it by default in
NodeInstanceView, so only the main instance of NodeInstanceView will
attempt to do it.
Fixes: QDS-10206
Change-Id: Ie2b273929c9dde4ab857f6ab47f7daef47808f19
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
