In order to not overwrite errors reported by clangd lower the priority
of clang tool marks if they only contain a warning.
Change-Id: Ida1c39ab11aaeb0c70f674c53762fa2707bec766
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Also, trigger build button re-check the hard way
This should not really be necessary, but the code paths on the
core side are still quite twisted. The extra notification here
is harmless in price, and removes the showstopper of not getting
a buildbutton.
Change-Id: If4bec892b4ebea533a95033629df60fa564985f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Locked curves had roughly the same color as the background color
of the curveeditor. They are now a little bit brighter in order
to see them better.
Fixes: QDS-10130
Change-Id: Ic9cfc8358d9e1f2d4df132b27cb286653a0c35e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Goal is to make option setup more similar to the other "simple" pages.
The GdbOptionPage is now separated in the setup code, but aggregated
into the old place and accessed there.
The per-backend separation seem quite weak, a full split would currently
need to have include gdb/* in several places now is an indication
that the gdb/non-gdb split in the options is dubious at best.
Change-Id: Iad210016739aa4a63645731e16825f546bdd5e8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Most aspect containers end in a widget at some time. Let them declare
how.
The optionspages don't need a layouter anymore when using their
settings' one. There was only one case where there was none, fix
that one (perforce).
Change-Id: Ibd39bcd4af98c3eae1daafa59f6c1d6e7a571989
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This fixes a bug on some systems where resizeSection did not work
as expected making the sections for the icons too wide and therefore
the item names unreadable for the default treeview width.
Fixes: QDS-10131
Change-Id: I10242a7f3f96c580b3256f7ca420466173581e35
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... and other special toolchains not in PATH.
Amends cacc4aeede.
Change-Id: I300f7d719c9e101c24e3750dd7afd54dd338b58d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
FilePath::searchInDirectories handles absolute paths on devices
better unlike Environment::searchInPath() which requires
a QString argument.
Previously the device:// part was dropped when trying to run
remote tests.
Fixes: QTCREATORBUG-29183
Change-Id: Idd04cdb8798d04abf88ab6cb4b68eb73d890a482
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
error: operands to '?:' have different types 'QStringBuilder<const QString&, QString>' and 'QStringBuilder<QString, QString>'
Caused by af8f9a2a6e3dbc8.
Change-Id: Ia3dfca2cb5f1cb1855f25d178f63898eb6745c46
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
add_qtc_library makes the code much more readable.
Change-Id: I60b397f3dc19de6911263c0818a25b41ab5a4209
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
There were problems with older google test versions which were found
instead. Now the google test version is always the same and there cannot
be "strange" compile bugs.
Change-Id: Ib3dc74d1abbe369fb37a4ee5616011d8e3696c01
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is not a proper fix but prevents a crash and is otherwise
harmless.
Some tree traversal seems to be able to hit non-leaf KitNodes
that don't have m_kit set.
Change-Id: I4328069ba9b82bb66dfa2c1e0d148a717d594a4b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It's no longer necessary to select camera to be able to align it.
Targeted camera is selected according to this priority list:
- Selected camera
- Previously selected camera
- Camera explicitly set as the camera for View3D of the scene
- Any camera
Fixes: QDS-10045
Change-Id: I3eedc92b7523e77ed5bc52f116ef83b4fe599b35
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Slider widget for particle seeker is recreated whenever slider changes
between being shown on the toolbar and being moved behind the extension
button. However, the widget shown in the extension menu didn't follow
action's enabled state.
Fixed by making the slider's enabled state explicitly follow the
associated action's enabled state.
Fixes: QDS-10057
Change-Id: Ie5f14d0072bab0a1c0b396c0589d39758990acef
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Codesigning is done implicitly when using e.g. build.py
but sometimes doing it explicitly is convenient.
Add a main() to common.py and add arguments for triggering
codesigning:
python3 common.py codesign -s identity app_bundle
Change-Id: I8b0f766cfae0ea9d8173f331792a14964993d705
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
They are meant to be used from subclasses only.
For the private virtual TaskInterface::start() -
it's meant to be implemented from subclasses only,
but not to be called from them.
Change-Id: I526c40766c204c868b4b3c857a382b2b61bbadd0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Add some crude hack to make QC work correctly when started from
Squish.
Squish explicitly sets DYLD_* paths but preserves the original
content in separate variables.
The modification is necessary from Squish's side to be able to
hook into QC, but these modifications interfere e.g. when
executing qmake from a different Qt version.
Use the preserved values and set them internally if needed to
get a corrected run environment.
Change-Id: I2c1c8aa79ad37463e0b974ec3ce18ff32d8e12a9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>